Hi All,
Please review an updation of ProblemList to remove/update resolved
client bugs from ProblemList
Bug: https://bugs.openjdk.java.net/browse/JDK-8217464
webrev: http://cr.openjdk.java.net/~psadhukhan/8217464/webrev.0/
Few test are closed as duplicate of other bug so the ProblemList is
+1
Krishna
> On 30-Jan-2019, at 3:56 PM, Prasanta Sadhukhan
> wrote:
>
> Hi All,
>
> Please review an updation of ProblemList to remove/update resolved client
> bugs from ProblemList
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8217464
> webrev:
The synopsis - which I rephrased for better English, turns out to still
not represent most of what is happening here. The synopsis would
make one think this is mostly about removing an unused abstract class
and the font changes are a foot note to that. In fact this is MOSTLY
about removing
You discuss the life cycle of an applet in jtreg
---
- Call init() and start() methods of the Applet
- Waits for 2 seconds
- Call stop() and destroy() methods of the Applet
- Dispose the frame
--
I see init() and start() being used but I don't see the rest replaced.
Why not
Looks fine. I can only suppose the C++ AwtRobot class existed only
because other peer classes need a C++ native object ?
But I can't think what would break if there's none here ...
-phil.
On 1/11/19 6:45 PM, Sergey Bylokhov wrote:
Hello.
Please review the fix for jdk 13.
Bug:
final is pointless on an interface method but please make sure that we
aren't
surprised that JCK signature tests check for this.
+ * Gets the search term. The platform may optionally provide the search
term
+ * that was used to find the files. This is for example the case on Mac OS
+ * X,
GIF 89a supports a transparent color index in the palette.
Brian
> On Nov 7, 2018, at 11:25 AM, Sergey Bylokhov
> wrote:
>
> On more question about "image/gif" format, as far as I understand this format
> do not support the alpha as well, then why it works w/o exceptions?
Hello, Philip!
No, I didn't submit a job. Please do it. Thanks!
With best regards,
Tagir Valeev.
пн, 1 окт. 2018 г., 23:45 Philip Race :
> Hi,
>
> On 9/30/18, 8:29 PM, Tagir Valeev wrote:
> > Hello!
> >
> > Please review JDK-8211300 [1] this change: [2]. Also it needs a
> > sponsor as I have
Hi,
If a system property is defined and specified as supported then it needs
a public declaration and specification as part of the public class or
package documentation.
Checking for and adding the tag will be a good way to reconfirm property
definitions are in the right place.
Would it be
The siblingsComparator in sun.lwawt.macosx.CPlatformWindow violates the contract if one of the windows is not visible and therefore has no peer:
private final Comparator siblingsComparator = (w1, w2) -> {
if (w1 == w2) {
return 0;
}
ComponentAccessor
+1
-phil
On 1/30/19 2:26 AM, Prasanta Sadhukhan wrote:
Hi All,
Please review an updation of ProblemList to remove/update resolved
client bugs from ProblemList
Bug: https://bugs.openjdk.java.net/browse/JDK-8217464
webrev: http://cr.openjdk.java.net/~psadhukhan/8217464/webrev.0/
Few test
Oh .. and I meant to ask what probably is an obvious question but needs
to be asked anyway.
You say you did not try to fix tests that already fail - this is just a
conversion - but did you
confirm there are no NEW failures on any platform ?
-phil.
On 1/30/19 2:29 PM, Phil Race wrote:
You
Sorry, please ignore my previous mail.
My mail client synced up mails (after re-formatting) and showed this as a new
mail.
Sorry for the confusion.
Thanks,
Krishna
> On 31-Jan-2019, at 12:30 PM, Krishna Addepalli
> wrote:
>
> Hi Shashi,
> I presume you meant this fix to be reviewed for 13.
Hi Shashi,
I presume you meant this fix to be reviewed for 13.
Could you re-upload the patch with latest code? I tried importing the patch,
but it fails to apply on the latest code.
Here is the output I get:
applying
I am not sure how an application is supposed to know what size to use,
which seems a bit of a problem with this API.
And does this work equally well on all platforms and resolutions ?
The extreme weirdness that you give it the name of a system object the
application
has to find and extract
On 30/01/2019 13:53, Phil Race wrote:
Looks fine. I can only suppose the C++ AwtRobot class existed only
because other peer classes need a C++ native object ?
I guess it was implemented with assumption that the robot
will need to store some data in the native code, but in fact
it was always an
16 matches
Mail list logo
