Mario,
Since you pushed this 4 modal dialog automated tests are failing - mostly -
on at least Ubuntu 16.04 and 18.04.
java/awt/Modal/ModalBlockingTests/BlockingWindowsSetModal6Test.java
java/awt/Modal/ModalBlockingTests/BlockingWindowsToolkitModal5Test.java
java/awt/Modal/ModalBlockingTests/Blo
Hi Phil,
This is strange, as I've run the full jtreg tests in addition to the
mouse event ones and didn't get any failure. Nonetheless, thanks for
spotting and apologise for breaking the build, I'll go through those
ASAP and see if there's a problem with the tests or something else, I
fail to see
On 2019-11-13 19:50, gerard ziemski wrote:
webrev: http://cr.openjdk.java.net/~gziemski/8223261_rev1
Nice cleanup! Looks good to me.
/Claes
Ok, I can reproduce the error now.
The test uses the VK_TAB to traverse the buttons, I admit this code is
quite... interesting I'll need to debug a bit more to see why the
focus logic for the wheel interest this. I'm not sure if in the
meantime you want to backout the change?
Cheers,
Mario
O
On 11/13/19 10:50 AM, gerard ziemski wrote:
Hi all,
Please review this cleanup, where we remove JDK_GetVersionInfo0 and
related code, since we can get build versions directly from within the
VM itself:
I'm including core-libs and awt in this review because the proposed
fix touches their
I'm not sure if in the meantime you want to backout the change?
I'm not sure either.
We are trying to get a clean sheet on the Linux headful tests - although
there are a lot that are problem listed.
If we can't figure this out very soon, we'll minimally have to problem list
these tests
and hav
Thanks Phil, I'll spend the whole of tomorrow on this, if I can't
figure it out I'll let you know ASAP so we can unblock the build.
Cheers,
Mario
Il giorno mer 13 nov 2019 alle ore 20:33 Phil Race
ha scritto:
>
> > I'm not sure if in the meantime you want to backout the change?
>
> I'm not sure
Hi Gerard,
generally it looks like a nice cleanup.
I've got a patch prepared though, which I was planning on posting tomorrow. It
is about cleanup for the canonicalize function in libjava. I wanted to use
jdk_util.h for the function prototype. I had not yet filed a bug but here is
what I have:
Hi Phil,
Ok, I got it and I feel very stupid now.
The issue was indeed in my original patch, two problems in fact, and I
really don't know how I made this mistake let alone made it through
all the way... apparently I can't count anymore like programmers do,
also I inverted the logic for the isWhe
Hi,
I'll also apply this and submit a job to our test system.
-phil.
On 11/13/19, 12:46 PM, Mario Torre wrote:
Hi Phil,
Ok, I got it and I feel very stupid now.
The issue was indeed in my original patch, two problems in fact, and I
really don't know how I made this mistake let alone made it
It looks reasonable, but we can be surprised .. if you have run all
headful tests on macos that might signal a problem then +1 ...
-phil.
On 10/18/19, 5:10 PM, Sergey Bylokhov wrote:
Hello.
Please review the fix for JDK 14.
Bug: https://bugs.openjdk.java.net/browse/JDK-8232433
Fix: http://cr.o
Hi Gerard,
On 14/11/2019 6:05 am, Langer, Christoph wrote:
Hi Gerard,
generally it looks like a nice cleanup.
I've got a patch prepared though, which I was planning on posting tomorrow. It
is about cleanup for the canonicalize function in libjava. I wanted to use
jdk_util.h for the function
Looks fine.
On 11/13/19 10:50 am, gerard ziemski wrote:
Hi all,
Please review this cleanup, where we remove JDK_GetVersionInfo0 and related
code, since we can get build versions directly from within the VM itself:
I'm including core-libs and awt in this review because the proposed fix touches
On 11/13/19 2:18 pm, Philip Race wrote:
It looks reasonable, but we can be surprised .. if you have run all
headful tests on macos that might signal a problem then +1 ...
Correct, no new issues were found.
-phil.
On 10/18/19, 5:10 PM, Sergey Bylokhov wrote:
Hello.
Please review the fix for
14 matches
Mail list logo
