Re: [OpenJDK 2D-Dev] RFR: Allow using the system libjpeg

2014-05-21 Thread Andrew Hughes
- Original Message - > Hi, > > Updated webrevs: > http://cr.openjdk.java.net/~omajid/webrevs/system-libjpeg/01/ > http://cr.openjdk.java.net/~omajid/webrevs/system-libjpeg/01.jdk/ > > * Anthony Petrov [2014-05-19 14:42]: > > make/lib/Awt2dLibraries.gmk > > >1236 LIBJPEG_CFLAGS := > >

Re: [OpenJDK 2D-Dev] RFR: Allow using the system libjpeg

2014-05-21 Thread Andrew Hughes
- Original Message - > * Andrew Hughes [2014-05-21 12:22]: > > I'm not keen on the hardcoding of '-ljpeg' > > > > + LIBJPEG_LIBS := -ljpeg > > There's no pkg-config files for it. Any suggestions on how to get > something generic? >

Re: [OpenJDK 2D-Dev] RFR: Allow using the system libjpeg

2014-05-22 Thread Andrew Hughes
- Original Message - > > On 2014-05-22 02:49, Omair Majid wrote: > > * Andrew Hughes [2014-05-21 20:23]: > >> - Original Message - > >>> * Andrew Hughes [2014-05-21 12:22]: > >>>> I'm not keen on the hardcoding of '-lj

RFR: 8081447: System JPEG builds include in-tree jpeglib.h, resulting in build failure

2015-05-28 Thread Andrew Hughes
Bug: https://bugs.openjdk.java.net/browse/JDK-8081447 Webrev: http://cr.openjdk.java.net/~andrew/8081447/webrev.01/ In testing a fix for [0], I found that system jpeg support seems to have bitrotted. Due to the movement of makefiles, it's hard to trace where this change occurred, but we have the c

Re: RFR: 8081447: System JPEG builds include in-tree jpeglib.h, resulting in build failure

2015-05-28 Thread Andrew Hughes
- Original Message - > Bug: https://bugs.openjdk.java.net/browse/JDK-8081447 > Webrev: http://cr.openjdk.java.net/~andrew/8081447/webrev.01/ > > In testing a fix for [0], I found that system jpeg support seems > to have bitrotted. Due to the movement of makefiles, it's hard > to trace wher

Re: RFR: 8081447: System JPEG builds include in-tree jpeglib.h, resulting in build failure

2015-05-29 Thread Andrew Hughes
- Original Message - > On 2015-05-29 04:24, Andrew Hughes wrote: > > > > Bug: https://bugs.openjdk.java.net/browse/JDK-8081447 Webrev: > http://cr.openjdk.java.net/~andrew/8081447/webrev.01/ In testing a fix for > [0], I found that system jpeg support seems > t

RFR: 8077982: giflib upgrade breaks system giflib builds with earlier versions

2015-06-02 Thread Andrew Hughes
Bug: https://bugs.openjdk.java.net/browse/JDK-8081315 Webrev: http://cr.openjdk.java.net/~andrew/8081315/webrev.01/ In 8011278, the option was added to build OpenJDK with a system installation of giflib, something we've been doing for many years in the IcedTea project. Following 8077982, the inte

Re: RFR: 8077982: giflib upgrade breaks system giflib builds with earlier versions

2015-06-02 Thread Andrew Hughes
- Original Message - > I think you meant the subject to be "RFR: 8081315 ..." > Ah yes, I moved the 8077982 in front of the colon when it's actually part of the bug description i.e. RFR: 8081315: 8077982 giflib upgrade :( > if (DGifCloseFile(gif, NULL) == GIF_ERROR) >return 0

Re: [OpenJDK 2D-Dev] RFR: 8081315: 8077982 giflib upgrade breaks system giflib builds with earlier versions

2015-06-05 Thread Andrew Hughes
- Original Message - > Hi Andrew, > > We have removed a workaround[0] for interlaced images support, there is > no need in it after 5.0.0 [1]: > > DGifSlurp() and EGifSpew() now read and write interlaced images properly. > I didn't test it, but it seems to me that interlaced images will lo

Re: [OpenJDK 2D-Dev] RFR: 8081315: 8077982 giflib upgrade breaks system giflib builds with earlier versions

2015-06-08 Thread Andrew Hughes
- Original Message - > Sure, looks good to me. > > Thanks, > > Alexander. > > On 06/05/2015 06:34 PM, Andrew Hughes wrote: > > - Original Message - > >> Hi Andrew, > >> > >> We have removed a workaround[0] for interlaced imag

Re: Taking screenshots on x11 composite desktop produce wrong result

2016-03-02 Thread Andrew Hughes
- Original Message - > Hi all, > > I have a fix for the issue detailed in the following bug report: > > https://bugs.openjdk.java.net/browse/JDK-8150954 > > The issue is does not affect JDK9 so I guess my primary target for the > bug is jdk8u-dev and the backports will go into 7 and 6 as

Re: Taking screenshots on x11 composite desktop produce wrong result

2016-03-09 Thread Andrew Hughes
- Original Message - > Hi Sergey, > > Here is a proposed fix for JDK9, it removes the dependencies on GTK > and use only X11 calls: > > http://cr.openjdk.java.net/~neugens/8150954/webrev.02/ > > I only tried this on a RHEL 7.2 so far but it seems to compile and > work as expected, and

[hohen...@amazon.com: RFO: 8068228: Test closed/java/awt/Mouse/MaximizedFrameTest/MaximizedFrameTest fails with GTKLookAndFeel]

2020-11-04 Thread Andrew Hughes
Forwarding to awt-dev for attention of Oracle AWT developers. - Forwarded message from "Hohensee, Paul" - Date: Wed, 4 Nov 2020 00:36:16 + From: "Hohensee, Paul" To: jdk8u-dev Subject: RFO: 8068228: Test closed/java/awt/Mouse/MaximizedFrameTest/MaximizedFrameTest fails with GTKLo

Re: RFR: Allow using a system installed libpng

2014-02-04 Thread Andrew Hughes
- Original Message - > > On 2014-02-03 18:43, Omair Majid wrote: > > Hi, > > > > The following webrevs modify the build system to allow building against > > the system-installed copy of libpng as well as using the bundled copy of > > libpng > > > > ROOT: http://cr.openjdk.java.net/~omaji

Re: RFR: Allow using a system installed libpng

2014-02-06 Thread Andrew Hughes
- Original Message - > * Andrew Hughes [2014-02-04 19:26]: > > > On 2014-02-03 18:43, Omair Majid wrote: > > > > The following webrevs modify the build system to allow building against > > > > the system-installed copy of libpng as well

Re: RFR: Allow using a system installed libpng

2014-02-10 Thread Andrew Hughes
- Original Message - > On 2014-02-05 16:15, Omair Majid wrote: > > * Andrew Hughes [2014-02-04 19:26]: > >>> On 2014-02-03 18:43, Omair Majid wrote: > >>>> The following webrevs modify the build system to allow building against > >>>> t

Re: RFR: Allow using a system installed libpng

2014-02-12 Thread Andrew Hughes
- Original Message - > On 2014-02-10 18:43, Andrew Hughes wrote: > > You're already using it: > > > > PKG_CHECK_MODULES([LIBFFI], [libffi]) > > > > Why that's in LIB_SETUP_STATIC_LINK_LIBSTDCPP, I have no idea. > Because lib

Re: RFR: Allow using a system installed libpng

2014-02-13 Thread Andrew Hughes
- Original Message - > > On 2014-02-12 18:47, Andrew Hughes wrote: > >> To be extremely clear: Andrew, do you object to bringing Omairs patch, > >> as it is, into OpenJDK? > >> > > Yes. > > Okay then. > > I'll put a mental note t

Re: RFR: Allow using a system installed libpng

2014-02-13 Thread Andrew Hughes
- Original Message - > Hi, > > * Magnus Ihse Bursie [2014-02-12 17:49]: > > > > On 2014-02-12 18:47, Andrew Hughes wrote: > > >>To be extremely clear: Andrew, do you object to bringing Omairs patch, > > >>as it is, into OpenJDK? > > &

Re: RFR: Allow using a system installed libpng

2014-02-18 Thread Andrew Hughes
- Original Message - > * Erik Joelsson [2014-02-17 04:16]: > > At least to me this looks good, but better let Magnus and Andrew > > have their say too. > This looks fine. > Feedback from an AWT expert would be appreciated too! > I'm not sure why this is needed, given it doesn't really

Re: RFR: Allow using a system installed libpng

2014-02-20 Thread Andrew Hughes
- Original Message - > Hi Omair, > > > Should I be pushing this to jdk9/dev ? (Or to jdk9/client?) > > If you change client code, then the fix should go to the client repo to > avoid merge conflicts and allow for more manual testing prior to > integrating the changes into the master repo.