Re: [10] RFR JDK-8088132:[Swing, singleThread] ClassCastException in nested event loop when showing multiple message dialogs in SwingNode

2017-08-16 Thread Prasanta Sadhukhan
Hi Sergey, AFAIK, FX singleThread feature is supported but experimental feature. I have modified webrev to include DefaultKeyboardFocusManager too http://cr.openjdk.java.net/~psadhukhan/fx/8088132/webrev.01/ I do not think there is any problem in skipping code which works with EDT as for

RFR: 8186259: IOExceptionIfEncodedURLTest.sh versus IOExceptionIfEncodedURLTest.java

2017-08-16 Thread Phil Race
http://cr.openjdk.java.net/~prr/8186259/ I'll take any reviewer on this which just fixes the JTREG test so that jtreg does not blow up. -phil.

Re: RFR: 8186259: IOExceptionIfEncodedURLTest.sh versus IOExceptionIfEncodedURLTest.java

2017-08-16 Thread Tim Bell
Phil: On 08/16/2017 11:09 AM, Phil Race wrote: http://cr.openjdk.java.net/~prr/8186259/ I'll take any reviewer on this which just fixes the JTREG test so that jtreg does not blow up. Looks good. Approved. Tim

Re: RFR: 8186259: IOExceptionIfEncodedURLTest.sh versus IOExceptionIfEncodedURLTest.java

2017-08-16 Thread Phil Race
fixing joe's email address. -phil. On 08/16/2017 11:09 AM, Phil Race wrote: http://cr.openjdk.java.net/~prr/8186259/ I'll take any reviewer on this which just fixes the JTREG test so that jtreg does not blow up. -phil.

Re: RFR: 8186259: IOExceptionIfEncodedURLTest.sh versus IOExceptionIfEncodedURLTest.java

2017-08-16 Thread joe darcy
For the purposes of getting the test suite passing again, this looks fine. (Longer term, replacing the shell with the process builder API is probably preferable.) Cheers, -Joe On 8/16/2017 11:18 AM, Tim Bell wrote: Phil: On 08/16/2017 11:09 AM, Phil Race wrote: