/browse/JDK-8165232
Webrev: http://cr.openjdk.java.net/~alanbur/JDK-8165232/
Thanks,
--
Alan Burlison
--
/browse/JDK-8165232
Webrev: http://cr.openjdk.java.net/~alanbur/JDK-8165232/
Thanks,
--
Alan Burlison
--
itched over
to Java_sun_awt_X11_XlibWrapper_XkbKeycodeToKeysym. I thought I'd found
those, clearly not.
Thanks for the catch,
--
Alan Burlison
--
able to find are normal calls.
Thanks for the help,
--
Alan Burlison
--
On 06/09/2016 22:03, Alan Burlison wrote:
Thanks for the detail, doing as you suggest and migrating all the
references seems like the best approach as it shouldn't require any
followup work in the future. I'll make the changes you've suggested,
retest and post an updated webrev
obust. I've updated
https://bugs.openjdk.java.net/browse/JDK-8165232 with the details and
with a suggested alternate approach, I'd appreciate any comments you have.
Thanks,
--
Alan Burlison
--
On 06/09/2016 11:16, Alan Burlison wrote:
XKeycodeToKeysym is deprecated and when compiled on Solaris 12 with
warnings-as-errors this causes a compile time failure. References to
XKeycodeToKeysym should be replaced by XkbKeycodeToKeysym. As this is
common XOrg code it will affect Linux as well
On 14/09/2016 18:42, Alan Burlison wrote:
I'd appreciate any review comments.
Ping...
--
Alan Burlison
--
have any suggestions how better to test this I'd be grateful to hear them.
Thanks,
--
Alan Burlison
--
rately. There were a couple of
test failures but they didn't seem related to this change, although a
pair of more experienced eyes would be good!
--
Alan Burlison
--
ymbol. Is the current name OK?
Done, new webrev at http://cr.openjdk.java.net/~alanbur/JDK-8165232.v2/
For testing can you submit a jprt job and I'll see if I can
rustle up some SQE support to identify any tests that might be
good to run.
JPRT run on the v2 patch is clean.
--
Alan Burlison
--
On 27/09/2016 16:41, Alan Burlison wrote:
Done, new webrev at http://cr.openjdk.java.net/~alanbur/JDK-8165232.v2/
Does this look OK?
--
Alan Burlison
--
On 30/09/2016 20:01, Phil Race wrote:
Our helpful SQE engineer has verified that this works as well as
previously.
And I've done some basic testing myself on Ubuntu 16.04, so "+1"
(meaning approved).
Thanks. Could someone sponsor this for me?
--
Alan Burlison
--
On 03/10/2016 22:08, Phil Race wrote:
Do we have a 2nd reviewer yet ? I have not seen it.
Gah you are right, I thought I'd seen a 2nd. Any takers?
--
Alan Burlison
--
is not freed.
So there is, thanks for the catch.
--
Alan Burlison
--
On 04/10/2016 19:34, Alan Burlison wrote:
key_syms is not freed.
So there is, thanks for the catch.
Done, webrev updated, jprt -tset hostpot rerun & clean.
--
Alan Burlison
--
On 06/10/2016 19:32, Phil Race wrote:
.. and Alan I did suggest last time that the updated webrev be a ".1" as
in place replacement loses history and context for people who aren't
reading the email thread "live".
Oops, sorry you did say that and I forgot this time ro
uot;
Oh .. Alan see you already did exactly that :-). So we are in
agreement there.
Yes, seen the push - thanks :-)
I'll check with a fresh clone tomorrow but I *think* with this committed
Java9 now builds cleanly on Solaris 12. Yay! :-)
--
Alan Burlison
--
On 06/10/2016 22:26, Alan Burlison wrote:
Oh .. Alan see you already did exactly that :-). So we are in
agreement there.
Yes, seen the push - thanks :-)
I'll check with a fresh clone tomorrow but I *think* with this committed
Java9 now builds cleanly on Solaris 12. Yay! :-)
Hmm, I&#x
rests...
--
Alan Burlison
--
20 matches
Mail list logo
