[9] Review request for 8012224: AWT_TopLevels/TopLevelEvents/Automated/WindowIconifyDeiconifyEventsTest02 fails on Ubuntu 12.04 Unity shell

Hello AWT team, please review fix http://cr.openjdk.java.net/~azvegint/jdk/9/8012224/00/ for https://bugs.openjdk.java.net/browse/JDK-8012224 X FAQ[1] says: Subject: 141) How do I deiconify a window? To de-iconify a window, map it with XMapWindow(). To iconify a window, use XIconifyWindow().

Re: [9] Review request for 8012224: AWT_TopLevels/TopLevelEvents/Automated/WindowIconifyDeiconifyEventsTest02 fails on Ubuntu 12.04 Unity shell

p://cr.openjdk.java.net/~azvegint/jdk/9/8012224/01/ Thanks, Alexander. -- best regards, Anthony On 3/5/2014 7:45 PM, Alexander Zvegintsev wrote: Hello AWT team, please review fix http://cr.openjdk.java.net/~azvegint/jdk/9/8012224/00/ for https://bugs.openjdk.java.net/browse/JDK-8012224 X FAQ

Re: [9] Review request for 8012224: AWT_TopLevels/TopLevelEvents/Automated/WindowIconifyDeiconifyEventsTest02 fails on Ubuntu 12.04 Unity shell

Hi Sergey, I've checked OEL 6, Solaris 10/11 and all works as expected. Thanks, Alexander. On 03/06/2014 07:51 PM, Sergey Bylokhov wrote: Hi, Alexander. The fix looks good. But can you check that it works properly on solaris. Thanks! On 3/5/14 7:45 PM, Alexander Zvegintsev wrote: Hell

Re: [9] Review request for 8012224: AWT_TopLevels/TopLevelEvents/Automated/WindowIconifyDeiconifyEventsTest02 fails on Ubuntu 12.04 Unity shell

Hi Anthony, Sure, it fails to deiconify unfocusable frame before the fix and works after applying this patch. Thanks, Alexander. On 03/07/2014 01:14 AM, Anthony Petrov wrote: On 3/6/2014 6:36 PM, Alexander Zvegintsev wrote: On 03/05/2014 08:18 PM, Anthony Petrov wrote: 1. What does this

Re: [9] Review Request: 8028050: Typo correction needed s/Classlaoder/Classloader/

Hi Sergey, the fix looks fine to me. Thanks, Alexander. On 03/17/2014 01:04 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 9. - typo fixed - small cleanup Bug: https://bugs.openjdk.java.net/browse/JDK-8028050 Webrev can be found at: http://cr.openjdk.java.net/~serb/802805

Re: [9] Review Request: 7124255 [macosx] java.awt.List: method select(int) doesn't work before be visible

Hi Sergey, the fix looks good to me too. -- Thanks, Alexander. 19.03.2014 0:07, Petr Pchelko wrote: Hello, Sergey. The fix looks good to me. With best regards. Petr. 19 марта 2014 г., в 12:03 до полудня, Sergey Bylokhov написал(а): Hello. Please review the fix for jdk 9. Actual bug was

[9] Review request: JDK-8030100 java.awt.Desktop: Enable check for supported URI schemes on Linux

Hello AWT team, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8030100/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8030100 64-bit linux usually does not have a full set of 32-bit gnome and gtk libraries installed, so it fails to open URIs like http:// , mailto:

[9] Review request : 6788138 leak in Java_sun_awt_X11_XlibWrapper_getStringBytes?

Hello AWT team, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/6788138/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-6788138 Currently we use this function to get Window Manager name from native only. It happens only once at startup, hence this leak is not noticea

Re: [9] Review request : 8022531 [TEST_BUG] After double-click on the folder names , there is no 'OK' button in the dialog.

Hi Konstantin, the fix looks good to me too. Thanks, Alexander. On 03/21/2014 02:44 PM, Konstantin Shefov wrote: Thanks for the review, look at the fix http://cr.openjdk.java.net/~kshefov/8022531/webrev.01/ -Konstantin On 21.03.2014 14:46, Petr Pchelko wrote: Hello, Konstanting. After som

Re: [9] Review request : 6788138 leak in Java_sun_awt_X11_XlibWrapper_getStringBytes?

w notes. - documentation of this method is wrong.(copypaste from XFree) - This two line was added by the dm, in the fix for "Fixed size problem in getStringBytes" in 2003. Note that the storage has "length +1" size. Why? On 3/21/14 2:27 PM, Alexander Zvegintsev wrote:

Re: [9] Review Request: JDK-8038106 PIT: access problem to a PrinterJob on OS X

Hi Petr, The fix looks good to me as well. -- Thanks, Alexander. 21.03.2014 18:28, Petr Pchelko wrote: Hello, AWT Team. Please review the fix for the issue: https://bugs.openjdk.java.net/browse/JDK-8038106 The fix is available here: http://cr.openjdk.java.net/~pchelko/9/8038106/webrev/

Re: [9] Review request : 8031422 [TEST_BUG] java/awt/Paint/bug8024864.java fails on Windows 7

Hello, Konstantin, the fix looks good to me too. Thanks, Alexander. On 03/25/2014 05:14 PM, Petr Pchelko wrote: Hello, Konstantin. The fix looks good to me. With best regards. Petr. On 25.03.2014, at 17:05, Konstantin Shefov mailto:konstantin.she...@oracle.com>> wrote: Hello AWT team,

Re: [9] Review Request: JDK-8032595 [macosx] setResizable(false) makes a frame slide down

Hello Petr, the fix looks good to me. Thanks, Alexander. On 03/24/2014 05:59 PM, Petr Pchelko wrote: Hello, AWT Team. Please review the fix for the issue: https://bugs.openjdk.java.net/browse/JDK-8032595 The fix is available at: http://cr.openjdk.java.net/~pchelko/9/8032595/webrev/

Re: Review request for JDK-8038631: Create wrapper for awt.Robot with additional functionality

Hello Dmitriy, Could you please update the copyright year to 2014? No new webrev is needed for such small change. Otherwise, the fix looks good to me as well. -- Thanks, Alexander. On 03/31/2014 04:29 PM, Petr Pchelko wrote: Hello, Dmirty. The new version of the fix looks good to me. With b

Re: [9] Review Request: 8039083 REGRESSION: closed/java/awt/dnd/DragSourceListenerSerializationTest/DragSourceListenerSerializationTest.html fails with NPE since 8u20 b07 on Linux

Hello Petr, the fix looks good to me. -- Thanks, Alexander. On 04/03/2014 03:23 PM, Petr Pchelko wrote: Hello, Please review the fix for the issue: https://bugs.openjdk.java.net/browse/JDK-8039083 The fix is available at: http://cr.openjdk.java.net/~pchelko/9/8039083/webrev/ When I’ve been m

Re: [9] Review Request: 8039267 Test closed/java/awt/Choice/ChoiceLocationTest/ChoiceLocationTest.html should be removed

Hello Petr, the fix looks good to me. Thanks, Alexander. On 04/04/2014 04:55 PM, Petr Pchelko wrote: Hello, AWT Team. Please review a simple fix for the issue: https://bugs.openjdk.java.net/browse/JDK-8039267 The fix is available here: http://cr.openjdk.java.net/~pchelko/9/8039267/webrev/ A

Re: Review request for JDK-8038631: Create wrapper for awt.Robot with additional functionality

Hello Dmitry, there is no need to use string array with doPrivileged: String tempDelay = AccessController.doPrivileged(new PrivilegedAction() { public Void run() { return System.getProperty("java.awt.robotdelay"); } }); Moreover, there

Re: [9] Review request : 6788138 leak in Java_sun_awt_X11_XlibWrapper_getStringBytes?

Hello AWT team, Could I get a second review? Thanks, Alexander. On 03/25/2014 08:07 PM, Sergey Bylokhov wrote: On 3/21/14 3:10 PM, Alexander Zvegintsev wrote: Hi Sergey, Updated: http://cr.openjdk.java.net/~azvegint/jdk/9/6788138/01/ - This two line was added by the dm, in the fix for

Re: Review request for JDK-8038631: Create wrapper for awt.Robot with additional functionality

Hello Dmitriy, this version looks good to me. Thanks, Alexander. On 04/04/2014 11:32 PM, Petr Pchelko wrote: Hello, Dmitry. This version looks great. With best regards. Petr. 04 апр. 2014 г., в 8:16 после полудня, Dmitriy Ermashov написал(а): Hi, Please, review the changeset for: https

Re: [9] Review Request: JDK-6690000 Typo's in DataFlavor Javadoc

Hello Petr, the fix looks good to me. Thanks, Alexander. On 04/07/2014 05:13 PM, Petr Pchelko wrote: Hello, AWT Team. Please review the fix for the javadoc typos: https://bugs.openjdk.java.net/browse/JDK-669 The fix is here: http://cr.openjdk.java.net/~pchelko/9/669/webrev.00/ With

Re: [9] Review Request: 8039752 Regression: Clipboard couldn't be used on linux

Hi Petr, the fix looks fine to me too. Thanks, Alexander. On 04/09/2014 05:43 PM, Petr Pchelko wrote: Hello, AWT Team. Please review the fix for the issue: https://bugs.openjdk.java.net/browse/JDK-8039752 The fix is available at: http://cr.openjdk.java.net/~pchelko/9/8039752/webrev/ I've re

Re: [9] Review Request: 8039567 Duplicated code in DataTransferer

Hi Petr, the fix looks good to me. Thanks, Alexander. On 04/09/2014 06:27 PM, Petr Pchelko wrote: Hello AWT team. Please review a simple cleanup fix for the issue: https://bugs.openjdk.java.net/browse/JDK-8039567 The fix is available here: http://cr.openjdk.java.net/~pchelko/9/8039567/webrev

Re: [9] Review Request: 7124365 [macosx] setMaximizedBounds() should be implemented

Hello Petr, #1: I noticed that a window doesn't move on setExtendedState(Frame.MAXIMIZED_BOTH) if a window already have the same size as provided to setMaximizedBounds(). Another case: we successfully maximized a window, its window state is MAXIMIZED_BOTH, we moved a window, its window state

Re: [9] Review Request: 8039926 -spash: can't be combined with -xStartOnFirstThread since JDK 7

Hello Petr, the fix looks fine to me. -- Thanks, Alexander. On 04/17/2014 12:38 PM, Petr Pchelko wrote: Hello, Could I get a second review on this. With best regards. Petr. On 11.04.2014, at 15:41, Anthony Petrov wrote: Sounds good. Thanks. -- best regards, Anthony On 4/11/2014 3:39 PM

Re: [9] Review Request: 8035169 Move ThreadGroupUtils from the sun.misc package

Hello Petr, the fix looks fine to me. -- Thanks, Alexander. On 04/16/2014 06:42 PM, Petr Pchelko wrote: Hello, AWT Team. Please review the fix for the issue: https://bugs.openjdk.java.net/browse/JDK-8035169 The fix is available at: http://cr.openjdk.java.net/~pchelko/9/8035169/webrev/ The Th

Re: [9] Review Request: 8035169 Move ThreadGroupUtils from the sun.misc package

Still looks good to me. -- Thanks, Alexander. 17.04.2014 19:51, Sergey Bylokhov wrote: Hi, Petr. The fix looks good. On 4/17/14 3:34 PM, Petr Pchelko wrote: Hello, Sergey. Thank you for the review. Fixed: http://cr.openjdk.java.net/~pchelko/9/8035169/webrev.01/ With best regards. Petr. On

Re: [9] Review Request: 8039567 Duplicated code in DataTransferer

review on this. With best regards. Petr. On 09.04.2014, at 18:57, Alexander Zvegintsev wrote: Hi Petr, the fix looks good to me. Thanks, Alexander. On 04/09/2014 06:27 PM, Petr Pchelko wrote: Hello AWT team. Please review a simple cleanup fix for the issue: https://bugs.openjdk.java.net

Re: [9] Review Request: 8026252 [macosx] Change AWT_DEBUG_BUG_REPORT_MESSAGE for macosx platform

Hello Sergey, the fix looks good to me. -- Thanks, Alexander. On 04/18/2014 03:48 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 9. The link was changed from http://java.net/jira/browse/MACOSX_PORT to http://bugreport.java.com/bugreport Also additional "\t" was added to "Coco

Re: [9] Review Request: 8036917 [macosx] Native memory leaks.

Hello, Petr, the fix looks good to me. Thanks, Alexander. On 04/30/2014 01:04 PM, Petr Pchelko wrote: Hello, It's a reminder about this review. With best regards. Petr. On 21.04.2014, at 16:34, Petr Pchelko wrote: Hello, AWT Team. Please review the fix for the issue: https://bugs.openj

Re: [7u60] Review Request: JDK-8036861 Application can't be loaded fine, the save dialog can't show up.

Hello, Petr, the fix looks good to me as well. Thanks, Alexander. On 05/07/2014 01:15 AM, Sergey Bylokhov wrote: Hi, Petr. The fix looks good. On 06.05.2014 19:00, Petr Pchelko wrote: Hello, AWT Team. Please review the fix for the issue: https://bugs.openjdk.java.net/browse/JDK-8036861 The

Re: [9] Review Request: JDK-8042585 [macosx] Unused code in LWCToolkit.m

Hello, Petr, the fix looks fine to me. Thanks, Alexander. On 05/07/2014 02:08 PM, Petr Pchelko wrote: Hello, AWT Team. Please review the fix for the issue: https://bugs.openjdk.java.net/browse/JDK-8042585 The fix is available at: http://cr.openjdk.java.net/~pchelko/9/8042585/webrev/ This co

Re: RFR(XS): 8042416: X11GraphicsEnvironment.isDisplayLocal() throws NoSuchElementException if DISPLAY host has more IP addresses than a local interface

Hi Volker, the fix looks fine to me. P.S. I noticed that there is no cast in the webrev itself, but the patch[1] under jdk.changeset link has it. [1] http://cr.openjdk.java.net/~simonis/webrevs/8042416/jdk.changeset Thanks, Alexander. On 05/05/2014 10:07 PM, Volker Simonis wrote: Hi, co

Re: [9] Review Request: 8042219 [macosx] LWComponentPeer should not reference classes from sun.lwawt.macosx

Hello, Petr, the fix look good to me too. Thanks, Alexander. On 05/07/2014 05:12 PM, Sergey Bylokhov wrote: Hi, Petr. The fix looks good. On 07.05.2014 13:53, Petr Pchelko wrote: Hello, Sergey. Please see the updated webrev here: http://cr.openjdk.java.net/~pchelko/9/8042219/webrev.01/

Re: [9] Review request: 8042752 [macosx] NSEvent instances leak throw JNI local references

Hello, Petr, the fix looks fine to me. -- Thanks, Alexander. On 05/08/2014 05:57 PM, Petr Pchelko wrote: Hello, AWT Team. Please review the fix for the issue: https://bugs.openjdk.java.net/browse/JDK-8042752 The fix is available at: http://cr.openjdk.java.net/~pchelko/9/8042752/webrev/ The p

[9] Review request: 8041896 Test closed/java/awt/Choice/RemoveAllShrinkTest/RemoveAllShrinkTest fails with java.awt.IllegalComponentStateException

Hello AWT team, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8041896/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8041896 This test failure is a regression of the JDK-7159566 fix. We trying to call getLocation

[9] Review request for 8031471: Test closed/java/awt/dnd/FileDialogDropTargetTest/FileDialogDropTargetTest.java fails on Solaris zones virtual hosts

Hello, please review the fix: http://cr.openjdk.java.net/~azvegint/jdk/9/8031471/00/ for https://bugs.openjdk.java.net/browse/JDK-8031471 This fix also fixes 7100524 [1] and 7054476 [2] as well. This issue is related to the X error handling code: when we setting a synthetic error handler with

Re: [9] Review Request: 8043979 Javadoc cleanup of javax.sound.sampled package

Hi Sergey, the fix looks good to me too. Thanks, Alexander. On 06/02/2014 01:15 PM, Sergey Bylokhov wrote: Hello. Please review another one javadoc "weekend cleanup" in jdk 9 in sound area: - @param, @return should not end with a dot, except a case when more than one sentences are used.

Re: [9] Review Request: 8039901 jdk/src/share/classes/com/sun/media/sound/services/ appear not to be used

Hello Sergey, the fix looks good to me. Thanks, Alexander. On 06/04/2014 06:10 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 9. The old sound configuration files were removed, its were used in the old (beatnik) sound engine in old build system. Bug: https://bugs.openjdk.j

[9] Review request: 8040007 GtkFileDialog strips user inputted filepath

Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8040007/00/ for the bug https://bugs.openjdk.java.net/browse/JDK-8040007 With this fix we don't use current folder from native GtkFileChooser anymore, now we build it by ourselves. [1] https://developer.gnome.org/gtk2/st

Re: [9] Review request: 8040007 GtkFileDialog strips user inputted filepath

is a hack for use with "Recent Folders" in gtk where each 279 //file could have its own directory. I assume you've tested this case, and it still works fine, right? -- best regards, Anthony On 6/6/2014 8:00 PM, Alexander Zvegintsev wrote: Hello, please review the fix

Re: [9] Review Request: 8048265 AWT crashes inside CCombinedSegTable::In called from Java_sun_awt_windows_WDefaultFontCharset_canConvert

Hi Sergey, the fix looks good to me. -- Thanks, Alexander. 01.07.2014 9:12, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 9. Bug was triggered by the change in JDK-8032435, when WingDings.java was changed to non-public class. This class is used in native, and looks like some of

[9] Review request for 8049418: [macosx] PopupMenuListener.popupMenuWillBecomeVisible is not called for empty combobox on MacOS/aqua look and feel

Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8049418/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8049418 The JDK-8041896 [1] fix consists of two part: actual fix in LWChoicePeer.java and unrelated improvements in AquaComboBoxPopup.java. Changes in Aqua

Re: [9] Review request for 8049418: [macosx] PopupMenuListener.popupMenuWillBecomeVisible is not called for empty combobox on MacOS/aqua look and feel

. Petr. On Jul 7, 2014, at 6:22 PM, Alexander Zvegintsev wrote: Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8049418/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8049418 The JDK-8041896 [1] fix consists of two part: actual fix in LWChoicePeer.java and

Re: [9] Review Request: 8049998 [macosx] test java/awt/image/ImageIconHang.java fails with NPE

Hello Petr, the fix looks good. BTW since you are touching this file maybe we can fix a typo at :547 within this CR ( fileneame2x -> filename2x ) Thanks, Alexander. On 07/11/2014 03:50 PM, Petr Pchelko wrote: Hello, AWT Team. Please review a little fix for the issue: https://bugs.openjdk.

Re: Review request for 8049694: Migrate functional AWT_DesktopProperties/Automated tests to OpenJDK

Hi Dmitriy, Correct me if I am wrong: jtreg keeps DISPLAY and strips many environment variables(e.g. DBUS_SESSION_BUS_ADDRESS). DBUS_SESSION_BUS_ADDRESS variable is needed for correct work of gconftool-2 and gsettings That's why we need pargs and /proc/$PID/environ. But this test fails for me

Re: Review request for 8049694: Migrate functional AWT_DesktopProperties/Automated tests to OpenJDK

PM, Alexander Zvegintsev wrote: Hi Dmitriy, Correct me if I am wrong: jtreg keeps DISPLAY and strips many environment variables(e.g. DBUS_SESSION_BUS_ADDRESS). DBUS_SESSION_BUS_ADDRESS variable is needed for correct work of gconftool-2 and gsettings That's why we need pargs and /proc

[9] Review request for 8048289 Gtk: call to UIManager.getSystemLookAndFeelClassName() leads to crash

Hello AWT team, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8048289/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8048289 UIManager.getSystemLookAndFeelClassName() calls UNIXToolkit.isNativeGTKAvailable() which loads gtk library, checks version, and closes libr

Re: [9] Review request for 8048289 Gtk: call to UIManager.getSystemLookAndFeelClassName() leads to crash

I remember, we have a code, which closes this lib for the usual usage of gtk look and feel. Looks like we never call it, but if we call it it will cause the same crash? Can you investigate that? Thanks. On 7/16/14 8:56 PM, Alexander Zvegintsev wrote: Hello AWT team, please review the fix

Re: Review request for 8049694: Migrate functional AWT_DesktopProperties/Automated tests to OpenJDK

Hi Alexander, On 07/16/2014 06:37 PM, Alexander Zvegintsev wrote: Hi Dmitriy, Correct me if I am wrong: jtreg keeps DISPLAY and strips many environment variables(e.g. DBUS_SESSION_BUS_ADDRESS). DBUS_SESSION_BUS_ADDRESS variable is needed for correct work of gconftool-2 and gsettings That

Re: [9] Review Request: 8050852 Javadoc cleanup of javax.sound.midi package

Hi Sergey, here is the list where I've found trailing dots: midi/MidiDevice.java:338 midi/SysexMessage.java:127 midi/Synthesizer.java:347 sampled/LineEvent.java:85 sampled/AudioInputStream.java:395 Otherwise the fix looks good to me. Thanks, Alexander. On 07/23/2014 01:44 PM, Sergey Bylokh

Re: [9] Review Request: 8033141 Cleanup of sun.awt.X11 package

Hi Sergey, the fix looks good to me. Thanks, Alexander. On 07/28/2014 07:03 PM, Sergey Bylokhov wrote: Hello. Please review a small KSS fix. Bug: https://bugs.openjdk.java.net/browse/JDK-8033141 Webrev can be found at: http://cr.openjdk.java.net/~serb/8033141/webrev.00

Re: [9] Review Request: 8026497 Font2DTest demo: unused resource files

Hi Sergey, the fix looks good to me. -- Thanks, Alexander. On 08/01/2014 02:25 PM, Sergey Bylokhov wrote: Hello. Please review a small fix for jdk9. Unused property files were removed. Bug: https://bugs.openjdk.java.net/browse/JDK-8026497 Webrev can be found at: http://cr.openjdk.java.net/~s

Review request for 8051617: Fullscreen mode is not working properly on Xorg

Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8051617/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8051617 Our logic for detecting top level window may fail on some window managers. This fix passes this window directly. -- -- Thanks, Alexander.

Re: [9] Review request for 6624085: Fourth mouse button (wheel) is treated like second button - isPopupTrigger returns true

Hello Alex, You are welcome and I am glad to see your contribution to OpenJDK project. Your fix looks good to me, it resolves JDK-6624085 issue too, so let it be fixed under this bug ID. As I can see in jdk9-dev mailing list OCA has been signed by you, so no further action is required from you

Re: [9] Review request for 8055664: move 14 tests about setLocationRelativeTo to jdk

Hello Yuri, IIUC, this test may fail on Ubuntu due to JDK-8036915 [1]. the fix looks good to me in general, but I have some minor comments: 91 testEverything = false; // NB: change this to true to test everything I think this line can be removed and comment should be at line 41. As fo

Re: [9] Review request for 8055664: move 14 tests about setLocationRelativeTo to jdk

Still looks good to me. -- Thanks, Alexander. On 08/28/2014 06:38 PM, Yuri Nesterenko wrote: Thank you Alexander! new version: http://cr.openjdk.java.net/~yan/8055664/webrev.01 -yan On 08/28/2014 05:59 PM, Alexander Zvegintsev wrote: Hello Yuri, IIUC, this test may fail on Ubuntu due to

[9] Review request for 8055746 : plenty of clipboard/dnd tests fail and break X11

Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8055746/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8055746 This is a merge issue. JDK-8051449 [2] was pushed to jdk9/client before the source reorganization fix [1], [2] integration to jdk9/dev was after [1]

Re: The path to flavormap.properties is currently broken in SystemFlavorMap

Hello Ludovic, Your fix solves the issue, but flavormap.properties files movement is part of the JDK-8051449 fix [1] which was lost during the merge. Reason of this movement is mentioned in the JDK-8051449 review thread [2]: On 7/28/14 3:35 PM, Petr Pchelko wrote: > ... > I've changed the pack

Re: [9] Review request for JDK-8056211: JCK test api/java_awt/Event/InputMethodEvent/serial fails

Hello Alexey, the fix looks good to me too. Thanks, Alexander. On 09/02/2014 03:31 PM, Petr Pchelko wrote: Hello, Alexey. The fix looks good to me. With best regards. Petr. On Sep 2, 2014, at 3:09 PM, Alexey Ivanov wrote: Hello AWT team, This is a reminder, Is there any volunteer to r

Re: The path to flavormap.properties is currently broken in SystemFlavorMap

On Mon, Sep 1, 2014 at 9:12 PM, Alexander Zvegintsev wrote: Hello Ludovic, Your fix solves the issue, but flavormap.properties files movement is part of the JDK-8051449 fix [1] which was lost during the merge. Reason of this movement is mentioned in the JDK-8051449 review thread [2]: On 7/28/

Re: [9] Review request for 6624085: Fourth mouse button (wheel) is treated like second button - isPopupTrigger returns true

Hello Alex, Sure, your fix should be available in 8u40, as for 7u-dev it will be decided by sustaining team. BTW, there is no need to make patches by hand for porting from JDK 9 to JDK 8u [1]. [1] http://cr.openjdk.java.net/~chegar/docs/portingScript.html Thanks, Alexander. On 09/02/2014

Re: [9] Review request for 6624085: Fourth mouse button (wheel) is treated like second button - isPopupTrigger returns true

Alex, Actually no action needed from your side, I've created a backport for jdk7 [1], and it looks like they already have a decision. [1] https://bugs.openjdk.java.net/browse/JDK-8057158 -- Thanks, Alexander. 03.09.2014 23:49, Alex Henrie wrote: 2014-09-03 7:50 GMT-06:00 Alex

Re: [9] Review Request: 8058136 Test api/java_awt/SplashScreen/index.html\#ClosedSplashScreenTests fails because of java.lang.IllegalStateException was not thrown

Hello Sergey, the fix looks good to me. Thanks, Alexander. On 09/12/2014 02:26 PM, Sergey Bylokhov wrote: Hello, Please review the fix for jdk 9. According to specification createGraphics() should throw IllegalStateException if the splash screen has already been closed. Bug: https://bugs.o

Re: [9] Review Request: 8055326 Fix typos in client-related packages

Hello Sergey, The fix looks good to me in general, but I have a few comments: It would be nice to add @Override annotation to java.awt.Window.adjustDescendantsOnParent() --- old/src/java.desktop/share/classes/java/awt/Component.java 2014-09-10 15:11:22.601342000 +0400 +++ new/src/java.deskt

Re: [9] Review Request: 8058858 JRE 8u20 crashes while using Japanese IM on Windows

Hello Sergey, the fix looks fine to me. Thanks, Alexander. On 09/22/2014 07:29 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 9. The problem is that we call DeleteLocalRef() on the cached global reference returned by JNU_ClassString(env). Bug: https://bugs.openjdk.java.ne

[9] Review request for 8051857: OperationTimedOut exception inside from XToolkit.syncNativeQueue call

Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8051857/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8051857 We have XNextSecondaryLoopEvent() which blocks all events processing except of this specific types: PropertyNotify, SelectionClear, SelectionNotify

Re: [9] Review request for 8051857: OperationTimedOut exception inside from XToolkit.syncNativeQueue call

(). On 23.09.2014 15:48, Alexander Zvegintsev wrote: Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8051857/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8051857 We have XNextSecondaryLoopEvent() which blocks all events processing except of this specific

Re: [9] Review Request: 8041734 JFrame in full screen mode leaves empty workspace after close

Hi Sergey, the fix looks good to me too. Thanks, Alexander. On 09/22/2014 04:14 PM, Sergey Bylokhov wrote: On 22.09.2014 15:21, Alexander Scherbatiy wrote: The fix looks good to me. Is it possible to write an automated test for the fix? No, at least w/o using some non-public api. Tha

Re: [PATCH] JDK-8058197: AWT fails on generic non-reparenting window managers

Hello Rohit, the fix looks good to me. We will be able to proceed after receiving a second review. (and after OCA Signatories List[1] update with your name in it). Thank you for your contribution to the OpenJDK project! [1] http://www.oracle.com/technetwork/community/oca-486395.html [2] https:

Re: [9] Review Request: 8058115 Some of MidiDeviceProviders do not follow the specification

The fix looks good to me. Thanks, Alexander. On 09/17/2014 09:45 PM, Sergey Bylokhov wrote: On 17.09.2014 21:28, Phil Race wrote: No real problems but I wonder why you made unsupportedDevice declare RuntimeException but actually throw IAE It is shorer, plus decrease the size of the classfile

Re: [9] Review Request: 7148531 [macosx] In test, the window does not have time to resize before make a screenshot

Hello Sergey, the fix looks good to me. Thanks, Alexander. On 10/14/2014 04:31 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 9. - Frame was changed to undecorated to solve a rounded corners(which was a main issue) + moved to the center of the screen. - waitForIdle() was ad

Re: [9] Review Request: 8061315 [JFXPanel, Mac] need an ability to check if Clipboard has been changed from outside of Swing/AWT

Hi Anton, Override annotation is missing in CClipboard, otherwise the fix looks good to me. Thanks, Alexander. On 10/20/2014 01:38 PM, Anton V. Tarasov wrote: Hello, Please review a fix: https://bugs.openjdk.java.net/browse/JDK-8061315 http://cr.openjdk.java.net/~ant/JDK-8061315/webrev.0

[9] Review reuest for 8036915: setLocationRelativeTo stopped working in Ubuntu 13.10 (Unity)

Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8036915/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8036915 The sample in JBS issue reusing one window with setLocationRelativeTo. This issues can be reproduced for a second and following re-appearance of the

Re: [9] Review Request: 8024626 CTW CRASH: SIGSEGV in ctw/jre/lib/rt_jar/preloading_1 and ctw/jre/lib/rt_jar/sun_awt_X11_ListHelper

Hello Sergey, the fix looks good to me. Thanks, Alexander. On 12/02/2014 05:16 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 9. The CTW test individually compiles each class (including the static initializer), and a crash occures during MotifDnDConstants initialization when

Re: [9] Review Request: 6345095 regression test EmptyClipRenderingTest fails

Hello Sergey, the fix looks good to me. Thanks, Alexander. On 12/02/2014 05:34 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 9. - This test fails on osx because of rounded corners. Now it use undecorated frame. - On windows it fails, because sometimes the paint event was

Re: [9] Review request for 8066756: Test test/sun/awt/dnd/8024061/bug8024061.java fails

Hello Alexey, The fix looks good to me too. Thanks, Alexander. On 12/08/2014 01:48 PM, Alexander Scherbatiy wrote: The fix look good to me. Thanks, Alexandr. On 12/5/2014 12:42 PM, Alexey Ivanov wrote: Hello AWT team, Could you please request review the fix for the test failure:

Re: [9] Review Request: 7077826 Unset and empty DISPLAY variable is handled differently by JDK

Hello Sergey, the fix looks fine to me. BTW, export and value assignment can be written in a single line, like: export DISPLAY= Thanks, Alexander. On 12/08/2014 04:02 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 9. After the fix we will use empty $DISPLAY in the same way

[8u40] Request for review 8066986: [headless] DataTransferer.getInstance throws ClassCastException in headless mode

Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/8u/8066986/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8066986 [2] fix for 8u40 was partially reverted by [1] backport. This issue appears due to mixed order of 8u40 backports: Original JDK9 order of fixes is [

Re: [9] Review request for 8065627 Animated GIFs fail to display on a HiDPI display

Hello Alexandr, the fix looks good to me. Thanks, Alexander. On 12/09/2014 06:31 PM, Alexander Scherbatiy wrote: Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8065627 webrev: http://cr.openjdk.java.net/~alexsch/8065627/webrev.00 MultiResolutionToolkit

[9] Review request for 7155963: Deadlock in SystemFlavorMap.getFlavorsForNative and SunToolkit.awtLock

Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/7155963/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-7155963 SunClipboard.checkChange() does not require an awtLock, so we can safely release awtLock for this call. I've run related tests(including JCK), it

Re: [9] Review request for 7155963: Deadlock in SystemFlavorMap.getFlavorsForNative and SunToolkit.awtLock

Hi Sergey, thanks for the review, The new RFE if filed as https://bugs.openjdk.java.net/browse/JDK-8067252 -- Thanks, Alexander. 11.12.2014 19:41, Sergey Bylokhov wrote: Hi, Alexander. The fix looks good. Please file a separate RFE to investigate possibility of splitting dispatchEvent in XTo

Re: [awt-dev] JDK 9 Request for Approval and Review: 8058793: [TEST_BUG] Test sun/awt/datatransfer/DataFlavorComparatorTest.java fails with compilation error

Hello, The fix looks good to me as well. Thanks, Alexander. On 12/22/2014 02:36 PM, Alexander Scherbatiy wrote: The fix looks good to me. Thanks, Alexandr. On 12/22/2014 11:56 AM, srinivasan raghavan wrote: Hello Reminder for review of 8058793 [TEST_BUG] Test sun/awt/datatransf

Re: [9] Review Request: 8068275 Some tests failed after JDK-8063104

Hi Sergey, the fix looks good to me as it is, but I think it can be improved by saving robot instance to a static field (to avoid robot creation at every waitForIdle() call). -- Thanks, Alexander. 25.12.2014 17:08, Sergey Bylokhov пишет: Hello. Please review a small fix for jdk 9. The proble

Re: [9] Review Request: 8068275 Some tests failed after JDK-8063104

Sergey, the fix still looks good to me. -- Thanks, Alexander. 25.12.2014 17:36, Sergey Bylokhov пишет: Hi, Alexander. On 25.12.2014 17:26, Alexander Zvegintsev wrote: but I think it can be improved by saving robot instance to a static field (to avoid robot creation at every waitForIdle() call

awt-dev@openjdk.java.net

Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8068305/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8068305 Unlike the other look and feels, GTK needs to click twice to press a button: the first click dismisses the menu, the second actually clicks on a co

Re:

Please see the updated version, http://cr.openjdk.java.net/~azvegint/jdk/9/8068305/01/ Second click make the original issue[1] check useless, so I decided to make it Metal L&F only. [1] https://bugs.openjdk.java.net/browse/JDK-6769511 Thanks, Alexander. On 01/12/2015 02:59 PM, Alexa

Re: [9] Review Request: 6475361 Attempting to remove help menu from java.awt.MenuBar throws NullPointerException

Hello Sergey, the fix looks good to me. Thanks, Alexander. On 01/12/2015 08:16 PM, Sergey Bylokhov wrote: Hello. Please review a fix for jdk 9. All problems mentioned in the CR were fixed: - Menu.isHelpMenu will be changed to false when a menu is removed from the MenuBar. - MenuBar.helpMen

[9] review request for 8061636: Fix for JDK-7079254 changes behavior of MouseListener, MouseMotionListener

Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8061636/00 for the issue https://bugs.openjdk.java.net/browse/JDK-8061636 7079254 fix[1] introduced a regression in MouseListener, MouseMotionListener behaviour. So this fix contains: rollback of 7079254 memory leak fix b

Re: [9] Review Request: 7185221 [macosx] Regtest should not throw exception if a suitable display mode found

Hello Sergey, the fix looks good to me. -- Thanks, Alexander. On 21.01.2015 20:12, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 9. The test modify a supported list of DisplayModes and try to check that IllegalArgumentException will be thrown. But the problem occurs, when the te

Re: Review Request: 8069015 Re-examine Solaris/Linux java.desktop dependency on java.logging

Hello Sergey, the fix looks fine to me. Thanks, Alexander. On 01/22/2015 08:11 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 9. Additional information about the problem in https://bugs.openjdk.java.net/browse/JDK-6879044 "There are many classes using java.util.logging to lo

Re: [9] Review request for 8064934: Incorrect Exception message from java.awt.Desktop.open()

Hello Dmitry, the fix looks fine to me. Thanks, Alexander. On 01/23/2015 03:00 PM, dmitry markov wrote: Hello, Could you review the fix for jdk9, please? bug: https://bugs.openjdk.java.net/browse/JDK-8064934 webrev: http://cr.openjdk.java.net/~dmarkov/8064934/jdk9/webrev.00/ Proble

[9] Review request for 8071483: Possible case-folding collision for color/Color subdirectories of jdk/test/java/awt/ (was: Re: jdk/test/java/awt/Color vs color directory name)

Hello Roger, I think it is unintentional. jdk/test/java/awt/color tests were added a few months ago (JDK-8039271 [1],JDK-8058969[2]): I've created an issue JDK-8071483 [3]. I also want convert this thread to a review request, here is the fix: http://cr.openjdk.java.net/~azvegint/jdk/9/8071483/0

Re: [9] Review Request: 8062738 Test java/awt/datatransfer/MissedHtmlAndRtfBug/MissedHtmlAndRtfBug fails in Windows

Hi Sergey, the fix looks fine to me. Thanks, Alexander. On 02/02/2015 04:52 PM, Sergey Bylokhov wrote: Hello. Please review a fix for jdk 9. Description: In the fix for JDK-8051449 was an incorrect assumption that String.replace() replaces only the first text occurrence, and it was changed

[9] Review request for 8072088: [PIT] NPE in DnD tests apparently because of the fix to JDK-8061636

Hello, please review the fix: http://cr.openjdk.java.net/~azvegint/jdk/9/8072088/00/ for the issue: https://bugs.openjdk.java.net/browse/JDK-8072088 Removed WeakReference nullification. -- Thanks, Alexander.

Re: [9] Review Request: 8068412 [macosx] Initialization of Cocoa hangs if CoreAudio was initialized before

Hi Sergey, the fix looks good to me. Thanks, Alexander. On 02/09/2015 04:10 PM, Sergey Bylokhov wrote: Hello. Please review a fix for jdk 9. The problem is that NSApplicationDidFinishLaunchingNotification is not coming if we find AudioOutputUnit via FindNextComponent before NSApplication wi

Re: [9] Review request for 7000965: NPE in sun.awt.X11.XlibWrapper.XGetAtomName on paste

Hi Denis, I don't think that this fix can help, since XAtom.get(long) doesn't return null value[0]. The NPE is thrown from native[1]. [0] http://hg.openjdk.java.net/jdk9/client/jdk/file/cf29d39bf0de/src/java.desktop/unix/classes/sun/awt/X11/XAtom.java#l168 [1] http://hg.openjdk.java.net/jdk9

Re: [9] Review request for 8072069: Toolkit.getScreenInsets() doesn't update if insets change

Hello Anton, getScreenInsets() is called from repositionSecurityWarning() also (which is called on every LWWindowPeer.notifyReshape()). It probably may affect performance in case when security warning is shown while resizing a window. Could you please check this case? If this leads to impaire

Re: [9] Review request for 8072069: Toolkit.getScreenInsets() doesn't update if insets change

ative method call time with a microbenchmark: it shows < 0.1ms/call. Thus we got ~1-2ms overhead for a single window resize. Visually there is no performance degradation. Thanks! Anton. On 13.02.2015 16:03, Alexander Zvegintsev wrote: Hello Anton, getScreenInsets() is cal

Re: [9] Review Request: 8043393 NullPointerException and no event received when clipboard data flavor changes

Hi Sergey, the fix looks good to me. Thanks, Alexander. On 02/24/2015 03:20 PM, Sergey Bylokhov wrote: Hello. Please review a fix for jdk 9. The NPE occurs, because we call getDefaultFlavorMap() on the Toolkit thread (formatArrayAsDataFlavorSet->getDefaultFlavorTable->SystemFlavorMap.getDef

[9] Review request for 8056151: Switching to GTK L&F on-the-fly leads to X Window System error RenderBadPicture

Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8056151/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8056151 There are several prerequisites for this crash: enabled XRender pipeline, visible window with non-opaque background with L&F other than GTK. Switc

  1   2   3   4   5   >