Re: jtreg failing in awt tests

2016-11-23 Thread Jonathan Gibbons
explained anywhere in the docs. The 10 second tax for the jdk repo is just small enough that everyone just lives with it, not knowing about -noreport. I'm guessing most people would be happier if -noreport was the default. On Wed, Nov 23, 2016 at 1:42 PM, Jonathan Gibbons <jona

Re: jtreg failing in awt tests

2016-11-23 Thread Jonathan Gibbons
That bears investigation ... next week, -- Jon On 11/23/2016 07:39 PM, Philip Race wrote: We have a PIT (pre-integration-testing process) but if that these clashes are presented only as an FYI and not an actual failure then SQE might not notice it. It may even get swallowed and not forwarded

Re: jtreg failing in awt tests

2016-11-23 Thread Jonathan Gibbons
On 11/23/2016 12:47 PM, Martin Buchholz wrote: Am I the only one seeing jtreg test failures in latest jdk9/dev, apparently due to https://bugs.openjdk.java.net/browse/JDK-8160766 Error: Test clashes with another test with a similar name:

Re: jtreg failing in awt tests

2016-11-23 Thread Jonathan Gibbons
for every jtreg invocation. On Wed, Nov 23, 2016 at 12:57 PM, Jonathan Gibbons <jonathan.gibb...@oracle.com <mailto:jonathan.gibb...@oracle.com>> wrote: On 11/23/2016 12:47 PM, Martin Buchholz wrote: Am I the only one seeing jtreg test failures in latest jd

Re: [9] Review Request: 8180326 Update the tables in java.desktop to be HTML-5 friendly

2017-05-12 Thread Jonathan Gibbons
On 05/12/2017 05:03 PM, Philip Race wrote: On 5/12/17, 4:58 PM, Jonathan Gibbons wrote: Phil, 1. javadoc now provides support for 3 named styles in the default stylesheet: borderless: no borders plain: simple 1px borders around tables and cells striped: reduced

Re: [9] Review Request: 8180326 Update the tables in java.desktop to be HTML-5 friendly

2017-05-12 Thread Jonathan Gibbons
Phil, 1. javadoc now provides support for 3 named styles in the default stylesheet: borderless: no borders plain: simple 1px borders around tables and cells striped: reduced borders; rows have alternating white and light grey backgrounds 2. summary attributes are

Re: [9] Review Request: 8180326 Update the tables in java.desktop to be HTML-5 friendly

2017-05-12 Thread Jonathan Gibbons
Sergey, FWIW, the invisible caption should be regarded as a temporary solution, until content authors can review/update the text of the caption and make it visible. The general guideline in this conversion work has been to avoid changing the visible text of the specification, and captions

Re: [9] Review Request: 8180326 Update the tables in java.desktop to be HTML-5 friendly

2017-05-17 Thread Jonathan Gibbons
to be visible when we were fine without. But being there and invisible may be pointless unless screen readers look for it even if invisible. But if its not doing any harm I guess we can leave it as proposed I still need to look at the rest of the changes. -phil. On 05/12/2017 05:11 PM, Jo

Re: [9] Review Request: 8180326 Update the tables in java.desktop to be HTML-5 friendly

2017-05-17 Thread Jonathan Gibbons
On 05/17/2017 11:52 AM, Jonathan Gibbons wrote: Phil, The bottom line is that in the JDK docs, tables should not have a summary attribute and should have a caption. This comes down to accessibility requirements, where we are slowly raising the bar on our docs, to be in accordance with Oracle

Re: [10] Review Request: 8182410, 8183508, 8181289

2017-11-22 Thread Jonathan Gibbons
Semyon, Using the files I previously posted, I confirm that I see the same display problem on a Mac, using the latest OS (High Sierra) and Safari. I also see the problem on the same Mac, with Firefox 55.0.2 -- Jon On 11/22/2017 02:53 PM, Jonathan Gibbons wrote: Semyon, I have

Re: [10] Review Request: 8182410, 8183508, 8181289

2017-11-22 Thread Jonathan Gibbons
about following to the HTML5 standards, so let's follow them in full and not to return to this once again. We have a good chance to provide documentation in clean HTML5 after the fix without any workarounds. --Semyon On 11/14/2017 09:16 AM, Jonathan Gibbons wrote: Semyon, I read the HTML

Re: [10] Review Request: 8182410, 8183508, 8181289

2017-11-22 Thread Jonathan Gibbons
margin-top: -129px; } so nothing specific comes from browser or " I think the next link may help you http://nicolasgallagher.com/jump-links-and-viewport-positioning/demo/ --Semyon On 11/22/2017 02:53 PM, Jonathan Gibbons wrote: Semyon, I have reconstructed a very simple, very artificial

Re: RFR 8191736: replace javah w/ javac in jdk tests

2017-11-21 Thread Jonathan Gibbons
Shura, Looks OK to me, although I'm not normally a Reviewer for AWT tests. -- Jon On 11/21/17 3:58 PM, Alexandre (Shura) Iline wrote: Hi. Please take look on this quick fix of removing remains of javah usages from test/jdk. Bug: https://bugs.openjdk.java.net/browse/JDK-8191736 Webrev:

Re: [10] Review Request: 8182410, 8183508, 8181289

2017-11-14 Thread Jonathan Gibbons
10/25/17 6:31 PM, Semyon Sadetsky wrote: Hi Jonathan, On 10/24/2017 03:20 PM, Jonathan Gibbons wrote: Semyon, Although id is a global attribute and can be used to identify any node, some browsers do better navigation/scrolling when the id is in an tag.  We have seen poor autoscrolling beh

Re: [10] Review Request: 8182410, 8183508, 8181289

2017-10-24 Thread Jonathan Gibbons
Semyon, Although id is a global attribute and can be used to identify any node, some browsers do better navigation/scrolling when the id is in an tag. We have seen poor autoscrolling behavior when the id is an a header tag, such that the header ends up obscured under the navigation bar at

FYI: new javadoc tag to document system properties

2018-11-14 Thread Jonathan Gibbons
This is an FYI to announce some initial, long-overdue support in javadoc for documenting system properties (JDK-5076751). Currently, system properties are just documented using ad-hoc narrative text, which is fine if you know where to look for any given property. JDK 12 introduces a new

Re: RFR: 8252999: Cleanup: replace .equals("") with .isEmpty() within all codebase

2020-09-10 Thread Jonathan Gibbons
On Thu, 10 Sep 2020 12:04:48 GMT, Dmitriy Dumanskiy wrote: > I have in mind dozens of improvements all over the code like this one. That sounds scary. Broad updates like these cause unnecessary churn in the codebase, and can make merging and back porting harder. Changes should be discussed

Re: RFR: 8260314: Replace border="1" on tables with CSS

2021-01-26 Thread Jonathan Gibbons
On Tue, 26 Jan 2021 18:33:48 GMT, Alexey Ivanov wrote: >>> Probably we can import the CSS used by the javadoc itself? >> >> We do. For example, [AWT Modality in JDK >> 15](https://docs.oracle.com/en/java/javase/15/docs/api/java.desktop/java/awt/doc-files/Modality.html) >> has borders because

RFR: JDK-8262420: typo: @implnote in java.desktop module

2021-02-25 Thread Jonathan Gibbons
Please review some doc changes in `java.awt.TrayIcon`. Note, the fix is more than the 1-character fix for the typo detected by doclint. The changes are: 1. Fix the name of the `@implNote` tag 2. Remove the redundant `` before the `@implNote` tag 3. Move the `@implNote` tag and its immediate

Re: New candidate JEP: 398: Deprecate the Applet API for Removal

2021-03-05 Thread Jonathan Gibbons
On 3/5/21 2:19 PM, mark.reinh...@oracle.com wrote: https://openjdk.java.net/jeps/398 Summary: Deprecate the Applet API for removal. It is essentially irrelevant since all web-browser vendors have either removed support for Java browser plug-ins or announced plans to do so. - Mark

Re: New candidate JEP: 398: Deprecate the Applet API for Removal

2021-03-05 Thread Jonathan Gibbons
is the only truly viable one. But definitely re-working all of those is one thing that has to happen before this JEP can be integrated. And of course submitted != targeted .. -phil On 3/5/21 2:37 PM, Jonathan Gibbons wrote: On 3/5/21 2:19 PM, mark.reinh...@oracle.com wrote: https

Integrated: JDK-8262420: typo: @implnote in java.desktop module

2021-02-26 Thread Jonathan Gibbons
On Thu, 25 Feb 2021 23:15:03 GMT, Jonathan Gibbons wrote: > Please review some doc changes in `java.awt.TrayIcon`. > > Note, the fix is more than the 1-character fix for the typo detected by > doclint. The changes are: > > 1. Fix the name of the `@implNote` tag > 2.