Re: AWT Dev [7u4] Review request for 7154177: [macosx] An invisible owner frame becomes visible upon clicking a child window

2012-03-20 Thread Anthony Petrov
Hi Sergey, Thanks for the review. Indeed, a test case should be fine for this fix, so here's the updated webrev: http://cr.openjdk.java.net/~anthony/7u4-5-invisibleOwner-7154177.1/ As to the 2), I prefer to not add tests for things that should be improved eventually, so instead I've filed a

Re: AWT Dev [7u4] Review request for 7154177: [macosx] An invisible owner frame becomes visible upon clicking a child window

2012-03-20 Thread Sergey Bylokhov
Hi, Anthony. looks good. 20.03.2012 16:07, Anthony Petrov wrote: Hi Sergey, Thanks for the review. Indeed, a test case should be fine for this fix, so here's the updated webrev: http://cr.openjdk.java.net/~anthony/7u4-5-invisibleOwner-7154177.1/ As to the 2), I prefer to not add tests for

Re: AWT Dev [7u4] Review request for 7154177: [macosx] An invisible owner frame becomes visible upon clicking a child window

2012-03-19 Thread Sergey Bylokhov
Hi Anthony. probably it would be good to add 2 regression tests for this issue? 1) For the current issue, which wasn't found by the existing tests. 2) For the issue which was not resolved in the current fix. 16.03.2012 19:22, Anthony Petrov wrote: Hello, Please review a fix for