[Ayatana-commits] [Merge] lp:~ken-vandine/libindicate/server_add_annotations into lp:libindicate

2011-05-31 Thread Ted Gould
The proposal to merge lp:~ken-vandine/libindicate/server_add_annotations into lp:libindicate has been updated. Status: Needs review = Work in progress For more details, see: https://code.launchpad.net/~ken-vandine/libindicate/server_add_annotations/+merge/58133 --

Re: [Ayatana-commits] [Merge] lp:~ken-vandine/libindicate/server_add_annotations into lp:libindicate

2011-05-31 Thread Ted Gould
Review: Needs Fixing -- https://code.launchpad.net/~ken-vandine/libindicate/server_add_annotations/+merge/58133 Your team ayatana-commits is subscribed to branch lp:libindicate. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to :

Re: [Ayatana-commits] [Merge] lp:~mterry/indicator-session/gtk3 into lp:indicator-session

2011-05-31 Thread Ted Gould
Review: Needs Fixing Hmm, it seems that session-service.c needs the same header check. But, it seems more likely that Dbusmenu is broken there. Are other libraries requiring that change? Seems it should be /usr/lib/libdbusmenu3-0.4/libdbusmenu-gtk, eh? --

Re: [Ayatana-commits] [Merge] lp:~mterry/indicator-messages/gtk3 into lp:indicator-messages

2011-05-31 Thread Ted Gould
Review: Approve Code looks fine. Worried about the dbusmenu-gtk3 includes though :-/ (see last review's comment). -- https://code.launchpad.net/~mterry/indicator-messages/gtk3/+merge/62527 Your team ayatana-commits is subscribed to branch lp:indicator-messages.

[Ayatana-commits] [Merge] lp:~mterry/indicator-messages/gtk3 into lp:indicator-messages

2011-05-31 Thread Ted Gould
The proposal to merge lp:~mterry/indicator-messages/gtk3 into lp:indicator-messages has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~mterry/indicator-messages/gtk3/+merge/62527 --

Re: [Ayatana] Global menu in Oneiric Ocelot (11.10)

2011-05-19 Thread Ted Gould
On Thu, 2011-05-19 at 13:08 -0400, anthropornis wrote: Does making an application Unity compatible involve more than making the menu entries exportable over the DBus system? Relative to other programming issues, is that more difficult, less difficult, or the same difficulty as other common

Re: [Ayatana] Message Indicator Behavior

2011-05-19 Thread Ted Gould
On Sun, 2011-05-15 at 00:03 -0400, Brandon Watkins wrote: The message indicator really needs some love. The current behavior is pretty un-intuitive regarding IM's. When you get a new IM you can click the indicator and click the message their to bring up the chat window, this is great.

[Ayatana-commits] [Merge] lp:~ted/indicator-session/classic-session into lp:indicator-session

2011-05-12 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/indicator-session/classic-session into lp:indicator-session. Requested reviews: Indicator Applet Developers (indicator-applet-developers) For more details, see: https://code.launchpad.net/~ted/indicator-session/classic-session/+merge/60746 Add

[Ayatana-commits] [Merge] lp:~ken-vandine/libindicate/vapi_fixes into lp:libindicate

2011-04-18 Thread Ted Gould
The proposal to merge lp:~ken-vandine/libindicate/vapi_fixes into lp:libindicate has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~ken-vandine/libindicate/vapi_fixes/+merge/57959 --

[Ayatana-commits] [Merge] lp:~karl-qdh/indicator-datetime/appointmentwidth into lp:indicator-datetime

2011-04-18 Thread Ted Gould
The proposal to merge lp:~karl-qdh/indicator-datetime/appointmentwidth into lp:indicator-datetime has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~karl-qdh/indicator-datetime/appointmentwidth/+merge/58098 --

Re: [Ayatana-commits] [Merge] lp:~ken-vandine/indicator-me/lp_754524 into lp:indicator-me

2011-04-14 Thread Ted Gould
Review: Approve -- https://code.launchpad.net/~ken-vandine/indicator-me/lp_754524/+merge/57713 Your team ayatana-commits is subscribed to branch lp:indicator-me. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to :

[Ayatana-commits] [Merge] lp:~ted/indicator-session/lp747818 into lp:indicator-session

2011-04-13 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/indicator-session/lp747818 into lp:indicator-session. Requested reviews: Indicator Applet Developers (indicator-applet-developers) Related bugs: Bug #747818 in Session Menu: indicator-session-service crashed with SIGABRT in g_closure_invoke() https

Re: [Ayatana-commits] [Merge] lp:~mterry/indicator-datetime/locale-and-version into lp:indicator-datetime

2011-04-06 Thread Ted Gould
Review: Approve On Wed, 2011-04-06 at 15:08 +, Michael Terry wrote: + version = ; This needs to be g_strdup() so that we can free it later. I'll fix on merge. review approve merge approve -- https://code.launchpad.net/~mterry/indicator-datetime/locale-and-version/+merge/56586

[Ayatana-commits] [Merge] lp:~ted/indicator-datetime/full-day-events into lp:indicator-datetime

2011-04-05 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/indicator-datetime/full-day-events into lp:indicator-datetime. Requested reviews: Karl Lattimer (karl-qdh) For more details, see: https://code.launchpad.net/~ted/indicator-datetime/full-day-events/+merge/56464 I think this handles the full day events

Re: [Ayatana-commits] [Merge] lp:~ken-vandine/indicator-me/lp_746962 into lp:indicator-me

2011-04-04 Thread Ted Gould
Review: Approve review approve -- https://code.launchpad.net/~ken-vandine/indicator-me/lp_746962/+merge/56209 Your team ayatana-commits is subscribed to branch lp:indicator-me. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to :

[Ayatana-commits] [Merge] lp:~ted/indicator-session/lp745323 into lp:indicator-session

2011-04-04 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/indicator-session/lp745323 into lp:indicator-session. Requested reviews: Indicator Applet Developers (indicator-applet-developers) Related bugs: Bug #745323 in Session Menu: unity-panel-service crashed with SIGABRT in g_simple_async_result_complete

Re: [Ayatana-commits] [Merge] lp:~ken-vandine/indicator-me/lp_739319 into lp:indicator-me

2011-03-29 Thread Ted Gould
Review: Approve -- https://code.launchpad.net/~ken-vandine/indicator-me/lp_739319/+merge/55367 Your team ayatana-commits is subscribed to branch lp:indicator-me. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to :

[Ayatana-commits] [Merge] lp:~ken-vandine/indicator-me/lp_739319 into lp:indicator-me

2011-03-29 Thread Ted Gould
The proposal to merge lp:~ken-vandine/indicator-me/lp_739319 into lp:indicator-me has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~ken-vandine/indicator-me/lp_739319/+merge/55367 --

Re: [Ayatana-commits] [Merge] lp:~karl-qdh/indicator-datetime/calendarmenuitemsignals into lp:indicator-datetime

2011-03-15 Thread Ted Gould
Review: Approve review approve merge approve -- https://code.launchpad.net/~karl-qdh/indicator-datetime/calendarmenuitemsignals/+merge/53467 Your team ayatana-commits is subscribed to branch lp:indicator-datetime. ___ Mailing list:

Re: [Ayatana-commits] [Merge] lp:~ken-vandine/indicator-me/lp_655252 into lp:indicator-me

2011-03-10 Thread Ted Gould
Review: Approve review approve merge approve -- https://code.launchpad.net/~ken-vandine/indicator-me/lp_655252/+merge/52893 Your team ayatana-commits is subscribed to branch lp:indicator-me. ___ Mailing list: https://launchpad.net/~ayatana-commits

[Ayatana-commits] [Merge] lp:~gunnarhj/indicator-session/fix-636693 into lp:indicator-session

2011-03-10 Thread Ted Gould
The proposal to merge lp:~gunnarhj/indicator-session/fix-636693 into lp:indicator-session has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~gunnarhj/indicator-session/fix-636693/+merge/37200 --

[Ayatana-commits] [Merge] lp:~ted/indicator-session/no-lock into lp:indicator-session

2011-03-10 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/indicator-session/no-lock into lp:indicator-session. Requested reviews: Indicator Applet Developers (indicator-applet-developers) For more details, see: https://code.launchpad.net/~ted/indicator-session/no-lock/+merge/52932 Use the no lock feature

Re: [Ayatana-commits] [Merge] lp:~karl-qdh/indicator-datetime/calendarmenuitemsignals into lp:indicator-datetime

2011-03-08 Thread Ted Gould
Review: Needs Fixing On Tue, 2011-03-08 at 15:46 +, Karl Lattimer wrote: + t2 = t1 + (time_t) (7 * 24 * 60 * 60); /* 7 days ahead of now, we actually need number_of_days_in_this_month */ Could you please make this comment a TODO. + } else if (!g_strcmp0(prop,

Re: [Ayatana-commits] [Merge] lp:~karl-qdh/indicator-datetime/fixappointmentformat into lp:indicator-datetime

2011-03-08 Thread Ted Gould
Review: Needs Fixing On Tue, 2011-03-08 at 16:09 +, Karl Lattimer wrote: + gchar *time_format_str = g_settings_get_string(conf, SETTINGS_TIME_FORMAT_S); + gint apt_output; + if (g_strcmp0(time_format_str, 12-hour) == 0) { + apt_output = SETTINGS_TIME_12_HOUR; +

Re: [Ayatana-commits] [Merge] lp:~karl-qdh/indicator-datetime/colours-refresh-fix into lp:indicator-datetime

2011-03-07 Thread Ted Gould
Review: Approve On Fri, 2011-03-04 at 23:23 +, Karl Lattimer wrote: gtk lookup icon size returns 12x13 the first time but -somehugenumber after that, so I went with what came out, I can change it to 12x12 if you'd prefer? No, it just seemed like an odd change :) I'm good then. review

Re: [Ayatana] Messaging / terminology questions

2011-03-05 Thread Ted Gould
On Fri, 2011-03-04 at 21:10 -0800, Dylan McCall wrote: * The Me Menu. I remember “Me Menu” being a code name at one point. Has that moved up to being what we call it for end users, too? Yes, it is The Me Menu. (see below) * The messaging menu and other menus are

[Ayatana-commits] [Merge] lp:~karl-qdh/indicator-datetime/week-numbers-on-start into lp:indicator-datetime

2011-03-04 Thread Ted Gould
Ted Gould has proposed merging lp:~karl-qdh/indicator-datetime/week-numbers-on-start into lp:indicator-datetime with lp:~karl-qdh/indicator-datetime/colours-refresh-fix as a prerequisite. Requested reviews: Ted Gould (ted) Related bugs: #729020 indicator datetime calendar doesn't show week

Re: [Ayatana-commits] [Merge] lp:~karl-qdh/indicator-datetime/week-numbers-on-start into lp:indicator-datetime

2011-03-04 Thread Ted Gould
Review: Approve -- https://code.launchpad.net/~karl-qdh/indicator-datetime/week-numbers-on-start/+merge/52214 Your team ayatana-commits is subscribed to branch lp:indicator-datetime. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to

Re: [Ayatana-commits] [Merge] lp:~karl-qdh/indicator-datetime/colours-refresh-fix into lp:indicator-datetime

2011-03-04 Thread Ted Gould
Review: Needs Information Why are the defaults now 12x13 instead of 12x12? -- https://code.launchpad.net/~karl-qdh/indicator-datetime/colours-refresh-fix/+merge/52175 Your team ayatana-commits is subscribed to branch lp:indicator-datetime. ___ Mailing

[Ayatana-commits] [Merge] lp:~karl-qdh/indicator-datetime/colours-refresh-fix into lp:indicator-datetime

2011-03-04 Thread Ted Gould
The proposal to merge lp:~karl-qdh/indicator-datetime/colours-refresh-fix into lp:indicator-datetime has been updated. Status: Needs review = Work in progress For more details, see: https://code.launchpad.net/~karl-qdh/indicator-datetime/colours-refresh-fix/+merge/52175 --

Re: [Ayatana-commits] [Merge] lp:~mterry/indicator-datetime/visual-nits into lp:indicator-datetime

2011-03-03 Thread Ted Gould
Review: Approve review approve merge approve If mpt is happy, I am happy :) -- https://code.launchpad.net/~mterry/indicator-datetime/visual-nits/+merge/52078 Your team ayatana-commits is subscribed to branch lp:indicator-datetime. ___ Mailing

Re: [Ayatana-commits] [Merge] lp:~karl-qdh/indicator-datetime/fixed-appointment-icon-colours into lp:indicator-datetime

2011-03-03 Thread Ted Gould
Review: Approve review approve merge approve -- https://code.launchpad.net/~karl-qdh/indicator-datetime/fixed-appointment-icon-colours/+merge/52080 Your team ayatana-commits is subscribed to branch lp:indicator-datetime. ___ Mailing list:

[Ayatana-commits] [Merge] lp:~ted/dbusmenu/icon-theme-directories into lp:dbusmenu

2011-03-03 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/dbusmenu/icon-theme-directories into lp:dbusmenu. Requested reviews: Conor Curran (cjcurran) For more details, see: https://code.launchpad.net/~ted/dbusmenu/icon-theme-directories/+merge/52099 Adds a property for icon theme directories. -- https

[Ayatana-commits] [Merge] lp:~ken-vandine/indicator-datetime/simplify_cal_query into lp:indicator-datetime

2011-03-03 Thread Ted Gould
The proposal to merge lp:~ken-vandine/indicator-datetime/simplify_cal_query into lp:indicator-datetime has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~ken-vandine/indicator-datetime/simplify_cal_query/+merge/51694 --

Re: [Ayatana-commits] [Merge] lp:~ken-vandine/indicator-datetime/close_should_quit into lp:indicator-datetime

2011-03-03 Thread Ted Gould
Review: Approve -- https://code.launchpad.net/~ken-vandine/indicator-datetime/close_should_quit/+merge/52109 Your team ayatana-commits is subscribed to branch lp:indicator-datetime. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to

[Ayatana-commits] [Merge] lp:~ken-vandine/indicator-datetime/close_should_quit into lp:indicator-datetime

2011-03-03 Thread Ted Gould
The proposal to merge lp:~ken-vandine/indicator-datetime/close_should_quit into lp:indicator-datetime has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~ken-vandine/indicator-datetime/close_should_quit/+merge/52109 --

[Ayatana-commits] [Merge] lp:~ken-vandine/libindicate/annotation_fixes into lp:libindicate

2011-03-03 Thread Ted Gould
The proposal to merge lp:~ken-vandine/libindicate/annotation_fixes into lp:libindicate has been updated. Status: Needs review = Work in progress For more details, see: https://code.launchpad.net/~ken-vandine/libindicate/annotation_fixes/+merge/43575 --

[Ayatana-commits] [Merge] lp:~ken-vandine/libindicate/annotation_fixes into lp:libindicate

2011-03-03 Thread Ted Gould
The proposal to merge lp:~ken-vandine/libindicate/annotation_fixes into lp:libindicate has been updated. Status: Needs review = Work in progress For more details, see: https://code.launchpad.net/~ken-vandine/libindicate/annotation_fixes/+merge/43575 --

[Ayatana-commits] [Merge] lp:~dbarth/indicator-me/gconf-switch into lp:indicator-me

2011-03-03 Thread Ted Gould
The proposal to merge lp:~dbarth/indicator-me/gconf-switch into lp:indicator-me has been updated. Status: Needs review = Work in progress For more details, see: https://code.launchpad.net/~dbarth/indicator-me/gconf-switch/+merge/35094 --

[Ayatana-commits] [Merge] lp:~dbarth/indicator-me/gconf-switch into lp:indicator-me

2011-03-03 Thread Ted Gould
The proposal to merge lp:~dbarth/indicator-me/gconf-switch into lp:indicator-me has been updated. Status: Needs review = Work in progress For more details, see: https://code.launchpad.net/~dbarth/indicator-me/gconf-switch/+merge/35094 --

[Ayatana-commits] [Merge] lp:~mterry/indicator-me/gsettings into lp:indicator-me

2011-03-03 Thread Ted Gould
The proposal to merge lp:~mterry/indicator-me/gsettings into lp:indicator-me has been updated. Status: Needs review = Work in progress For more details, see: https://code.launchpad.net/~mterry/indicator-me/gsettings/+merge/38005 --

[Ayatana-commits] [Merge] lp:~ken-vandine/evolution-indicator/unity_counter into lp:evolution-indicator

2011-03-03 Thread Ted Gould
The proposal to merge lp:~ken-vandine/evolution-indicator/unity_counter into lp:evolution-indicator has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~ken-vandine/evolution-indicator/unity_counter/+merge/50821 --

[Ayatana-commits] [Merge] lp:~ken-vandine/evolution-indicator/unity_counter into lp:evolution-indicator

2011-03-03 Thread Ted Gould
The proposal to merge lp:~ken-vandine/evolution-indicator/unity_counter into lp:evolution-indicator has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~ken-vandine/evolution-indicator/unity_counter/+merge/50821 --

Re: [Ayatana-commits] [Merge] lp:~agateau/dbusmenu/dbus-compliant-names into lp:dbusmenu

2011-03-02 Thread Ted Gould
Review: Approve review approve merge approve -- https://code.launchpad.net/~agateau/dbusmenu/dbus-compliant-names/+merge/51878 Your team ayatana-commits is subscribed to branch lp:dbusmenu. ___ Mailing list: https://launchpad.net/~ayatana-commits

[Ayatana-commits] [Merge] lp:~ted/dbusmenu/destroy-prototype-change into lp:dbusmenu

2011-03-02 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/dbusmenu/destroy-prototype-change into lp:dbusmenu. Requested reviews: DBus Menu Team (dbusmenu-team) For more details, see: https://code.launchpad.net/~ted/dbusmenu/destroy-prototype-change/+merge/51922 Change the prototype to be a GDestroyNotify so

[Ayatana-commits] [Merge] lp:~chrisccoulson/appmenu-gtk/lp718926 into lp:appmenu-gtk

2011-03-02 Thread Ted Gould
The proposal to merge lp:~chrisccoulson/appmenu-gtk/lp718926 into lp:appmenu-gtk has been updated. Status: Needs review = Work in progress For more details, see: https://code.launchpad.net/~chrisccoulson/appmenu-gtk/lp718926/+merge/51504 --

Re: [Ayatana-commits] [Merge] lp:~ken-vandine/indicator-me/tp_am_cleanup into lp:indicator-me

2011-03-02 Thread Ted Gould
Review: Approve -- https://code.launchpad.net/~ken-vandine/indicator-me/tp_am_cleanup/+merge/51944 Your team ayatana-commits is subscribed to branch lp:indicator-me. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to :

[Ayatana-commits] [Merge] lp:~ken-vandine/indicator-me/tp_am_cleanup into lp:indicator-me

2011-03-02 Thread Ted Gould
The proposal to merge lp:~ken-vandine/indicator-me/tp_am_cleanup into lp:indicator-me has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~ken-vandine/indicator-me/tp_am_cleanup/+merge/51944 --

[Ayatana-commits] [Merge] lp:~ken-vandine/indicator-me/let_there_be_online into lp:indicator-me

2011-03-02 Thread Ted Gould
The proposal to merge lp:~ken-vandine/indicator-me/let_there_be_online into lp:indicator-me has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~ken-vandine/indicator-me/let_there_be_online/+merge/51965 --

[Ayatana-commits] [Merge] lp:~mterry/indicator-datetime/spin-buttons into lp:indicator-datetime

2011-03-02 Thread Ted Gould
The proposal to merge lp:~mterry/indicator-datetime/spin-buttons into lp:indicator-datetime has been updated. Status: Needs review = Work in progress For more details, see: https://code.launchpad.net/~mterry/indicator-datetime/spin-buttons/+merge/51824 --

[Ayatana-commits] [Merge] lp:~chrisccoulson/dbusmenu/bluetooth-applet-fix into lp:dbusmenu

2011-03-01 Thread Ted Gould
The proposal to merge lp:~chrisccoulson/dbusmenu/bluetooth-applet-fix into lp:dbusmenu has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~chrisccoulson/dbusmenu/bluetooth-applet-fix/+merge/51764 --

[Ayatana-commits] [Merge] lp:~chrisccoulson/dbusmenu/lp723873 into lp:dbusmenu

2011-03-01 Thread Ted Gould
The proposal to merge lp:~chrisccoulson/dbusmenu/lp723873 into lp:dbusmenu has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~chrisccoulson/dbusmenu/lp723873/+merge/51648 --

[Ayatana-commits] [Merge] lp:~chrisccoulson/dbusmenu/theme_changed_cb_disconnect into lp:dbusmenu

2011-03-01 Thread Ted Gould
The proposal to merge lp:~chrisccoulson/dbusmenu/theme_changed_cb_disconnect into lp:dbusmenu has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~chrisccoulson/dbusmenu/theme_changed_cb_disconnect/+merge/51596 --

Re: [Ayatana-commits] [Merge] lp:~chrisccoulson/dbusmenu/lp720895 into lp:dbusmenu

2011-03-01 Thread Ted Gould
Review: Approve I moved the keyname check to before the builder is initialized to avoid a possible leak with the builder there. Otherwise all good. -- https://code.launchpad.net/~chrisccoulson/dbusmenu/lp720895/+merge/51594 Your team ayatana-commits is subscribed to branch lp:dbusmenu.

[Ayatana-commits] [Merge] lp:~ted/appmenu-gtk/alt-to-alert into lp:appmenu-gtk

2011-02-28 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/appmenu-gtk/alt-to-alert into lp:appmenu-gtk. Requested reviews: Canonical Desktop Experience Team (canonical-dx-team) For more details, see: https://code.launchpad.net/~ted/appmenu-gtk/alt-to-alert/+merge/51645 When the appropriate key is used to show

[Ayatana-commits] [Merge] lp:~ted/dbusmenu/use-correct-i18n into lp:dbusmenu

2011-02-26 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/dbusmenu/use-correct-i18n into lp:dbusmenu. Requested reviews: DBus Menu Team (dbusmenu-team) For more details, see: https://code.launchpad.net/~ted/dbusmenu/use-correct-i18n/+merge/51430 Use the library i18n instead of the program one. -- https

[Ayatana-commits] [Merge] lp:~ted/dbusmenu/grrr-use-right-interfaces into lp:dbusmenu

2011-02-26 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/dbusmenu/grrr-use-right-interfaces into lp:dbusmenu. Requested reviews: DBus Menu Team (dbusmenu-team) For more details, see: https://code.launchpad.net/~ted/dbusmenu/grrr-use-right-interfaces/+merge/51431 Fixing the gir scanner so it only provides

Re: [Ayatana-commits] [Merge] lp:~chrisccoulson/dbusmenu/more-memory-fixes into lp:dbusmenu

2011-02-24 Thread Ted Gould
Review: Approve A few comments: * Please don't comment out code. Either delete or fix, we have version control to find old code if we need it. * Added a check to see if we're the parent to delete or else we could end up with really weird unparenting from non-parents. * get_parent() needs a

Re: [Ayatana-commits] [Merge] lp:~mathieu-tl/dbusmenu/widget_notify_properties_access into lp:dbusmenu

2011-02-24 Thread Ted Gould
Review: Approve Well, I think that this patch is an improvement. But, I don't think it'll fix that bug. So I'll merge the patch, but I think that we need to find someone that could recreate the crash before to see if it still exists. --

[Ayatana-commits] [Merge] lp:~ted/dbusmenu/signals-do-crazy-shit into lp:dbusmenu

2011-02-24 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/dbusmenu/signals-do-crazy-shit into lp:dbusmenu. Requested reviews: DBus Menu Team (dbusmenu-team) For more details, see: https://code.launchpad.net/~ted/dbusmenu/signals-do-crazy-shit/+merge/51246 Fixes a crasher as the variant gets unref'd

Re: [Ayatana-commits] [Merge] lp:~mterry/indicator-datetime/clock-prefs into lp:indicator-datetime

2011-02-24 Thread Ted Gould
Review: Needs Fixing It seems that this branch is missing a file: libmap/data/olsen_map.png ? It's not building without that file. -- https://code.launchpad.net/~mterry/indicator-datetime/clock-prefs/+merge/51013 Your team ayatana-commits is subscribed to branch lp:indicator-datetime.

Re: [Ayatana-commits] [Merge] lp:~ted/dbusmenu/handle-event-signal into lp:dbusmenu

2011-02-23 Thread Ted Gould
Review: Resubmit Good idea. Fixed in r204. review resubmit -- https://code.launchpad.net/~ted/dbusmenu/handle-event-signal/+merge/50785 Your team ayatana-commits is subscribed to branch lp:dbusmenu. ___ Mailing list:

[Ayatana-commits] [Merge] lp:~ted/dbusmenu/limited-recursion into lp:dbusmenu

2011-02-23 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/dbusmenu/limited-recursion into lp:dbusmenu. Requested reviews: DBus Menu Team (dbusmenu-team) For more details, see: https://code.launchpad.net/~ted/dbusmenu/limited-recursion/+merge/50950 Fixing the recursion so it happens in the right cases

[Ayatana-commits] [Merge] lp:~ted/dbusmenu/null-protect-when-set into lp:dbusmenu

2011-02-23 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/dbusmenu/null-protect-when-set into lp:dbusmenu. Requested reviews: DBus Menu Team (dbusmenu-team) For more details, see: https://code.launchpad.net/~ted/dbusmenu/null-protect-when-set/+merge/50977 Don't check on the default anything if the incomming

[Ayatana-commits] [Merge] lp:~ted/indicator-messages/funky-fix into lp:indicator-messages

2011-02-23 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/indicator-messages/funky-fix into lp:indicator-messages. Requested reviews: Indicator Applet Developers (indicator-applet-developers) For more details, see: https://code.launchpad.net/~ted/indicator-messages/funky-fix/+merge/51000 Sets the type early

Re: [Ayatana-commits] [Merge] lp:~ted/indicator-messages/mem-leaks into lp:indicator-messages

2011-02-23 Thread Ted Gould
Rejected because of CA. -- https://code.launchpad.net/~ted/indicator-messages/mem-leaks/+merge/47088 Your team ayatana-commits is subscribed to branch lp:indicator-messages. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to :

[Ayatana-commits] [Merge] lp:~ted/dbusmenu/signature-fixes into lp:dbusmenu

2011-02-22 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/dbusmenu/signature-fixes into lp:dbusmenu. Requested reviews: DBus Menu Team (dbusmenu-team) For more details, see: https://code.launchpad.net/~ted/dbusmenu/signature-fixes/+merge/50767 Fixes to the signatures in the spec to make them more consistent

[Ayatana-commits] [Merge] lp:~ted/dbusmenu/handle-event-signal into lp:dbusmenu

2011-02-22 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/dbusmenu/handle-event-signal into lp:dbusmenu. Requested reviews: DBus Menu Team (dbusmenu-team) For more details, see: https://code.launchpad.net/~ted/dbusmenu/handle-event-signal/+merge/50785 Add a signal for generic events to make some situations

Re: [Ayatana-commits] [Merge] lp:~pitti/dbusmenu/fix-annotations into lp:dbusmenu

2011-02-21 Thread Ted Gould
Review: Approve In the parser the annotation should be transfer full. I'll fix that and merge it in. Thanks! review approve -- https://code.launchpad.net/~pitti/dbusmenu/fix-annotations/+merge/50578 Your team ayatana-commits is subscribed to branch lp:dbusmenu.

[Ayatana-commits] [Merge] lp:~ted/dbusmenu/doc-check into lp:dbusmenu

2011-02-21 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/dbusmenu/doc-check into lp:dbusmenu. Requested reviews: DBus Menu Team (dbusmenu-team) For more details, see: https://code.launchpad.net/~ted/dbusmenu/doc-check/+merge/50657 Making it so that the documentation checks is part of 'make check'. Oh

[Ayatana-commits] [Merge] lp:~ted/dbusmenu/ltr-rtl-property into lp:dbusmenu

2011-02-18 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/dbusmenu/ltr-rtl-property into lp:dbusmenu. Requested reviews: DBus Menu Team (dbusmenu-team) For more details, see: https://code.launchpad.net/~ted/dbusmenu/ltr-rtl-property/+merge/50380 Adding tracking of text direction so we can handle cases

[Ayatana-commits] [Merge] lp:~ted/dbusmenu/selective-properties into lp:dbusmenu

2011-02-18 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/dbusmenu/selective-properties into lp:dbusmenu. Requested reviews: DBus Menu Team (dbusmenu-team) For more details, see: https://code.launchpad.net/~ted/dbusmenu/selective-properties/+merge/50396 When we do an GetLayout send that we want the type

[Ayatana-commits] [Merge] lp:~ted/dbusmenu/need-some-love into lp:dbusmenu

2011-02-18 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/dbusmenu/need-some-love into lp:dbusmenu with lp:~ted/dbusmenu/ltr-rtl-property as a prerequisite. Requested reviews: DBus Menu Team (dbusmenu-team) For more details, see: https://code.launchpad.net/~ted/dbusmenu/need-some-love/+merge/50403 Adds

[Ayatana-commits] [Merge] lp:~ted/indicator-application/love-null-pointers into lp:indicator-application

2011-02-18 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/indicator-application/love-null-pointers into lp:indicator-application. Requested reviews: Indicator Applet Developers (indicator-applet-developers) For more details, see: https://code.launchpad.net/~ted/indicator-application/love-null-pointers/+merge

Re: [Ayatana-commits] [Merge] lp:~mterry/dbusmenu/handle-icons-better into lp:dbusmenu

2011-02-17 Thread Ted Gould
Review: Approve -- https://code.launchpad.net/~mterry/dbusmenu/handle-icons-better/+merge/49321 Your team ayatana-commits is subscribed to branch lp:dbusmenu. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to :

Re: [Ayatana-commits] [Merge] lp:~karl-qdh/indicator-datetime/multiplecalendarsources_and_timezones into lp:indicator-datetime

2011-02-16 Thread Ted Gould
Review: Needs Fixing On Wed, 2011-02-16 at 17:07 +, Karl Lattimer wrote: +// Authentication function taken from http://git.gnome.org/browse/evolution/tree/calendar/common/authentication.c In order to maintain clean copyright on the code we can't cut-and-paste code from other sources.

Re: [Ayatana-commits] [Merge] lp:~pitti/dbusmenu/fix-dbusmenu-dumper into lp:dbusmenu

2011-02-16 Thread Ted Gould
Review: Approve review approve -- https://code.launchpad.net/~pitti/dbusmenu/fix-dbusmenu-dumper/+merge/49992 Your team ayatana-commits is subscribed to branch lp:dbusmenu. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to :

Re: [Ayatana-commits] [Merge] lp:~ken-vandine/appmenu-gtk/lp674047 into lp:appmenu-gtk

2011-02-16 Thread Ted Gould
Review: Approve review approve -- https://code.launchpad.net/~ken-vandine/appmenu-gtk/lp674047/+merge/49641 Your team ayatana-commits is subscribed to branch lp:appmenu-gtk. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to :

Re: [Ayatana-commits] [Merge] lp:~themuso/indicator-messages/accessible-desc into lp:indicator-messages

2011-02-16 Thread Ted Gould
Review: Needs Fixing On Tue, 2011-02-15 at 00:59 +, Luke Yelavich wrote: @@ -205,10 +230,14 @@ if (prop) { indicator_image_helper_update(GTK_IMAGE(main_image), indicator-messages-new); + accessible_desc = g_strdup(_(New Messages)); } else {

Re: [Ayatana-commits] [Merge] lp:~themuso/indicator-datetime/accessible-desc into lp:indicator-datetime

2011-02-16 Thread Ted Gould
Review: Needs Fixing On Tue, 2011-02-15 at 01:04 +, Luke Yelavich wrote: @@ -621,6 +623,11 @@ if (ltime == NULL) { g_debug(Error getting local time); gtk_label_set_label(self-priv-label, _(Error getting time)); + g_signal_emit(G_OBJECT(self),

Re: [Ayatana-commits] [Merge] lp:~themuso/indicator-appmenu/accessible-desc into lp:indicator-appmenu

2011-02-16 Thread Ted Gould
Review: Needs Fixing There also needs to be code in menu_prop_changed() so that when the label changes the accessible label also gets updated. review needsfixing -- https://code.launchpad.net/~themuso/indicator-appmenu/accessible-desc/+merge/49748 Your team ayatana-commits is subscribed to

Re: [Ayatana-commits] [Merge] lp:~themuso/indicator-session/a11y-desc into lp:indicator-session

2011-02-16 Thread Ted Gould
Review: Approve review approve -- https://code.launchpad.net/~themuso/indicator-session/a11y-desc/+merge/49750 Your team ayatana-commits is subscribed to branch lp:indicator-session. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to

Re: [Ayatana-commits] [Merge] lp:~mterry/appmenu-gtk/blacklist-eclipse into lp:appmenu-gtk

2011-02-16 Thread Ted Gould
Review: Approve review approve -- https://code.launchpad.net/~mterry/appmenu-gtk/blacklist-eclipse/+merge/49393 Your team ayatana-commits is subscribed to branch lp:appmenu-gtk. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to :

Re: [Ayatana-commits] [Merge] lp:~mterry/indicator-application/dont-abort-so-much into lp:indicator-application

2011-02-16 Thread Ted Gould
Review: Approve review approve -- https://code.launchpad.net/~mterry/indicator-application/dont-abort-so-much/+merge/49405 Your team ayatana-commits is subscribed to branch lp:indicator-application. ___ Mailing list:

Re: [Ayatana-commits] [Merge] lp:~themuso/indicator-application/a11y-desc into lp:indicator-application

2011-02-16 Thread Ted Gould
This is blocked on getting agreement with KDE on the properties names and signals on KSNI. -- https://code.launchpad.net/~themuso/indicator-application/a11y-desc/+merge/49583 Your team ayatana-commits is subscribed to branch lp:indicator-application.

Re: [Ayatana-commits] [Merge] lp:~themuso/indicator-applet/accessible-desc into lp:indicator-applet

2011-02-16 Thread Ted Gould
Review: Needs Information On Mon, 2011-02-14 at 03:46 +, Luke Yelavich wrote: + /* Not all indicator entries have a get_accessible_desc method, such as +indicator-application entries */ + if (class-get_accessible_desc != NULL) { + entry-accessible_desc =

Re: [Ayatana-commits] [Merge] lp:~themuso/indicator-applet/accessible-desc into lp:indicator-applet

2011-02-16 Thread Ted Gould
On Thu, 2011-02-17 at 00:21 +, Luke Yelavich wrote: On Thu, Feb 17, 2011 at 10:01:20AM EST, Ted Gould wrote: I'm not sure why we need to update the entry here, it seems that should be done internally in the IndicatorObject no? Not all indicators have their own get_entries method, i.e

[Ayatana-commits] [Merge] lp:~ted/dbusmenu/group-prop-change-signals into lp:dbusmenu

2011-02-15 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/dbusmenu/group-prop-change-signals into lp:dbusmenu with lp:~ted/dbusmenu/no-more-xml as a prerequisite. Requested reviews: DBus Menu Team (dbusmenu-team) For more details, see: https://code.launchpad.net/~ted/dbusmenu/group-prop-change-signals/+merge

[Ayatana-commits] [Merge] lp:~ted/dbusmenu/no-more-xml into lp:dbusmenu

2011-02-15 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/dbusmenu/no-more-xml into lp:dbusmenu with lp:~ted/dbusmenu/group-prop-change-signals as a prerequisite. Requested reviews: DBus Menu Team (dbusmenu-team) For more details, see: https://code.launchpad.net/~ted/dbusmenu/no-more-xml/+merge/49848 Removes

Re: [Ayatana-commits] [Merge] lp:~mterry/indicator-application/update-label-too into lp:indicator-application

2011-02-11 Thread Ted Gould
Review: Approve -- https://code.launchpad.net/~mterry/indicator-application/update-label-too/+merge/49403 Your team ayatana-commits is subscribed to branch lp:indicator-application. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to

Re: [Ayatana-commits] [Merge] lp:~mterry/indicator-appmenu/free-entries-first into lp:indicator-appmenu

2011-02-10 Thread Ted Gould
Review: Approve No, I think this is good. It was done that way before because the entires used to not hold any references. Since they now have references they should be in dispose. -- https://code.launchpad.net/~mterry/indicator-appmenu/free-entries-first/+merge/49120 Your team

Re: [Ayatana-commits] [Merge] lp:~ken-vandine/dbusmenu/lp713099 into lp:dbusmenu

2011-02-09 Thread Ted Gould
Review: Approve review approve Does this mean we need to change libappindicator and libindicate's GIR generation as well? -- https://code.launchpad.net/~ken-vandine/dbusmenu/lp713099/+merge/49102 Your team ayatana-commits is subscribed to branch lp:dbusmenu.

[Ayatana-commits] [Merge] lp:~ted/indicator-appmenu/more-hashing-fun into lp:indicator-appmenu

2011-02-08 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/indicator-appmenu/more-hashing-fun into lp:indicator-appmenu. Requested reviews: Indicator Applet Developers (indicator-applet-developers) For more details, see: https://code.launchpad.net/~ted/indicator-appmenu/more-hashing-fun/+merge/48969 Removing

Re: [Ayatana-commits] [Merge] lp:~ted/indicator-datetime/bug714763 into lp:indicator-datetime

2011-02-08 Thread Ted Gould
On Tue, 2011-02-08 at 09:49 +, Mikkel Kamstrup Erlandsen wrote: If this happens because geoclue-master crashes then I think it deserves a more sensible error message. It's not a programming error but a runtime error. I think it's a programming error in GeoClue ;) Yeah, I put a more user

Re: [Ayatana-commits] [Merge] lp:~mterry/indicator-appmenu/dont-abort-at-drop-of-hat into lp:indicator-appmenu

2011-02-08 Thread Ted Gould
Review: Approve review approve -- https://code.launchpad.net/~mterry/indicator-appmenu/dont-abort-at-drop-of-hat/+merge/48940 Your team ayatana-commits is subscribed to branch lp:indicator-appmenu. ___ Mailing list:

Re: [Ayatana-commits] [Merge] lp:~mterry/appmenu-gtk/rebuild-if-realized into lp:appmenu-gtk

2011-02-08 Thread Ted Gould
Review: Approve review approve -- https://code.launchpad.net/~mterry/appmenu-gtk/rebuild-if-realized/+merge/48827 Your team ayatana-commits is subscribed to branch lp:appmenu-gtk. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to

[Ayatana-commits] [Merge] lp:~ted/appmenu-gtk/unref-if-non-null into lp:appmenu-gtk

2011-02-07 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/appmenu-gtk/unref-if-non-null into lp:appmenu-gtk. Requested reviews: Indicator Applet Developers (indicator-applet-developers) Related bugs: #703988 (various) crashed with SIGSEGV in g_atomic_int_exchange_and_add()/g_variant_unref/?libappmenu.so

[Ayatana-commits] [Merge] lp:~ted/indicator-appmenu/dont-just-remove into lp:indicator-appmenu

2011-02-07 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/indicator-appmenu/dont-just-remove into lp:indicator-appmenu. Requested reviews: Indicator Applet Developers (indicator-applet-developers) Related bugs: #714531 unity-panel-service consuming very high cpu time https://bugs.launchpad.net/bugs/714531

[Ayatana-commits] [Merge] lp:~ted/indicator-datetime/bug714763 into lp:indicator-datetime

2011-02-07 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/indicator-datetime/bug714763 into lp:indicator-datetime. Requested reviews: Indicator Applet Developers (indicator-applet-developers) Related bugs: #714763 indicator-datetime-service crashed with SIGSEGV in geoclue_master_client_set_requirements_async

[Ayatana-dev] TODO list for Feature Freeze

2011-02-04 Thread Ted Gould
Hey all, So I'm trying to document the features that I'm planning on trying to land before feature freeze. If you see something missing on this list that you're expecting from me this cycle, please speak up now! Feature freeze is approaching like a freight train (and I had an especially

<    1   2   3   4   5   6   7   >