Re: [Ayatana-commits] [Merge] lp:~ted/dbusmenu/show-menu-on-activate into lp:dbusmenu

2010-08-24 Thread Aurélien Gâteau
On Mon, 2010-08-23 at 07:39 +, Aurélien Gâteau wrote: I wanted to try it on KDE, but it seems the menubar items (File, Edit, View) do not contain any '_' character. Is it a known problem? The fact that you can't see them visually, yes, it's part of a GTK thing where we're

Re: [Ayatana-commits] [Merge] lp:~ted/dbusmenu/show-menu-on-activate into lp:dbusmenu

2010-08-24 Thread David Barth
Review: Approve +1 -- https://code.launchpad.net/~ted/dbusmenu/show-menu-on-activate/+merge/33268 Your team ayatana-commits is subscribed to branch lp:dbusmenu. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to :

Re: [Ayatana-commits] [Merge] lp:~ted/dbusmenu/show-menu-on-activate into lp:dbusmenu

2010-08-24 Thread Aurélien Gâteau
Review: Approve +1 -- https://code.launchpad.net/~ted/dbusmenu/show-menu-on-activate/+merge/33268 Your team ayatana-commits is subscribed to branch lp:dbusmenu. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to :

Re: [Ayatana-commits] [Merge] lp:~ted/dbusmenu/show-menu-on-activate into lp:dbusmenu

2010-08-23 Thread Aurélien Gâteau
Review: Needs Information I wanted to try it on KDE, but it seems the menubar items (File, Edit, View...) do not contain any '_' character. Is it a known problem? -- https://code.launchpad.net/~ted/dbusmenu/show-menu-on-activate/+merge/33268 Your team ayatana-commits is subscribed to branch

Re: [Ayatana-commits] [Merge] lp:~ted/dbusmenu/show-menu-on-activate into lp:dbusmenu

2010-08-23 Thread David Barth
Review: Needs Fixing Line 125: a bit uneasy to see priv dereferenced without being controlled first; is the GET_PRIVATE macro ensuring you will return immediately if passed some garbage/null pointer? Being a callback, it makes sense to be a bit picky. Otherwise, good for me. --

Re: [Ayatana-commits] [Merge] lp:~ted/dbusmenu/show-menu-on-activate into lp:dbusmenu

2010-08-23 Thread Ted Gould
On Mon, 2010-08-23 at 07:39 +, Aurélien Gâteau wrote: I wanted to try it on KDE, but it seems the menubar items (File, Edit, View) do not contain any '_' character. Is it a known problem? The fact that you can't see them visually, yes, it's part of a GTK thing where we're supposed to

Re: [Ayatana-commits] [Merge] lp:~ted/dbusmenu/show-menu-on-activate into lp:dbusmenu

2010-08-23 Thread Ted Gould
On Mon, 2010-08-23 at 10:34 +, David Barth wrote: Review: Needs Fixing Line 125: a bit uneasy to see priv dereferenced without being controlled first; is the GET_PRIVATE macro ensuring you will return immediately if passed some garbage/null pointer? Being a callback, it makes sense to be

[Ayatana-commits] [Merge] lp:~ted/dbusmenu/show-menu-on-activate into lp:dbusmenu

2010-08-20 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/dbusmenu/show-menu-on-activate into lp:dbusmenu. Requested reviews: DBus Menu Team (dbusmenu-team) Opening menus when requested. Originally I thought we'd be able to use activate, but that created a nice little signal loop -- oops. Added a new