Re: [B.A.T.M.A.N.] [PATCHv2 maint] batman-adv: set network coding packet handlers in batadv_recv_handler_init()

2013-09-27 Thread Marek Lindner
On Thursday 26 September 2013 10:29:49 Matthias Schiffer wrote: batman-adv saves its table of packet handlers as a global state, so handlers must be set up only once (and setting them up a second time will fail). The recently-added network coding support tries to set up its handler each time

Re: [B.A.T.M.A.N.] [PATCHv2 maint] batman-adv: set network coding packet handlers in batadv_recv_handler_init()

2013-09-27 Thread Matthias Schiffer
On 09/27/2013 08:07 AM, Marek Lindner wrote: On Thursday 26 September 2013 10:29:49 Matthias Schiffer wrote: batman-adv saves its table of packet handlers as a global state, so handlers must be set up only once (and setting them up a second time will fail). The recently-added network coding

Re: [B.A.T.M.A.N.] [PATCHv2 maint] batman-adv: set network coding packet handlers in batadv_recv_handler_init()

2013-09-27 Thread Marek Lindner
On Friday 27 September 2013 10:13:51 Matthias Schiffer wrote: No problem. Any idea for a good name for the new function? Currently, the init functions are named a bit inconsistently, there is batadv_iv_init, which is called in batadv_init, and many other batadv_*_init called in

[B.A.T.M.A.N.] [PATCHv3 maint] batman-adv: set up network coding packet handlers during module init

2013-09-27 Thread Matthias Schiffer
batman-adv saves its table of packet handlers as a global state, so handlers must be set up only once (and setting them up a second time will fail). The recently-added network coding support tries to set up its handler each time a new softif is registered, which obviously fails when more that one