In commit 1488 the orig_str has been removed from
purge_orig_neighbours(). Apparently, this breaks compilation when
enabling debug-flags, as bat_dbg() is expecting this variable as a
parameter. Actually, this variable has never been initialised also
before commit 1488 (which was probably the
Hi Simon,
I just gave your patch a try on my laptop and could successfully,
reproduceably crash my kernel in the following way:
Setting up wifi to ad-hoc mode and connecting it to other
batman-wifi-nodes, insmodding batman-adv on my laptop and adding
this wifi interface to batman - kernel hangs
On 12/02/2009 04:24 PM, Linus Lüssing wrote:
In commit 1488 the orig_str has been removed from
purge_orig_neighbours(). Apparently, this breaks compilation when
enabling debug-flags, as bat_dbg() is expecting this variable as a
parameter. Actually, this variable has never been initialised also
On Thursday 03 December 2009 08:24:07 Linus Lüssing wrote:
In commit 1488 the orig_str has been removed from
purge_orig_neighbours(). Apparently, this breaks compilation when
enabling debug-flags, as bat_dbg() is expecting this variable as a
parameter. Actually, this variable has never been
Hi Gus,
Shouldn't the addr_to_string(orig_str, orig_node-orig); be moved out
side the loop to near the top of the function? There is only one
originator node and there is no reason to iterate over it. One time
should suffice.
you are probably right but I know that Andrew has a patch in his
On Thursday 03 December 2009 01:31:23 Gus Wirth wrote:
When trying to compile batman-adv revision 1489 checked out from
Subversion I get a failure if I activate debugging by editing the
appropriate line in Makefile.kbuild. The error is:
Should be fixed in revision 1490 (thanks to Linus).
On Thursday 03 December 2009 11:12:27 Gus Wirth wrote:
Should be fixed in revision 1490 (thanks to Linus).
Thanks. But should I use Trac to report bugs or just post to this list?
I think both is fine. The trac is better suited for attaching things and as a
reminder for outstanding bugs. It
you are probably right but I know that Andrew has a patch in his
pipeline which will remove these addr_to_string() calls entirely
(printk can handle mac addresses for us). Until then we can live
with this workaround. :)
I've been holding off on this patch because of Simon's big lock
removal
On Thu, Dec 03, 2009 at 02:31:22AM +0100, Linus L??ssing wrote:
Hi Simon,
I just gave your patch a try on my laptop and could successfully,
reproduceably crash my kernel in the following way:
This looks like a deadlock.
Simon: Did you try lockdep on this new code?
It seems to deadlock according to
https://lists.open-mesh.net/pipermail/b.a.t.m.a.n/2009-December/001938.html
Patch was modified by Sven Eckelmann sven.eckelm...@gmx.de to apply
cleanly against r1490.
Is this just modification so that it cleanly applies? Or does it also
fix the deadlock?
Andrew Lunn wrote:
It seems to deadlock according to
https://lists.open-mesh.net/pipermail/b.a.t.m.a.n/2009-December/001938.ht
ml
Patch was modified by Sven Eckelmann sven.eckelm...@gmx.de to apply
cleanly against r1490.
Is this just modification so that it cleanly applies? Or
11 matches
Mail list logo
