[B.A.T.M.A.N.] [PATCH 5/5] batman-adv: Prevent duplicated tvlv handler

basic infrastructure") Signed-off-by: Sven Eckelmann --- net/batman-adv/tvlv.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/net/batman-adv/tvlv.c b/net/batman-adv/tvlv.c index a6374582..40e69c93 100644 --- a/net/batman-adv/tvlv.c +++ b/net/batman-adv/tvlv.c @@ -529,

[B.A.T.M.A.N.] [PATCH 4/5] batman-adv: Prevent duplicated global TT entry

rence counting for type batadv_tt_orig_list_entry") Signed-off-by: Sven Eckelmann --- net/batman-adv/translation-table.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/net/batman-adv/translation-table.c b/net/batman-adv/translation-table.c index 12a2b7d2..d2162

[B.A.T.M.A.N.] [PATCH 2/5] batman-adv: Prevent duplicated nc_node entry

twork coding - detect coding nodes and remove these after timeout") Signed-off-by: Sven Eckelmann --- net/batman-adv/network-coding.c | 27 +++ 1 file changed, 15 insertions(+), 12 deletions(-) diff --git a/net/batman-adv/network-coding.c b/net/batman-adv/network-codi

[B.A.T.M.A.N.] [PATCH 1/5] batman-adv: Prevent duplicated gateway_node entry

Signed-off-by: Sven Eckelmann --- net/batman-adv/gateway_client.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/net/batman-adv/gateway_client.c b/net/batman-adv/gateway_client.c index 8b198ee7..0df4e87d 100644 --- a/net/batman-adv/gateway_client.c +++ b/net/

[B.A.T.M.A.N.] [PATCH 0/5] batman-adv: Missing list checks for *list_add*

/issues/241 [8] https://patchwork.open-mesh.org/patch/4919/ Sven Eckelmann (5): batman-adv: Prevent duplicated gateway_node entry batman-adv: Prevent duplicated nc_node entry batman-adv: Prevent duplicated softif_vlan entry batman-adv: Prevent duplicated global TT entry batman-adv: Prevent

[B.A.T.M.A.N.] [PATCH 0/2] batman-adv: Continue with deprecation of debugfs

Sven [1] https://lwn.net/Articles/379903/ [2] https://lwn.net/Articles/381064/ [3] https://lwn.net/Articles/383362/ Sven Eckelmann (2): batman-adv: Mark debugfs functionality as deprecated batman-adv: Provide debug messages as trace events Makefile | 3 ++ README.ext

[B.A.T.M.A.N.] [PATCH 2/2] batman-adv: Provide debug messages as trace events

cted 66:25:a7:48:37:fb addr=49328 dist=65109 1.828 batadv:batadv_dbg:batman_adv bat0 DHT_SEND for 10.204.32.1 Signed-off-by: Sven Eckelmann --- Makefile| 3 ++ README.external.rst | 1 + gen-compat-autoconf.sh | 1 + net/batman-adv/Kconfig | 11 ++ net/batman-ad

[B.A.T.M.A.N.] [PATCH 1/2] batman-adv: Mark debugfs functionality as deprecated

CONFIG_BATMAN_ADV_DEBUGFS is disabled by default because debugfs is not supported for batman-adv interfaces in any non-default netns. Any remaining users of this interface should still be informed about the deprecation and the generic netlink alternative. Signed-off-by: Sven Eckelmann

Re: [B.A.T.M.A.N.] Paper "Performance Evaluation of BATMAN-adv Wireless Mesh Network Routing Algorithms "

On Samstag, 4. August 2018 16:39:50 CEST j...@nhfn.net wrote: > I HATE dealing with ieee.org. Please login. Pay LOTS of money. MAYBE we > will get around to you eventually. > > I USED to be a member. Waste of $$. Please avoiding switching topics in threads. I've asked some questions

Re: [B.A.T.M.A.N.] [PATCH v3 6/7] batman-adv: ELP - use tp meter to estimate the throughput if otherwise not available

On Samstag, 4. August 2018 15:48:53 CEST Marek Lindner wrote: > + total_bytes = atomic64_read(_vars->tot_sent); > + > + /* The following calculation includes these steps: > +* - divide bytes by the test length (msecs) > +* - convert

[B.A.T.M.A.N.] Paper "Performance Evaluation of BATMAN-adv Wireless Mesh Network Routing Algorithms "

Hi, Just saw your paper "Performance Evaluation of BATMAN-adv Wireless Mesh Network Routing Algorithms" [1]. Some small questions: * What is OpenWrt 1703? (you've referenced a batman-adv config tutorial here and there is no such version as OpenWrt 1703) * When did you want to contact the

Re: [B.A.T.M.A.N.] [PATCH v2 7/7] batman-adv: ELP - add throughput meter test duration attribute

On Samstag, 4. August 2018 10:41:09 CEST Antonio Quartulli wrote: [...] > >> Documentation/ABI/testing/sysfs-class-net-batman-adv | 7 +++ > > > > Please discuss this with Jiri [1]. > > > > After re-reading Jiri's points I can't really understand why we should > now switch to netlink. I

Re: [B.A.T.M.A.N.] BATMAN 2018.1 fails to compile

On Dienstag, 31. Juli 2018 21:24:54 CEST MK wrote: [...] > make[1]: Verzeichnis „/lib/modules/4.9.0-7-amd64/build“ wird betreten > make[1]: *** Keine Regel, um „modules“ zu erstellen. Schluss. [...] > This is a debian stretch installation. Someone out there with the same > problem? Make clean did

Re: [B.A.T.M.A.N.] Issue with mesh network on different RTL chipsets

On Donnerstag, 19. Juli 2018 09:53:26 CEST Francesco Salvatore [fabbricadigitale] wrote: [...] > Do you know if there's any issue related to listed hardware chipsets? If > yes, you know of some action I can take to fix that problem? Yes, nearly all [0] wifi USB sticks are problematic. Please get

[B.A.T.M.A.N.] [PATCH] batman-adv: Disable MCAST during compilation

The multicast optimization compile option is disabled by default in the Kconfig of batman-adv. The out-of-tree module should keep this setting in sync and thus has to also disable the build of multicast optimization by default. Signed-off-by: Sven Eckelmann --- Makefile | 2

Re: [B.A.T.M.A.N.] [PATCH v2 1/2] batman-adv: Remove "default n" in Kconfig

On Samstag, 26. Mai 2018 11:40:31 CEST Sven Eckelmann wrote: > The "default n" is the default value for any bool or tristate Kconfig > setting. It is therefore not necessary to add it to a config entry. > > Reported-by: Sergei Shtylyov > Signed-off-by: Sven Eckel

Re: [B.A.T.M.A.N.] [PATCH 0/3] batman-adv: Minor cleanups

On Samstag, 7. Juli 2018 22:01:18 CEST Sven Eckelmann wrote: > Hi, > > this mini patchset contains some minor cleanups which are on my HDD > since a longer time but were never submitted. They still didn't reach a > critical mass - but they will not get better with age.

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: fix checkpatch warning about misspelled "cache"

On Donnerstag, 5. Juli 2018 16:57:12 CEST Sven Eckelmann wrote: > commit a2d4df9b673c ("spelling.txt: add more spellings to spelling.txt") > introduced the spellcheck of "cache" for checkpatch.pl. > > Signed-off-by: Sven Eckelmann > --- > net/batman-adv

Re: [B.A.T.M.A.N.] [PATCH v2 2/2] batman-adv: Drop "experimental" from BATMAN_V Kconfig

On Samstag, 26. Mai 2018 11:40:32 CEST Sven Eckelmann wrote: > The Kconfig option BATMAN_ADV_BATMAN_V is now enabled by default when the > BATMAN_ADV is enabled. A feature which is enabled by default for a module > should not be considered experimental. > > Reported-by: Joe Perche

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: enable DAT by default at compile time

On Sonntag, 3. Juni 2018 12:52:03 CEST Antonio Quartulli wrote: > DAT (Distributed ARP Table) has been enabled by default > in the out-of-tree batman-adv kernel module for several > years already. > It can now be enabled in the kernel too. > > Signed-off-by: Antonio Quartulli > --- Added as

Re: [B.A.T.M.A.N.] What is link throughput used for?

On Samstag, 7. Juli 2018 21:31:16 CEST dan wrote: > How is this used? Where's the documentation? https://www.open-mesh.org/projects/batman-adv/wiki/BATMAN_V + linked pages Kind regards, Sven

[B.A.T.M.A.N.] [PATCH 3/3] batman-adv: Convert batadv_dat_addr_t to proper type

The #define for batadv_dat_addr_t is doing nothing else than giving u16 a new typename. But C already has the special keyword "typedef" which is also better supported by kernel-doc. Signed-off-by: Sven Eckelmann --- net/batman-adv/types.h | 7 --- 1 file changed, 4 insert

[B.A.T.M.A.N.] [PATCH 1/3] batman-adv: Unify include guards style

All other include guards in batman-adv use the style: * _NET_BATMAN_ADV_$(FILENAME)_ * uppercase only * "." & "-" replaced with "_" Use this also in the B.A.T.M.A.N. IV/V OGM implementation headers. Signed-off-by: Sven Eckelmann --- net/batman-adv/bat_i

[B.A.T.M.A.N.] [PATCH 0/3] batman-adv: Minor cleanups

Hi, this mini patchset contains some minor cleanups which are on my HDD since a longer time but were never submitted. They still didn't reach a critical mass - but they will not get better with age. Kind regards, Sven Sven Eckelmann (3): batman-adv: Unify include guards style batman

[B.A.T.M.A.N.] [PATCH 2/3] batman-adv: Join batadv_purge_orig_ref and _batadv_purge_orig

The single line function batadv_purge_orig_ref has no function beside providing the name used by other source files. This can also be done simpler by just renaming _batadv_purge_orig to batadv_purge_orig_ref. Signed-off-by: Sven Eckelmann --- net/batman-adv/originator.c | 17

[B.A.T.M.A.N.] [PATCH] batman-adv: fix checkpatch warning about misspelled "cache"

commit a2d4df9b673c ("spelling.txt: add more spellings to spelling.txt") introduced the spellcheck of "cache" for checkpatch.pl. Signed-off-by: Sven Eckelmann --- net/batman-adv/debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/batman-adv/de

[B.A.T.M.A.N.] [PATCH] batman-adv: Don't redefine EPOLL*

definition of these variables when they are already defined and drop the ones which are not used by batman-adv. Reported-by: Andre Kasper Signed-off-by: Sven Eckelmann --- Cc: Andre Kasper --- compat-include/uapi/linux/eventpoll.h | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-)

Re: [B.A.T.M.A.N.] [PATCH v4 3/5] batman-adv: use BIT_ULL for NL80211_STA_INFO_* attribute types

On Montag, 25. Juni 2018 14:31:19 CEST Omer Efrat wrote: > Sven Eckelmann wrote: > >Please fix the alignment: > > > >* Found wrong alignment at net/batman-adv/bat_v_elp.c:118, was 27 but > >expected 23 > > checkpatch script doesn't catch this error. > how d

Re: [B.A.T.M.A.N.] [PATCH v5] batman-adv: Snoop DHCPACKs for DAT

On Donnerstag, 21. Juni 2018 12:35:55 CEST Linus Lüssing wrote: [...] > diff --git a/include/uapi/linux/batadv_packet.h > b/include/uapi/linux/batadv_packet.h > index 894d8d2f..6a48f36c 100644 > --- a/include/uapi/linux/batadv_packet.h > +++ b/include/uapi/linux/batadv_packet.h > @@ -630,6

Re: [B.A.T.M.A.N.] [PATCH v4 3/5] batman-adv: use BIT_ULL for NL80211_STA_INFO_* attribute types

On Mittwoch, 20. Juni 2018 13:46:56 CEST Omer Efrat wrote: > - if (!(sinfo.filled & > BIT(NL80211_STA_INFO_EXPECTED_THROUGHPUT))) > + if (!(sinfo.filled & > + BIT_ULL(NL80211_STA_INFO_EXPECTED_THROUGHPUT))) > goto

Re: [B.A.T.M.A.N.] [PATCH v3 3/5] batman-adv: use BIT_ULL for NL80211_STA_INFO_* attribute types

On Sonntag, 17. Juni 2018 12:06:54 CEST Omer Efrat wrote: [...] > --- a/net/batman-adv/bat_v_elp.c > +++ b/net/batman-adv/bat_v_elp.c > @@ -114,7 +114,7 @@ static u32 batadv_v_elp_get_throughput(struct > batadv_hardif_neigh_node *neigh) > } > if (ret) >

Re: [B.A.T.M.A.N.] [PATCH v2 3/5] batman: use BIT_ULL for NL80211_STA_INFO_* attribute types

On Donnerstag, 14. Juni 2018 13:05:16 CEST Johannes Berg wrote: [...] > > in commit 739960f128e5 ("cfg80211/nl80211: Add support for > > NL80211_STA_INFO_RX_DURATION") > > Yeah, which actually means this patch isn't needed? > > BIT(NL80211_STA_INFO_EXPECTED_THROUGHPUT) is fine since >

Re: [B.A.T.M.A.N.] [PATCH v2 3/5] batman: use BIT_ULL for NL80211_STA_INFO_* attribute types

Hi, here are the infos which were missing and which should be included in the commit message > > Since 'filled' member in station_info changed to u64 in commit 739960f128e5 ("cfg80211/nl80211: Add support for NL80211_STA_INFO_RX_DURATION") [...] Fixes: d62890885efb ("batman-adv: Accept only

Re: [B.A.T.M.A.N.] [PATCH v2 3/5] batman: use BIT_ULL for NL80211_STA_INFO_* attribute types

On Donnerstag, 14. Juni 2018 13:12:17 CEST Omer Efrat wrote: > Since 'filled' member in station_info changed to u64, BIT_ULL macro > should be used with NL80211_STA_INFO_* attribute types instead of BIT. > > The BIT macro uses unsigned long type which some architectures handle as 32bit > and this

Re: [B.A.T.M.A.N.] [PATCH maint 2/2] batman-adv: Fix multicast TT issues with bogus ROAM flags

On Donnerstag, 7. Juni 2018 00:46:24 CEST Linus Lüssing wrote: > When a (broken) node wrongly sends multicast TT entries with a ROAM > flag then this causes any receiving node to drop all entries for the > same multicast MAC address announced by other nodes, leading to > packet loss. > > Fix this

Re: [B.A.T.M.A.N.] [PATCH maint 1/2] batman-adv: Avoid storing non-TT-sync flags on singular entries too

On Donnerstag, 7. Juni 2018 00:46:23 CEST Linus Lüssing wrote: > Since commit 382d020fe3fa ("batman-adv: fix TT sync flag inconsistencies") > TT sync flags and TT non-sync'd flags are supposed to be stored > separately. > > The previous patch missed to apply this separation on a TT entry with >

Re: [B.A.T.M.A.N.] [PATCH maint] batman-adv: compat: initialize sinfo in cfg80211_get_station

On Mittwoch, 6. Juni 2018 17:35:29 CEST Sven Eckelmann wrote: > Most of the implementations behind cfg80211_get_station will not initialize > sinfo to zero before manipulating it. For example, the member "filled", > which indicates the filled in parts of this struct, is

[B.A.T.M.A.N.] [PATCH maint] batman-adv: compat: initialize sinfo in cfg80211_get_station

witch to non-optimal neighbors for certain destinations. batman-adv's compat layer must take care of intializing sinfo until it is fixed in the upstream kernel. Fixes: 7406353d43c8 ("cfg80211: implement cfg80211_get_station cfg80211 API") Reported-by: Thomas Lauer Reported-by: Marcel Schmidt

[B.A.T.M.A.N.] [PATCH v2] cfg80211: initialize sinfo in cfg80211_get_station

witch to non-optimal neighbors for certain destinations. Fixes: 7406353d43c8 ("cfg80211: implement cfg80211_get_station cfg80211 API") Reported-by: Thomas Lauer Reported-by: Marcel Schmidt Cc: b.a.t.m.a.n@lists.open-mesh.org Signed-off-by: Sven Eckelmann --- v2: - do a complete memset of sin

[B.A.T.M.A.N.] [PATCH] cfg80211: initialize sinfo.filled in cfg80211_get_station

on-optimal neighbors for certain destinations. Fixes: 7406353d43c8 ("cfg80211: implement cfg80211_get_station cfg80211 API") Reported-by: Thomas Lauer Reported-by: Marcel Schmidt Cc: b.a.t.m.a.n@lists.open-mesh.org Signed-off-by: Sven Eckelmann --- Matthias, you may want to take care t

Re: [B.A.T.M.A.N.] [PATCH maint v2] batman-adv: Initialize memory for station_info

On Mittwoch, 6. Juni 2018 07:39:51 CEST Sven Eckelmann wrote: > batadv_v_elp_get_throughput is calling cfg80211_get_station with a pointer > (sinfo) to some uninitialized memory on the stack. But most of the > implementations behind cfg80211_get_station will not initialize sinfo to >

[B.A.T.M.A.N.] [PATCH maint v2] batman-adv: Initialize memory for station_info

d-by: Marcel Schmidt Signed-off-by: Sven Eckelmann Signed-off-by: Simon Wunderlich --- v2: * rewrite commit message net/batman-adv/bat_v_elp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/batman-adv/bat_v_elp.c b/net/batman-adv/bat_v_elp.c index 28687493..846316ea 100644 --- a/net/ba

Re: [B.A.T.M.A.N.] [PATCH maint] batman-adv: Initialize memory for station_info

On Mittwoch, 6. Juni 2018 06:44:32 CEST Antonio Quartulli wrote: [...] > This looks fairly reasonable and at a first glance I can confirm that > even ieee80211_get_station() does not clear it up before filling it. > > However, what do you think about zero'ing the sinfo object directly in >

Re: [B.A.T.M.A.N.] [PATCH maint] batman-adv: Initialize memory for station_info

Hi Antonio, On Dienstag, 5. Juni 2018 20:31:31 CEST Sven Eckelmann wrote: > cfg80211_get_station is not initializing the memory given as parameter > sinfo. The caller has to handle it. Otherwise the filled parameter may be > set incorrectly and thus uninitialized memory is used to

[B.A.T.M.A.N.] [PATCH maint] batman-adv: Initialize memory for station_info

mpute the metric based on the estimated throughput") Reported-by: Thomas Lauer Reported-by: Marcel Schmidt Signed-off-by: Sven Eckelmann --- Cc: Thomas Lauer Cc: Marcel Schmidt net/batman-adv/bat_v_elp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/batman-adv/bat_v_elp.c b/net/

Re: [B.A.T.M.A.N.] [PATCH maint 1/2] batman-adv: Fix debugfs path for renamed hardif

On Freitag, 1. Juni 2018 19:24:23 CEST Sven Eckelmann wrote: > batman-adv is creating special debugfs directories in the init > net_namespace for each valid hard-interface (net_device). But it is > possible to rename a net_device to a completely different name then the > original one.

Re: [B.A.T.M.A.N.] [PATCH maint 2/2] batman-adv: Fix debugfs path for renamed softif

On Freitag, 1. Juni 2018 19:24:24 CEST Sven Eckelmann wrote: > batman-adv is creating special debugfs directories in the init > net_namespace for each created soft-interface (batadv net_device). But it > is possible to rename a net_device to a completely different name then the >

Re: [B.A.T.M.A.N.] [PATCH maint 2/2] batman-adv: Fix bat_v best gw refcnt after netlink dump

On Samstag, 2. Juni 2018 17:26:35 CEST Sven Eckelmann wrote: > A reference to the best gateway is taken when the list of gateways in the > mesh is sent via netlink. This is necessary to check whether the currently > dumped entry is the currently selected gateway or not. This in

Re: [B.A.T.M.A.N.] [PATCH maint 1/2] batman-adv: Fix bat_ogm_iv best gw refcnt after netlink dump

On Samstag, 2. Juni 2018 17:26:34 CEST Sven Eckelmann wrote: > A reference to the best gateway is taken when the list of gateways in the > mesh is sent via netlink. This is necessary to check whether the currently > dumped entry is the currently selected gateway or not. This in

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Drop support for Linux < 3.16

On Freitag, 1. Juni 2018 17:38:45 CEST Sven Eckelmann wrote: > The Linux Kernel 3.2 reached its end of life [1] after over 6 years. > Instead it is recommended to use at least kernel 3.16 which is also already > over 3 years old. All older kernels (v3.2 - v3.15) should therefore be

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Drop support for Linux < 3.16

On Freitag, 1. Juni 2018 17:38:45 CEST Sven Eckelmann wrote: > The Linux Kernel 3.2 reached its end of life [1] after over 6 years. > Instead it is recommended to use at least kernel 3.16 which is also already > over 3 years old. All older kernels (v3.2 - v3.15) should therefore be

[B.A.T.M.A.N.] [PATCH maint 2/2] batman-adv: Fix bat_v best gw refcnt after netlink dump

.N. V bat_gw_dump implementations") Signed-off-by: Sven Eckelmann --- Cc: Andreas Ziegler net/batman-adv/bat_v.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/batman-adv/bat_v.c b/net/batman-adv/bat_v.c index ec93337e..6baec4e6 100644 --- a/net/batman-adv/bat_v.c

[B.A.T.M.A.N.] [PATCH maint 2/2] batman-adv: Fix debugfs path for renamed softif

e debugfs directories for soft-interfaces whenever it detects such a net_device rename. Fixes: 230202d4b530 ("batman-adv: Move device for icmp injection to debugfs") Signed-off-by: Sven Eckelmann --- net/batman-adv/debugfs.c| 20 +++ net/batman-adv/debug

[B.A.T.M.A.N.] [PATCH maint 1/2] batman-adv: Fix debugfs path for renamed hardif

k the registering of this device. batman-adv must therefore take care of renaming the debugfs directories for hard-interfaces whenever it detects such a net_device rename. Fixes: 3c926a01c8e8 ("batman-adv: add debugfs structure for information per interface") Reported-by: John Soros Sign

[B.A.T.M.A.N.] [PATCH] batman-adv: Drop support for Linux < 3.16

/a3d2d2b2c3559217eb8315d25df0c5883f922066.ca...@decadent.org.uk Signed-off-by: Sven Eckelmann --- Makefile | 42 ++- README.external.rst| 2 +- compat-include/linux/etherdevice.h | 55 - compat-include/linux/export.h | 30

[B.A.T.M.A.N.] [PATCH v2 1/2] batman-adv: Remove "default n" in Kconfig

The "default n" is the default value for any bool or tristate Kconfig setting. It is therefore not necessary to add it to a config entry. Reported-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> Signed-off-by: Sven Eckelmann <s...@narfation.org> --- v2: change

[B.A.T.M.A.N.] [PATCH v2 2/2] batman-adv: Drop "experimental" from BATMAN_V Kconfig

The Kconfig option BATMAN_ADV_BATMAN_V is now enabled by default when the BATMAN_ADV is enabled. A feature which is enabled by default for a module should not be considered experimental. Reported-by: Joe Perches <j...@perches.com> Signed-off-by: Sven Eckelmann <s...@narfation.or

[B.A.T.M.A.N.] [RFC 2/2] batman-adv: Disable MCAST during compilation

The multicast optimization compile option is disabled by default in the Kconfig of batman-adv. The out-of-tree module should keep this setting in sync and thus has to also disable the build of multicast optimization by default. Signed-off-by: Sven Eckelmann <s...@narfation.org> --- Ma

[B.A.T.M.A.N.] [RFC 1/2] batman-adv: Disable DAT during compilation

The distributed arp table compile option is disabled by default in the Kconfig of batman-adv. The out-of-tree module should keep this setting in sync and thus has to also disable the build of DAT by default. Signed-off-by: Sven Eckelmann <s...@narfation.org> --- Makefile

[B.A.T.M.A.N.] [RFC 0/2] batman-adv: Default build sync with Kconfig

, Sven Sven Eckelmann (2): batman-adv: Disable DAT during compilation batman-adv: Disable MCAST during compilation Makefile | 4 ++-- README.external.rst| 4 ++-- gen-compat-autoconf.sh | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) -- 2.17.0

[B.A.T.M.A.N.] [PATCH 1/2] batman-adv: Remove "default n" in Kconfig

The "default n" is the default value for any bool or tristate Kconfig setting. It is therefore not necessary to add it to the an config entry. Reported-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> Signed-off-by: Sven Eckelmann <s...@narfation.org> --- net/

[B.A.T.M.A.N.] [PATCH 2/2] batman-adv: Drop "experimental" from BATMAN_V Kconfig

The Kconfig option BATMAN_ADV_BATMAN_V is now enabled by default when the BATMAN_ADV is enabled. A feature which is enabled by default for a module should not be considered experimental. Reported-by: Joe Perches <j...@perches.com> Signed-off-by: Sven Eckelmann <s...@narfation.org> ---

Re: [B.A.T.M.A.N.] [PATCH 2/8] batman-adv: Disable CONFIG_BATMAN_ADV_DEBUGFS by default

On Freitag, 25. Mai 2018 14:13:40 CEST Sergei Shtylyov wrote: > > [...] > >>> --- a/net/batman-adv/Kconfig > >>> +++ b/net/batman-adv/Kconfig > >>> @@ -94,13 +94,13 @@ config BATMAN_ADV_DEBUGFS > >>> bool "batman-adv debugfs entries" > >>> depends on BATMAN_ADV > >>> depends on DEBUG_FS > >>> -

Re: [B.A.T.M.A.N.] [PATCH 2/8] batman-adv: Disable CONFIG_BATMAN_ADV_DEBUGFS by default

On Freitag, 25. Mai 2018 13:33:59 CEST Sergei Shtylyov wrote: [...] > > --- a/net/batman-adv/Kconfig > > +++ b/net/batman-adv/Kconfig > > @@ -94,13 +94,13 @@ config BATMAN_ADV_DEBUGFS > > bool "batman-adv debugfs entries" > > depends on BATMAN_ADV > > depends on DEBUG_FS > > - default y > >

Re: [B.A.T.M.A.N.] [PATCH v2 6/7] batman-adv: ELP - use tp meter to estimate the throughput if otherwise not available

On Montag, 21. Mai 2018 15:17:11 CEST Linus Lüssing wrote: > > + throughput = total_bytes * 8 >> ilog2(test_time) / 10; [...] > - [...] > > throughput = total_bytes * 8 >> log_test_time / 10; > > // Straightforward approach? > throughput2 = total_bytes *

Re: [B.A.T.M.A.N.] [PATCH v2 6/7] batman-adv: ELP - use tp meter to estimate the throughput if otherwise not available

On Montag, 21. Mai 2018 15:17:11 CEST Linus Lüssing wrote: > What is the advantage of using the ilog2 and shift operator here > compared to plain multiplications and divisions? They most likely ran into the problem that they must do a 64 bit division (which cannot be done on 32 bit machines in

Re: [B.A.T.M.A.N.] [PATCH v2 6/7] batman-adv: ELP - use tp meter to estimate the throughput if otherwise not available

On Freitag, 18. Mai 2018 03:47:53 CEST Marek Lindner wrote: > Signed-off-by: Marek Lindner > --- > net/batman-adv/bat_v_elp.c | 63 -- > net/batman-adv/bat_v_elp.h | 21 + > net/batman-adv/main.h | 1 + >

Re: [B.A.T.M.A.N.] [PATCH v2 7/7] batman-adv: ELP - add throughput meter test duration attribute

On Freitag, 18. Mai 2018 03:47:54 CEST Marek Lindner wrote: > When the ELP throughput meter fallback kicks in to trigger > a throughput meter measurement the test duration can be > configured via this attribute. > > Default tp test duration: 1000ms > > Signed-off-by: Marek Lindner

Re: [B.A.T.M.A.N.] [PATCH 03/17] batman-adv: Add network_coding and mcast sysfs files to README

Hi Jiri, seems like you still haven't answered Linus' question. On Montag, 7. Mai 2018 08:34:16 CEST Sven Eckelmann wrote: > On Dienstag, 27. März 2018 17:43:08 CEST Linus Lüssing wrote: > > On Sat, Oct 29, 2016 at 12:56:28PM +0200, Jiri Pirko wrote: > > > >> I stron

Re: [B.A.T.M.A.N.] [PATCH v4] batman-adv: Snoop DHCPACKs for DAT

On Dienstag, 15. Mai 2018 17:59:08 CEST Linus Lüssing wrote: > + magic = skb_header_pointer(skb, offset, sizeof(_magic), &_magic); > + if (!magic || *magic != htonl(BATADV_DHCP_MAGIC)) > + return -EINVAL; I just hear a neoraider cry [1] in the background because you've

Re: [B.A.T.M.A.N.] [PATCH v4] batman-adv: Snoop DHCPACKs for DAT

On Dienstag, 15. Mai 2018 17:59:08 CEST Linus Lüssing wrote: [...] > diff --git a/include/uapi/linux/batadv_packet.h b/include/uapi/linux/ batadv_packet.h > index 894d8d2f..6a48f36c 100644 > --- a/include/uapi/linux/batadv_packet.h > +++ b/include/uapi/linux/batadv_packet.h > @@ -630,6 +630,46 @@

Re: [B.A.T.M.A.N.] [PATCH v2] batman-adv: enable B.A.T.M.A.N. V compilation by default

On Montag, 14. Mai 2018 06:42:59 CEST Marek Lindner wrote: > Signed-off-by: Marek Lindner > Acked-by: Antonio Quartulli > --- > v2: > * add relevant changes to README.external.rst & gen-compat-autoconf.sh Applied in 8f4e0b5472a0 [1] Thanks,

Re: [B.A.T.M.A.N.] [PATCH v2] batman-adv: disable ethtool link speed detection when auto negotiation off

On Montag, 14. Mai 2018 06:38:49 CEST Marek Lindner wrote: > Virtual interface drivers such as tun / tap interfaces, VLAN, etc tend > to initialize the interface throughput with some value for the sake of > having a throughput number to export via ethtool. This exported > throughput leaves

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: disable ethtool link speed detection when auto negotiation off

On Sonntag, 13. Mai 2018 11:19:52 CEST Antonio Quartulli wrote: > Hi Sven, > > thanks for your comment. > > On 13/05/18 14:56, Sven Eckelmann wrote: > > On Sonntag, 13. Mai 2018 00:02:23 CEST Marek Lindner wrote: > >> If link auto-negotiation is disabl

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: disable ethtool link speed detection when auto negotiation off

Name of failed tests ecsv/pu --- * sparse linux-3.18 cfg: BLA=n DAT=n DEBUGFS=y DEBUG=y NC=y MCAST=y BATMAN_V=y * sparse linux-3.18 cfg: BLA=y DAT=n DEBUGFS=y DEBUG=n NC=n MCAST=n BATMAN_V=y * sparse linux-4.2 cfg: BLA=y DAT=n DEBUGFS=n DEBUG=n NC=n MCAST=n BATMAN_V=y

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: disable ethtool link speed detection when auto negotiation off

On Sonntag, 13. Mai 2018 00:02:23 CEST Marek Lindner wrote: > If link auto-negotiation is disabled the exported link speed can > not be relied on. Why is a manual set speed less worth than a auto-configured one? Kind regards, Sven signature.asc Description: This is a digitally signed

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: enable B.A.T.M.A.N. V compilation by default

On Sonntag, 13. Mai 2018 00:24:03 CEST Marek Lindner wrote: > Signed-off-by: Marek Lindner > --- > Makefile | 2 +- > net/batman-adv/Kconfig | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > Please change all relevant files: * Makefile *

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: don't implement skb_postpush_rcsum() for linux >=4.4.47

On Freitag, 11. Mai 2018 21:02:44 CEST Antonio Quartulli wrote: > skb_postpush_rcsum() has been implemented in 4.4.47 therefore > our compat code has to be changed to prevent this function to > be implemented when using those kernels. > > Signed-off-by: Antonio Quartulli > ---

Re: [B.A.T.M.A.N.] [maint v3] batman-adv: prevent TT request storms by not sending inconsistent TT TLVLs

On Freitag, 11. Mai 2018 18:23:07 CEST Marek Lindner wrote: > A translation table TVLV changset sent with an OGM consists > of a number of headers (one per VLAN) plus the changeset > itself (addition and/or deletion of entries). > > The per-VLAN headers are used by OGM recipients for consistency

Re: [B.A.T.M.A.N.] [PATCH v3 maint] batman-adv: Fix TT sync flags for intermediate TT responses

On Freitag, 11. Mai 2018 08:13:09 CEST Sven Eckelmann wrote: > On Donnerstag, 10. Mai 2018 19:44:28 CEST Linus Lüssing wrote: > [...] > > + * @flags: a pointer to store TT flags for the given @orig_node and @entry > > to > [...] > > + * @flags: a pointer to sto

Re: [B.A.T.M.A.N.] [PATCH v3 maint] batman-adv: Fix TT sync flags for intermediate TT responses

On Donnerstag, 10. Mai 2018 19:44:28 CEST Linus Lüssing wrote: [...] > + * @flags: a pointer to store TT flags for the given @orig_node and @entry to [...] > + * @flags: a pointer to store TT flags for this client to [...] > + * @flags: a pointer to store TT flags to Antonio wanted to have some

Re: [B.A.T.M.A.N.] sanity check please

On Donnerstag, 10. Mai 2018 01:43:56 CEST dan wrote: [...] > I'm running iperf3 with VM1 the server and VM3 the client > > VM1 > iperf3 -s > VM3 > iperf3 -c 192.168.5.1 -b 1M -t 60 -P 1 > > output is 1.75Gbits > > -P 99 > > output is 831Mbps > > > -P 99 *BUT* hitting the 'native' LAN

Re: [B.A.T.M.A.N.] [RFC maint] batman-adv: fix adding VLANs with partial state

On Donnerstag, 10. Mai 2018 17:27:52 CEST Marek Lindner wrote: > Amongst other things, the MAC address of > the VLAN interface itself has to be stored. > > Without this change a VLAN and its infrastructure could be created > while the interface MAC address is not stored without triggering > any

Re: [B.A.T.M.A.N.] [RFC maint] batman-adv: fix adding VLANs with partial state

On Donnerstag, 10. Mai 2018 17:27:52 CEST Marek Lindner wrote: > Whenever a new VLAN is created on top of batman virtual interfaces > the batman-adv kernel module creates internal structures to track > the status of said VLAN. Amongst other things, the MAC address of > the VLAN interface itself

Re: [B.A.T.M.A.N.] [RFC v2] batman-adv: prevent TT request storms by not sending inconsistent TT TLVLs

On Donnerstag, 10. Mai 2018 16:41:37 CEST Marek Lindner wrote: > rcu_read_lock(); > hlist_for_each_entry_rcu(vlan, _priv->softif_vlan_list, list) { > + vlan_entries = atomic_read(>tt.num_entries); > + if (vlan_entries < 1) > +

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: fix argument name in kernel-doc

On Donnerstag, 10. Mai 2018 17:29:46 CEST Antonio Quartulli wrote: > Signed-off-by: Antonio Quartulli > --- > net/batman-adv/tp_meter.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/batman-adv/tp_meter.c b/net/batman-adv/tp_meter.c > index

Re: [B.A.T.M.A.N.] [PATCH maint v2] batman-adv: Avoid race in TT TVLV allocator helper

On Donnerstag, 10. Mai 2018 15:27:34 CEST Antonio Quartulli wrote: [...] > > Fixes: 21a57f6e7a3b ("batman-adv: make the TT CRC logic VLAN specific") > > Signed-off-by: Sven Eckelmann <s...@narfation.org> > > Acked-by: Antonio Quartulli <a...@unstable.cc

Re: [B.A.T.M.A.N.] batman-adv: Bug: Missing TT entry leads to inconsistent but stable TT state

On Donnerstag, 10. Mai 2018 03:20:42 CEST me wrote: > We have three nodes, which have the following topology: > > NDS-Agenda21Haus70 <-> sn04 <-> sn03 > > Something happened, so they came into a stable (for hours) but inconsistent > state of their translation tables: > > - sn03 has 11 entries

Re: [B.A.T.M.A.N.] [RFC] batman-adv: prevent TT request storms by not sending inconsistent TT TLVLs

On Mittwoch, 9. Mai 2018 20:20:58 CEST Sven Eckelmann wrote: > On Mittwoch, 9. Mai 2018 19:21:32 CEST Sven Eckelmann wrote: > [...] > > [...] > > > diff --git a/net/batman-adv/translation-table.c > > > b/net/batman-adv/translation-table.c > > > index 02

[B.A.T.M.A.N.] [PATCH maint v2] batman-adv: Avoid race in TT TVLV allocator helper

(*tt_change) is smaller then the now required extra buffer for new VLAN entries. Fixes: 21a57f6e7a3b ("batman-adv: make the TT CRC logic VLAN specific") Signed-off-by: Sven Eckelmann <s...@narfation.org> --- v2: - adjusted last paragraph because tt_change (third parameter &quo

Re: [B.A.T.M.A.N.] [RFC] batman-adv: prevent TT request storms by not sending inconsistent TT TLVLs

On Mittwoch, 9. Mai 2018 19:21:32 CEST Sven Eckelmann wrote: [...] > [...] > > diff --git a/net/batman-adv/translation-table.c > > b/net/batman-adv/translation-table.c > > index 0225616d..def8d109 100644 > > --- a/net/batman-adv/translation-table.c > > +++ b/n

[B.A.T.M.A.N.] [PATCH maint] batman-adv: Avoid race in TT TVLV allocator helper

then the now required extra buffer for new VLAN entries. Or the buffer overflow can happen when the caller now does no longer gets its requested extra buffer size tt_len. Fixes: 21a57f6e7a3b ("batman-adv: make the TT CRC logic VLAN specific") Signed-off-by: Sven Eckelmann <s...@narfation.org>

Re: [B.A.T.M.A.N.] [RFC] batman-adv: prevent TT request storms by not sending inconsistent TT TLVLs

On Mittwoch, 9. Mai 2018 18:06:05 CEST Marek Lindner wrote: [...] > Fixes: 7ea7b4a14275 ("batman-adv: make the TT CRC logic VLAN specific") I know, my fault but please use 21a57f6e7a3b instead of 7ea7b4a14275. The latter is in the official Linux repository and not batman-adv.git. [...] > diff

Re: [B.A.T.M.A.N.] [PATCH v3 0/2] batman-adv: DHCP snooping for DAT

Name of failed tests ecsv/pu --- * kerneldoc ./net/batman-adv/distributed-arp-table.c Output of different failed tests ecsv/pu: kerneldoc ./net/batman-adv/distributed-arp-table.c

Re: [B.A.T.M.A.N.] [RFC 0/6] B.A.T.M.A.N. V - fallback to tp meter estimation if throughput otherwise not available

Name of failed tests ecsv/pu --- * checkpatch ./net/batman-adv/bat_v_elp.c * checkpatch ./net/batman-adv/tp_meter.c * checkpatch ./net/batman-adv/types.h * headers * kerneldoc ./net/batman-adv/routing.c * kerneldoc ./net/batman-adv/tp_meter.c * kerneldoc

Re: [B.A.T.M.A.N.] [RFC PATCH] batman-adv: mitigate issue when empty vlan is received

On Montag, 7. Mai 2018 10:06:20 CEST me wrote: > On 05/07/2018 08:32 AM, Sven Eckelmann wrote: > > Can you attach a (small) pcap of actual traffic which show a packet which > > triggers this behavior? > > For sure. See for the originator 5e:25:f7:13:2d:eb and vid=0x8000 in t

Re: [B.A.T.M.A.N.] [PATCH 03/17] batman-adv: Add network_coding and mcast sysfs files to README

On Dienstag, 27. März 2018 17:43:08 CEST Linus Lüssing wrote: > On Sat, Oct 29, 2016 at 12:56:28PM +0200, Jiri Pirko wrote: > > >> I strongly believe it is a huge mistake to use sysfs for things like > > >> this. This should be done via generic netlink api. > > > > > >This doesn't change the

Re: [B.A.T.M.A.N.] [PATCH maint] batman-adv: Fix TT sync flags for intermediate TT responses

On Samstag, 5. Mai 2018 17:30:20 CEST Linus Lüssing wrote: [...] > diff --git a/net/batman-adv/translation-table.c > b/net/batman-adv/translation-table.c > index 0225616d..a95724ea 100644 > --- a/net/batman-adv/translation-table.c > +++ b/net/batman-adv/translation-table.c > @@ -2914,6 +2914,41

Re: [B.A.T.M.A.N.] about mesh network with batman-adv

On Montag, 30. April 2018 23:18:59 CEST KwangMin Kim wrote: [...] > However, I have disabled one of these batman-adv settings and rejoined the > wireless mesh network. > > As a result, only two raspberry pies that have set up batman-adv communicate. > > is this right? They still communicate

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: fix batadv_interface_tx()'s return type

On Dienstag, 24. April 2018 15:18:46 CEST Luc Van Oostenryck wrote: > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type, but the implementation in this > driver returns an 'int'. > > Fix this by returning 'netdev_tx_t' in this driver too.

<    5   6   7   8   9   10   11   12   13   14   >