Re: [B.A.T.M.A.N.] [RFC 5/6] batman-adv: Generalize snooping mechanism in order to suport NDP too

2013-10-05 Thread Mihail Costea
Unfortunately yes. With everything it will take too many weeks and I'd like to do other things too. Sorry, Mihail On 5 October 2013 10:14, Antonio Quartulli anto...@meshcoding.com wrote: Hi Mihail, On Fri, Oct 04, 2013 at 09:28:54PM +0300, Mihail Costea wrote: Hi Linus, Unfortunately I

Re: [B.A.T.M.A.N.] [RFC 5/6] batman-adv: Generalize snooping mechanism in order to suport NDP too

2013-10-04 Thread Mihail Costea
Hi Linus, Unfortunately I won't work on this anymore because it will take another 1-2 months. I had a vacation last week and now I started school again. I will start something new and this takes too much time. Sorry, Mihail On 30 September 2013 23:38, Linus Lüssing linus.luess...@web.de wrote:

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Generalize DAT in order to support any type of key/value, not only IPv4 and MAC

2013-09-13 Thread Mihail Costea
On 13 September 2013 14:39, Antonio Quartulli anto...@meshcoding.com wrote: On Wed, Sep 11, 2013 at 03:51:04PM +0300, Mihail Costea wrote: This is the github url: https://github.com/cmihail/batman-adv Mihail, but on github I see only this patch. Do you plan to merge the others as soon

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Generalize DAT in order to support any type of key/value, not only IPv4 and MAC

2013-09-11 Thread Mihail Costea
This is the github url: https://github.com/cmihail/batman-adv On 11 September 2013 15:44, Mihail Costea mihail.costea2...@gmail.com wrote: Mades DAT support more types by making its key and value a void* and by adding type field to dat_entry. This change is needed in order to make DAT support

Re: [B.A.T.M.A.N.] [RFC 1/6] batman-adv: Generalize DAT in order to support any type of data, not only IPv4

2013-09-10 Thread Mihail Costea
On 11 September 2013 00:01, Antonio Quartulli anto...@meshcoding.com wrote: On Tue, Sep 10, 2013 at 03:45:44PM +0300, Mihail Costea wrote: On 10 September 2013 08:38, Antonio Quartulli anto...@meshcoding.com wrote: On Tue, Sep 10, 2013 at 07:35:34AM +0300, Mihail Costea wrote: On 9 September

Re: [B.A.T.M.A.N.] [RFC 1/6] batman-adv: Generalize DAT in order to support any type of data, not only IPv4

2013-09-09 Thread Mihail Costea
Quartulli or...@autistici.org wrote: On Sat, Aug 10, 2013 at 12:01:02PM -0700, Mihail Costea wrote: Hi Antonio, Thanks for the update. I will do the changes as soon as possible. I haven't sync in a while with the code base, so I think the whole changes might take a while to implement (+ I'm also

Re: [B.A.T.M.A.N.] [RFC 4/6] batman-adv: Adds necessary functions for NDP, like checking if a packet is valid or creating a Neighbor Advertisement

2013-08-14 Thread Mihail Costea
Hi, On 10 August 2013 05:20, Antonio Quartulli or...@autistici.org wrote: On Mon, Jul 08, 2013 at 03:12:43AM +0300, mihail.costea2...@gmail.com wrote: From: Mihail Costea mihail.coste...@gmail.com Adds functions needed for NDP snooping, like getting the IPv6 addresses or getting the target

Re: [B.A.T.M.A.N.] [RFC 6/6] batman-adv: Adds snooping of router and override flags for NA creation

2013-08-14 Thread Mihail Costea
On 10 August 2013 06:20, Antonio Quartulli or...@autistici.org wrote: On Mon, Jul 08, 2013 at 03:12:45AM +0300, mihail.costea2...@gmail.com wrote: From: Mihail Costea mihail.coste...@gmail.com Snoops router and override flags for Neighbor Advertisement in order to use it in NA creation

Re: [B.A.T.M.A.N.] [RFC 1/6] batman-adv: Generalize DAT in order to support any type of data, not only IPv4

2013-08-10 Thread Mihail Costea
, mihail.costea2...@gmail.com wrote: From: Mihail Costea mihail.coste...@gmail.com Mades DAT support more types by making its data a void*, adding type field to dat_entry and adding data_type to necessary functions. This change is needed in order to make DAT support any type of data, like IPv6 too

Re: [B.A.T.M.A.N.] [RFC 1/4] batman-adv: renamed batadv_dat_snoop_*_arp_* functions to batadv_dat_snoop_*_msg_*

2013-06-24 Thread Mihail Costea
On 24 June 2013 00:57, Antonio Quartulli or...@autistici.org wrote: Hey Mihail, any news on this? Do you need any input from us? If so, please ask :) Cheers, -- Antonio Quartulli ..each of us alone is worth nothing.. Ernesto Che Guevara Hi Antonio, I got my laptop a weekend ago and

Re: [B.A.T.M.A.N.] [RFC 1/4] batman-adv: renamed batadv_dat_snoop_*_arp_* functions to batadv_dat_snoop_*_msg_*

2013-05-29 Thread Mihail Costea
in order to suggest that they should work on more protocols than ARP. You are introducing the change now, therefore I'd rather speak using simple present instead of past (at least this is what we usually do in all the commits...same applies for the subject). ACK Signed-off-by: Mihail Costea

Re: [B.A.T.M.A.N.] [RFC 2/4] batman-adv: added IPv6 to DAT and generic functions in distributed-arp-table.c

2013-05-29 Thread Mihail Costea
/third patch. Once committed, they will just be some patches in the list. You can either explicitly mention the name of the patch (writing the subject in this way) or just saying previously/whatever else. Signed-off-by: Mihail Costea mihail.coste...@gmail.com Signed-off-by: Stefan Popa

Re: [B.A.T.M.A.N.] [RFC 3/4] batman-adv: added necessary functions for NDP, like checking if a packet is valid or creating a Neighbor Advertisement

2013-05-29 Thread Mihail Costea
On 26 May 2013 07:02, Antonio Quartulli or...@autistici.org wrote: On Fri, May 17, 2013 at 03:27:51PM +0300, Mihail wrote: From: mihail.coste...@gmail.com mihail.coste...@gmail.com Added functions needed for NDP snooping, like getting the IPv6 addresses or getting the target HW address from

Re: [B.A.T.M.A.N.] [RFC 3/4] batman-adv: added necessary functions for NDP, like checking if a packet is valid or creating a Neighbor Advertisement

2013-05-29 Thread Mihail Costea
On 29 May 2013 08:43, Antonio Quartulli or...@autistici.org wrote: On Wed, May 29, 2013 at 08:36:50AM -0700, Mihail Costea wrote: On 26 May 2013 07:02, Antonio Quartulli or...@autistici.org wrote: On Fri, May 17, 2013 at 03:27:51PM +0300, Mihail wrote: From: mihail.coste...@gmail.com

Re: [B.A.T.M.A.N.] [RFC 1/4] batman-adv: renamed batadv_dat_snoop_*_arp_* functions to batadv_dat_snoop_*_msg_*

2013-05-17 Thread Mihail Costea
-by: Mihail Costea mihail.coste...@gmail.com Signed-off-by: Stefan Popa stefan.a.p...@intel.com Reviewed-by: Stefan Popa stefan.a.p...@intel.com --- distributed-arp-table.c | 16 distributed-arp-table.h | 16 routing.c | 12 ++-- soft

Re: [B.A.T.M.A.N.] [PATCH] Made DAT more generic by adding support to any type of data

2013-05-06 Thread Mihail Costea
On 4 May 2013 14:39, Antonio Quartulli or...@autistici.org wrote: On Fri, Apr 26, 2013 at 04:56:54 +0300, Mihail wrote: From: Mihail Costea mihail.coste...@gmail.com Made DAT support more types by making its data a void*, adding type field to dat_entry and adding data_type to necessary

Re: [B.A.T.M.A.N.] [PATCH] Added generic transformer to string function for DAT data

2013-04-23 Thread Mihail Costea
batadv_dat_data_to_str calls). On Mon, Apr 22, 2013 at 02:12:18PM +0300, YourName wrote: Signed-off-by: Mihail Costea mihail.coste...@gmail.com Signed-off-by: Stefan Popa stefan.a.p...@intel.com Reviewed-by: Stefan Popa stefan.a.p...@intel.com --- distributed-arp-table.c | 71

Re: [B.A.T.M.A.N.] [RFCv3] batman-adv: Modified DAT structures and functions in order to support both IPv4 and IPv6

2013-04-20 Thread Mihail Costea
On 20 April 2013 16:56, Antonio Quartulli or...@autistici.org wrote: On Fri, Apr 19, 2013 at 09:39:17 +0300, Mihail Costea wrote: On 19 April 2013 15:38, Antonio Quartulli or...@autistici.org wrote: I think this define is pretty overkill..What about creating a function which only takes

Re: [B.A.T.M.A.N.] [RFCv3] batman-adv: Modified DAT structures and functions in order to support both IPv4 and IPv6

2013-04-19 Thread Mihail Costea
On 19 April 2013 15:38, Antonio Quartulli or...@autistici.org wrote: Hi Mihail, On Mon, Apr 15, 2013 at 12:37:33PM +0300, Mihail Costea wrote: [...] +#ifdef CONFIG_BATMAN_ADV_DEBUG + +#if IS_ENABLED(CONFIG_IPV6) + +/* batadv_dat_dbg_ip - print similar debug message for IPv4

[B.A.T.M.A.N.] [RFCv3] batman-adv: Modified DAT structures and functions in order to support both IPv4 and IPv6

2013-04-15 Thread Mihail Costea
Subject: [RFCv3] batman-adv: Modified DAT structures and functions in order to support both IPv4 and IPv6 Signed-off-by: Mihail Costea mihail.coste...@gmail.com Signed-off-by: Stefan Popa stefan.a.p...@intel.com Reviewed-by: Stefan Popa stefan.a.p...@intel.com --- Removed the ugly debug

Re: [B.A.T.M.A.N.] [RFCv2] batman-adv: Modified DAT structures and functions in order to support both IPv4 and IPv6

2013-04-03 Thread Mihail Costea
On 3 April 2013 01:06, Antonio Quartulli or...@autistici.org wrote: On Mon, Mar 18, 2013 at 02:07:42PM +0200, Mihail Costea wrote: Subject: [RFCv2] batman-adv: Modified DAT structures and functions in order to support both IPv4 and IPv6 Signed-off-by: Mihail Costea mihail.coste...@gmail.com

Re: [B.A.T.M.A.N.] [RFCv2] batman-adv: Modified DAT structures and functions in order to support both IPv4 and IPv6

2013-03-29 Thread Mihail Costea
On 29 March 2013 14:30, Marek Lindner lindner_ma...@yahoo.de wrote: On Friday, March 29, 2013 03:14:25 Mihail Costea wrote: But it's not a problem. I can go forward without having this submitted :). This is for my diploma project, but it doesn't hurt to push it upstream. It is an excellent

Re: [B.A.T.M.A.N.] [RFCv2] batman-adv: Modified DAT structures and functions in order to support both IPv4 and IPv6

2013-03-28 Thread Mihail Costea
On 28 March 2013 12:19, Antonio Quartulli or...@autistici.org wrote: Hi Mihail, sorry for taking so long to review your patch..I've been very busy last 10 days and so it was difficult for me to allocate enough time to review your code. I'll try to do it within the end of this week. Nobody

Re: [B.A.T.M.A.N.] [RFC] batman-adv: Modified DAT structures and functions in order to support both IPv4 and IPv6

2013-03-15 Thread Mihail Costea
On 15 March 2013 13:57, Antonio Quartulli or...@autistici.org wrote: On Sat, Mar 09, 2013 at 07:40:48PM +0200, Mihail Costea wrote: Subject: [RFC] batman-adv: Modified DAT structures and functions in order to support both IPv4 and IPv6 In order to support DHT for IPv6 there was needed

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Added IP enum types for dat and generic functions for comparing IPs and calculating hash

2013-03-09 Thread Mihail Costea
On 9 March 2013 12:12, Marek Lindner lindner_ma...@yahoo.de wrote: On Friday, March 08, 2013 18:50:46 Mihail Costea wrote: From d7a67d268ddd4d8788f806872459609994da7586 Mon Sep 17 00:00:00 2001 From: Mihail Costea mihail.coste...@gmail.com Date: Fri, 8 Mar 2013 12:43:16 +0200 Subject: [PATCH

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Added IP enum types for dat and generic functions for comparing IPs and calculating hash

2013-03-09 Thread Mihail Costea
On 9 March 2013 13:01, Marek Lindner lindner_ma...@yahoo.de wrote: On Saturday, March 09, 2013 18:55:46 Mihail Costea wrote: Is the rest of the patchset still coming or did it get lost in transit ? Cheers, Marek I thought do send it in steps to make it easier for reading

Re: [B.A.T.M.A.N.] Implement DAT for IPv6

2013-03-08 Thread Mihail Costea
Hi, I have created a patch for this, just that is quite big (~ 450 lines the whole patch, with signature, etc). It doesn't contain complex changes, just small changes from __be32 to (unsigned char *), a new parameter to functions in order to give the IP type and added comments. I've tested it

Re: [B.A.T.M.A.N.] Implement DAT for IPv6

2013-03-08 Thread Mihail Costea
On 8 March 2013 11:33, Antonio Quartulli or...@autistici.org wrote: On Fri, Mar 08, 2013 at 11:22:37AM +0200, Mihail Costea wrote: Hi, I have created a patch for this, just that is quite big (~ 450 lines the whole patch, with signature, etc). It doesn't contain complex changes, just small

[B.A.T.M.A.N.] [PATCH] batman-adv: Added IP enum types for dat and generic functions for comparing IPs and calculating hash

2013-03-08 Thread Mihail Costea
From d7a67d268ddd4d8788f806872459609994da7586 Mon Sep 17 00:00:00 2001 From: Mihail Costea mihail.coste...@gmail.com Date: Fri, 8 Mar 2013 12:43:16 +0200 Subject: [PATCH] batman-adv: Added IP enum types for dat and generic functions for comparing IPs and calculating hash Signed-off-by: Mihail

[B.A.T.M.A.N.] Implement DAT for IPv6

2013-03-01 Thread Mihail Costea
Hi, I've started implementing DAT for IPv6 and I have a few questions regarding the design. I've already implemented a snooping mechanism for Network Solicitation package, but now I have to add it to the ipv6 distributed table. I'm also a beginner in kernel programming so any help would be

Re: [B.A.T.M.A.N.] Implement DAT for IPv6

2013-03-01 Thread Mihail Costea
On 1 March 2013 13:08, Antonio Quartulli or...@autistici.org wrote: On Fri, Mar 01, 2013 at 12:59:18PM +0200, Mihail Costea wrote: Hi, I've started implementing DAT for IPv6 and I have a few questions regarding the design. I've already implemented a snooping mechanism for Network

Re: [B.A.T.M.A.N.] Implement DAT for IPv6

2013-03-01 Thread Mihail Costea
On 1 March 2013 13:11, Antonio Quartulli or...@autistici.org wrote: On Fri, Mar 01, 2013 at 12:59:18PM +0200, Mihail Costea wrote: Hi, I've started implementing DAT for IPv6 and I have a few questions regarding the design. I've already implemented a snooping mechanism for Network

Re: [B.A.T.M.A.N.] Implement DAT for IPv6

2013-03-01 Thread Mihail Costea
On 1 March 2013 13:43, Antonio Quartulli or...@autistici.org wrote: On Fri, Mar 01, 2013 at 01:38:43PM +0200, Mihail Costea wrote: On 1 March 2013 13:08, Antonio Quartulli or...@autistici.org wrote: On Fri, Mar 01, 2013 at 12:59:18PM +0200, Mihail Costea wrote: Hi, I've started