On Tuesday, 2 April 2024 19:23:01 CEST Erick Archer wrote:
> The "struct batadv_tvlv_tt_data" uses a dynamically sized set of
> trailing elements. Specifically, it uses an array of structures of type
> "batadv_tvlv_tt_vlan_data". So, use the preferred way in the kernel
> declaring a flexible array
On Tuesday, 19 March 2024 11:33:17 CET syzbot wrote:
> syzbot has found a reproducer for the following issue on:
>
> HEAD commit:35c3e2791756 Revert "net: Re-use and set mono_delivery_tim..
> git tree: net
> console output: https://syzkaller.appspot.com/x/log.txt?x=1056918118
>
y_release()' and
> 'batadv_tt_orig_list_entry_release()', respectively.
>
> Signed-off-by: Dmitry Antipov
Ah, SLOB is gone and now this is possible.
Acked-by: Sven Eckelmann
Thanks,
Sven
signature.asc
Description: This is a digitally signed message part.
("batman-adv: limit local translation table max size")
Reported-by:
Signed-off-by: Sven Eckelmann
---
net/batman-adv/translation-table.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/batman-adv/translation-table.c
b/net/batman-adv/translation-table.c
inde
st
>From 5984ace8f8df7cf8d6f98ded0eebe7d962028992 Mon Sep 17 00:00:00 2001
From: Sven Eckelmann
Date: Mon, 12 Feb 2024 13:10:33 +0100
Subject: [PATCH] batman-adv: Avoid infinite loop trying to resize local TT
If the MTU of one of an attached interface becomes too small to transmit
the loc
On Monday, 12 February 2024 11:41:38 CET Eric Dumazet wrote:
> This patch [1] looks suspicious
Shouldn't be caused by this - but this might be another way to trigger the
problem. The problem would be visible even without it when a mtu is explicitly
set. But the reproducer is not available so I
On Saturday, 27 January 2024 13:48:58 CET Sven Eckelmann wrote:
> While many parts of batctl are rather simple, tcpdump is one of the most
> complex parts - which unfortunately is also dealing all the time
> with potentially harmful input. It is therefore a good idea to perform
>
the
UDP header using the inner ihl IPv4 header length information. So it is
possible that it tries to read outside of the received data.
Fixes: 75d68356f3fa ("[batctl] tcpdump - add basic IPv4 support")
Signed-off-by: Sven Eckelmann
---
tcpdump.c | 14 +++---
1 file changed, 11
t;add IPv6 support to tcpdump parser")
Cc: Marco Dalla Torre
Signed-off-by: Sven Eckelmann
---
tcpdump.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tcpdump.c b/tcpdump.c
index 2ae3909..c253755 100644
--- a/tcpdump.c
+++ b/tcpdump.c
@@ -652,6 +652,8 @@ static void dump_ipv6(uns
t;add IPv6 support to tcpdump parser")
Cc: Marco Dalla Torre
Signed-off-by: Sven Eckelmann
---
tcpdump.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tcpdump.c b/tcpdump.c
index 3fdd7c3..2ae3909 100644
--- a/tcpdump.c
+++ b/tcpdump.c
@@ -659,6 +659,8 @@ static void dump_ipv6(uns
if
there are at least enough bytes available to read the basic IPv4 header. So
it is possible that it tries to read outside of the received data.
Fixes: 75d68356f3fa ("[batctl] tcpdump - add basic IPv4 support")
Signed-off-by: Sven Eckelmann
---
tcpdump.c | 2 ++
1 file changed, 2
("batctl: introduce throughput meter support")
Signed-off-by: Sven Eckelmann
---
tcpdump.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tcpdump.c b/tcpdump.c
index d15c32e..9bb4b9e 100644
--- a/tcpdump.c
+++ b/tcpdump.c
@@ -911,7 +911,6 @@ static void dump_b
to
read outside of the received data.
Fixes: 3bdfc388e74b ("implement simple tcpdump, first only batman packets")
Signed-off-by: Sven Eckelmann
---
tcpdump.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tcpdump.c b/tcpdump.c
index d340af9..d15c32e 100644
--- a/tcpdump.c
+++ b
ding them to the fuzzme
subcommand:
./batctl fuzzme <
out/fuzzer1/crashes/id:00,sig:06,src:000528,time:12,execs:23992,op:havoc,rep:8
Signed-off-by: Sven Eckelmann
---
Sven Eckelmann (6):
batctl: tcpdump: Fix missing sanity check for batman-adv header
batctl: tcpdump: Add mi
is no longer needed.
Signed-off-by: Sven Eckelmann
---
net/batman-adv/netlink.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/batman-adv/netlink.c b/net/batman-adv/netlink.c
index cda99753..6aff7cc1 100644
--- a/net/batman-adv/netlink.c
+++ b/net/batman-adv/netlink.c
@@ -15,7 +15,6 @@
On Tuesday, 16 January 2024 10:27:20 CET syzbot wrote:
> Hello,
>
> syzbot found the following issue on:
>
> HEAD commit:052d534373b7 Merge tag 'exfat-for-6.8-rc1' of git://git.ke..
> git tree: upstream
> console output: https://syzkaller.appspot.com/x/log.txt?x=14620debe8
> kernel
@Linus, this looks like something for you.
On Tuesday, 16 January 2024 10:27:20 CET syzbot wrote:
> syzbot found the following issue on:
>
> HEAD commit:052d534373b7 Merge tag 'exfat-for-6.8-rc1' of git://git.ke..
> git tree: upstream
> console output:
://lore.kernel.org/r/2024011046-ecology-tiptoeing-ce50@gregkh/
Signed-off-by: Sven Eckelmann
---
Changes in v2:
- Add EOL announcement URL to commit message
- Fix conflict in README.external.rst
- Link to v1:
https://lore.kernel.org/r/20231104-drop-compat-4-14-v1-1-d2453b1cf...@narfation.org
e contained a null pointer.
> This issue was detected by using the Coccinelle software.
>
> * Thus adjust jump targets.
>
> * Reorder kfree() calls at the end.
>
> Signed-off-by: Markus Elfring
Acked-by: Sven Eckelmann
> ---
> net/batman-adv/main.c | 14 --
&g
ned a null pointer.
> This issue was detected by using the Coccinelle software.
>
> * Thus return directly after a batadv_dat_select_candidates() call failed
> at the beginning.
>
> * Delete the label “out” which became unnecessary with this refactoring.
>
> Signed-off-by:
The newest Linux stable kernel releases:
* v5.10.205
* v5.15.144
* v6.1.69
received a backported version of commit 1f5020acb33f ("net: vlan: introduce
skb_vlan_eth_hdr()"). batman-adv must therefore not provide this function
any longer for these kernel versions.
Signed-off-by: Sven
On Thursday, 21 December 2023 06:52:01 CET Jinho Ju wrote:
> Resending to everyone on the mailing list as per previous mail, adding some
> things that were missing.
>
> Regarding the cause of the L2-related crash being detected by syzkaller,
What crash? I can't see it in your mail [1]
> I
>
On Tuesday, 12 December 2023 20:30:24 CET Rich Chase wrote:
> For my life I can't see anything I'm doing wrong. Why can't bat0
> have MTU greater than 1500?
>
> I don't have any other devices mastered by bat0, other than my .1s wifi mesh
> link.
>
> Throwing myself at your mercy. Help?
On Thursday, 7 September 2023 03:09:07 CET Linus Lüssing wrote:
[...]
> Changelog v7:
> * PATCH 1/3:
> * rebased to current main/master branch (resolved net/multicast/routing.h)
> * renamed batadv_mcast_forw_orig_to_neigh() to
> batadv_orig_to_router() and moved it to originator.c, for
>
The commit 3cd39bc3b11b ("kernel.h: Move ARRAY_SIZE() to a separate
header") introduced a new header for the ARRAY_SIZE macro which was
previously exposed via linux/kernel.h.
Signed-off-by: Sven Eckelmann
---
compat-include/linux/array_size.h | 20
net/batman-
://lore.kernel.org/r/
Signed-off-by: Sven Eckelmann
---
The last 4.14 version was not yet released but is announced to be in Jan,
2024: https://kernel.org/category/releases.html
---
README.external.rst | 2 +-
compat-include/linux/netdevice.h | 8
compat-include/linux/stddef.h
The commit 39ced19b9e60 ("lib/vsprintf: split out sprintf() and friends")
introduced a new header for the sprintf related functions which were
previously exposed via linux/kernel.h.
Signed-off-by: Sven Eckelmann
---
Changes in v2:
- version for out-of-tree kernel with compat header
-
The commit 39ced19b9e60 ("lib/vsprintf: split out sprintf() and friends")
introduced a new header for the sprintf related functions which were
previously exposed via linux/kernel.h.
Signed-off-by: Sven Eckelmann
---
net/batman-adv/bridge_loop_avoidance.c | 2 +-
net/batman-adv/gatewa
On Thursday, 7 September 2023 03:09:07 CEST Linus Lüssing wrote:
[...]
> Changelog v7:
> * PATCH 1/3:
> * rebased to current main/master branch (resolved net/multicast/routing.h)
Are you trying to take over batman-adv and make it the *multicast* mesh
protocol? :D
> * renamed
ndrzej Siewior
Shan Wei
Shaokun Zhang
Shigeru Yoshida
Simon Wunderlich
Stephen Hemminger
Steven Rostedt (Google)
Sven Eckelmann
Sven-Thorsten Dietrich
Sylvestre Ledru
Taehee Yoo
Tejun Heo
Tetsuo Handa
Tobias Klauser
Tom Gundersen
Tracey Dent
Vasiliy Kulikov
Vladimir Oltean
Vladislav Efanov
Wilfried
On Wednesday, 6 September 2023 17:50:26 CEST MK wrote:
[...]
> batman-adv/gateway_common.c:55:8: error: implicit declaration of
> function ‘kstrtou64’ [-Werror=implicit-function-declaration]
> 55 | ret = kstrtou64(buff, 10, );
> cc1: some warnings being treated as errors
>
> Tried make
: c6a953cce8d0 ("batman-adv: Trigger events for auto adjusted MTU")
Signed-off-by: Sven Eckelmann
---
This problem was just identified by syzbot [1]. I hope it is ok to directly
send this patch to netdev instead of creating a single-patch PR from
the batadv/net branch. If you still prefer a
On Saturday, 29 July 2023 13:11:28 CEST Sven Eckelmann wrote:
> I have now acked the various patches and have queued them up for submission
> to
> net-next. But it would be good when Simon also checks them.
Just discussed with Simon, and he had some good points regarding the
re
read+0x1fc/0x210
> [<0c587d3a>] ret_from_fork+0x10/0x20
>
> [...]
Applied, thanks!
[1/1] batman-adv: Fix batadv_v_ogm_aggr_send memory leak
commit: 421d467dc2d483175bad4fb76a31b9e5a3d744cf
Best regards,
--
Sven Eckelmann
signature.asc
Description: This is a digitally signed message part.
On Fri, 04 Aug 2023 11:39:36 +0200, Remi Pommarel wrote:
> When a client roamed back to a node before it got time to destroy the
> pending local entry (i.e. within the same originator interval) the old
> global one is directly removed from hash table and left as such.
>
> But because this entry
the function pointer, just store the limits directly
in struct batadv_algo_gw_ops.
Signed-off-by: Sven Eckelmann
---
net/batman-adv/bat_iv_ogm.c | 1 +
net/batman-adv/bat_v.c | 23 ++---
net/batman-adv/gateway_common.c | 74 +
net/batman
The batadv_netlink_notify_*() functions are not used by any other source
file. Just keep them local to netlink.c to get informed by the compiler
when they are not used anymore.
Signed-off-by: Sven Eckelmann
---
net/batman-adv/netlink.c | 10 +-
net/batman-adv/netlink.h | 6 --
2
This function is no longer used since the sysfs support was removed from
batman-adv.
Signed-off-by: Sven Eckelmann
---
net/batman-adv/gateway_common.c | 88 -
net/batman-adv/gateway_common.h | 2 -
2 files changed, 90 deletions(-)
diff --git a/net
There were a couple of functions which were still compiled but not used
anymore since a while. Just drop them and make sure that other ones are
local only (to make it easier to spot them in the future).
Signed-off-by: Sven Eckelmann
---
Sven Eckelmann (3):
batman-adv: Drop unused function
On Thursday, 20 July 2023 06:35:52 CEST Linus Lüssing wrote:
[...]
> The purpose of this new packet type is to allow to forward an IP
> multicast packet with less transmissions / overhead than the
> multicast-via-multiple-unicasts approach. Or to reach a lot more
> destinations (currently up to
man-adv/multicast_forw.c | 195
> 1 file changed, 195 insertions(+)
Acked-by: Sven Eckelmann
Kind regards,
Sven
signature.asc
Description: This is a digitally signed message part.
+-
> net/batman-adv/multicast.h | 25 +-
> net/batman-adv/multicast_forw.c | 727
> net/batman-adv/soft-interface.c | 6 +-
> net/batman-adv/types.h | 6 +
> 5 files changed, 835 insertions(+), 8 deletions(-)
Acked-by: Sven Eckelmann
| 11 ++
> net/batman-adv/soft-interface.c| 12 ++
> net/batman-adv/types.h | 64
> 11 files changed, 504 insertions(+), 11 deletions(-)
> create mode 100644 net/batman-adv/multicast_forw.c
Acked-by: Sven Eckelmann
signature.asc
Description: This is a digitally signed message part.
On Fri, 28 Jul 2023 15:38:50 +0200, Remi Pommarel wrote:
> If received skb in batadv_v_elp_packet_recv or batadv_v_ogm_packet_recv
> is either cloned or non linearized then its data buffer will be
> reallocated by batadv_check_management_packet when skb_cow or
> skb_linearize get called. Thus
Since batman-adv is not actually depending on hardware capabilities, it has
no limit on the MTU. Only the lower hard interfaces can limit it. In case
these have an high enough MTU or fragmentation is enabled, a higher MTU
than 1500 can be enabled.
Signed-off-by: Sven Eckelmann
---
net/batman
If the MTU of the soft/mesh interface was already reduced (enough), it is
not necessary to print a warning about a hard interface not having a MTU to
transport ethernet payloads of 1500 bytes.
Signed-off-by: Sven Eckelmann
---
net/batman-adv/hard-interface.c | 20 +---
1 file
The header linux/if_ether.h already defines a constant for the minimum MTU.
So simply use it instead of having a magic constant in the code.
Signed-off-by: Sven Eckelmann
---
net/batman-adv/soft-interface.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/batman-adv/soft
] can be collected - or some fixes.
[1] https://www.open-mesh.org/issues/365
[2]
https://www.kernel.org/doc/html/v6.4/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes
Signed-off-by: Sven Eckelmann
---
Sven Eckelmann (3):
batman-adv: Avoid magic
On Wed, 26 Jul 2023 22:25:25 +0800, YueHaibing wrote:
> Since commit 335fbe0f5d25 ("batman-adv: tvlv - convert tt query packet to use
> tvlv unicast packets")
> batadv_recv_tt_query() is not used.
> And commit 122edaa05940 ("batman-adv: tvlv - convert roaming adv packet to
> use tvlv unicast
On Saturday, 8 July 2023 23:51:10 CEST Linus Lüssing wrote:
[...]
> Changelog v5:
> * removed patches 1/5 + 2/5, as they were already applied
> * rebased to current main branch
> * changed padding behaviour:
> * now 2 bytes padding on the end of the multicast
> tracker TVLV, if number of
to be decreased because batman-adv is not able to transfer packets
with the user specified size.
Fixes: 88861ea9acb7 ("[batman-adv] replacing if up/down timer with kernel
notifications")
Signed-off-by: Sven Eckelmann
---
net/batman-adv/hard-interface.c | 14 +-
net/batma
were
simply missing.
Due to this problem, non-batman-adv components weren't aware of MTU changes
and thus couldn't perform their own tasks correctly.
Fixes: 8009e9f7ac4f ("set bat0 MTU according to the MTUs of the hard
interfaces")
Signed-off-by: Sven Eckelmann
---
net/batma
overwritten when a hard-interface
became active
Signed-off-by: Sven Eckelmann
---
Sven Eckelmann (2):
batman-adv: Trigger events for auto adjusted MTU
batman-adv: Don't increase MTU when set by user
net/batman-adv/hard-interface.c | 14 +-
net/batman-adv/soft-interface.c
On Tuesday, 11 July 2023 15:03:25 CEST anders.berndts...@idptech.se wrote:
> Is there anyone supporting Yocto layer meta-batman ?
>
> https://github.com/jhaws1982/meta-batman
Why aren't you asking the maintainer [1]? But he already wrote [2] on the
mailinglist [3] that he will only accept PRs
On Friday, 9 June 2023 20:55:24 CEST Mark Mundy wrote:
> I think I understand this to mean that I should remove the ipaddress, netmask
> configuration items from the bat0 interface, and create a bridge with bat0
> and eth1.
Nearly correct - the eth1 IP configuration must also be removed
On Thursday, 8 June 2023 22:38:23 CEST mark.mu...@draeger.com wrote:
> What is the best way to figure out why 2 nodes that are connected on a WMN
> can see each other through 'batctl n', but 'batman ping' fails with the
> message "Error - mac address of the ping destination could not be resolved
On Thursday, 8 June 2023 11:27:31 CEST Paolo Abeni wrote:
[...]
> > We're still not preventing the timer / work from getting scheduled
> > and staying alive after the netdev has been freed, right?
>
> I *think* this specific use case does not expose such problem, as the
> delayed work is (AFAICS)
inter to already freed memory.
>
> Found by Linux Verification Center (linuxtesting.org) with syzkaller.
>
> Fixes: 2f1dfbe18507 ("batman-adv: Distributed ARP Table - implement local
> storage")
> Signed-off-by: Vladislav Efanov
> ---
Acked-by: Sven Eckelmann
Thanks,
Sven
signature.asc
Description: This is a digitally signed message part.
On Friday, 26 May 2023 18:16:32 CEST Vladislav Efanov wrote:
> The reason for these issues is the lack of synchronization. Delayed
> work (batadv_dat_purge) schedules new timer/work while the device
> is being deleted. As the result new timer/delayed work is set after
> cancel_delayed_work_sync()
On Tuesday, 7 February 2023 11:41:53 CET Leon Romanovsky wrote:
> Once you stop to update version, you will push users to look on the real
> version (kernel) which really matters.
I would have understood if you say "let us use a magic value like 'in-tree' or
'linux'" but setting it to an old
On Tuesday, 7 February 2023 10:02:58 CET Leon Romanovsky wrote:
> In cases where you can prove real userspace breakage, we simply stop to
> update module versions.
That would be the worst option. Then the kernel shows bogus values and no one
is helped.
And how should I prove it to you? Is that
On Friday, 3 February 2023 09:29:50 CET Jiri Pirko wrote:
[...]
> Why kernel version is not enough for you? My point is, why to maintain
> internal driver version alongside with the kernel version?
[...]
> >Also note that we can't do a simple kernel version to year
> >notation mapping in userspace
On Tuesday, 27 December 2022 20:34:04 CET Linus Lüssing wrote:
[...]
> The purpose of this new packet type is to allow to forward an IP
> multicast packet with less transmissions / overhead than the
> multicast-via-multiple-unicasts approach. Or to reach a lot more
> destinations (currently up to
Fixes: d83571147325 ("add some README to describe the usage")
Signed-off-by: Sven Eckelmann
---
Documentation/networking/batman-adv.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/networking/batman-adv.rst
b/Documentation/networking/batman-adv
is
process.
It is therefore not easily possible to figure out whether the libgps API
will provide this functionality or not. To avoid a conflict during the
build, just rename fixsource_t and gpsd_source_spec.
Reported-by: Bjørn Forsman
Signed-off-by: Sven Eckelmann
---
gpsd/alfred-gpsd.c | 11 +++
On Tuesday, 27 December 2022 20:34:09 CET Linus Lüssing wrote:
> +/**
> + * batadv_mcast_forw_shrink_move_headers() - move multicast headers by offset
> + * @skb: the batman-adv multicast packet to move headers for
> + * @offset: a non-negative offset to move headers by, towards the skb tail
> + *
+-
> net/batman-adv/multicast.h | 25 +-
> net/batman-adv/multicast_forw.c | 513
> net/batman-adv/soft-interface.c | 6 +-
> net/batman-adv/types.h | 6 +
> 5 files changed, 621 insertions(+), 8 deletions(-)
Acked-by: Sven Eck
| 11 ++
> net/batman-adv/soft-interface.c| 12 ++
> net/batman-adv/types.h | 64 +++
> 11 files changed, 523 insertions(+), 11 deletions(-)
> create mode 100644 net/batman-adv/multicast_forw.c
Acked-by: Sven Eckelmann
But I want to have at least another maintain
The commit a15d3f3c1c2a ("batman-adv: use get_random_u32_below() instead of
deprecated function") replaced the prandom.h function prandom_u32_max with
the random.h function get_random_u32_below. There is no need to still
include prandom.h.
Signed-off-by: Sven Eckelmann
---
v2:
- Fix
://lore.kernel.org/r/y7lbu6%2f0p7q%2fp...@kroah.com
Signed-off-by: Sven Eckelmann
---
README.external.rst | 2 +-
compat-include/linux/build_bug.h | 31 -
compat-include/linux/netdevice.h | 19
compat-include/linux/prandom.h | 1
Hi,
maybe some of you remember the time when the archive of this mailing list was
also mirrored to Gmane - providing services like web ui, nntp or raw
(unmangled) mail downloads. But the original Gmane is gone since a long time.
And the other public mirror (mail-archive.com) is a lot more web
_containers_process parameters start to become a mess. Anyway, this
has not really anything to do with your patch.
Acked-by: Sven Eckelmann
Just wondering if it is a good idea to use the network/transport header
offsets/pointers like this.
Kind regards,
Sven
signature.asc
Description: This is a digitally signed message part.
--
> net/batman-adv/multicast.h | 38 +
> net/batman-adv/soft-interface.c | 26 ++--
> 3 files changed, 33 insertions(+), 280 deletions(-)
Acked-by: Sven Eckelmann
Kind regards,
Sven
signature.asc
Description: This is a digitally signed message part.
On Tuesday, 27 December 2022 12:58:41 CET Linus Lüssing wrote:
> On Tue, Dec 27, 2022 at 10:07:36AM +0100, Sven Eckelmann wrote:
> > ecsv/pu: checkpatch ./net/batman-adv/multicast_forw.c
> > -
> >
> > CHECK: Macr
On Monday, 26 December 2022 21:42:37 CET Linus Lüssing wrote:
> Remove all zero MAC address entries (00:00:00:00:00:00) from a multicast
> packet's tracker TVLV before transmitting it and update all headers
> accordingly. This way, instead of keeping the multicast packet at a
> constant size
On Monday, 26 December 2022 21:42:36 CET Linus Lüssing wrote:
> Implement the preparation of a batman-adv multicast packet and use this
> under certain conditions.
>
> For one thing this implements the capability to push a complete
> batman-adv multicast packet header, including a tracker TVLV
On Monday, 26 December 2022 21:42:35 CET Linus Lüssing wrote:
> Implement functionality to receive and forward a new TVLV capable
> multicast packet type.
>
> The new batman-adv multicast packet type allows to contain several
> originator destination addresses within a TVLV. Routers on the way
The commit a15d3f3c1c2a ("batman-adv: use get_random_u32_below() instead of
deprecated function") replaced the prandom.h function prandom_u32_max with
the random.h function get_random_u32_below. There is no need to still
include prandom.h.
Signed-off-by: Sven Eckelmann
diff --gi
The commit a15d3f3c1c2a ("batman-adv: use get_random_u32_below() instead of
deprecated function") replaced the prandom.h function prandom_u32_max with
the random.h function get_random_u32_below.
Signed-off-by: Sven Eckelmann
diff --git a/net/batman-adv/network-coding.c b/net/batman-a
On Monday, 26 December 2022 17:15:50 CET Linus Lüssing wrote:
> The multicast code to send a multicast packet via multiple batman-adv
> unicast packets is not only capable of sending to multiple but also to a
> single node. Therefore we can safely remove the old, specialized, now
> redundant
Subject is missing something like ..." after calling rtnl_link_register()" or
..."s during module initialization".
On Sunday, 25 December 2022 00:33:11 CET Artem Chernyshev wrote:
[...]
> diff --git a/net/batman-adv/main.c b/net/batman-adv/main.c
> index e8a449915566..04cd9682bd29 100644kwin
> @@
://lore.kernel.org/r/
Signed-off-by: Sven Eckelmann
---
README.external.rst | 2 +-
compat-include/linux/build_bug.h | 31 -
compat-include/linux/netdevice.h | 19
compat-include/linux/prandom.h | 1 -
compat-include/linux
On Tuesday, 1 November 2022 19:49:54 CET cch...@creonexsystems.com wrote:
> We are now looking into getting BATMAN working on a Zynq-7000 Xilinx FPGA.
> This FPGA hosts dual-arm A9 cores. We have successfully loaded up Ubuntu on
> this platform and it is running
> Linux version
On Wednesday, 7 September 2022 18:00:37 CEST Shigeru Yoshida wrote:
> ping?
This was applied a while ago:
https://git.open-mesh.org/linux-merge.git/commit/b1cb8a71f1eaec4eb77051590f7f561f25b15e32
Kind regards,
Sven
signature.asc
Description: This is a digitally signed message part.
r that will use a va_list and only write enough of the
> string into the ring buffer that is needed.
Acked-by: Sven Eckelmann
(and sorry for taking such a long time to respond to the v1 version of the
patch).
> ---
> Changes since v1:
> https://lkml.kernel.org/r/20220705224751.080390...@
On Thursday, 14 July 2022 18:43:13 CEST Steven Rostedt wrote:
> From: "Steven Rostedt (Google)"
>
> Instead of open coding a __dynamic_array() with a fixed length (which
> defeats the purpose of the dynamic array in the first place).
Please also make sure to remove the define of
is needed.
Link: https://lkml.kernel.org/r/20220705224751.080390...@goodmis.org
Signed-off-by: Steven Rostedt (Google)
[s...@narfation.org: add compat code]
Signed-off-by: Sven Eckelmann
---
Already added to
https://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git/commit/?
On Monday, 20 June 2022 12:20:19 CEST cch...@creonexsystems.com wrote:
> Does BATMAN ADV interfaces with the radio via the network driver or does
> BATMAN include the network driver?
As said before, it is interfacing with the generic ethernet netdev layer of
the kernel. For example in:
*
On Friday, 17 June 2022 10:41:46 CEST cch...@creonexsystems.com wrote:
[...]
> We would like to use batman with a custom radio and are trying to figure out
> what part of the source code we may need to modify to allow batman to work
> with a custom radio.
> Custom radio means that the radio is
On Friday, 20 May 2022 08:18:45 CEST Charles Chien wrote:
> We’re currently trying to install batman-adv on an ARM platform but we
> ran into some issues and we would appreciate your help to answer our
> questions below:
>
> Is the batman-adv module compatible with an ARM processor (Raspberry PI
On Tuesday, 17 May 2022 09:44:07 CEST Marek Lindner wrote:
[...]
> Thanks for preparing the rebase & code change patches. Wouldn't you say that
> EPOLL_CTL_DEL somewhere near unix_sock_event_listener_free() could be helpful?
>
> Something like:
> -static void unix_sock_event_listener_free(struct
On Thursday, 1 October 2020 09:59:35 CEST Sabrina Dubroca wrote:
> device has the same ifindex as its link. Let's use the presence of a
> ndo_get_iflink operation, rather than the value it returns, to detect
> a device without a link.
There wasn't any activity in this patchset since a while, it
On Monday, 2 May 2022 13:46:51 CEST Marek Lindner wrote:
> The alfred server instance accepts event notification registration
> via the unix socket. These notification sockets only inform
> registered parties of the availability of an alfred datatype change.
> The actual data itself needs to be
documented.
Fixes: 5a7d28b1866d ("alfred: introduce 'server status' IPC call")
Signed-off-by: Sven Eckelmann
---
main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/main.c b/main.c
index 68d6efd..30e18a5 100644
--- a/main.c
+++ b/main.c
@@ -163,7 +163,7 @@ sta
.
Signed-off-by: Sven Eckelmann
---
alfred.h | 20 --
batadv_querynl.c | 4 --
epoll_handle.h | 25 +++
netsock.c| 171 ++-
server.c | 127 ---
unix_sock.c | 59
implementation:
[12.673756426] announce primary ...
[22.673779811] announce primary ...
[32.673778362] announce primary ...
[42.673775216] announce primary ...
Signed-off-by: Sven Eckelmann
---
alfred.h | 2 ++
server.c | 89 +++-
2 files
On Sunday, 1 May 2022 11:10:13 CEST Marek Lindner wrote:
> > > +static void unix_sock_event_listener_free(struct event_listener
> > > *listener)
> > > +{
> > > + list_del_init(>list);
> > > + close(listener->fd);
> > > + free(listener);
> >
> > list_del_init has no benefit (only downsides) when
On Saturday, 30 April 2022 12:56:47 CEST Marek Lindner wrote:
> The alfred server instance accepts event notification registration
> via the unix socket. These notification sockets only inform
> registered parties of the availibility of an alfred datatype change.
availability
> +int
On Monday, 25 April 2022 13:36:35 CEST Yu Zhe wrote:
> remove unnecessary void* type castings.
>
> Signed-off-by: Yu Zhe
> ---
> net/batman-adv/translation-table.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
If you send a second version then please use `git format-patch -v2
there will be no next ping packet to avoid
this problem.
Reported-by: Roman Le bg
Signed-off-by: Sven Eckelmann
---
ping.c | 4
1 file changed, 4 insertions(+)
diff --git a/ping.c b/ping.c
index 7565dcd..3681e7e 100644
--- a/ping.c
+++ b/ping.c
@@ -282,6 +282,10 @@ static int ping(struct
1 - 100 of 3882 matches
Mail list logo
