Re: [B.A.T.M.A.N.] [PATCH] batman-adv: encourage batman to take shorter routes by changing the default hop penalty

2012-02-05 Thread Marek Lindner
On Friday, January 27, 2012 23:11:55 Marek Lindner wrote: Signed-off-by: Marek Lindner lindner_ma...@yahoo.de --- soft-interface.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Thanks for all the feedback and comments. I applied the patch in revision 6a12de1. Let's see how it

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: encourage batman to take shorter routes by changing the default hop penalty

2012-01-30 Thread Andrew Lunn
On Sat, Jan 28, 2012 at 03:12:57PM +0100, Antonio Quartulli wrote: Hi all, Very nice setup Andrew :) I cannot take much credit for it. I helped write the project proposal, but then was not allowed to take part in the project because of other higher priority projects. The credit goes to

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: encourage batman to take shorter routes by changing the default hop penalty

2012-01-28 Thread Antonio Quartulli
Hi all, Very nice setup Andrew :) On Fri, Jan 27, 2012 at 08:13:34 +0100, Andrew Lunn wrote: So, you had to reduce the default value of 10 to something even smaller ? A hop penalty of 10 results in a penatly of 4% per hop. A rough equivalent of 2 lost packets (62/64). Does not sound

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: encourage batman to take shorter routes by changing the default hop penalty

2012-01-28 Thread Simon Wunderlich
On Fri, Jan 27, 2012 at 11:54:25PM +0800, Marek Lindner wrote: Hi Andrew, Do you have any performance analysis to show this is really helpful and not harmful? I've seen indoor results where i had to reduce the hop penalty, otherwise BATMAN was taking a short path which worked

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: encourage batman to take shorter routes by changing the default hop penalty

2012-01-28 Thread Marek Lindner
Hi, In my honest opinion we are mixing two different issues: 1) current hop penalty value not really significant 2) OGM link quality measurements do not reflect the metric we'd like it to be problem 2 is not going to be solved by hacking the hop penalty. It needs further

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: encourage batman to take shorter routes by changing the default hop penalty

2012-01-28 Thread Marek Lindner
On Saturday, January 28, 2012 03:13:34 Andrew Lunn wrote: When iperf was used to measure the traffic from one end of the chain to the other. With the default hop penalty we got poor performance. With the traceroute facility of batctl, we could see it was route flipping between 3 hops and 4

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: encourage batman to take shorter routes by changing the default hop penalty

2012-01-28 Thread Marek Lindner
Hi, I have experencied the same situation in some tests, and I agree with Andrew when he says that some form of justification is necessary. you also have seen that a hop penalty of 10 is too high ? Can you explain your setup a bit more ? The problems of TQ emerges when the rate of devices

[B.A.T.M.A.N.] [PATCH] batman-adv: encourage batman to take shorter routes by changing the default hop penalty

2012-01-27 Thread Marek Lindner
Signed-off-by: Marek Lindner lindner_ma...@yahoo.de --- soft-interface.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/soft-interface.c b/soft-interface.c index 2ffdc74..7548762 100644 --- a/soft-interface.c +++ b/soft-interface.c @@ -836,7 +836,7 @@ struct net_device

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: encourage batman to take shorter routes by changing the default hop penalty

2012-01-27 Thread Andrew Lunn
On Fri, Jan 27, 2012 at 11:11:55PM +0800, Marek Lindner wrote: Signed-off-by: Marek Lindner lindner_ma...@yahoo.de --- soft-interface.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/soft-interface.c b/soft-interface.c index 2ffdc74..7548762 100644 ---

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: encourage batman to take shorter routes by changing the default hop penalty

2012-01-27 Thread Marek Lindner
Hi Andrew, Do you have any performance analysis to show this is really helpful and not harmful? I've seen indoor results where i had to reduce the hop penalty, otherwise BATMAN was taking a short path which worked badly. By reducing the hop penalty, so encouraging it to take more hops, i

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: encourage batman to take shorter routes by changing the default hop penalty

2012-01-27 Thread Daniele Furlan
Hi all, 2012/1/27 Marek Lindner lindner_ma...@yahoo.de: Hi Andrew, Do you have any performance analysis to show this is really helpful and not harmful? I've seen indoor results where i had to reduce the hop penalty, otherwise BATMAN was taking a short path which worked badly. By reducing

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: encourage batman to take shorter routes by changing the default hop penalty

2012-01-27 Thread Andrew Lunn
So, you had to reduce the default value of 10 to something even smaller ? A hop penalty of 10 results in a penatly of 4% per hop. A rough equivalent of 2 lost packets (62/64). Does not sound very much to me. Can you explain your test setup a little more ? These observations come from a