Re: [B.A.T.M.A.N.] [PATCH v2 0/2] batman-adv: netlink support for DAT and MCAST

2018-03-13 Thread Antonio Quartulli
On 11/03/18 18:54, Sven Eckelmann wrote: > On Sonntag, 11. März 2018 00:53:19 CET Linus Lüssing wrote: >> This patchset adds netlink support for dumping DAT cache and multicast >> flags tables. >> >> Changes in v2: >> == >> >> - Added missing includes, "#include " and >> "#include "

Re: [B.A.T.M.A.N.] [PATCH v2 0/2] batman-adv: netlink support for DAT and MCAST

2018-03-13 Thread Sven Eckelmann
On Dienstag, 13. März 2018 16:02:34 CET Antonio Quartulli wrote: [...] > Another observation: do these attributes need to be DAT specific? or can > we just define (or reuse) a generic HWADDRESS attribute that we might > already be using somewhere else (i.e. for TT)? I've asked myself the same but

Re: [B.A.T.M.A.N.] [PATCH v2 0/2] batman-adv: netlink support for DAT and MCAST

2018-03-13 Thread Antonio Quartulli
On 13/03/18 16:20, Sven Eckelmann wrote: > On Dienstag, 13. März 2018 16:02:34 CET Antonio Quartulli wrote: > [...] >> Another observation: do these attributes need to be DAT specific? or can >> we just define (or reuse) a generic HWADDRESS attribute that we might >> already be using somewhere el

Re: [B.A.T.M.A.N.] [PATCH v2 0/2] batman-adv: netlink support for DAT and MCAST

2018-03-13 Thread Sven Eckelmann
On Dienstag, 13. März 2018 16:22:24 CET Antonio Quartulli wrote: [...] > (if we wanted to, we could still rename all the attrs pointing to the > very same data type and unify them, but I don't have a strong opinion > about it at this time). This would break backwards compatibility. Kind regards,

Re: [B.A.T.M.A.N.] [PATCH v2 0/2] batman-adv: netlink support for DAT and MCAST

2018-03-13 Thread Antonio Quartulli
On 13/03/18 16:52, Sven Eckelmann wrote: > On Dienstag, 13. März 2018 16:22:24 CET Antonio Quartulli wrote: > [...] >> (if we wanted to, we could still rename all the attrs pointing to the >> very same data type and unify them, but I don't have a strong opinion >> about it at this time). > > Thi

[B.A.T.M.A.N.] [PATCH v3 0/2] batman-adv: netlink support for DAT and MCAST

2018-03-13 Thread Linus Lüssing
This patchset adds netlink support for dumping DAT cache and multicast flags tables. Changes in v3: == - renamed netlink attributes: - BATADV_ATTR_DC_ADDRESS -> BATADV_ATTR_DAT_CACHE_IP4ADDRESS - BATADV_ATTR_DC_HWADDRESS -> BATADV_ATTR_DAT_CACHE_HWADDRESS - BATADV_ATTR_DC_VID

[B.A.T.M.A.N.] [PATCH v3 1/2] batman-adv: add DAT cache netlink support

2018-03-13 Thread Linus Lüssing
Dump the list of DAT cache entries via the netlink socket. Signed-off-by: Linus Lüssing --- compat-include/net/netlink.h | 51 +++ include/uapi/linux/batman_adv.h| 20 + net/batman-adv/distributed-arp-table.c | 152 + net/batman-adv

[B.A.T.M.A.N.] [PATCH v3 2/2] batman-adv: add multicast flags netlink support

2018-03-13 Thread Linus Lüssing
Dump the list of multicast flags entries via the netlink socket. Signed-off-by: Linus Lüssing --- include/uapi/linux/batman_adv.h | 62 +++ net/batman-adv/multicast.c | 237 net/batman-adv/multicast.h | 18 +++ net/batman-adv/netlink.c

[B.A.T.M.A.N.] [PATCH v3 2/4] batctl: add netlink dump function for DAT cache table

2018-03-13 Thread Linus Lüssing
Signed-off-by: Linus Lüssing --- debug.c | 1 + netlink.c | 205 ++ netlink.h | 2 + 3 files changed, 156 insertions(+), 52 deletions(-) diff --git a/debug.c b/debug.c index a7c5adf..5f9a87b 100644 --- a/debug.c +++ b/debug.c @@ -

[B.A.T.M.A.N.] [PATCH v3 0/4] batctl: netlink support for DAT and MCAST

2018-03-13 Thread Linus Lüssing
This patchset adds netlink support for dumping DAT cache and multicast flags tables. Changes in v3: == - renamed netlink attributes: - BATADV_ATTR_DC_ADDRESS -> BATADV_ATTR_DAT_CACHE_IP4ADDRESS - BATADV_ATTR_DC_HWADDRESS -> BATADV_ATTR_DAT_CACHE_HWADDRESS - BATADV_ATTR_DC_VID

[B.A.T.M.A.N.] [PATCH v3 1/4] batctl: add DAT cache netlink support

2018-03-13 Thread Linus Lüssing
Dump the list of DAT cache entries via the netlink socket. Signed-off-by: Linus Lüssing --- batman_adv.h | 20 1 file changed, 20 insertions(+) diff --git a/batman_adv.h b/batman_adv.h index 56ae289..95ab5db 100644 --- a/batman_adv.h +++ b/batman_adv.h @@ -272,6 +272,21 @@

[B.A.T.M.A.N.] [PATCH v3 3/4] batctl: add multicast flags netlink support

2018-03-13 Thread Linus Lüssing
Dump the list of multicast flags entries via the netlink socket. Signed-off-by: Linus Lüssing --- batman_adv.h | 62 1 file changed, 62 insertions(+) diff --git a/batman_adv.h b/batman_adv.h index 95ab5db..324a0e1 100644 --- a/batman_

[B.A.T.M.A.N.] [PATCH v3 4/4] batctl: add netlink dump function for multicast flags table

2018-03-13 Thread Linus Lüssing
Signed-off-by: Linus Lüssing --- debug.c | 1 + netlink.c | 143 ++ netlink.h | 2 + 3 files changed, 146 insertions(+) diff --git a/debug.c b/debug.c index 5f9a87b..63fb633 100644 --- a/debug.c +++ b/debug.c @@ -100,6 +100,7 @@ c