Re: [B.A.T.M.A.N.] [RFCv2] batman-adv: Add blocking of one hop OGM messages

[Simon Wunderlich]

Hey Martin,

On Fri, Feb 10, 2012 at 03:53:11PM +0100, Martin Hundebøll wrote:
  13 files changed, 491 insertions(+), 0 deletions(-)

please excuse my superficial review, but do we really need to bloat batman-adv
by 491 more lines to drop these OGMs? I'm afraid the filter will evolve
more and more, and eventually the research/debugging code in batman-adv
is bigger than the routing code. ;)

(sorry for ranting ;] )

Have you considered using and/or extending the former ebtables patch
from Linus[1]? We removed [2] it after some discussions [3], but maybe
its worth fixing these problems if its just about dropping some neighbors
packets. The patch has some problems, but it was really short and I guess
we wouldn't mind accepting the performance overhead by ebtables for
research/debugging purposes. Plus, we could make this a compile-feature too.

Cheers,
Simon

[1] 
http://ftp.uni-kl.de/pub/linux/kernel/people/gregkh/staging/2.6/2.6.35/0120-Staging-batman-adv-Adding-netfilter-bridge-hooks.patch
[2] https://lists.open-mesh.org/pipermail/b.a.t.m.a.n/2010-September/003305.html
[3] http://lkml.indiana.edu/hypermail/linux/kernel/1008.1/02232.html


signature.asc
Description: Digital signature

Re: [B.A.T.M.A.N.] [RFCv2] batman-adv: Add blocking of one hop OGM messages

[Martin Hundebøll]

On 2012-02-10 15:53, Martin Hundebøll wrote:

For testing purposes, forcing specific paths in a network where all
nodes are within reach, can be useful. This patch allows the user to
enter addresses from which direct OGMs should be ignored or not dropped.


The code/patch is also available in the git repositorie:
http://git.open-mesh.org/?p=hundeboll/batman-adv.git;h=refs/heads/filter

--
Kind Regards,
Martin Hundebøll
Nordborggade 57, 2. 1
8000 Aarhus C

+45 61 65 54 61
mar...@hundeboll.net