Re: b43 crashes on rmmod (bcm4331)

2018-06-13 Thread Wirz
On 11/06/18 23:46, Michael Büsch wrote: > On Mon, 11 Jun 2018 23:09:06 +0300 > Wirz wrote: > >> the bisection leads to >> >> 142a27f0a731ddcf467546960a5585970ca98e21 is the first bad commit >> commit 142a27f0a731ddcf467546960a5585970ca98e21 >> Author: PrasannaKumar Muralidharan >> Date: Fri Oc

Re: b43 crashes on rmmod (bcm4331)

2018-06-13 Thread Michael Büsch
On Wed, 13 Jun 2018 12:25:16 +0300 Wirz wrote: > > This commit introduces a bug, if b43 is the only RNG in the system. But > > that is unlikely on modern systems and it's fixed by > > 0e4b52942b1c76f89e0dcb829f72e123d0678f54, which is in 4.16. > > > > Other than that I currently can't see why th

Re: b43 crashes on rmmod (bcm4331)

2018-06-13 Thread Wirz
On 13/06/18 13:27, Michael Büsch wrote: > On Wed, 13 Jun 2018 12:25:16 +0300 > Wirz wrote: > >>> This commit introduces a bug, if b43 is the only RNG in the system. But >>> that is unlikely on modern systems and it's fixed by >>> 0e4b52942b1c76f89e0dcb829f72e123d0678f54, which is in 4.16. >>> >>>

Re: b43 crashes on rmmod (bcm4331)

2018-06-13 Thread Michael Büsch
On Wed, 13 Jun 2018 14:01:53 +0300 Wirz wrote: > > CONFIG_B43_HWRNG completely switches off hwrng support in b43. > > I don't see how a change in hwrng core could still lead to a crash in > > b43 with this option switched off. > > > > What do you mean by "manually in the .config"? > > What I

Re: b43 crashes on rmmod (bcm4331)

2018-06-13 Thread Michael Büsch
On Wed, 13 Jun 2018 13:09:05 +0200 Michael Büsch wrote: > On Wed, 13 Jun 2018 14:01:53 +0300 > Wirz wrote: > > > > CONFIG_B43_HWRNG completely switches off hwrng support in b43. > > > I don't see how a change in hwrng core could still lead to a crash in > > > b43 with this option switched off.

Re: b43 crashes on rmmod (bcm4331)

2018-06-13 Thread Wirz
CONFIG_B43_HWRNG completely switches off hwrng support in b43. I don't see how a change in hwrng core could still lead to a crash in b43 with this option switched off. What do you mean by "manually in the .config"? >>> >>> What I meant is, that I have outcommented the

Re: b43 crashes on rmmod (bcm4331)

2018-06-13 Thread Michael Büsch
On Wed, 13 Jun 2018 16:07:02 +0300 Wirz wrote: > CONFIG_B43_HWRNG completely switches off hwrng support in b43. > I don't see how a change in hwrng core could still lead to a crash in > b43 with this option switched off. > > What do you mean by "manually in the .config"?