Re: [Bacula-devel] quoting changes being committed

2007-09-14 Thread Kern Sibbald
On Friday 14 September 2007 19:02, Dan Langille wrote: > On 14 Sep 2007 at 18:57, Kern Sibbald wrote: > > Thanks. > > > > It is fixed in trunk SVN rev. 5556. > > Can you explain that magic commit? I don't understand how you came > up with those magic strings. cd win32 make (it fails) cd c

Re: [Bacula-devel] quoting changes being committed

2007-09-14 Thread Dan Langille
On 14 Sep 2007 at 18:57, Kern Sibbald wrote: > Thanks. > > It is fixed in trunk SVN rev. 5556. Can you explain that magic commit? I don't understand how you came up with those magic strings. -- Dan Langille - http://www.langille.org/ Available for hire: http://www.freebsddiary.org/dan_langil

Re: [Bacula-devel] quoting changes being committed

2007-09-14 Thread Kern Sibbald
Thanks. It is fixed in trunk SVN rev. 5556. Regards, Kern On Friday 14 September 2007 18:38, John Drescher wrote: > On 9/12/07, Dan Langille <[EMAIL PROTECTED]> wrote: > > The quoting changes we have been talking about are ready to be > > committed. I've run the regression tests many times ove

Re: [Bacula-devel] quoting changes being committed

2007-09-14 Thread John Drescher
On 9/12/07, Dan Langille <[EMAIL PROTECTED]> wrote: > The quoting changes we have been talking about are ready to be > committed. I've run the regression tests many times over the past > week or so. > > Sometimes a tests will fail, but when rerunning the test manually, it > passes. I'll be commit

Re: [Bacula-devel] quoting changes being committed

2007-09-12 Thread Dan Langille
On 12 Sep 2007 at 16:12, Kern Sibbald wrote: > Hello Dan, > > Do the tests fail without the patch applied? Yes. It's been random failures, perhaps one per regression test run. I do a make distclean, I run the tests again, all is OK. > If they only fail with the patch applied, I'd suggest you

Re: [Bacula-devel] quoting changes being committed

2007-09-12 Thread Kern Sibbald
Hello Dan, Do the tests fail without the patch applied? If they only fail with the patch applied, I'd suggest you wait until the tests I suggest below are done. I suggest regardless of whether or not the failures have something to do with your patch that you set up a script that does the follo

[Bacula-devel] quoting changes being committed

2007-09-12 Thread Dan Langille
The quoting changes we have been talking about are ready to be committed. I've run the regression tests many times over the past week or so. Sometimes a tests will fail, but when rerunning the test manually, it passes. I'll be committing this into trunk later today. If you start seeing ve