Re: [Bacula-devel] Is JS_Warnings job status implemented?

2016-10-01 Thread Kern Sibbald
I have planned a JobStatus == 'W' for quite some time, but I am very concerned that implementing it will break many existing environments, scripts/programs that look at the output.  Consequently, it remains suspended. Best regards, Kern O

Re: [Bacula-devel] Is JS_Warnings job status implemented?

2016-10-01 Thread Hankins, Jonathan
And I think that I confused myself. I'll check, but I think I saw that the director code for show dir does print ok with warnings, and not just ok, on jobs with warnings (by looking at JobErrors). I was confusing that output with list jobs, which shows JobStatus, and thus indicates T even on jobs

Re: [Bacula-devel] Is JS_Warnings job status implemented?

2016-10-01 Thread Hankins, Jonathan
Kern, what are your thoughts about, in an effort to phase in W job status without breaking people's stuff, a per-fileset/job/client/whatever directive such as WarnOnError, default = no, and some logic in the JobStatus code to write W to the database/wherever it needs to go, in cases where the user

Re: [Bacula-devel] Is JS_Warnings job status implemented?

2016-10-01 Thread Kern Sibbald
Jonathan, That might be a good "compromise".  The only thing that doesn't appeal to me is adding yet another directive.  I have been trying hard to avoid adding new directives since Bacula now has so many directives, I am starting to forget what does what :

Re: [Bacula-devel] Is JS_Warnings job status implemented?

2016-10-01 Thread Hankins, Jonathan
I may poke around it a bit when I have time. I'm not a C programmer, but the code is pretty clear from what I've seen. If I can get something working, I'll send a patch. Thanks! -Jonathan Hankins On Sat, Oct 1, 2016, 1:43 PM Kern Sibbald wrote: Jonathan, That might be a good "compromise". Th

Re: [Bacula-devel] Is JS_Warnings job status implemented?

2016-10-01 Thread Kern Sibbald
On 10/01/2016 08:52 PM, Hankins, Jonathan wrote: I may poke around it a bit when I have time. I'm not a C programmer, but the code is pretty clear from what I've seen. If I can get something working, I'll send a patch. If you im