Re: [Barry-devel] Android build support patch

2011-11-11 Thread Chris Frey
On Fri, Nov 11, 2011 at 02:06:24PM +, Toby Gray wrote: > I had to make a small change here to get it working correctly when > Init() is called twice. See > https://github.com/tobygray/barry/commit/d55b5049ba3e9e1a6ce871406e8519c5e7b0346d > > I don't know if you'd pick it up from my github bra

Re: [Barry-devel] Android build support patch

2011-11-11 Thread Chris Frey
On Fri, Nov 11, 2011 at 01:06:04PM +, Toby Gray wrote: > Seems fine to me. I've got one small change to make to the Makefile as > it's no longer processed by automake which I've done as: > > https://github.com/tobygray/barry/commit/c8a0e02fd876bb90c29922fcd4739e10f1671526 Merged, thanks! -

Re: [Barry-devel] Android build support patch

2011-11-11 Thread Nicolas
To do quick... Use generic header file name (as time.h, config.h...) is quiet dangerous... We have to use correctly the brackets or the quotes. #include <...> search in the includes dir (toolchains or specified from the gcc options -I) #include "..." search at first in the current directory (wh

Re: [Barry-devel] Android build support patch

2011-11-11 Thread Toby Gray
On 11/11/11 01:57, Chris Frey wrote: The libusb error code patch got me thinking, and I had to change it back, for the most part, but I also changed the API of the Init call that relied on it, so hopefully this issue is fully solved now. The TranslateErrcode() function is now just a convenience

Re: [Barry-devel] Android build support patch

2011-11-11 Thread Toby Gray
On 11/11/11 01:57, Chris Frey wrote: I'm assuming that you need EXTRA_DIST for the buildtest script? Or do you need it for your own work? My only reason for doing it as a subdir was so that doing "make distclean && make dist" in the root generated tarballs without any Android object files or

Re: [Barry-devel] Android build support patch

2011-11-10 Thread Chris Frey
On Wed, Nov 09, 2011 at 05:13:42PM +, Toby Gray wrote: > On 08/11/11 22:57, Chris Frey wrote: > > If you can somehow adjust Android's build system to make sure that all > > system directories are listed first, and that all Barry headers must > > be included via , then this shouldn't be a prob

Re: [Barry-devel] Android build support patch

2011-11-09 Thread Toby Gray
On 08/11/11 22:57, Chris Frey wrote: > If you can somehow adjust Android's build system to make sure that all > system directories are listed first, and that all Barry headers must > be included via , then this shouldn't be a problem. Is this > possible? Yes, turns out it is possible. Thanks f

Re: [Barry-devel] Android build support patch

2011-11-08 Thread Chris Frey
On Wed, Nov 02, 2011 at 03:44:00PM +, Toby Gray wrote: > The reason for this is, I suspect, due to the Android NDK tools being > able to target several different Android versions. Each version has > different functions present and so the usr/include for that particular > version is included.

Re: [Barry-devel] Android build support patch

2011-11-02 Thread Toby Gray
On 01/11/11 23:14, Chris Frey wrote: > In looking over the changes, I noticed that Android doesn't support > pthread_cancel(). A quick web search revealed some fairly logical > reasons for this: > > http://www.netmite.com/android/mydroid/1.5/bionic/libc/docs/OVERVIEW.TXT > > Since Barry only

Re: [Barry-devel] Android build support patch

2011-11-02 Thread Toby Gray
On 01/11/11 21:23, Chris Frey wrote: Can you explain to me the technical reasons for the time.h rename? I kinda have that in there on purpose, to expose brokenness... and it looks like Android is broken, if this is a problem. I'm therefore pre-disposed to not like that patch, unless it comes wi

Re: [Barry-devel] Android build support patch

2011-11-01 Thread Chris Frey
On Tue, Nov 01, 2011 at 01:10:57PM +, Toby Gray wrote: > I've managed to get Barry building and working on Android. Currently > it's just libbarry and the tools which only make use of libbarry (e.g. > not bjdwp as it uses libbarrydp and libarryjdwp). In looking over the changes, I noticed th

Re: [Barry-devel] Android build support patch

2011-11-01 Thread Chris Frey
On Tue, Nov 01, 2011 at 01:10:57PM +, Toby Gray wrote: > Hi, > > I've managed to get Barry building and working on Android. Currently > it's just libbarry and the tools which only make use of libbarry (e.g. > not bjdwp as it uses libbarrydp and libarryjdwp). Very cool! :-) > Does anyone h

[Barry-devel] Android build support patch

2011-11-01 Thread Toby Gray
Hi, I've managed to get Barry building and working on Android. Currently it's just libbarry and the tools which only make use of libbarry (e.g. not bjdwp as it uses libbarrydp and libarryjdwp). The changes are in my github repository at: git://github.com/tobygray/barry.git They start at b44a