Re: gerrit for osmocom-bb

[Harald Welte]

Hi Max,

On Wed, Apr 19, 2017 at 03:31:52PM +0200, Max wrote:
> I've just noticed that OsmocomBB is not on the list of projects at
> https://gerrit.osmocom.org/#/admin/projects/
> Is this because nobody bothered adding it there yet or it's because 
> maintainers do
> not find it suitable? If it's the latter than I'd love to see it added to 
> streamline
> contributions and patch review process.

I guess it's simply that nobody bothered to do so, as activity on
OsmocomBB has been extremely low.

I don't mind gerrit for OsmocomBB, not sure how the others think.

One issue that I fear is that I see very little activity outside of the
sysmocom team in gerrit in terms of review.  I had the feeling this was
better while posting patches still on the mailing lists.  I'm not sure
there is a causality.

-- 
- Harald Welte    http://laforge.gnumonks.org/

"Privacy in residential applications is a desirable marketing option."
  (ETSI EN 300 175-7 Ch. A6)

Re: gerrit for osmocom-bb

[Sylvain Munaut]

Hi,

> One issue that I fear is that I see very little activity outside of the
> sysmocom team in gerrit in terms of review.  I had the feeling this was
> better while posting patches still on the mailing lists.  I'm not sure
> there is a causality.

I'm not sure if it's just me or if I'm using it wrong but I'm always
annoyed when I have to login to gerrit ...

1) I shouldn't be logged out at all ... it's not a high security stuff
that session should be kept open for a long time, like > 1 week
without issues ...
2) I have to retype the openid login url. I mean there is a login with
Yahoo and login with Launchpad Id dedicated link, isn't there a way to
add, "login with your osmocom redmine account" link ?
3) Then I'm redirected to redmine, where I have to login as well,
because again for some reason I've been logged out. Same comment as
above, unless I explicitely log out, that session should last for ever
pretty much ...
4) When I then login to redmine, I get redirected to the OpenID end
point but at this point the "open id state" or whatever has been lost
and so I need to go back to gerrit and re-do the whole login process
so it can do it in one go without being interrupted by the redmine
login process and finally log me into gerrit ...

I can assure you I gave up on the whole process more than one time 

Cheers,

   Sylvain

Re: gerrit for osmocom-bb

[Harald Welte]

Hi Sylvain,

On Wed, Apr 19, 2017 at 09:01:30PM +0200, Sylvain Munaut wrote:
> I'm not sure if it's just me or if I'm using it wrong but I'm always
> annoyed when I have to login to gerrit ...

thanks for raising this issue.  It is probably as simple as to extend
the cookie expiration or something like that.  That would at least
already resolve '1)' + '4)' from your list.

I've created https://osmocom.org/issues/2015 and
https://osmocom.org/issues/2016 to track this.  We'll have to see who
can look into it, guess Holger and Neels are most familiar with the
setup.

-- 
- Harald Welte    http://laforge.gnumonks.org/

"Privacy in residential applications is a desirable marketing option."
  (ETSI EN 300 175-7 Ch. A6)