Re: [RFC][RFH] Small fixes to N-PHY init

2010-01-03 Thread Rafał Miłecki
W dniu 4 stycznia 2010 00:15 użytkownik Michael Buesch napisał: > On Sunday 03 January 2010 22:34:38 Rafał Miłecki wrote: >> > Also I need some help with: >> > //TODO: Set bit 0x40 in the Chip Control register (0x28) >> > could someone let me know how can I write to chip control register? Is >> >

Re: [RFC][RFH] Small fixes to N-PHY init

2010-01-03 Thread Michael Buesch
On Sunday 03 January 2010 22:34:38 Rafał Miłecki wrote: > > Also I need some help with: > > //TODO: Set bit 0x40 in the Chip Control register (0x28) > > could someone let me know how can I write to chip control register? Is > > following correct? > > tmp = b43_read16(dev, 0x28); > > b43_write16(dev

Re: b43: acking patches

2010-01-03 Thread Michael Buesch
On Sunday 03 January 2010 22:30:27 Rafał Miłecki wrote: > Michael, you gave me some reviews of patches I was very glad to see. I > posted some (hopefully) corrected versions but didn't get your > response. > > Can we expect you ACKing patches as well? > > I post this question publicly as I may be

Re: [RFC][RFH] Small fixes to N-PHY init

2010-01-03 Thread Rafał Miłecki
W dniu 2 stycznia 2010 23:41 użytkownik Rafał Miłecki napisał: > It's my first patch that tries to do something. Could you review this, > please? Did I write it correctly? Did I use correct registers names (like > B43_NPHY_TXF_*)? > > Also I need some help with: > //TODO: Set bit 0x40 in the Chip

b43: acking patches

2010-01-03 Thread Rafał Miłecki
Michael, you gave me some reviews of patches I was very glad to see. I posted some (hopefully) corrected versions but didn't get your response. Can we expect you ACKing patches as well? I post this question publicly as I may be not the only one person who would like to know this. -- Rafał _