Re: b43/b43legacy driver
Thanks Rafal! I updated the kernel to 2.6.32 and it doesn't work yet. monte...@latosca:~$ uname -a Linux latosca 2.6.32-020632-generic #020632 SMP Thu Dec 3 10:58:45 UTC 2009 i686 GNU/Linux After updating the kernel I have deleted the directory /lib/firmware/b43 and I have executed again the below procedure. After that I restarted my laptop and it doesn't work... :-( Can you help me, please? You are using the b43 driver with an LP-PHY card (e.g. BCM4312) Follow these instructions if you are using the *b43* driver from * linux-2.6.32* and newer or *compat-wireless-2.6*, or from any current GIT tree, and have a device with a low-power PHY. Use the current Git version of b43-fwcutter. Download, extract the b43-fwcutter tarball and build it: git clone http://git.bu3sch.de/git/b43-tools.git cd b43-tools/fwcutter make cd .. Use version 4.174.64.19 of Broadcom's proprietary driver. (The tarball is mislabeled as 4.178.10.4, but it is actually 4.174.64.19.) Download and extract the firmware from this driver tarball: export FIRMWARE_INSTALL_DIR=/lib/firmware wget http://downloads.openwrt.org/sources/broadcom-wl-4.178.10.4.tar.bz2 tar xjf broadcom-wl-4.178.10.4.tar.bz2 cd broadcom-wl-4.178.10.4/linux sudo ../../fwcutter/b43-fwcutter -w $FIRMWARE_INSTALL_DIR wl_apsta.o Note that you must adjust the FIRMWARE_INSTALL_DIR path to your distribution. The standard place where firmware is installed to is /lib/firmware. However some distributions put firmware in a different place. 2010/2/5 Rafał Miłecki zaj...@gmail.com Argh, please, use text/plain for ML! 2010/2/5 David Montero monte...@gmail.com monte...@latosca:~$ uname -r 2.6.31-14-generic I thing it's working with 64 bits You can check that with uname -a. Should not make difference however. I thing that my card is the following: (...) 14e4:4315 supported 2.6.32 and later BCM4312 b/g LP b43 Then, I applied the following procedure without problems and when I restarted my laptop the wifi network didn't work yet. Can you help me? You installed (hopefully) firmware but missed supported 2.6.32 and later. Update your kernel. -- Rafał -- Skype user: montero.david E-mail: monte...@gmail.com http://www.globalcool.org/ http://www.compartir.org/ ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: b43/b43legacy driver
Op 05-02-10 12:06, David Montero schreef: Thanks Rafal! I updated the kernel to 2.6.32 and it doesn't work yet. monte...@latosca:~$ uname -a Linux latosca 2.6.32-020632-generic #020632 SMP Thu Dec 3 10:58:45 UTC 2009 i686 GNU/Linux After updating the kernel I have deleted the directory /lib/firmware/b43 and I have executed again the below procedure. After that I restarted my laptop and it doesn't work... :-( Can you help me, please? Hi, It should be ok (although I would recommend a 2.6.33 if you have the opportunity to find one already available). To help you further, I recommend you provide the output of these 3 commands: # dmesg | grep b43 # lsmod # iwconfig Cheers, Eric ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: b43/b43legacy driver
W dniu 5 lutego 2010 12:06 użytkownik David Montero monte...@gmail.com napisał: Thanks Rafal! I updated the kernel to 2.6.32 and it doesn't work yet. Please, *stop* using html for your mails. Use Éric's commands. -- Rafał ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: b43/b43legacy driver
Hi Rafal, I am sorry, what do you mean with *stop* using html for your mails? I am using my gmail account from internet, could you recommend me another way to use it? Thanks in advance david 2010/2/5 Rafał Miłecki zaj...@gmail.com W dniu 5 lutego 2010 12:06 użytkownik David Montero monte...@gmail.com napisał: Thanks Rafal! I updated the kernel to 2.6.32 and it doesn't work yet. Please, *stop* using html for your mails. Use Éric's commands. -- Rafał -- Skype user: montero.david E-mail: monte...@gmail.com http://www.globalcool.org/ http://www.compartir.org/ ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: b43/b43legacy driver
Hi: I will try to install that kernel version. Here you can find the outputs. Thanks monte...@latosca:/etc$ dmesg | grep b43 [2.079698] b43-pci-bridge :04:00.0: PCI INT A - GSI 18 (level, low) - IRQ 18 [2.079720] b43-pci-bridge :04:00.0: setting latency timer to 6 monte...@latosca:/etc$ lsmod Module Size Used by nls_iso8859_1 3177 2 nls_cp437 4847 2 vfat8713 2 fat46452 1 vfat binfmt_misc 6311 1 ppdev 5101 0 snd_hda_codec_conexant22468 1 snd_hda_codec_intelhdmi12779 1 snd_hda_intel 22647 2 snd_hda_codec 71914 3 snd_hda_codec_conexant,snd_hda_codec_intelhdmi,snd_hda_intel snd_hwdep 5257 1 snd_hda_codec snd_pcm_oss37172 0 snd_mixer_oss 15029 1 snd_pcm_oss snd_pcm71804 3 snd_hda_intel,snd_hda_codec,snd_pcm_oss bridge 44005 0 snd_seq_dummy 1456 0 snd_seq_oss26458 0 snd_seq_midi4435 0 snd_rawmidi18299 1 snd_seq_midi stp 1583 1 bridge snd_seq_midi_event 5707 2 snd_seq_oss,snd_seq_midi iptable_filter 2199 0 bnep9500 2 snd_seq45535 6 snd_seq_dummy,snd_seq_oss,snd_seq_midi,snd_seq_midi_event snd_timer 19260 2 snd_pcm,snd_seq joydev 8915 0 lp 6900 0 snd_seq_device 5596 5 snd_seq_dummy,snd_seq_oss,snd_seq_midi,snd_rawmidi,snd_seq uvcvideo 57156 0 ip_tables 10370 1 iptable_filter videodev 36381 1 uvcvideo snd53253 17 snd_hda_codec_conexant,snd_hda_codec_intelhdmi,snd_hda_intel,snd_hda_codec,snd_hwdep,snd_pcm_oss,snd_mixer_oss,snd_pcm,snd_seq_oss,snd_rawmidi,snd_seq,snd_timer,snd_seq_device sdhci_pci 5536 0 x_tables 13791 1 ip_tables parport32240 2 ppdev,lp psmouse54168 0 v4l1_compat13316 2 uvcvideo,videodev soundcore 6410 1 snd jmb38x_ms 7431 0 sdhci 16371 1 sdhci_pci snd_page_alloc 7108 2 snd_hda_intel,snd_pcm led_class 2830 1 sdhci serio_raw 3978 0 memstick7818 1 jmb38x_ms btusb 10716 2 usbhid 35312 0 fbcon 36595 72 tileblit1927 1 fbcon font7517 1 fbcon bitblit 4509 1 fbcon softcursor 1117 1 bitblit i915 282796 3 drm_kms_helper 26652 1 i915 drm 153012 4 i915,drm_kms_helper intel_agp 23625 1 i2c_algo_bit4858 1 i915 agpgart31758 2 drm,intel_agp ssb34172 0 tg3 112825 0 video 17586 1 i915 output 1799 1 video monte...@latosca:/etc$ iwconfig lono wireless extensions. eth0 no wireless extensions. pan0 no wireless extensions. On 5 February 2010 13:47, Éric Piel e.a.b.p...@tudelft.nl wrote: Op 05-02-10 12:06, David Montero schreef: Thanks Rafal! I updated the kernel to 2.6.32 and it doesn't work yet. monte...@latosca:~$ uname -a Linux latosca 2.6.32-020632-generic #020632 SMP Thu Dec 3 10:58:45 UTC 2009 i686 GNU/Linux After updating the kernel I have deleted the directory /lib/firmware/b43 and I have executed again the below procedure. After that I restarted my laptop and it doesn't work... :-( Can you help me, please? Hi, It should be ok (although I would recommend a 2.6.33 if you have the opportunity to find one already available). To help you further, I recommend you provide the output of these 3 commands: # dmesg | grep b43 # lsmod # iwconfig Cheers, Eric -- Skype user: montero.david E-mail: monte...@gmail.com http://www.globalcool.org/ http://www.compartir.org/ ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: b43/b43legacy driver
Op 05-02-10 14:18, David Montero schreef: Hi: I will try to install that kernel version. Here you can find the outputs. Thanks monte...@latosca:/etc$ dmesg | grep b43 [2.079698] b43-pci-bridge :04:00.0: PCI INT A - GSI 18 (level, low) - IRQ 18 [2.079720] b43-pci-bridge :04:00.0: setting latency timer to 6 Not sure why, but the b43 driver is not even tried to be loaded. (maybe due to some black-listing in modprobe?) David, please do a modprobe b43 and rerun the 3 commands. Eric ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: b43/b43legacy driver
Hi all, Attached are the outputs. Now I am going to setup my gmail account in Thunderbird. I am sorry for the inconvenients! r...@latosca:~# dmesg | grep b43 [2.074486] b43-pci-bridge :04:00.0: PCI INT A - GSI 18 (level, low) - IRQ 18 [2.074504] b43-pci-bridge :04:00.0: setting latency timer to 64 [ 118.548653] b43-phy0: Broadcom 4312 WLAN found (core revision 15) [ 118.659228] Registered led device: b43-phy0::tx [ 118.659267] Registered led device: b43-phy0::rx [ 118.659304] Registered led device: b43-phy0::radio [ 118.800147] b43 ssb0:0: firmware: requesting b43/ucode15.fw [ 118.858012] b43 ssb0:0: firmware: requesting b43/lp0initvals15.fw [ 118.866463] b43 ssb0:0: firmware: requesting b43/lp0bsinitvals15.fw [ 119.028134] b43-phy0: Loading firmware version 478.104 (2008-07-01 00:50:23) r...@latosca:~# lsmod Module Size Used by arc41113 2 b43 160155 0 mac80211 169408 1 b43 cfg80211 124530 2 b43,mac80211 binfmt_misc 6311 1 ppdev 5101 0 snd_hda_codec_conexant22468 1 snd_hda_codec_intelhdmi12779 1 snd_hda_intel 22647 2 snd_hda_codec 71914 3 snd_hda_codec_conexant,snd_hda_codec_intelhdmi,snd_hda_intel snd_hwdep 5257 1 snd_hda_codec bridge 44005 0 snd_pcm_oss37172 0 snd_mixer_oss 15029 1 snd_pcm_oss snd_pcm71804 3 snd_hda_intel,snd_hda_codec,snd_pcm_oss stp 1583 1 bridge snd_seq_dummy 1456 0 bnep9500 2 snd_seq_oss26458 0 snd_seq_midi4435 0 snd_rawmidi18299 1 snd_seq_midi snd_seq_midi_event 5707 2 snd_seq_oss,snd_seq_midi snd_seq45535 6 snd_seq_dummy,snd_seq_oss,snd_seq_midi,snd_seq_midi_event snd_timer 19260 2 snd_pcm,snd_seq snd_seq_device 5596 5 snd_seq_dummy,snd_seq_oss,snd_seq_midi,snd_rawmidi,snd_seq snd53253 17 snd_hda_codec_conexant,snd_hda_codec_intelhdmi,snd_hda_intel,snd_hda_codec,snd_hwdep,snd_pcm_oss,snd_mixer_oss,snd_pcm,snd_seq_oss,snd_rawmidi,snd_seq,snd_timer,snd_seq_device lp 6900 0 soundcore 6410 1 snd joydev 8915 0 sdhci_pci 5536 0 snd_page_alloc 7108 2 snd_hda_intel,snd_pcm sdhci 16371 1 sdhci_pci iptable_filter 2199 0 parport32240 2 ppdev,lp led_class 2830 2 b43,sdhci btusb 10716 2 psmouse54168 0 serio_raw 3978 0 uvcvideo 57156 0 videodev 36381 1 uvcvideo v4l1_compat13316 2 uvcvideo,videodev ip_tables 10370 1 iptable_filter x_tables 13791 1 ip_tables jmb38x_ms 7431 0 memstick7818 1 jmb38x_ms usbhid 35312 0 fbcon 36595 72 tileblit1927 1 fbcon font7517 1 fbcon bitblit 4509 1 fbcon softcursor 1117 1 bitblit i915 282796 3 drm_kms_helper 26652 1 i915 drm 153012 4 i915,drm_kms_helper intel_agp 23625 1 i2c_algo_bit4858 1 i915 tg3 112825 0 agpgart31758 2 drm,intel_agp ssb34172 1 b43 video 17586 1 i915 output 1799 1 video r...@latosca:~# iwconfig lono wireless extensions. eth0 no wireless extensions. pan0 no wireless extensions. wlan0 IEEE 802.11bg Mode:Managed Access Point: Not-Associated Tx-Power=20 dBm Retry long limit:7 RTS thr:off Fragment thr:off Encryption key:off Power Management:off On 5 February 2010 14:34, Éric Piel e.a.b.p...@tudelft.nl wrote: Op 05-02-10 14:18, David Montero schreef: Hi: I will try to install that kernel version. Here you can find the outputs. Thanks monte...@latosca:/etc$ dmesg | grep b43 [2.079698] b43-pci-bridge :04:00.0: PCI INT A - GSI 18 (level, low) - IRQ 18 [2.079720] b43-pci-bridge :04:00.0: setting latency timer to 6 Not sure why, but the b43 driver is not even tried to be loaded. (maybe due to some black-listing in modprobe?) David, please do a modprobe b43 and rerun the 3 commands. Eric -- Skype user: montero.david E-mail: monte...@gmail.com http://www.globalcool.org/ http://www.compartir.org/ ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: b43/b43legacy driver
Op 05-02-10 14:47, David Montero schreef: Hi all, Attached are the outputs. Now I am going to setup my gmail account in Thunderbird. I am sorry for the inconvenients! : r...@latosca:~# iwconfig lono wireless extensions. eth0 no wireless extensions. pan0 no wireless extensions. wlan0 IEEE 802.11bg Mode:Managed Access Point: Not-Associated Tx-Power=20 dBm Retry long limit:7 RTS thr:off Fragment thr:off Encryption key:off Power Management:off Ah, it looks much better! You should now be able to use the wifi (via NetworkManager for instance) :-) To get the driver automatically loaded, I would recommend you ask on a community who knows more about ubuntu, I highly suspect some kind of blacklisting in modprobe (because this hardware required the wl driver in older kernels). Please let us know if you succeed in connecting to your wifi network. See you, Eric ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: b43/b43legacy driver
David Montero wrote: Hi Rafal, I am sorry, what do you mean with *stop* using html for your mails? I am using my gmail account from internet, could you recommend me another way to use it? Yes, stop using gmail. Use a real mailer (thunderbird, mutt, etc.) and set it to use plain-text. Bottom-post (add text on the bottom of the previous text). It makes what you say fully readable for everyone who sees it. Very few people on the developer lists use HTML-readers. Regards, Ehud smime.p7s Description: S/MIME Cryptographic Signature ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: b43/b43legacy driver
Thanks a lot! Now It's working properly. GREAT! Yes, you were right, it was in the blacklist. See below: monte...@latosca:~$ more /etc/modprobe.d/blacklist-local.conf #blacklist b43 #blacklist wl I have commented these lines and it works. Thanks a lot, BR david On 5 February 2010 15:02, Éric Piel e.a.b.p...@tudelft.nl wrote: Op 05-02-10 14:47, David Montero schreef: Hi all, Attached are the outputs. Now I am going to setup my gmail account in Thunderbird. I am sorry for the inconvenients! : r...@latosca:~# iwconfig lono wireless extensions. eth0 no wireless extensions. pan0 no wireless extensions. wlan0 IEEE 802.11bg Mode:Managed Access Point: Not-Associated Tx-Power=20 dBm Retry long limit:7 RTS thr:off Fragment thr:off Encryption key:off Power Management:off Ah, it looks much better! You should now be able to use the wifi (via NetworkManager for instance) :-) To get the driver automatically loaded, I would recommend you ask on a community who knows more about ubuntu, I highly suspect some kind of blacklisting in modprobe (because this hardware required the wl driver in older kernels). Please let us know if you succeed in connecting to your wifi network. See you, Eric -- Skype user: montero.david E-mail: monte...@gmail.com http://www.globalcool.org/ http://www.compartir.org/ ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: b43/b43legacy driver
On Fri, Feb 5, 2010 at 3:23 PM, David Montero monte...@gmail.com wrote: Thanks a lot! Now It's working properly. GREAT! Yes, you were right, it was in the blacklist. See below: monte...@latosca:~$ more /etc/modprobe.d/blacklist-local.conf #blacklist b43 #blacklist wl I have commented these lines and it works. Thanks a lot, BR david On 5 February 2010 15:02, Éric Piel e.a.b.p...@tudelft.nl wrote: Op 05-02-10 14:47, David Montero schreef: Hi all, Attached are the outputs. Now I am going to setup my gmail account in Thunderbird. I am sorry for the inconvenients! : r...@latosca:~# iwconfig lono wireless extensions. eth0 no wireless extensions. pan0 no wireless extensions. wlan0 IEEE 802.11bg Mode:Managed Access Point: Not-Associated Tx-Power=20 dBm Retry long limit:7 RTS thr:off Fragment thr:off Encryption key:off Power Management:off Ah, it looks much better! You should now be able to use the wifi (via NetworkManager for instance) :-) To get the driver automatically loaded, I would recommend you ask on a community who knows more about ubuntu, I highly suspect some kind of blacklisting in modprobe (because this hardware required the wl driver in older kernels). Please let us know if you succeed in connecting to your wifi network. See you, Eric -- Skype user: montero.david E-mail: monte...@gmail.com http://www.globalcool.org/ http://www.compartir.org/ ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev 2010/2/5 Ehud Gavron gav...@wetwork.net - Show quoted text - David Montero wrote: Hi Rafal, I am sorry, what do you mean with *stop* using html for your mails? I am using my gmail account from internet, could you recommend me another way to use it? Yes, stop using gmail. Use a real mailer (thunderbird, mutt, etc.) and set it to use plain-text. Bottom-post (add text on the bottom of the previous text). It makes what you say fully readable for everyone who sees it. Very few people on the developer lists use HTML-readers. Regards, Ehud ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev There is an option in gmail to tell it to send the mails as plain-text too. That is what I use, it should be in the first tab that is opened when you go to settings. Regards, Daniel ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: b43/b43legacy driver
On Friday 05 February 2010, Rafał Miłecki wrote: W dniu 5 lutego 2010 12:06 użytkownik David Montero monte...@gmail.com napisał: Thanks Rafal! I updated the kernel to 2.6.32 and it doesn't work yet. Please, *stop* using html for your mails. Use Éric's commands. While I took the time to look, there is a plain text component which kmail is showing me, in Davids msgs, and to see the html, I have to specifically click on that line in the automatic mime report kmail gives me. Perhaps its one of your own prefs that mixed up? -- Cheers, Gene There are four boxes to be used in defense of liberty: soap, ballot, jury, and ammo. Please use in that order. -Ed Howdershelt (Author) Things are more like they used to be than they are now. ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: b43/b43legacy driver
On Friday 05 February 2010, David Montero wrote: Hi Rafal, I am sorry, what do you mean with *stop* using html for your mails? I am using my gmail account from internet, could you recommend me another way to use it? Thanks in advance david You are actually sending both plain text and an html version of it, and unless I click on the html line in the mime report window kmail opens when the msgs has different mimetype sections, I do not see the html. If I can copy/paste from that little window your msg has the following parts: And no, it won't let me copy it. But there are 2 copies of the plain text, and one copy of the html'd version. 2010/2/5 Rafał Miłecki zaj...@gmail.com W dniu 5 lutego 2010 12:06 użytkownik David Montero monte...@gmail.com napisał: Thanks Rafal! I updated the kernel to 2.6.32 and it doesn't work yet. Please, *stop* using html for your mails. Use Éric's commands. -- Rafał -- Cheers, Gene There are four boxes to be used in defense of liberty: soap, ballot, jury, and ammo. Please use in that order. -Ed Howdershelt (Author) Things are more like they used to be than they are now. ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: b43/b43legacy driver
On 02/05/2010 08:48 AM, Gene Heskett wrote: While I took the time to look, there is a plain text component which kmail is showing me, in Davids msgs, and to see the html, I have to specifically click on that line in the automatic mime report kmail gives me. Perhaps its one of your own prefs that mixed up? That does not matter. The HTML version should not be on the lists! Period!! Larry ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: [RFC][PATCH] b43: LP-PHY: always adjust gain table on channel switch
On Fri, Feb 5, 2010 at 4:24 AM, Larry Finger larry.fin...@lwfinger.net wrote: On 02/04/2010 02:57 PM, Rafał Miłecki wrote: --- Gábor: I think you missed specs here. Could you check whole routine just for sure, please? I don't understand whole radio and chanspec magic yet. --- drivers/net/wireless/b43/phy_lp.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/wireless/b43/phy_lp.c b/drivers/net/wireless/b43/phy_lp.c index 185219e..61009ee 100644 --- a/drivers/net/wireless/b43/phy_lp.c +++ b/drivers/net/wireless/b43/phy_lp.c @@ -2655,8 +2655,8 @@ static int b43_lpphy_op_switch_channel(struct b43_wldev *dev, if (err) return err; lpphy_set_analog_filter(dev, new_channel); - lpphy_adjust_gain_table(dev, channel2freq_lp(new_channel)); } + lpphy_adjust_gain_table(dev, channel2freq_lp(new_channel)); lpphy-channel = new_channel; b43_write16(dev, B43_MMIO_CHANNEL, new_channel); Both the lpphy_set_analog_filter() and lpphy_adjust_gain_table() calls should be outside the if statement. I changed the spec a little. It used to test radio enabled, but I have found that is always true for our driver. Larry Isn't set_analog_filter() rev0/1-specific? -- Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-) ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: [RFC][PATCH] b43: LP-PHY: always adjust gain table on channel switch
On Fri, Feb 5, 2010 at 4:24 AM, Larry Finger larry.fin...@lwfinger.net wrote: On 02/04/2010 02:57 PM, Rafał Miłecki wrote: --- Gábor: I think you missed specs here. Could you check whole routine just for sure, please? I don't understand whole radio and chanspec magic yet. --- drivers/net/wireless/b43/phy_lp.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/wireless/b43/phy_lp.c b/drivers/net/wireless/b43/phy_lp.c index 185219e..61009ee 100644 --- a/drivers/net/wireless/b43/phy_lp.c +++ b/drivers/net/wireless/b43/phy_lp.c @@ -2655,8 +2655,8 @@ static int b43_lpphy_op_switch_channel(struct b43_wldev *dev, if (err) return err; lpphy_set_analog_filter(dev, new_channel); - lpphy_adjust_gain_table(dev, channel2freq_lp(new_channel)); } + lpphy_adjust_gain_table(dev, channel2freq_lp(new_channel)); lpphy-channel = new_channel; b43_write16(dev, B43_MMIO_CHANNEL, new_channel); Both the lpphy_set_analog_filter() and lpphy_adjust_gain_table() calls should be outside the if statement. I changed the spec a little. It used to test radio enabled, but I have found that is always true for our driver. Larry Isn't set_analog_filter() rev0/1-specific? -- Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-) ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: [PATCH] b43: N-PHY: handle allocation fail in samples generation
2010/2/4 Rafał Miłecki zaj...@gmail.com: Signed-off-by: Rafał Miłecki zaj...@gmail.com --- drivers/net/wireless/b43/phy_n.c | 4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/net/wireless/b43/phy_n.c b/drivers/net/wireless/b43/phy_n.c index 074b34c..795bb1e 100644 --- a/drivers/net/wireless/b43/phy_n.c +++ b/drivers/net/wireless/b43/phy_n.c @@ -1069,6 +1069,10 @@ static u16 b43_nphy_gen_load_samples(struct b43_wldev *dev, u32 freq, u16 max, } samples = kzalloc(len * sizeof(struct b43_c32), GFP_KERNEL); + if (!samples) { + b43err(dev-wl, allocation for samples generation failed\n); + return 0; return -ENOMEM; + } rot = (((freq * 36) / bw) 16) / 100; angle = 0; -- 1.6.4.2 -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-) ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: [RFC][PATCH] b43: LP-PHY: always adjust gain table on channel switch
On 02/05/2010 10:41 AM, Gábor Stefanik wrote: On Fri, Feb 5, 2010 at 4:24 AM, Larry Finger larry.fin...@lwfinger.net wrote: On 02/04/2010 02:57 PM, Rafał Miłecki wrote: --- Gábor: I think you missed specs here. Could you check whole routine just for sure, please? I don't understand whole radio and chanspec magic yet. --- drivers/net/wireless/b43/phy_lp.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/wireless/b43/phy_lp.c b/drivers/net/wireless/b43/phy_lp.c index 185219e..61009ee 100644 --- a/drivers/net/wireless/b43/phy_lp.c +++ b/drivers/net/wireless/b43/phy_lp.c @@ -2655,8 +2655,8 @@ static int b43_lpphy_op_switch_channel(struct b43_wldev *dev, if (err) return err; lpphy_set_analog_filter(dev, new_channel); - lpphy_adjust_gain_table(dev, channel2freq_lp(new_channel)); } + lpphy_adjust_gain_table(dev, channel2freq_lp(new_channel)); lpphy-channel = new_channel; b43_write16(dev, B43_MMIO_CHANNEL, new_channel); Both the lpphy_set_analog_filter() and lpphy_adjust_gain_table() calls should be outside the if statement. I changed the spec a little. It used to test radio enabled, but I have found that is always true for our driver. Larry Isn't set_analog_filter() rev0/1-specific? It was in the 4.174.64.19 driver that I RE'd when you wrote the LP PHY code. That as changed in 5.10.56.46, which I am now doing. It will take me a while to complete the new routine LP PHY TX Filter Init and a routine that it calls. Certainly, there is no hurry that these changes be made. Whenever you or Rafał have time. There is no guarantee that these changes will have any effect on the LP PHY operations. Hitting a moving target is not easy. Larry ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: [RFC][PATCH] b43: LP-PHY: always adjust gain table on channel switch
On Fri, Feb 5, 2010 at 7:09 PM, Larry Finger larry.fin...@lwfinger.net wrote: On 02/05/2010 10:41 AM, Gábor Stefanik wrote: On Fri, Feb 5, 2010 at 4:24 AM, Larry Finger larry.fin...@lwfinger.net wrote: On 02/04/2010 02:57 PM, Rafał Miłecki wrote: --- Gábor: I think you missed specs here. Could you check whole routine just for sure, please? I don't understand whole radio and chanspec magic yet. --- drivers/net/wireless/b43/phy_lp.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/wireless/b43/phy_lp.c b/drivers/net/wireless/b43/phy_lp.c index 185219e..61009ee 100644 --- a/drivers/net/wireless/b43/phy_lp.c +++ b/drivers/net/wireless/b43/phy_lp.c @@ -2655,8 +2655,8 @@ static int b43_lpphy_op_switch_channel(struct b43_wldev *dev, if (err) return err; lpphy_set_analog_filter(dev, new_channel); - lpphy_adjust_gain_table(dev, channel2freq_lp(new_channel)); } + lpphy_adjust_gain_table(dev, channel2freq_lp(new_channel)); lpphy-channel = new_channel; b43_write16(dev, B43_MMIO_CHANNEL, new_channel); Both the lpphy_set_analog_filter() and lpphy_adjust_gain_table() calls should be outside the if statement. I changed the spec a little. It used to test radio enabled, but I have found that is always true for our driver. Larry Isn't set_analog_filter() rev0/1-specific? It was in the 4.174.64.19 driver that I RE'd when you wrote the LP PHY code. That as changed in 5.10.56.46, which I am now doing. It will take me a while to complete the new routine LP PHY TX Filter Init and a routine that it calls. Certainly, there is no hurry that these changes be made. Whenever you or Rafał have time. There is no guarantee that these changes will have any effect on the LP PHY operations. Hitting a moving target is not easy. Larry Just out of curiosity, is 5.10.56.46 available anywhere (for firmware reasons)? -- Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-) ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: [RFC][PATCH] b43: LP-PHY: always adjust gain table on channel switch
On 02/05/2010 12:46 PM, Gábor Stefanik wrote: On Fri, Feb 5, 2010 at 7:09 PM, Larry Finger larry.fin...@lwfinger.net wrote: On 02/05/2010 10:41 AM, Gábor Stefanik wrote: On Fri, Feb 5, 2010 at 4:24 AM, Larry Finger larry.fin...@lwfinger.net wrote: On 02/04/2010 02:57 PM, Rafał Miłecki wrote: --- Gábor: I think you missed specs here. Could you check whole routine just for sure, please? I don't understand whole radio and chanspec magic yet. --- drivers/net/wireless/b43/phy_lp.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/wireless/b43/phy_lp.c b/drivers/net/wireless/b43/phy_lp.c index 185219e..61009ee 100644 --- a/drivers/net/wireless/b43/phy_lp.c +++ b/drivers/net/wireless/b43/phy_lp.c @@ -2655,8 +2655,8 @@ static int b43_lpphy_op_switch_channel(struct b43_wldev *dev, if (err) return err; lpphy_set_analog_filter(dev, new_channel); - lpphy_adjust_gain_table(dev, channel2freq_lp(new_channel)); } + lpphy_adjust_gain_table(dev, channel2freq_lp(new_channel)); lpphy-channel = new_channel; b43_write16(dev, B43_MMIO_CHANNEL, new_channel); Both the lpphy_set_analog_filter() and lpphy_adjust_gain_table() calls should be outside the if statement. I changed the spec a little. It used to test radio enabled, but I have found that is always true for our driver. Larry Isn't set_analog_filter() rev0/1-specific? It was in the 4.174.64.19 driver that I RE'd when you wrote the LP PHY code. That as changed in 5.10.56.46, which I am now doing. It will take me a while to complete the new routine LP PHY TX Filter Init and a routine that it calls. Certainly, there is no hurry that these changes be made. Whenever you or Rafał have time. There is no guarantee that these changes will have any effect on the LP PHY operations. Hitting a moving target is not easy. Larry Just out of curiosity, is 5.10.56.46 available anywhere (for firmware reasons)? I'm not sure what the driver version is, but a file with 508 ucode dated 6/26/09 is found at: http://www.linksysbycisco.com/gpl/wrt610n_v2.00.00.05_us.tar.gz The binaries are in directory wrt610n_v2.00.00.05_us/release/src/wl/linux/. I used Daniel Lenski's script names b43_fwcutter.py can extract the firmware from wl_apsta.o. Included are ucode_2w20 - Rev 20 802.11 cores have an SSLPN PHY. I'm still looking for a file with 5XX firmware that is not a huge download. This file contains everything needed to build the firmware for a WRT610N AP and is 356 MB. If anyone knows of a smaller file, please let me know. Larry ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: [PATCH] b43: N-PHY: handle allocation fail in samples generation
W dniu 5 lutego 2010 18:34 użytkownik Gábor Stefanik netrolller...@gmail.com napisał: 2010/2/4 Rafał Miłecki zaj...@gmail.com: Signed-off-by: Rafał Miłecki zaj...@gmail.com --- drivers/net/wireless/b43/phy_n.c | 4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/net/wireless/b43/phy_n.c b/drivers/net/wireless/b43/phy_n.c index 074b34c..795bb1e 100644 --- a/drivers/net/wireless/b43/phy_n.c +++ b/drivers/net/wireless/b43/phy_n.c @@ -1069,6 +1069,10 @@ static u16 b43_nphy_gen_load_samples(struct b43_wldev *dev, u32 freq, u16 max, } samples = kzalloc(len * sizeof(struct b43_c32), GFP_KERNEL); + if (!samples) { + b43err(dev-wl, allocation for samples generation failed\n); + return 0; return -ENOMEM; Function was somehow designed to return unsigned only. Returning 0 means error (see place where we call b43_nphy_gen_load_samples, we check result for 0 there. Is that OK then? + } rot = (((freq * 36) / bw) 16) / 100; angle = 0; -- 1.6.4.2 -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-) -- Rafał ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: [PATCH] b43: N-PHY: handle allocation fail in samples generation
2010/2/5 Rafał Miłecki zaj...@gmail.com: W dniu 5 lutego 2010 18:34 użytkownik Gábor Stefanik netrolller...@gmail.com napisał: 2010/2/4 Rafał Miłecki zaj...@gmail.com: Signed-off-by: Rafał Miłecki zaj...@gmail.com --- drivers/net/wireless/b43/phy_n.c | 4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/net/wireless/b43/phy_n.c b/drivers/net/wireless/b43/phy_n.c index 074b34c..795bb1e 100644 --- a/drivers/net/wireless/b43/phy_n.c +++ b/drivers/net/wireless/b43/phy_n.c @@ -1069,6 +1069,10 @@ static u16 b43_nphy_gen_load_samples(struct b43_wldev *dev, u32 freq, u16 max, } samples = kzalloc(len * sizeof(struct b43_c32), GFP_KERNEL); + if (!samples) { + b43err(dev-wl, allocation for samples generation failed\n); + return 0; return -ENOMEM; Function was somehow designed to return unsigned only. Returning 0 means error (see place where we call b43_nphy_gen_load_samples, we check result for 0 there. Is that OK then? In that case, OK - I thought this could be passed up to userspace handlers. + } rot = (((freq * 36) / bw) 16) / 100; angle = 0; -- 1.6.4.2 -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-) -- Rafał -- Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-) ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: [PATCH] b43: N-PHY: handle allocation fail in samples generation
W dniu 5 lutego 2010 22:38 użytkownik Gábor Stefanik netrolller...@gmail.com napisał: 2010/2/5 Rafał Miłecki zaj...@gmail.com: W dniu 5 lutego 2010 18:34 użytkownik Gábor Stefanik netrolller...@gmail.com napisał: 2010/2/4 Rafał Miłecki zaj...@gmail.com: Signed-off-by: Rafał Miłecki zaj...@gmail.com --- drivers/net/wireless/b43/phy_n.c | 4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/net/wireless/b43/phy_n.c b/drivers/net/wireless/b43/phy_n.c index 074b34c..795bb1e 100644 --- a/drivers/net/wireless/b43/phy_n.c +++ b/drivers/net/wireless/b43/phy_n.c @@ -1069,6 +1069,10 @@ static u16 b43_nphy_gen_load_samples(struct b43_wldev *dev, u32 freq, u16 max, } samples = kzalloc(len * sizeof(struct b43_c32), GFP_KERNEL); + if (!samples) { + b43err(dev-wl, allocation for samples generation failed\n); + return 0; return -ENOMEM; Function was somehow designed to return unsigned only. Returning 0 means error (see place where we call b43_nphy_gen_load_samples, we check result for 0 there. Is that OK then? In that case, OK - I thought this could be passed up to userspace handlers. Thanks for review :) -- Rafał ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: [RFC][PATCH] b43: LP-PHY: always adjust gain table on channel switch
On 02/05/2010 10:27 AM, Gábor Stefanik wrote: On Fri, Feb 5, 2010 at 4:24 AM, Larry Finger larry.fin...@lwfinger.net wrote: On 02/04/2010 02:57 PM, Rafał Miłecki wrote: --- Gábor: I think you missed specs here. Could you check whole routine just for sure, please? I don't understand whole radio and chanspec magic yet. --- drivers/net/wireless/b43/phy_lp.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/wireless/b43/phy_lp.c b/drivers/net/wireless/b43/phy_lp.c index 185219e..61009ee 100644 --- a/drivers/net/wireless/b43/phy_lp.c +++ b/drivers/net/wireless/b43/phy_lp.c @@ -2655,8 +2655,8 @@ static int b43_lpphy_op_switch_channel(struct b43_wldev *dev, if (err) return err; lpphy_set_analog_filter(dev, new_channel); - lpphy_adjust_gain_table(dev, channel2freq_lp(new_channel)); } + lpphy_adjust_gain_table(dev, channel2freq_lp(new_channel)); lpphy-channel = new_channel; b43_write16(dev, B43_MMIO_CHANNEL, new_channel); Both the lpphy_set_analog_filter() and lpphy_adjust_gain_table() calls should be outside the if statement. I changed the spec a little. It used to test radio enabled, but I have found that is always true for our driver. Larry Isn't set_analog_filter() rev0/1-specific? The new routines are described in http://bcm-v4.sipsolutions.net/802.11/PHY/LP/TxFilterInit http://bcm-v4.sipsolutions.net/802.11/PHY/LP/TxDigFiltUcodeRev2 The revised routines are: http://bcm-v4.sipsolutions.net/802.11/PHY/LP/SetChanSpecLPPHY http://bcm-v4.sipsolutions.net/802.11/PHY/LP/PR41573 Larry ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev