[PATCH] b43: Fix rfkill allocation leakage in error paths

2008-01-23 Thread Michael Buesch
We must kill rfkill in any error paths that trigger after rfkill init. Signed-off-by: Michael Buesch [EMAIL PROTECTED] --- John, please try to push this for 2.6.24. Seems quite important, as it leaks resources and might crash the kernel. Index: wireless-2.6/drivers/net/wireless/b43/main.c

[PATCH] b43legacy: Fix rfkill allocation leakage in error paths

2008-01-23 Thread Michael Buesch
We must kill rfkill in any error paths that trigger after rfkill init. Signed-off-by: Michael Buesch [EMAIL PROTECTED] --- John, please try to push this for 2.6.24. Seems quite important, as it leaks resources and might crash the kernel. Index:

Re: [PATCH] b43legacy: Fix rfkill allocation leakage in error paths

2008-01-23 Thread Stefano Brivio
On Wed, 23 Jan 2008 12:15:38 +0100 Michael Buesch [EMAIL PROTECTED] wrote: We must kill rfkill in any error paths that trigger after rfkill init. Signed-off-by: Michael Buesch [EMAIL PROTECTED] Acked-by: Stefano Brivio [EMAIL PROTECTED] -- Ciao Stefano

Re: resuming from suspend to disk not working with b43

2008-01-23 Thread Rafael J. Wysocki
On Wednesday, 23 of January 2008, Celejar wrote: Hi, Hi, I know there's an ongoing long thread about suspend in b43, but the technical level has been above me, and I don't know if anything there is relevant to me. When I suspend to disk ('s2disk' from uswsusp), the resume fails if b43

[PATCH] b43: Fix suspend/resume

2008-01-23 Thread Michael Buesch
This fixes suspend/resume. We must not overwrite the MAC addresses on resume. Otherwise the card won't ACK any packets anymore. Signed-off-by: Michael Buesch [EMAIL PROTECTED] --- John, this is a bugfix that makes suspend/resume working. Without this people need to do an interface up/down

Re: resuming from suspend to disk not working with b43

2008-01-23 Thread Celejar
On Wed, 23 Jan 2008 16:00:15 +0100 Rafael J. Wysocki [EMAIL PROTECTED] wrote: On Wednesday, 23 of January 2008, Celejar wrote: Hi, Hi, I know there's an ongoing long thread about suspend in b43, but the technical level has been above me, and I don't know if anything there is

[PATCH] b43: Drop packets that we are not able to encrypt

2008-01-23 Thread Michael Buesch
We must not transmit packets we're not able to encrypt. This fixes a bug where in a tiny timeframe after machine resume packets can get sent unencrypted and might leak information. This also fixes three small resource leakages I spotted while fixing the security problem. Properly deallocate the

Re: resuming from suspend to disk not working with b43

2008-01-23 Thread Rafael J. Wysocki
On Wednesday, 23 of January 2008, Celejar wrote: On Wed, 23 Jan 2008 16:00:15 +0100 Rafael J. Wysocki [EMAIL PROTECTED] wrote: On Wednesday, 23 of January 2008, Celejar wrote: Hi, Hi, I know there's an ongoing long thread about suspend in b43, but the technical level has