On 03/11/15 01:50, Pan, Xiuli wrote:
LGTM, but the commit line is too long,
When it was written, the longest line was 66, but something appears to
have joined it back together; does
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/email-clients.txt#n208
wrote
One comment.
> -Original Message-
> From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of
> junyan...@inbox.com
> Sent: Tuesday, October 27, 2015 18:36
> To: beignet@lists.freedesktop.org
> Subject: [Beignet] [PATCH 3/5] Backend: Add double conversion to insn
> selectio
LGTM
Thanks!
Ruiling
> -Original Message-
> From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of
> Pan Xiuli
> Sent: Tuesday, November 3, 2015 11:29 AM
> To: beignet@lists.freedesktop.org
> Cc: Pan, Xiuli
> Subject: [Beignet] [PATCH] utests: fix multithread queue chao
LGTM, thanks.
> -Original Message-
> From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of
> Guo Yejun
> Sent: Friday, October 23, 2015 3:27
> To: beignet@lists.freedesktop.org
> Cc: Guo, Yejun
> Subject: [Beignet] [PATCH] add more OP for LOGICAL_SRCMOD case
>
> curren
Pushed.
> -Original Message-
> From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of
> Zhigang Gong
> Sent: Tuesday, October 27, 2015 7:45
> To: Pan, Xiuli
> Cc: beignet@lists.freedesktop.org
> Subject: Re: [Beignet] [PATCH V2 1/4] drivers: change the buf size to size_t
LGTM, thanks.
> -Original Message-
> From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of
> Guo Yejun
> Sent: Friday, October 23, 2015 9:25
> To: beignet@lists.freedesktop.org
> Cc: Guo, Yejun
> Subject: [Beignet] [PATCH] fix regression issue for climage + uesrptr
>
>
LGTM, thanks.
> -Original Message-
> From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of
> Guo Yejun
> Sent: Friday, October 23, 2015 3:10
> To: beignet@lists.freedesktop.org
> Cc: Guo, Yejun
> Subject: [Beignet] [PATCH] add comments to explain 32bit is enough to
> re
Two comments.
> -Original Message-
> From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of
> Pan Xiuli
> Sent: Friday, October 23, 2015 11:22
> To: beignet@lists.freedesktop.org
> Cc: Pan, Xiuli
> Subject: [Beignet] [PATCH 2/2] Backend: add debugwait function
>
> Use w
LGTM, thanks.
> -Original Message-
> From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of
> Ruiling Song
> Sent: Thursday, October 22, 2015 16:28
> To: beignet@lists.freedesktop.org
> Cc: Song, Ruiling
> Subject: [Beignet] [PATCH] GBE: Fix unaligned load/store issues.
The PrintfParse::printfs static is not thread
safe and maybe reset or adding something wrong
when runing in mutlithread. Fix the problem by
change the printfs to a thread local variable.
Signed-off-by: Pan Xiuli
---
backend/src/llvm/llvm_printf_parser.cpp | 9 -
1 file changed, 4 inserti
Utest profiling exec create a new queue
and replace the global shared queue for
no use. It will result in some strange
segmeng fault.
Fix by removing the replacment of the
global queue.
Signed-off-by: Pan Xiuli
---
utests/profiling_exec.cpp | 8 +---
1 file changed, 1 insertion(+), 7 deletio
GBE/DebugInfo: is a more suitable keyword in patch subject.
Thanks!
Ruiling
___
Beignet mailing list
Beignet@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/beignet
>
> + extern bool OCL_PROFILING; // first defined by calling BVAR in program.cpp
> +#define SET_GENINSN_DBGINFO(I) \
> + if(OCL_PROFILING) { \
> +p->DBGInfo.line = I.DBGInfo.line; \
> +p->DBGInfo.col = I.DBGInfo.col;}
Please don't assign the fields one by one in DBGInfo, please use p->DB
> +
> + if (OCL_PROFILING)
> +fprintf(file, "[%3i,%3i]", p->storedbg[insnID].srcline, p-
> >storedbg[insnID].srcline);
You printf srcline two times.
And here using OCL_PROFILING to control the output of debuginfo is a little
misunderstanding.
Profiling often means performance informa
Thanks for you remind about the INF problem, the spec does not talk about the
and , so I think we may consider it more.
This is surely a problem, so how about mad? It can also calculate the mix but
may need some more instruction, can it handle the INF problem?
-Original Message-
From: M
LGTM, but the commit line is too long, could you make the newlines by
hand to make sure the commit is readable for all situation like this.
Or we could help you to break the line into serval lines.
Also it seems the patch is made from git diff? Could you try to use
[git format-patch -s] to create p
When p==end (the null terminator byte), don't try to read p+1
(outside the string, so might be an invalid address or a '%' from
a different object).
Signed-off-by: Rebecca Palmer
diff --git a/backend/src/llvm/llvm_printf_parser.cpp
b/backend/src/llvm/llvm_printf_parser.cpp
index bdaed8a..f42710
On Wed, Oct 21, 2015 at 8:21 PM, Pan Xiuli wrote:
> Add a testcase for compiler mix. Since mix will have
> error, we take err limit as 1e-3 and print the max err.
I don't know what OpenCL's spec says about this issue, but you should
be aware that Gen's LRP instruction does not return INFINITY whe
18 matches
Mail list logo
