Re: [Beignet] [PATCH] create GIT_SHA1 without any dependency

2014-10-24 Thread Zhigang Gong
LGTM, pushed, thanks. On Sat, Oct 25, 2014 at 03:10:02AM +0800, Meng Mengmeng wrote: --- src/CMakeLists.txt | 5 ++--- src/git_sha1.sh| 4 ++-- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index 0d22589..9e65856 100644 ---

Re: [Beignet] [Intel-gfx] Beignet crashes on vanilla 3.17.1 with IVB hardware

2014-10-24 Thread Zhigang Gong
I just checked again, and found both 3.17 and 3.17.1 should work fine on IVB with beignet. I just tested beignet on IVB with kernel 3.17.1, all unit tests passed successfully. For IVB user, no need to wait for 3.18. Don't know which application you were testing on your IVB machine. If it could be

Re: [Beignet] [Intel-gfx] Beignet crashes on vanilla 3.17.1 with IVB hardware

2014-10-24 Thread Vasily Khoruzhick
Hi Zhigang, Luxmark crashes with following backtrace: Program received signal SIGSEGV, Segmentation fault. 0x004cd8b0 in slg::PathOCLRenderEngine::StopLockLess() () (gdb) bt #0 0x004cd8b0 in slg::PathOCLRenderEngine::StopLockLess() () #1 0x00482236 in

Re: [Beignet] possilbe bug when run opencv_test_imgproc

2014-10-24 Thread yan . wang
Hi, Zhigang, May your platform also get failed cases when run OCL_ImageProc/Filter2D.Mat* although no crash, because I have only Baytail T platfrom. I am not sure the other platform has the same issue. If yes, I could try to investigate the reason. It may have issue of filter2D OpenCL

Re: [Beignet] possilbe bug when run opencv_test_imgproc

2014-10-24 Thread Zhigang Gong
I have BYT box, an IVB machine and a HSW notebook. All of them haven't this issue. Yang rong is working on a race condition patch. This issue may be related. You may try again once he send out the patch. On Fri, Oct 24, 2014 at 5:46 PM, yan.w...@linux.intel.com wrote: Hi, Zhigang, May your

Re: [Beignet] [Intel-gfx] Beignet crashes on vanilla 3.17.1 with IVB hardware

2014-10-24 Thread Zhigang Gong
Hi, Luxmark (both 2.0/2.1) works fine on my IVB machine. The back trace you provided below doesn't indicate it's a beignet related problem. It hadn't enter beignet domain and just crashed in luxmark internal. On Fri, Oct 24, 2014 at 12:04:29PM +0300, Vasily Khoruzhick wrote: Hi Zhigang,

[Beignet] [PATCH] GBE: fix a wrong type of cl_device_info.

2014-10-24 Thread Zhigang Gong
Per OpenCL spec 1.2: CL_DEVICE_IMAGE_MAX_BUFFER_SIZE should be size_t type rather than cl_ulong. This bug will cause problems on i386 platform. Signed-off-by: Zhigang Gong zhigang.g...@intel.com --- src/cl_device_id.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Beignet] [Intel-gfx] Beignet crashes on vanilla 3.17.1 with IVB hardware

2014-10-24 Thread Vasily Khoruzhick
Hi Zhigang, On Fri, Oct 24, 2014 at 12:13 PM, Zhigang Gong zhigang.g...@linux.intel.com wrote: Hi, Luxmark (both 2.0/2.1) works fine on my IVB machine. The back trace you provided below doesn't indicate it's a beignet related problem. It hadn't enter beignet domain and just crashed in

Re: [Beignet] possilbe bug when run opencv_test_imgproc

2014-10-24 Thread yan . wang
Sure. I could try Yang Rong's patch. BTW, I also meet the following failed cases. Could you please confirm them? Thanks. [ FAILED ] 3 tests, listed below: [ FAILED ] OCL_ImgProc/Canny.Accuracy/8, where GetParam() = (Channels(3), AppertureSize(3), L2gradient(false), UseRoi(false)) [ FAILED ]

Re: [Beignet] possilbe bug when run opencv_test_imgproc

2014-10-24 Thread Zhigang Gong
All of these three failures are already tracked in JIRA. If you have access to JIRA, you can check them easily. Thanks, Zhigang Gong. On Fri, Oct 24, 2014 at 10:33 PM, yan.w...@linux.intel.com wrote: Sure. I could try Yang Rong's patch. BTW, I also meet the following failed cases. Could you

Re: [Beignet] possilbe bug when run opencv_test_imgproc

2014-10-24 Thread yan . wang
Could you give me one URL? Thanks. Yan Wang All of these three failures are already tracked in JIRA. If you have access to JIRA, you can check them easily. Thanks, Zhigang Gong. On Fri, Oct 24, 2014 at 10:33 PM, yan.w...@linux.intel.com wrote: Sure. I could try Yang Rong's patch. BTW,

Re: [Beignet] possilbe bug when run opencv_test_imgproc

2014-10-24 Thread Meng, Mengmeng
Hi, The 2 bugs are: 1. https://jira01.devtools.intel.com/browse/VIZ-4490 VIZ-4490 [HSW/IVB/BYT-M] After update opencv, 1 opencv case (opencv_test_imgproc/OCL_Imgproc/HoughLines)fail 2. https://jira01.devtools.intel.com/browse/VIZ-4489 VIZ-4489 [IVB/HSW/BYT-M] After update opencv, some

[Beignet] beignet not working with Wolfram Mathematica

2014-10-24 Thread Lorenzo Pistone
Hello, I'm trying to run beignet from Wolfram Mathematica 10.0.1, I have beignet 0.9.2, Fedora 20 x86_64, kernel 3.16.3, i5-3230M. First, there is an issue which is probably to be blamed on Mathematica (you need to manually load /usr/lib64/beignet/libcl.so with LibraryLoad), I suppose that

Re: [Beignet] [PATCH 6/6] BDW: Add function intel_gpgpu_bind_buf for gen8.

2014-10-24 Thread He Junyan
This patchset LGTM On 一, 2014-09-29 at 13:37 +0800, Yang Rong wrote: From: Junyan He junyan...@linux.intel.com Must call cl_bind_buf instead of intel_gpgpu_bind_buf directly in intel_gpgpu. Signed-off-by: Junyan He junyan...@linux.intel.com --- src/intel/intel_gpgpu.c | 36

Re: [Beignet] [PATCH 5/5] BDW: Add class Gen8Context.

2014-10-24 Thread Yang, Rong R
Yes, I am also plan to change GenContext to a pure virtual class, and I think It is better to do this when optimize the long operations in BDW. -Original Message- From: He Junyan [mailto:junyan...@inbox.com] Sent: Thursday, October 9, 2014 13:09 To: Yang, Rong R Cc:

Re: [Beignet] [PATCH 1/6] BDW: Add gen8 into intel_driver_init

2014-10-24 Thread Zhigang Gong
This patch itself LGTM. But I will move it after other patches. Thus once this patch get applied, it can accept Gen8 device and work as expected. Thanks. On Mon, Sep 29, 2014 at 01:37:44PM +0800, Yang Rong wrote: From: Junyan He junyan...@linux.intel.com Signed-off-by: Junyan He

Re: [Beignet] [PATCH 1/3] GBE: Fix a bug when setting flag register

2014-10-24 Thread Zhigang Gong
This patch LGTM, will push latter, thanks. On Fri, Oct 10, 2014 at 03:01:25PM +0800, Ruiling Song wrote: we should use simd1, instead of simd8/simd16. Signed-off-by: Ruiling Song ruiling.s...@intel.com --- backend/src/backend/gen_context.cpp | 20 ++--

[Beignet] [PATCH] Fix HSW thread_n = 64 assert.

2014-10-24 Thread Yang Rong
In function cl_get_kernel_max_wg_sz, hsw's thread count may large than 64, add a max limit. Signed-off-by: Yang Rong rong.r.y...@intel.com --- src/cl_device_id.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/cl_device_id.c b/src/cl_device_id.c index

Re: [Beignet] [PATCH] Fix AUX buffer for really page aligned

2014-10-24 Thread Guo, Yejun
three comments in line, thanks. -Original Message- From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Zhenyu Wang Sent: Wednesday, October 22, 2014 4:11 PM To: beignet@lists.freedesktop.org Subject: [Beignet] [PATCH] Fix AUX buffer for really page aligned Apply

Re: [Beignet] Problems with recent beignet

2014-10-24 Thread Zhigang Gong
On Sat, Oct 18, 2014 at 04:26:02PM +0200, Martin Hauke wrote: Hi Zhigang, On 18.10.2014 04:36, you wrote: building git master on OpenSUSE 13.1 actually fails since this OpenSUSE version ships only with libdrm2-2.4.46-3.2.2 As you may know, we are working on enable BDW. And the new

[Beignet] [PATCH V2] Add the disasm support for Gen8

2014-10-24 Thread junyan . he
From: Junyan He junyan...@linux.intel.com Signed-off-by: Junyan He junyan...@linux.intel.com --- backend/src/backend/gen/gen_mesa_disasm.c | 1110 +++-- backend/src/backend/gen_defs.hpp |2 + 2 files changed, 582 insertions(+), 530 deletions(-) diff --git

Re: [Beignet] Which version of mesa that Beignet could compile with?

2014-10-24 Thread Steven Newbury
On Sun, 2014-10-19 at 22:15 +0800, Boxiang Sun wrote: Did you set the 'MESA_SOURCE_FOUND' to '1' and the path of mesa source directory in Beignet cmake file? I'm pretty sure that the current master could not compiles with Mesa 10.3.x if without some modifications. Regards, Sun

Re: [Beignet] [PATCH] Fix AUX buffer for really page aligned

2014-10-24 Thread Zhenyu Wang
On 2014.10.22 08:49:53 +, Guo, Yejun wrote: three comments in line, thanks. Thanks for review this. gpgpu-aux_offset.surface_heap_offset = size_aux; size_aux += sizeof(surface_heap_t); @@ -784,7 +782,10 @@ intel_gpgpu_state_init(intel_gpgpu_t *gpgpu,

Re: [Beignet] [PATCH v2 1/5] Make use of write enable flag for mem bo map

2014-10-24 Thread Yang, Rong R
This patchset LGTM, thanks. -Original Message- From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Zhenyu Wang Sent: Thursday, October 23, 2014 15:19 To: beignet@lists.freedesktop.org Subject: [Beignet] [PATCH v2 1/5] Make use of write enable flag for mem bo

Re: [Beignet] [PATCH 3/5] Remove intel_gpgpu_check_binded_buf_address()

2014-10-24 Thread Zhigang Gong
This assertion is just to make sure we will not get a NULL pointer for a normal buffer. The OpenCL spec doesn't give a very specific statement about a NULL buffer object. But it does allow to pass a NULL to a buffer object. Thus some one may implement the following kernel: __kernel foo( global

Re: [Beignet] Performances of beignet ... macbook pro 13

2014-10-24 Thread Zhigang Gong
Jérôme, Thanks for sharing the very interesting performance data. We will look into the large image issue. Thanks, Zhigang Gong. ___ Beignet mailing list Beignet@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/beignet

Re: [Beignet] johntheripper/OpenCL clGetEventProfilingInfo issue

2014-10-24 Thread Zhigang Gong
This should be an application bug, according to OpenCL 1.2 spec: CL_PROFILING_INFO_NOT_AVAILABLE if the CL_QUEUE_PROFILING_ENABLE flag is not set for the command-queue, if the execution status of the command identified by event is not CL_COMPLETE or if event is a user event object. To make

Re: [Beignet] beignet not working with Wolfram Mathematica

2014-10-24 Thread Zhigang Gong
As you are using 3.16.x kernel, the most possible solution is in the README.md's known issue section: Almost all unit tests fail on Linux kernel 3.15/3.16. There is a known issue in some versions of linux kernel which enable register whitelist feature but miss some necessary registers which are