Re: [bitcoin-dev] Attack by modifying non-segwit transactions after segwit is accepted ?

2016-09-01 Thread Johnson Lau via bitcoin-dev
Thank you so much for taking time to actually review the codes. I hope you will keep raising questions when you feel something might be wrong. This is how things supposed to work and we should not be affected by some forum discussions. > On August 26, 2016 at 9:16 AM Sergio Demian Lerner > wro

Re: [bitcoin-dev] Attack by modifying non-segwit transactions after segwit is accepted ?

2016-08-26 Thread Sergio Demian Lerner via bitcoin-dev
Because there was a discussion on reddit about this topic, I want to clarify that Johnson Lau explained how a check in the code prevents this attack. So there is no real attack. Also note that the subject of this thread has a question mark, which means that I'm asking the community for clarificati

Re: [bitcoin-dev] Attack by modifying non-segwit transactions after segwit is accepted ?

2016-08-24 Thread Johnson Lau via bitcoin-dev
Adding witness data to a non-segwit script is invalid by consensus: https://github.com/bitcoin/bitcoin/blob/d612837814020ae832499d18e6ee5eb919a87907/src/script/interpreter.cpp#L1467 This PR will detect such violation early and ban the peer: https://github.com/bitcoin/bitcoin/pull/8499 Another

[bitcoin-dev] Attack by modifying non-segwit transactions after segwit is accepted ?

2016-08-24 Thread Sergio Demian Lerner via bitcoin-dev
In a previous thread ("New BIP: Dealing with OP_IF and OP_NOTIF malleability in P2WSH") it was briefly discussed what happens if someone modifies segwit data during transmission. I think the discussion should continue. What worries me is what happens with non-segwit transactions after segwit is ac