Re: [bitcoin-dev] Package Relay Proposal

2023-05-10 Thread Greg Sanders via bitcoin-dev
Hi Tom, Yesterday a PR was opened to do just that, with caveats: https://github.com/bitcoin/bitcoin/pull/27609 For higher level tracking of the project: https://github.com/bitcoin/bitcoin/issues/27463 Cheers, Greg On Wed, May 10, 2023 at 11:39 AM Tom Trevethan via bitcoin-dev <

Re: [bitcoin-dev] Package Relay Proposal

2022-11-01 Thread Gloria Zhao via bitcoin-dev
Hi everyone, I've made some significant changes to my package relay proposal based on observations while implementing, feedback on this thread, and offline discussions [1]. The new proposal is called Ancestor Package Relay, BIP331, and PR'd at https://github.com/bitcoin/bips/pull/1382 The major

Re: [bitcoin-dev] Package Relay Proposal

2022-06-17 Thread Antoine Riard via bitcoin-dev
Hi Gloria, Thanks for working on that, > Always overestimating fees may sidestep this issue temporarily (while mempool > traffic is low and predictable), but this solution is not foolproof > and wastes users' money. The feerate market can change due to sudden > spikes in traffic (e.g. huge

Re: [bitcoin-dev] Package Relay Proposal

2022-06-14 Thread Gloria Zhao via bitcoin-dev
uarantee, >> not an intended use case for package relay, and not worsened by this. >> >> Thanks for your feedback! >> >> Best, >> Gloria >> >> [1]: >> https://github.com/bitcoin/bips/blob/master/bip-0152.mediawiki#cmpctblock >> [2]: >> http

Re: [bitcoin-dev] Package Relay Proposal

2022-06-08 Thread Suhas Daftuar via bitcoin-dev
th a Merkle root (e.g. "identity" field) for the package, uniquely >> identifying the partially-ordered set of txs. And use of 'getdata' (to >> obtain a package by hash) can be eliminated (not a use case). >> >> e >> >> > -Original Message

Re: [bitcoin-dev] Package Relay Proposal

2022-06-07 Thread Gloria Zhao via bitcoin-dev
etdata' (to > obtain a package by hash) can be eliminated (not a use case). > > e > > > -Original Message- > > From: e...@voskuil.org > > Sent: Wednesday, May 25, 2022 1:52 PM > > To: 'Anthony Towns' ; 'Bitcoin Protocol Discussion' > > ; 'Gloria Z

Re: [bitcoin-dev] Package Relay Proposal

2022-05-28 Thread Gloria Zhao via bitcoin-dev
Hi aj, answering slightly out of order: > what happens if the peer announcing packages to us is dishonest? > They announce pkg X, say X has parents A B C and the fee rate is garbage. But actually X has parent D and the fee rate is excellent. Do we request the package from another peer, or every

Re: [bitcoin-dev] Package Relay Proposal

2022-05-25 Thread Eric Voskuil via bitcoin-dev
> From: bitcoin-dev On Behalf > Of Anthony Towns via bitcoin-dev > Sent: Wednesday, May 25, 2022 11:56 AM > So the other thing is what happens if the peer announcing packages to us is > dishonest? > > They announce pkg X, say X has parents A B C and the fee rate is garbage. But > actually X has

Re: [bitcoin-dev] Package Relay Proposal

2022-05-25 Thread Anthony Towns via bitcoin-dev
On 24 May 2022 5:05:35 pm GMT-04:00, Gloria Zhao via bitcoin-dev wrote: >To clarify, in this situation, I'm imagining something like >A: 0 sat, 100vB >B: 1500 sat, 100vB >C: 0 sat, 100vB >X: 500 sat, 100vB >feerate floor is 3sat/vB > >With the algo: >> * is X alone above my fee rate? no, then

Re: [bitcoin-dev] Package Relay Proposal

2022-05-24 Thread Eric Voskuil via bitcoin-dev
The set of txs is the graph. Anything else would just reproduce the tx graph which must be traversed in any case. Similarly the set of txs is the fee, the sigops, the size, and the weight. The only information required by packaging is the association of the txs with each other for the purpose

Re: [bitcoin-dev] Package Relay Proposal

2022-05-24 Thread Gloria Zhao via bitcoin-dev
Hi aj, > If you've got (A,B,C,X) where B spends A and X spends A,B,C where X+C is below fee floor while A+B and A+B+C+X are above fee floor you have the problem though. To clarify, in this situation, I'm imagining something like A: 0 sat, 100vB B: 1500 sat, 100vB C: 0 sat, 100vB X: 500 sat,

Re: [bitcoin-dev] Package Relay Proposal

2022-05-24 Thread Anthony Towns via bitcoin-dev
On 23 May 2022 9:13:43 pm GMT-04:00, Gloria Zhao wrote: >> If you're asking for the package for "D", would a response telling you: >> txid_D (500 sat, 100vB) >> txid_A (0 sat, 100vB) >> txid_B (2000 sat, 100 vB) >> be better, in that case? Then the receiver can maybe do the logic >>

Re: [bitcoin-dev] Package Relay Proposal

2022-05-24 Thread Gloria Zhao via bitcoin-dev
Hi aj, > if you're writing a protocol that's > dependent on people seeing that a package as a whole pays a competitive > feerate, don't you want to know in advance what conditions the network > is going to impose on your transactions in order to consider them as a > package? I do think unifying

Re: [bitcoin-dev] Package Relay Proposal

2022-05-23 Thread Anthony Towns via bitcoin-dev
On Wed, May 18, 2022 at 02:40:58PM -0400, Gloria Zhao via bitcoin-dev wrote: > > Does it make sense for these to be configurable, rather than implied > > by the version? > > … would it be better to either just not do sendpackages > > at all if you're limiting ancestors in the mempool incompatibly

Re: [bitcoin-dev] Package Relay Proposal

2022-05-18 Thread Gloria Zhao via bitcoin-dev
(To everyone): I should have made it much clearer that version 1 is only supposed to solve 1 of the 2 use cases. I was a lot more focused on the fee-bumping use case, since it’s more important. Orphan-fetching was added to the motivation section last-minute because John Newbery mentioned to me

Re: [bitcoin-dev] Package Relay Proposal

2022-05-17 Thread Anthony Towns via bitcoin-dev
On Tue, May 17, 2022 at 12:01:04PM -0400, Gloria Zhao via bitcoin-dev wrote: > New Messages > Three new protocol messages are added for use in any version of > package relay. Additionally, each version of package relay must define > its own inv type and "pckginfo" message version, referred

Re: [bitcoin-dev] Package Relay Proposal

2022-05-17 Thread Gloria Zhao via bitcoin-dev
Hi Greg, Thanks for reading! >> A child-with-unconfirmed-parents package sent between nodes must abide by the rules below, otherwise the package is malformed and the sender should be disconnected. >> However, if the child has confirmed parents, they must not be in the package. > If my naive

Re: [bitcoin-dev] Package Relay Proposal

2022-05-17 Thread Greg Sanders via bitcoin-dev
Hi Gloria, Thanks for working on this important proposal! Still a lot to digest, but I just had on area of comment/question: > A child-with-unconfirmed-parents package sent between nodes must abide by the rules below, otherwise the package is malformed and the sender should be disconnected. >