Re: [Bitcoin-development] Why Bitcoin is and isn't like the Internet

2015-01-21 Thread odinn
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 3rd party / web wallets are no longer viable except as means to burn customers and divulge (or be forced to divulge) their data to governments and corporations. Rather than restate what I have already posted on this matter I'll leave it there. It's

Re: [Bitcoin-development] [softfork proposal] Strict DER signatures

2015-01-21 Thread Douglas Roark
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 2015/1/20 19:35, Pieter Wuille wrote: Hello everyone, Comments/criticisms are very welcome, but I'd prefer keeping the discussion here on the mailinglist (which is more accessible than on the gist). Nice paper, Pieter. I do have a bit of

Re: [Bitcoin-development] [softfork proposal] Strict DER signatures

2015-01-21 Thread Pieter Wuille
On Tue, Jan 20, 2015 at 11:45 PM, Rusty Russell ru...@rustcorp.com.au wrote: // Null bytes at the start of R are not allowed, unless it would otherwise be // interpreted as a negative number. if (lenS 1 (sig[lenR + 6] == 0x00) !(sig[lenR + 7] 0x80)) return false; You mean null

Re: [Bitcoin-development] [softfork proposal] Strict DER signatures

2015-01-21 Thread Andrew Poelstra
I've read this and it looks A-OK to me. Andrew On Tue, Jan 20, 2015 at 07:35:49PM -0500, Pieter Wuille wrote: Hello everyone, We've been aware of the risk of depending on OpenSSL for consensus rules for a while, and were trying to get rid of this as part of BIP 62 (malleability

Re: [Bitcoin-development] [softfork proposal] Strict DER signatures

2015-01-21 Thread Douglas Roark
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 2015/1/21 15:30, Pieter Wuille wrote: Thanks for the comments. I hope I have clarified the text a bit accordingly. You're welcome. All the revisions look good to me. - --- Douglas Roark Senior Developer Armory Technologies, Inc.

Re: [Bitcoin-development] [softfork proposal] Strict DER signatures

2015-01-21 Thread Pieter Wuille
On Wed, Jan 21, 2015 at 3:37 PM, Gavin Andresen gavinandre...@gmail.com wrote: DERSIG BIP looks great to me, just a few nit-picky changes suggested: You mention the DER standard : should link to http://www.itu.int/ITU-T/studygroups/com17/languages/X.690-0207.pdf (or whatever is best reference

Re: [Bitcoin-development] [softfork proposal] Strict DER signatures

2015-01-21 Thread Douglas Roark
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 2015/1/21 15:37, Gavin Andresen wrote: You mention the DER standard : should link to http://www.itu.int/ITU-T/studygroups/com17/languages/X.690-0207.pdf (or whatever is best reference for DER). The link you gave is to the 2002 revision.

Re: [Bitcoin-development] [softfork proposal] Strict DER signatures

2015-01-21 Thread Gavin Andresen
DERSIG BIP looks great to me, just a few nit-picky changes suggested: You mention the DER standard : should link to http://www.itu.int/ITU-T/studygroups/com17/languages/X.690-0207.pdf (or whatever is best reference for DER). this would simplify avoiding OpenSSL in consensus implementations --

Re: [Bitcoin-development] [softfork proposal] Strict DER signatures

2015-01-21 Thread Pieter Wuille
On Wed, Jan 21, 2015 at 2:29 PM, Douglas Roark d...@bitcoinarmory.com wrote: Nice paper, Pieter. I do have a bit of feedback. Thanks for the comments. I hope I have clarified the text a bit accordingly. 1)The first sentence of Deployment has a typo. We reuse the double-threshold switchover

Re: [Bitcoin-development] [softfork proposal] Strict DER signatures

2015-01-21 Thread Dave Collins
I'm really glad to see this proposal. We already treat non-DER signatures as non-standard in btcd and agree that extending them be illegal as a part of a soft fork is a smart and sane thing to do. It's also good to see the explicit use of signature parsing since it matches what we already do as

Re: [Bitcoin-development] Deanonymisation of clients in Bitcoin P2P network paper

2015-01-21 Thread Isidor Zeuner
Hi there, some thoughts in-line: Finally, distributors of consumer wallets can use this research in order to distribute their wallet with policies which may be less prone to Tor-specific attacks. Or leave this out altogether if their audience has different expectations for connecting to

Re: [Bitcoin-development] [softfork proposal] Strict DER signatures

2015-01-21 Thread Rusty Russell
Pieter Wuille pieter.wui...@gmail.com writes: Hello everyone, We've been aware of the risk of depending on OpenSSL for consensus rules for a while, and were trying to get rid of this as part of BIP 62 (malleability protection), which was however postponed due to unforeseen complexities. The

Re: [Bitcoin-development] [softfork proposal] Strict DER signatures

2015-01-21 Thread Matt Whitlock
To be more in the C++ spirit, I would suggest changing the (const std::vectorunsigned char sig, size_t off) parameters to (std::vectorunsigned char::const_iterator itr, std::vectorunsigned char::const_iterator end). Example: bool ConsumeNumber(std::vectorunsigned char::const_iterator itr,

Re: [Bitcoin-development] [softfork proposal] Strict DER signatures

2015-01-21 Thread David Vorick
Seems like a good change to me. On Wed, Jan 21, 2015 at 7:32 PM, Rusty Russell ru...@rustcorp.com.au wrote: Pieter Wuille pieter.wui...@gmail.com writes: Hello everyone, We've been aware of the risk of depending on OpenSSL for consensus rules for a while, and were trying to get rid of

Re: [Bitcoin-development] [softfork proposal] Strict DER signatures

2015-01-21 Thread Pieter Wuille
On Wed, Jan 21, 2015 at 11:18 PM, Matt Whitlock b...@mattwhitlock.name wrote: To be more in the C++ spirit, I would suggest changing the (const std::vectorunsigned char sig, size_t off) parameters to (std::vectorunsigned char::const_iterator itr, std::vectorunsigned char::const_iterator

Re: [Bitcoin-development] Why Bitcoin is and isn't like the Internet

2015-01-21 Thread Alon Muroch
Bitcoin has a major crossroad ahead regarding a suitable platform for the average non technical main stream user. Until now the majority of the available solutions were at two extremes, or DIY your security and privacy *OR* let a 3rd party service do it for you. The DIY solution is obviously not