Re: [blink-dev] Intent to Ship: Protected Audience ads reporting - allow cross-origin subframes to send reportEvent() beacons

2024-05-22 Thread Chris Harrelson
LGTM3 On Wed, May 22, 2024 at 7:41 AM Yoav Weiss (@Shopify) < yoavwe...@chromium.org> wrote: > LGTM2 > > On Tuesday, May 21, 2024 at 2:11:37 PM UTC+2 Mike Taylor wrote: > >> Thanks Liam! >> >> LGTM1 to ship. >> On 5/20/24 3:51 PM, Liam Brady wrote: >> >> Thanks for your feedback on this intent!

Re: [blink-dev] Intent to Ship: Protected Audience ads reporting - allow cross-origin subframes to send reportEvent() beacons

2024-05-22 Thread Yoav Weiss (@Shopify)
LGTM2 On Tuesday, May 21, 2024 at 2:11:37 PM UTC+2 Mike Taylor wrote: > Thanks Liam! > > LGTM1 to ship. > On 5/20/24 3:51 PM, Liam Brady wrote: > > Thanks for your feedback on this intent! We plan on modifying the > "Allow-Cross-Origin-Event-Reporting" response header to accept a boolean >

Re: [blink-dev] Intent to Ship: Protected Audience ads reporting - allow cross-origin subframes to send reportEvent() beacons

2024-05-21 Thread Mike Taylor
Thanks Liam! LGTM1 to ship. On 5/20/24 3:51 PM, Liam Brady wrote: Thanks for your feedback on this intent! We plan on modifying the "Allow-Cross-Origin-Event-Reporting" response header to accept a boolean instead of a string literal to match the preferred convention for response headers.

Re: [blink-dev] Intent to Ship: Protected Audience ads reporting - allow cross-origin subframes to send reportEvent() beacons

2024-05-20 Thread 'Liam Brady' via blink-dev
Thanks for your feedback on this intent! We plan on modifying the "Allow-Cross-Origin-Event-Reporting" response header to accept a boolean instead of a string literal to match the preferred convention for response headers. On Thursday, May 9, 2024 at 1:21:43 PM UTC-4 Liam Brady wrote: > Can I

Re: [blink-dev] Intent to Ship: Protected Audience ads reporting - allow cross-origin subframes to send reportEvent() beacons

2024-05-09 Thread 'Liam Brady' via blink-dev
> > Can I ask why string literal vs boolean? I had done this to match the convention already being used for other Protected Audience-related response headers (such as Ad-Auction-Allowed/X-Allow-FLEDGE

Re: [blink-dev] Intent to Ship: Protected Audience ads reporting - allow cross-origin subframes to send reportEvent() beacons

2024-05-09 Thread Mike Taylor
On 5/9/24 12:13 PM, Liam Brady wrote: Can you clarify what the type is for this new header? It reads as if you're adding a String Item that looks like a boolean, rather than a Boolean Item. Is that correct? It doesn't seem to be actually defined in the spec. This is meant to

Re: [blink-dev] Intent to Ship: Protected Audience ads reporting - allow cross-origin subframes to send reportEvent() beacons

2024-05-09 Thread 'Liam Brady' via blink-dev
> > Can you clarify what the type is for this new header? It reads as if > you're adding a String Item that looks like a boolean, rather than a > Boolean Item. Is that correct? It doesn't seem to be actually defined in > the spec. This is meant to be a string literal that is either "true" or

Re: [blink-dev] Intent to Ship: Protected Audience ads reporting - allow cross-origin subframes to send reportEvent() beacons

2024-05-08 Thread Mike Taylor
On 5/8/24 11:30 AM, 'Liam Brady' via blink-dev wrote: Contact emails lbr...@google.com , shivani...@chromium.org , jkar...@chromium.org Explainer(s) https://github.com/WICG/turtledove/pull/1134

[blink-dev] Intent to Ship: Protected Audience ads reporting - allow cross-origin subframes to send reportEvent() beacons

2024-05-08 Thread 'Liam Brady' via blink-dev
Contact emails lbr...@google.com, shivani...@chromium.org, jkar...@chromium.org Explainer(s) https://github.com/WICG/turtledove/pull/1134 Spec(s) https://github.com/WICG/fenced-frame/pull/152 Summary Ad frames (both fenced frames and urn-iframes) created through a Protected Audience