Re: [blink-dev] Re: Intent to Ship: 'writingsuggestions' attribute

2024-03-21 Thread Yoav Weiss (@Shopify)
On Thu, Mar 21, 2024 at 8:07 AM Marcos Caceres wrote: > > > On Wednesday, March 20, 2024 at 4:57:56 AM UTC+11 Sanket Joshi (Edge) > wrote: > > Hi Marcos, > > The spec for the writing suggestions attribute > doesn't specify how > UAs should imple

Re: [blink-dev] Re: Intent to Ship: 'writingsuggestions' attribute

2024-03-21 Thread Marcos Caceres
On Wednesday, March 20, 2024 at 4:57:56 AM UTC+11 Sanket Joshi (Edge) wrote: Hi Marcos, The spec for the writing suggestions attribute doesn't specify how UAs should implement writing suggestions under the hood, it just aims to provide deve

Re: [blink-dev] Re: Intent to Ship: 'writingsuggestions' attribute

2024-03-19 Thread 'Sanket Joshi (Edge)' via blink-dev
Hi Marcos, The spec for the writing suggestions attribute doesn't specify how UAs should implement writing suggestions under the hood, it just aims to provide developers with a way to control whether the writing suggestions are shown on their

Re: [blink-dev] Re: Intent to Ship: 'writingsuggestions' attribute

2024-03-19 Thread Yoav Weiss (@Shopify)
Thanks for the heads up, Marcos! :) On Tue, Mar 19, 2024 at 3:51 AM Marcos Caceres wrote: > Hi Blink-Dev Friends! > > We (WebKit) hit some web compat issues with this feature while testing our > implementation is Safari Tech Preview. > > Could you please take a look at: > https://github.com/what

Re: [blink-dev] Re: Intent to Ship: 'writingsuggestions' attribute

2024-03-18 Thread Marcos Caceres
Hi Blink-Dev Friends! We (WebKit) hit some web compat issues with this feature while testing our implementation is Safari Tech Preview. Could you please take a look at: https://github.com/whatwg/html/issues/10209 And see if there is a way to leave this on by default somehow without affecting

Re: [blink-dev] Re: Intent to Ship: 'writingsuggestions' attribute

2024-03-14 Thread Alex Russell
LGTM3 On Thursday, March 14, 2024 at 2:59:45 PM UTC-7 Mike Taylor wrote: > LGTM2 > On 3/14/24 12:43 AM, Domenic Denicola wrote: > > Awesome! LGTM1. > > On Thu, Mar 14, 2024 at 1:35 PM 'Stephanie Zhang' via blink-dev < > blink-dev@chromium.org> wrote: > >> Thanks for clarifying! Updated the Chrome

Re: [blink-dev] Re: Intent to Ship: 'writingsuggestions' attribute

2024-03-14 Thread Mike Taylor
LGTM2 On 3/14/24 12:43 AM, Domenic Denicola wrote: Awesome! LGTM1. On Thu, Mar 14, 2024 at 1:35 PM 'Stephanie Zhang' via blink-dev wrote: Thanks for clarifying! Updated the Chrome Status' "Finch Feature Name" field to kWritingSuggestions and removed the "Non-finch justification"

Re: [blink-dev] Re: Intent to Ship: 'writingsuggestions' attribute

2024-03-13 Thread Domenic Denicola
Awesome! LGTM1. On Thu, Mar 14, 2024 at 1:35 PM 'Stephanie Zhang' via blink-dev < blink-dev@chromium.org> wrote: > Thanks for clarifying! Updated the Chrome Status' "Finch Feature Name" > field to kWritingSuggestions and removed the "Non-finch justification" > field. > > On Wednesday, March 13, 2

Re: [blink-dev] Re: Intent to Ship: 'writingsuggestions' attribute

2024-03-13 Thread 'Stephanie Zhang' via blink-dev
Thanks for clarifying! Updated the Chrome Status' "Finch Feature Name" field to kWritingSuggestions and removed the "Non-finch justification" field. On Wednesday, March 13, 2024 at 9:20:57 PM UTC-7 Domenic Denicola wrote: > On Thu, Mar 14, 2024 at 12:54 PM 'Stephanie Zhang' via blink-dev < > b

Re: [blink-dev] Re: Intent to Ship: 'writingsuggestions' attribute

2024-03-13 Thread Domenic Denicola
On Thu, Mar 14, 2024 at 12:54 PM 'Stephanie Zhang' via blink-dev < blink-dev@chromium.org> wrote: > We do have a runtime feature flag 'WritingSuggestions >

[blink-dev] Re: Intent to Ship: 'writingsuggestions' attribute

2024-03-13 Thread 'Stephanie Zhang' via blink-dev
We do have a runtime feature flag 'WritingSuggestions '. We didn't think a Finch Trial was necessary, as the bulk of the changes were just adding the

[blink-dev] Re: Intent to Ship: 'writingsuggestions' attribute

2024-03-13 Thread Domenic Denicola
On Thursday, March 14, 2024 at 2:08:28 AM UTC+9 Stephanie Zhang wrote: *Contact emails* *sa...@microsoft.com* , *dan...@microsoft.com* , *stephanie.zh...@microsoft.com* *Explainer* *https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/main/WritingSuggestions/explainer.md*