Re: [Bro-Dev] Bloom filter interface

2013-06-05 Thread Robin Sommer
I already talked to Matthias but for the record, this looks good to me. One more question: On Tue, Jun 04, 2013 at 15:24 -0700, you wrote: (4) bloomfilter_merge(bf1: opaque of bloomfilter, bf2: opaque of bloomfilter) : bool Is this merging bf2 into bf1? Would it make sense to return a new

Re: [Bro-Dev] Bloom filter interface

2013-06-05 Thread Matthias Vallentin
So it sounds like having the merge function returning bool was an accident? Exactly, well-spotted! Matthias ___ bro-dev mailing list bro-dev@bro.org http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev

[Bro-Dev] Bloom filter interface

2013-06-04 Thread Matthias Vallentin
I'm the process of devising Bro's new Bloom filter interface and would like to have your feedback on the BiFs. This is what I came up with so far: (1) bloomfilter_init(fp: double, capacity: count, max: count): opaque of bloomfilter (2) bloomfilter_add(bf: opaque of bloomfilter, x: any) (3)