Re: Various improvements to tests/run-all
> > I am attaching patch against tests/run-all with the hope that the > > changes can be accepted upstream. The patch should be self explanatory. > > For completeness here are the errors I saw before I erased SHELLOPTS > > variable > > I can see doing this. From the error messages in your message, it seems > like you enable posix mode via SHELLOPTS. The tests definitely don't > expect to be run in posix mode. Makes sense. > As for your other suggestions, bash-4.4 doesn't use /tmp/xx; that's a > remnant from previous versions. bash-4.4 sets, exports, and uses > $BASH_TSTOUT. That's my next goal - remove as many local patches as possible from our bash build. And I'm happy that this is first one :) > Also, sh is just used to run each test harness (e.g., > run-redir). All of those scripts run the actual test scripts using > $THIS_SH, so there's no real gain to using $THIS_SH there. I _think_ that there was problem with running the actual 'run_*' scripts using 'real' sh. But I don't see the problem now, so another local change to loose I think. Thank you -- Vlad
Re: Various improvements to tests/run-all
On 12/1/16 3:21 PM, Vladimir Marek wrote: > Hi, > > I am attaching patch against tests/run-all with the hope that the > changes can be accepted upstream. The patch should be self explanatory. > For completeness here are the errors I saw before I erased SHELLOPTS > variable I can see doing this. From the error messages in your message, it seems like you enable posix mode via SHELLOPTS. The tests definitely don't expect to be run in posix mode. As for your other suggestions, bash-4.4 doesn't use /tmp/xx; that's a remnant from previous versions. bash-4.4 sets, exports, and uses $BASH_TSTOUT. Also, sh is just used to run each test harness (e.g., run-redir). All of those scripts run the actual test scripts using $THIS_SH, so there's no real gain to using $THIS_SH there. Chet -- ``The lyf so short, the craft so long to lerne.'' - Chaucer ``Ars longa, vita brevis'' - Hippocrates Chet Ramey, UTech, CWRUc...@case.eduhttp://cnswww.cns.cwru.edu/~chet/
