[Bug binutils/13300] out-of-bounds memcpy in peXXigen.c
http://sourceware.org/bugzilla/show_bug.cgi?id=13300 --- Comment #3 from Pascal.Stumpf at cubes dot de 2011-10-25 13:47:10 UTC --- Well yeah, of course this will work here (FILNMLEN being used only at those two places). But it's still very prone to break in other places due to the design of those include files. I wonder what the reasoning might have been to override FILNMLEN in coff/pe.h (even #undefining it in case it already exists), even if it has already been used in a declaration. In the meantime, do I have permission to use your patch under GPLv2 (important for backporting)? -- Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ bug-binutils mailing list bug-binutils@gnu.org https://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug binutils/13300] out-of-bounds memcpy in peXXigen.c
http://sourceware.org/bugzilla/show_bug.cgi?id=13300 --- Comment #4 from Nick Clifton nickc at redhat dot com 2011-10-25 15:53:29 UTC --- Hi Pascal, Well yeah, of course this will work here (FILNMLEN being used only at those two places). But it's still very prone to break in other places due to the design of those include files. I wonder what the reasoning might have been to override FILNMLEN in coff/pe.h (even #undefining it in case it already exists), even if it has already been used in a declaration. Agreed. It was mainly because I do not know the answer to this question that I was reluctant to change the definitions of FILNMLEN. In the meantime, do I have permission to use your patch under GPLv2 (important for backporting)? Yes, you do. Cheers Nick -- Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ bug-binutils mailing list bug-binutils@gnu.org https://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug binutils/13300] out-of-bounds memcpy in peXXigen.c
http://sourceware.org/bugzilla/show_bug.cgi?id=13300 --- Comment #1 from Nick Clifton nickc at redhat dot com 2011-10-24 16:04:54 UTC --- Created attachment 6030 -- http://sourceware.org/bugzilla/attachment.cgi?id=6030 Fix memcpys -- Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ bug-binutils mailing list bug-binutils@gnu.org https://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug binutils/13300] out-of-bounds memcpy in peXXigen.c
http://sourceware.org/bugzilla/show_bug.cgi?id=13300 Nick Clifton nickc at redhat dot com changed: What|Removed |Added Status|NEW |WAITING CC||nickc at redhat dot com --- Comment #2 from Nick Clifton nickc at redhat dot com 2011-10-24 16:06:50 UTC --- Hi Pascal, Defining FILNMLEN in only one place would be good, but I am worried that tampering with those header files might break something. So instead, what do you think of the uploaded patch which should fix the memcpys instead ? Cheers Nick -- Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ bug-binutils mailing list bug-binutils@gnu.org https://lists.gnu.org/mailman/listinfo/bug-binutils
