[Bug binutils/20666] [libopcodes][Aarch64] BFI instruction decoded as bad BFC instruction

2017-02-22 Thread cvs-commit at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=20666

--- Comment #4 from cvs-commit at gcc dot gnu.org  ---
The master branch has been updated by Jan Beulich :

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=11648de5a91658326748dea1e4965559e9bd7a0f

commit 11648de5a91658326748dea1e4965559e9bd7a0f
Author: Jan Beulich 
Date:   Wed Feb 22 10:36:05 2017 +0100

aarch64: actually copy first operand in convert_bfc_to_bfm()

Commit 93562a343c ("[AArch64] PR target/20666, fix wrong encoding of
new introduced BFC pseudo") changed the destination operand to 0,
making the whole function invocation a no-op. We really want to copy
operand 0 (a register) to operand 1 (an immediate before coming here),
even if right now this likely is only a latent bug.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug binutils/20666] [libopcodes][Aarch64] BFI instruction decoded as bad BFC instruction

2016-10-11 Thread jiwang at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=20666

Jiong Wang  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #3 from Jiong Wang  ---
Since ARMv8.2-A, we introduced new pseduo instruction "BFC [Wd/Xd], LSB, WIDTH"
as an alias of "BFI [Wd|Xd], [WZR/XZR], LSB, WIDTH".

And if the bit source operand if WZR/XZR, BFC is the preferred disassembly
output.

Now, AArch64 GAS do support "bfc w26, #7, #22", but you need to specify
-march=armv8.2-a (There are discussions for whether we should also support
"BFC" in GAS in pre-8.2 architecture
https://sourceware.org/ml/binutils/2015-12/msg00067.html)

Meanwhile for those "BFI [Wd|Xd], [WZR/XZR], LSB, WIDTH" in pre-8.2 binary, the
latest disassembler will print "BFC" for them.

Thanks for reporting this, I actually noticed the encoding for the new AArch64
BFC pseudo is wrong, fixed by above commit.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug binutils/20666] [libopcodes][Aarch64] BFI instruction decoded as bad BFC instruction

2016-10-11 Thread cvs-commit at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=20666

--- Comment #2 from cvs-commit at gcc dot gnu.org  ---
The master branch has been updated by Jiong Wang :

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=93562a343c26f67d2bd0e93cceb18a0a793087c2

commit 93562a343c26f67d2bd0e93cceb18a0a793087c2
Author: Jiong Wang 
Date:   Tue Oct 11 11:24:44 2016 +0100

[AArch64] PR target/20666, fix wrong encoding of new introduced BFC pseudo

opcode/
PR target/20666
* aarch64-asm.c (convert_bfc_to_bfm): Fix dest index.

gas/
* testsuite/gas/aarch64/alias-2.d: Update expected results.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug binutils/20666] [libopcodes][Aarch64] BFI instruction decoded as bad BFC instruction

2016-10-05 Thread jiwang at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=20666

Jiong Wang  changed:

   What|Removed |Added

 Target||aarch64*
 CC||jiwang at gcc dot gnu.org
Version|2.26|2.28 (HEAD)
   Assignee|unassigned at sourceware dot org   |jiwang at gcc dot 
gnu.org

--- Comment #1 from Jiong Wang  ---
I will investigate this.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils