bug#24232: [PATCH] ls: postpone installation of signal handlers

2016-09-06 Thread Pádraig Brady
On 06/09/16 18:18, Jim Meyering wrote: > On Tue, Sep 6, 2016 at 10:05 AM, Paul Eggert wrote: >> On 09/06/2016 08:59 AM, Pádraig Brady wrote: >>> >>> Will push later. >> >> >> Before pushing, can you please change the name of "sigs" back to "sig"? I >> prefer the old name, as "sig[i]" clearly means

bug#24232: [PATCH] ls: postpone installation of signal handlers

2016-09-06 Thread Jim Meyering
On Tue, Sep 6, 2016 at 10:05 AM, Paul Eggert wrote: > On 09/06/2016 08:59 AM, Pádraig Brady wrote: >> >> Will push later. > > > Before pushing, can you please change the name of "sigs" back to "sig"? I > prefer the old name, as "sig[i]" clearly means "signal i", whereas "sigs[i]" > is more confusi

bug#24232: [PATCH] ls: postpone installation of signal handlers

2016-09-06 Thread Paul Eggert
On 09/06/2016 08:59 AM, Pádraig Brady wrote: Will push later. Before pushing, can you please change the name of "sigs" back to "sig"? I prefer the old name, as "sig[i]" clearly means "signal i", whereas "sigs[i]" is more confusing. (This is one of my pet peeves about array names.) Thanks.

bug#24232: [PATCH] ls: postpone installation of signal handlers

2016-09-06 Thread Pádraig Brady
On 06/09/16 16:38, Kamil Dudka wrote: > ... until they are actually needed. That is right before the first > escape sequence is printed to a terminal. Cool, that's a good improvement. Note I moved the NEWS from "bugs" to "improvements". Also I tweaked a long line to avoid `make syntax-check` fail

bug#24232: [PATCH] ls: postpone installation of signal handlers

2016-09-06 Thread Kamil Dudka
... until they are actually needed. That is right before the first escape sequence is printed to a terminal. * src/ls.c (sigs): Moved from main() to global scope to make it available in put_indicator(), too. Renamed to prevent identifier clashes with parameters of subsequent function definitions