Re: [PATCH] ls: with -LR, exit with status 2 upon detecting a cycle

2009-09-29 Thread Jim Meyering
Pádraig Brady wrote: > Jim Meyering wrote: >> Jim Meyering wrote: >>> Here's a fix to make ls -LR work the same way Solaris 10's /bin/ls >>> does in the presence of a cycle. > > It makes sense to exit(2) along with the printed error. > The patch looks good. Thanks for the review.

Re: [PATCH] ls: with -LR, exit with status 2 upon detecting a cycle

2009-09-28 Thread Pádraig Brady
Jim Meyering wrote: > Jim Meyering wrote: >> Here's a fix to make ls -LR work the same way Solaris 10's /bin/ls >> does in the presence of a cycle. It makes sense to exit(2) along with the printed error. The patch looks good. cheers, Pádraig.

Re: [PATCH] ls: with -LR, exit with status 2 upon detecting a cycle

2009-09-28 Thread Jim Meyering
Date: Mon, 28 Sep 2009 18:29:02 +0200 Subject: [PATCH] ls: with -LR, exit with status 2 upon detecting a cycle * src/ls.c (print_dir): Diagnosing the cycle is not enough. Also set exit status to 2. This is what Solaris' /bin/ls does, too. * tests/ls/infloop: Rework test: match both expected

[PATCH] ls: with -LR, exit with status 2 upon detecting a cycle

2009-09-28 Thread Jim Meyering
Here's a fix to make ls -LR work the same way Solaris 10's /bin/ls does in the presence of a cycle. >From fb245d0be6231f2962d1481d032b77f3211b29de Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Mon, 28 Sep 2009 18:29:02 +0200 Subject: [PATCH] ls: with -LR, exit with status 2 upo