Re: [PATCH] ls: with -LR, exit with status 2 upon detecting a cycle

2009-09-29 Thread Jim Meyering
Pádraig Brady wrote: > Jim Meyering wrote: >> Jim Meyering wrote: >>> Here's a fix to make ls -LR work the same way Solaris 10's /bin/ls >>> does in the presence of a cycle. > > It makes sense to exit(2) along with the printed error. > The patch looks good. Thanks for the review.

Re: [PATCH] ls: with -LR, exit with status 2 upon detecting a cycle

2009-09-28 Thread Pádraig Brady
Jim Meyering wrote: > Jim Meyering wrote: >> Here's a fix to make ls -LR work the same way Solaris 10's /bin/ls >> does in the presence of a cycle. It makes sense to exit(2) along with the printed error. The patch looks good. cheers, Pádraig.

Re: [PATCH] ls: with -LR, exit with status 2 upon detecting a cycle

2009-09-28 Thread Jim Meyering
Jim Meyering wrote: > Here's a fix to make ls -LR work the same way Solaris 10's /bin/ls > does in the presence of a cycle. I've tweaked the patch to udpate the documentation, too. >From 9fad0c69f218a57c9404f7c1137961eec5a818f1 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Mon, 28 Sep 2009 1