RE: Patch for making CommitID configurable

2005-04-28 Thread Torsten Martinsen
Mark D. Bausche wrote: > There are a number of tools and utilities that use RCS which may have > problems: > > ViewCVS > CVSWeb > SmartCVS > TortoiseCVS > > but I suspect that all of them have already run across the CVSNT > commitid and are handling it correctly. Indeed, TortoiseCVS is

Re: Patch for making CommitID configurable

2005-04-27 Thread Peter Backes
Hello, On 27 Apr 2005 at 18:11, Derek Price wrote: > This information doesn't need to be processed in any non-opaque way > once created, but uniqueness is an argument. Once created, it can be > passed, basically, as a tag to CVS, at which point only uniqueness > matters. not where the unique val

Re: Patch for making CommitID configurable

2005-04-27 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Peter Backes wrote: >Hello, > >On 27 Apr 2005 at 12:48, Mark D. Baushke wrote: > >>>(long)time(NULL), getpid(): not portable. >> >>That one requires supporting documentation. >> >>Which platforms do not provide them? CVSNT and CVS both use them >>exte

Re: Patch for making CommitID configurable

2005-04-27 Thread Peter Backes
Hello, On 27 Apr 2005 at 12:48, Mark D. Baushke wrote: > > (long)time(NULL), getpid(): not portable. > That one requires supporting documentation. > > Which platforms do not provide them? CVSNT and CVS both use them > extensively across all of our supported platforms. I can only say that Standa

Re: Patch for making CommitID configurable

2005-04-27 Thread Peter Backes
Hello, On 27 Apr 2005 at 12:31, Mark D. Baushke wrote: > Summary: I can see the (marginal) utility of adding a way to avoid > creating new commitid tags in the RCS files of the CVS repository. I can > not see any benefit in supressing new CVS functionality for revisions of > files that use them.

Re: Patch for making CommitID configurable

2005-04-27 Thread Mark D. Baushke
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Peter Backes <[EMAIL PROTECTED]> writes: > On 27 Apr 2005 at 11:08, Mark D. Baushke wrote: > > > global_session_id = Xasprintf ("%x%08lx%04x", (int)getpid(), > > (long)time (NULL), rand()&0x); > > (long)time

Re: Patch for making CommitID configurable

2005-04-27 Thread Mark D. Baushke
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Derek Price <[EMAIL PROTECTED]> writes: > Just a note, I already agreed to commit Peter's patch some days ago in > this thread, with the change that I was going to make the default > behavior leaving commitID enabled, with his config key able to turn

Re: Patch for making CommitID configurable

2005-04-27 Thread Derek Price
Mark D. Baushke wrote: > >Even if it isn't, I don't see why it shouldn't be possible to apply > >my patch to let the user decide what he wants. What is currently > >being done is that users are forced to have CommitIDs even if they > >don't want them (for whatever reason). This cannot be right.

Re: Patch for making CommitID configurable

2005-04-27 Thread Peter Backes
Hello, On 27 Apr 2005 at 11:08, Mark D. Baushke wrote: > global_session_id = Xasprintf ("%x%08lx%04x", (int)getpid(), > (long)time (NULL), rand()&0x); (long)time(NULL), getpid(): not portable. rand()&0x: makes commit IDs probabilistic, not unique. W

Re: Patch for making CommitID configurable

2005-04-27 Thread Mark D. Baushke
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Peter Backes <[EMAIL PROTECTED]> writes: > On 27 Apr 2005 at 3:21, Mark D. Baushke wrote: > > > It may be worth noting that CVSNT has had this feature for a long time > > and moving to adopt it satisfies a minor goal of trying to reduce the > > separ

RE: Patch for making CommitID configurable

2005-04-27 Thread Peter Backes
Hello, On 27 Apr 2005 at 11:23, Jim.Hyslop wrote: > Peter, it is clear that you and I have fundamentally different, and > probably irreconcilable, approaches and philosophies on software > development. These differences are extremely unlikely to be resolved in > this forum. I know, and this is

RE: Patch for making CommitID configurable

2005-04-27 Thread Jim.Hyslop
Peter Backes wrote: [a lot of stuff] > Just see TeX. Without doubt, and you will surely agree, one of the > best programs, perhaps the best program, ever written. I've used it. Can't stand it. I don't have the time, nor the patience, to learn all the arcane commands you need to know in order to

Re: Patch for making CommitID configurable

2005-04-27 Thread Peter Backes
Hi, On 27 Apr 2005 at 3:21, Mark D. Baushke wrote: > It may be worth noting that CVSNT has had this feature for a long time > and moving to adopt it satisfies a minor goal of trying to reduce the > separation and entropy between the major CVSNT fork of CVS and the CVS > that cvshome offers. I ag

RE: Patch for making CommitID configurable

2005-04-27 Thread Peter Backes
Hello, On 26 Apr 2005 at 16:02, Jim.Hyslop wrote: > Peter Backes wrote: > > Just think about what *is* the big advantage of CVS besides working > > on RCS files instead of a strange ever-changing file format? > "ever-changing"? I think you're exaggerating here. When was the last > time the RCS f

Re: Patch for making CommitID configurable

2005-04-27 Thread Mark D. Baushke
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Peter, Jim has already mentioned some things about why the commitid code may be useful. It may be worth noting that CVSNT has had this feature for a long time and moving to adopt it satisfies a minor goal of trying to reduce the separation and ent

RE: Patch for making CommitID configurable

2005-04-26 Thread Jim.Hyslop
Peter Backes wrote: > Just think about what *is* the big advantage of CVS besides working > on RCS files instead of a strange ever-changing file format? "ever-changing"? I think you're exaggerating here. When was the last time the RCS file format changed? What's the point in having the rcsfile(5)

Re: Patch for making CommitID configurable

2005-04-26 Thread Mark D. Baushke
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Derek Price <[EMAIL PROTECTED]> writes: > Mark D. Baushke wrote: > > I am given to understand that WebCVS and ViewCVS can run 'rcs' commands > > like rlog as a way to glean information out of the local repository > > without running 'cvs' commands on

Re: Patch for making CommitID configurable

2005-04-26 Thread Derek Price
Mark D. Baushke wrote: > Derek Price <[EMAIL PROTECTED]> writes: > > >Peter Backes wrote: > > >>On 21 Apr 2005 at 10:02, Derek Price wrote: > >> > >>>I really want to make this the default behavior, even after an > >>>upgrade. Would this do the trick for you? > >> > >>What do you mean exactly? n

Re: Patch for making CommitID configurable

2005-04-26 Thread Peter Backes
On 26 Apr 2005 at 0:25, Mark D. Baushke wrote: > Derek Price <[EMAIL PROTECTED]> writes: > > I'm not sure I believe that. I think most people would prefer to not > > have to jump through any hoops to see new features enabled, especially > > when dealing with feature releases, and I don't think al

Re: Patch for making CommitID configurable

2005-04-26 Thread Mark D. Baushke
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Derek Price <[EMAIL PROTECTED]> writes: > Peter Backes wrote: > >On 21 Apr 2005 at 10:02, Derek Price wrote: > >>I really want to make this the default behavior, even after an > >>upgrade. Would this do the trick for you? > > > >What do you mean exac

Re: Patch for making CommitID configurable

2005-04-25 Thread Peter Backes
Hi, On 21 Apr 2005 at 10:02, Derek Price wrote: > I really want to make this the default behavior, even after an > upgrade. Would this do the trick for you? What do you mean exactly? new->use_commit_id = true instead of false, i.e. have commit IDs written even for old repositories after an u