Re: size_max

2009-10-06 Thread Simon Josefsson
Bruno Haible writes: > I now have no objection against removing just size_max.h, if it's > reasonably documented how to use the m4/size_max.m4 macros. That > essentially means to copy its contents to the 'Include' section of the > module description. Proposed changed patch (plus the NEWS paragrap

Re: SIZE_MAX

2009-10-06 Thread Simon Josefsson
Bruno Haible writes: > I explained why the size_max module is needed. But I have no problems with > discouraging its use: I think that will help -- I believe I pulled in the size_max module into one of my projects by mistake, where I should have used stdint instead. I think better documentation

Re: test-open failure on Hurd

2009-10-06 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Eric Blake on 10/2/2009 6:32 PM: > I'll let others decide how Hurd will fix /dev/null, or if a fix is even > necessary. But meanwhile, the point of test-open was to test that opening > a non-directory with a trailing slash fails, not whet

Re: new modules getopt-posix, getopt-gnu

2009-10-06 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Bruno Haible on 8/12/2009 5:24 PM: > To make all this clearer, I'm introducing 'getopt-posix' and 'getopt-gnu' > modules, in the same way as we did for 'fnmatch'. Ultimately 'getopt-posix' > should be renamed to 'getopt', but this cannot b

Re: getopt compilation failure on Darwin (gzip 1.3.13)

2009-10-06 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Eric Blake on 10/6/2009 11:04 AM: > Ludovic Courtès gnu.org> writes: > >> GNU zip 1.3.13 fails to build on Darwin: > This is a sign that our #include_next of darwin's worked, but that > darwin's header recursively includes some other h

Re: How to get isblank?

2009-10-06 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Bruno Haible on 10/6/2009 3:15 PM: >> Sorry if I'm being dense, but perhaps there's an opportunity for >> clarification here? > > The relevant documentation in gnulib for this function is in the file > doc/posix-functions/isblank.texi: >

Re: Possible m4-1.4.13 issue

2009-10-06 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 [adding bug-gnulib, since the gnulib test-ftello test failed] According to Tim Wood on 10/6/2009 11:40 AM: > TWIMC: > > Platform info: > Linux axolotl.home.tim.wood.name 2.4.20-30.7.legacy #1 Fri Feb 20 > test-ftello.c:119: assertion failed > ./test

Re: size_max

2009-10-06 Thread Bruno Haible
Eric Blake wrote: > > Hello? You propose to remove a file that is in use by other files in gnulib, > > without explaining what to do with the other files. ?! > > No. Reread the proposal. The size_max module stays, and the used file > m4/size_max.m4 remains available for use. The unused file li

Re: size_max

2009-10-06 Thread Bruno Haible
Simon Josefsson wrote: > I recall some reports about SIZE_MAX problem anyway, but it may > because of config.h or size_max.m4 issues. You reported a problem in this area, and it was fixed immediately: . > Also, any application

Re: size_max

2009-10-06 Thread Eric Blake
Bruno Haible clisp.org> writes: > > +2009-10-06 Simon Josefsson josefsson.org> > > + > > + * lib/size_max.h: Remove file. > > + * modules/size_max: Drop size_max.h. > > + * NEWS: Explain. > > Hello? You propose to remove a file that is in use by other files in gnulib, > without explaini

Re: size_max

2009-10-06 Thread Bruno Haible
Jim Meyering wrote: > AFAICS, gettext and xsize are the only gnulib modules that use it, > so deprecating size_max sounds like a good idea, assuming > Bruno doesn't mind adjusting those two modules. In why it is important for vas

Re: SIZE_MAX

2009-10-06 Thread Bruno Haible
Simon Josefsson wrote: > > I suppose these should include stdint.h also? > > > > areadlink.c:# define SIZE_MAX ((size_t) -1) > > areadlink-with-size.c:# define SIZE_MAX ((size_t) -1) > > backupfile.c:# define SIZE_MAX ((size_t) -1) > > fnmatch.c:# define SIZE_MAX ((size_t) -1) > > quotearg.c:# defi

Re: How to get isblank?

2009-10-06 Thread Reuben Thomas
2009/10/6 Bruno Haible : > Reuben Thomas wrote: >> As far as I can see, there is an implementation of isblank in gnulib >> for systems that lack it, but I can't see how I'm supposed to use it: >> I can see the module c-ctypes which seems to be specifically for the C >> locale, and unictype/ctype-bl

Re: How to get isblank?

2009-10-06 Thread Bruno Haible
Reuben Thomas wrote: > As far as I can see, there is an implementation of isblank in gnulib > for systems that lack it, but I can't see how I'm supposed to use it: > I can see the module c-ctypes which seems to be specifically for the C > locale, and unictype/ctype-blank module, which mentions > "g

Re: getopt compilation failure on Darwin (gzip 1.3.13)

2009-10-06 Thread Eric Blake
Ludovic Courtès gnu.org> writes: > GNU zip 1.3.13 fails to build on Darwin: > > --8<---cut here---start->8--- > gcc -std=gnu99 -DHAVE_CONFIG_H -I. -g -O2 -c getopt.c > In file included from ./getopt.h:28, > from getopt.h:28, >

getopt compilation failure on Darwin (gzip 1.3.13)

2009-10-06 Thread Ludovic Courtès
Hello, (Cc’ing ‘bug-gnulib’ as this looks like a Gnulib issue.) GNU zip 1.3.13 fails to build on Darwin: --8<---cut here---start->8--- gcc -std=gnu99 -DHAVE_CONFIG_H -I. -g -O2 -c getopt.c In file included from ./getopt.h:28, from getopt.h

Re: size_max

2009-10-06 Thread Simon Josefsson
Eric Blake writes: > Simon Josefsson josefsson.org> writes: > >> So how about this patch? >> >> Of course, stdint.h has to define SIZE_MAX on these systems to make sure >> it will still work. But I suppose we'll notice if it doesn't already. > > stdint.in.h already takes care of SIZE_MAX. Yes

Re: size_max

2009-10-06 Thread Eric Blake
Simon Josefsson josefsson.org> writes: > So how about this patch? > > Of course, stdint.h has to define SIZE_MAX on these systems to make sure > it will still work. But I suppose we'll notice if it doesn't already. stdint.in.h already takes care of SIZE_MAX. > +2009-10-06 Simon Josefsson j

fcntl-h race

2009-10-06 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 fcntl_h.m4 has a race, because I just completed a run of ./gnulib-tool - --with-tests on GNU/Hurd where: > In file included from ../../gltests/test-string.c:19: > ./config.h:326:1: warning: "HAVE_WORKING_O_NOATIME" redefined > In file included from ./

How to get isblank?

2009-10-06 Thread Reuben Thomas
As far as I can see, there is an implementation of isblank in gnulib for systems that lack it, but I can't see how I'm supposed to use it: I can see the module c-ctypes which seems to be specifically for the C locale, and unictype/ctype-blank module, which mentions "generalisation", though it's not

Re: new snapshot available: coreutils-7.6.63-addb6

2009-10-06 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Jim Meyering on 10/6/2009 5:01 AM: >> However given that SIZE_MAX should be in stdint.h according to POSIX, >> maybe it makes more sense to make sure gnulib's stdint.h replacement is >> enabled when SIZE_MAX is not provided by the system's

size_max

2009-10-06 Thread Simon Josefsson
Jim Meyering writes: >> However given that SIZE_MAX should be in stdint.h according to POSIX, >> maybe it makes more sense to make sure gnulib's stdint.h replacement is >> enabled when SIZE_MAX is not provided by the system's stdint.h? And >> then deprecate size_max.h in favor of stdint. > > AFA

Re: new snapshot available: coreutils-7.6.63-addb6

2009-10-06 Thread Jim Meyering
Simon Josefsson wrote: > Pádraig Brady writes: ... >> I suppose these should include stdint.h also? >> >> areadlink.c:# define SIZE_MAX ((size_t) -1) >> areadlink-with-size.c:# define SIZE_MAX ((size_t) -1) >> backupfile.c:# define SIZE_MAX ((size_t) -1) >> fnmatch.c:# define SIZE_MAX ((size_t) -1

Re: new snapshot available: coreutils-7.6.63-addb6

2009-10-06 Thread Simon Josefsson
Pádraig Brady writes: > Jim Meyering wrote: >> Pádraig Brady wrote: >> >>> Jim Meyering wrote: Eric Blake wrote: > According to Pádraig Brady on 10/5/2009 3:53 PM: > This is a new test, but FC5 is s old, > that I'm not sure it's worth worrying about. March 2

Re: new snapshot available: coreutils-7.6.63-addb6

2009-10-06 Thread Pádraig Brady
Paolo Bonzini wrote: > On 10/06/2009 11:05 AM, Pádraig Brady wrote: >> Also a minor nit in s/Linux/Gnu\/Linux/ > > Definitely not when it's talking explicitly of a kernel version? Right, it could be "GNU/Linux" or "Linux kernels? (.*)?" cheers, Pádraig.

Re: new snapshot available: coreutils-7.6.63-addb6

2009-10-06 Thread Pádraig Brady
Jim Meyering wrote: > Pádraig Brady wrote: > >> Jim Meyering wrote: >>> Eric Blake wrote: According to Pádraig Brady on 10/5/2009 3:53 PM: This is a new test, but FC5 is s old, that I'm not sure it's worth worrying about. >>> March 2006? >> The failure is probabl

Re: new snapshot available: coreutils-7.6.63-addb6

2009-10-06 Thread Paolo Bonzini
On 10/06/2009 11:05 AM, Pádraig Brady wrote: Also a minor nit in s/Linux/Gnu\/Linux/ Definitely not when it's talking explicitly of a kernel version? Paolo

Re: new snapshot available: coreutils-7.6.63-addb6

2009-10-06 Thread Jim Meyering
Pádraig Brady wrote: > Jim Meyering wrote: >> Eric Blake wrote: >>> According to Pádraig Brady on 10/5/2009 3:53 PM: >>> This is a new test, but FC5 is s old, >>> that I'm not sure it's worth worrying about. >> March 2006? > The failure is probably a function of the kernel. >>>

Re: new snapshot available: coreutils-7.6.63-addb6

2009-10-06 Thread Pádraig Brady
Jim Meyering wrote: > Eric Blake wrote: >> According to Pádraig Brady on 10/5/2009 3:53 PM: >> This is a new test, but FC5 is s old, >> that I'm not sure it's worth worrying about. > March 2006? The failure is probably a function of the kernel. Which is it? >>> In summary

Re: new snapshot available: coreutils-7.6.63-addb6

2009-10-06 Thread Jim Meyering
Eric Blake wrote: > According to Pádraig Brady on 10/5/2009 3:53 PM: > This is a new test, but FC5 is s old, > that I'm not sure it's worth worrying about. March 2006? >>> The failure is probably a function of the kernel. >>> Which is it? >> >> In summary this is what fails: >> >>