* m4/extern-inline.m4 (gl_EXTERN_INLINE): __header_inline is defined in
but the header is not included and as result
_GL_EXTERN_INLINE doesn't work as intended on macOS.
Signed-off-by: Roman Bolshakov
---
Hi,
The issue prevents -O1/-O0 compilation of libtasn1 on macOS:
https://gitlab.com
On Thu, Dec 13, 2018 at 06:34:51PM +0300, Roman Bolshakov wrote:
> Hello,
>
> There was an issue with syntax-check on FreeBSD reported a few years
> ago:
> https://www.redhat.com/archives/libvir-list/2015-August/msg00758.html
> http://lists.gnu.org/archive/html/bug-gnulib/201
grep we don't get the messages in syntax-check:
prohibit_diagnostic_without_format
grep: empty (sub)expression
grep: empty (sub)expression
grep: empty (sub)expression
grep: empty (sub)expression
grep: empty (sub)expression
grep: empty (sub)expression
Signed-off-by: Roman Bolshakov
_ARG_MAX
- removed "-n" flag in xargs invocations
- added /dev/null as an extra file for uniform grep output regardless of
number of files. The file isn't added if grep invocation has "-L" flag
- added dependency on AC_PROG_GREP to modules/maintainer-makefile
--
Best regards,
ds default value for "-s"
flag (max-chars), xargs will feed less arguments than max-args.
Signed-off-by: Roman Bolshakov
---
top/maint.mk | 135 ---
1 file changed, 86 insertions(+), 49 deletions(-)
diff --git a/top/maint.mk b/top/main
On Wed, Dec 12, 2018 at 07:42:44PM -0600, Eric Blake wrote:
> On 12/12/18 3:13 PM, Roman Bolshakov wrote:
>
> > > > @@ -845,7 +853,10 @@ sc_prohibit_always-defined_macros:
> > > > case $$(echo all: | grep -l -f - Makefile) in Makefile);; *)
> >
On Tue, Dec 04, 2018 at 04:10:08PM -0600, Eric Blake wrote:
> On 12/3/18 9:00 AM, Roman Bolshakov wrote:
> > $(VC_LIST_EXCEPT) is usually expanded into arguments for a command.
> > When a project contains too many, some operating systems can't pass all
> > the arguments becau
On Tue, Dec 04, 2018 at 01:44:42AM +0100, Bruno Haible wrote:
> Roman Bolshakov wrote:
> > - added /dev/null as an extra file for uniform grep output regardless of
> > number of files. The file isn't added if grep invocation has "-L" flag
>
> Good point. And
On Tue, Dec 04, 2018 at 04:14:04PM -0600, Eric Blake wrote:
> On 12/3/18 9:00 AM, Roman Bolshakov wrote:
> > : Filter by file name; \
> > if test -n "$$in_files"; then \
> > - fi
ds default value for "-s"
flag (max-chars), xargs will feed less arguments than max-args.
Signed-off-by: Roman Bolshakov
---
top/maint.mk | 53 +---
1 file changed, 34 insertions(+), 19 deletions(-)
diff --git a/top/maint.mk b/top/main
grep we don't get the messages in syntax-check:
prohibit_diagnostic_without_format
grep: empty (sub)expression
grep: empty (sub)expression
grep: empty (sub)expression
grep: empty (sub)expression
grep: empty (sub)expression
grep: empty (sub)expression
Signed-off-by: Roman Bolshakov
ency on AC_PROG_GREP to modules/maintainer-makefile
--
Best regards,
Roman
Roman Bolshakov (2):
maint.mk: Split long argument lists
maint.mk: Replace grep with $(GREP)
modules/maintainer-makefile | 1 +
top/maint.mk| 145
2 files ch
On Sun, Dec 02, 2018 at 01:31:03PM +0100, Bruno Haible wrote:
> Roman Bolshakov wrote:
> > I'm quite new to gnulib but thanks to Eric and your comments that should do
> > it:
> >
> > diff --git a/modules/maintainer-makefile b/modules/maintainer-makefile
> >
On Sun, Dec 02, 2018 at 01:26:52PM +0100, Bruno Haible wrote:
> Roman Bolshakov wrote:
> > But then we will need to correct calculation of VC_ARG_MAX. We can take
> > formulae from [2]:
> > expr `getconf ARG_MAX` - `env|wc -c` - `env|egrep '^[^ ]+='|wc -l` \* 4 -
>
On Mon, Dec 03, 2018 at 08:16:22AM +0100, Bernhard Voelker wrote:
> On 11/30/18 12:14 PM, Roman Bolshakov wrote:
> > May I ask you to review what way we should go with ARG_MAX?
> >
> > I'm okay with both ways whether it's:
> > * computing effective argument length an
Hi Bruno,
May I ask you to review what way we should go with ARG_MAX?
I'm okay with both ways whether it's:
* computing effective argument length and passing it to "-s" option;
* or exploiting behaviour of GNU/BSD xargs and specifying "-n" beyond
the limit.
Thank you,
Roman
On Tue, Nov 27, 2018 at 07:47:12PM +0100, Bruno Haible wrote:
> Eric Blake wrote:
> > > In other words, can you guarantee that $(GREP) will never expand to empty?
> >
> > If we change gl_INIT() to AC_REQUIRE([AC_PROG_GREP]), then that should
> > be sufficient to ensure $(GREP) is set by the time
On Tue, Nov 27, 2018 at 07:40:24PM +0100, Bruno Haible wrote:
> Roman Bolshakov wrote:
> > if test -n "$$files"; then
> > \
> > if test -n "$$prohibit"; then
On Tue, Nov 27, 2018 at 07:19:43PM +0100, Bruno Haible wrote:
> Hi,
>
> > The workaround is to split argument list into chunks that operating
> > system can process. "getconf ARG_MAX" is used to determine size of the
> > chunk.
>
> Two questions on this:
>
> 1) People say that 'getconf ARG_MAX'
5d5f55e.60...@redhat.com
Signed-off-by: Roman Bolshakov
---
top/maint.mk | 55 ++--
1 file changed, 36 insertions(+), 19 deletions(-)
diff --git a/top/maint.mk b/top/maint.mk
index 4889ebacc..c4f21f947 100644
--- a/top/maint.mk
+++ b/top/maint.mk
@@ -
grep we don't get the messages in syntax-check:
prohibit_diagnostic_without_format
grep: empty (sub)expression
grep: empty (sub)expression
grep: empty (sub)expression
grep: empty (sub)expression
grep: empty (sub)expression
grep: empty (sub)expression
Signed-off-by: Roman Bolshakov
changes on libvirt side I can run make syntax-check on macOS.
I wasn't entirely sure on indentation in the long commands. I did my best,
sorry if something is wrong.
--
Best regards,
Roman
Roman Bolshakov (2):
maint.mk: Split long argument lists
maint.mk: Replace grep with $(GREP)
top
22 matches
Mail list logo
