Re: [PATCH] gnulib-tool.py: Append, don't replace existing VCS ignore files

2017-11-21 Thread Darshit Shah
Thanks! * Dmitry Selyutin [171120 20:17]: > Hi Darshit, > > I've just pushed your patch. I took the liberty to > format it as if it was sent via git format-patch. > Thank you again! -- Thanking You, Darshit Shah PGP Fingerprint: 7845 120B 07CB D8D6 ECE5 FF2B 2A17

Re: [PATCH] gnulib-tool.py: Append, don't replace existing VCS ignore files

2017-11-20 Thread Dmitry Selyutin
Hi Darshit, I've just pushed your patch. I took the liberty to format it as if it was sent via git format-patch. Thank you again! signature.asc Description: This is a digitally signed message part.

Re: [PATCH] gnulib-tool.py: Append, don't replace existing VCS ignore files

2017-11-20 Thread Darshit Shah
Hi Dmitry, That's perfectly fine. Long as I know that it is being looked into, it's okay. There's always so many things that are going on and other items often take priority. No issues. * Dmitry Selyutin [171120 06:40]: > Hi Darshit, > > the reason is actually very

Re: [PATCH] gnulib-tool.py: Append, don't replace existing VCS ignore files

2017-11-19 Thread Dmitry Selyutin
Hi Darshit, the reason is actually very simple: I just had no time to apply it due to activities on a regular work. Hopefully I'll continue developing gnulib-tool in the end of this week. The patch seems to be OK though; I'll try to push it this evening. Thank you again and sorry for the delay.

Re: [PATCH] gnulib-tool.py: Append, don't replace existing VCS ignore files

2017-11-19 Thread Darshit Shah
It's been a while. Atleast some response on why it isn't being accepted would be appreciated * Darshit Shah [171113 09:07]: > Hi, > > Is there something blocking this patch? It doesn't seem like it has been > merged > yet. > > * Darshit Shah

Re: [PATCH] gnulib-tool.py: Append, don't replace existing VCS ignore files

2017-11-13 Thread Darshit Shah
Hi, Is there something blocking this patch? It doesn't seem like it has been merged yet. * Darshit Shah [170913 00:19]: > * Dmitry Selyutin [170911 21:32]: > > Hi all, > > > > > As explained above, this patch helps converge gnulib-tool.py and > >

Re: [PATCH] gnulib-tool.py: Append, don't replace existing VCS ignore files

2017-09-12 Thread Darshit Shah
* Dmitry Selyutin [170911 21:32]: > Hi all, > > > As explained above, this patch helps converge gnulib-tool.py and > > gnulib-tool. There is a behavioural difference which I also consider to > > be a regression, and hence a string need to fix it. > Thanks for the patch!

Re: [PATCH] gnulib-tool.py: Append, don't replace existing VCS ignore files

2017-09-11 Thread Dmitry Selyutin
Hi all, > As explained above, this patch helps converge gnulib-tool.py and > gnulib-tool. There is a behavioural difference which I also consider to > be a regression, and hence a string need to fix it. Thanks for the patch! Looks perfectly fine from my side. Could you push it into the

Re: [PATCH] gnulib-tool.py: Append, don't replace existing VCS ignore files

2017-09-11 Thread Darshit Shah
Hi Bruno, > Hi Darshit, > > > * pygnulib/GLImport.py(_update_ignorelist_): Append the ignore data to > > any existing VCS ignore files instead of replacing them > > We cannot judge this patch, for lack of information about what it does and > why it is needed. Sorry, I meant to have a detailed

Re: [PATCH] gnulib-tool.py: Append, don't replace existing VCS ignore files

2017-09-11 Thread Bruno Haible
Hi Darshit, > * pygnulib/GLImport.py(_update_ignorelist_): Append the ignore data to > any existing VCS ignore files instead of replacing them We cannot judge this patch, for lack of information about what it does and why it is needed. 1) What is the problem with the current behaviour of

Re: [PATCH] gnulib-tool.py: Append, don't replace existing VCS ignore files

2017-09-11 Thread Darshit Shah
* Eric Blake [170911 14:00]: > On 09/11/2017 06:49 AM, Darshit Shah wrote: > > * pygnulib/GLImport.py(_update_ignorelist_): Append the ignore data to > > any existing VCS ignore files instead of replacing them > > --- > > pygnulib/GLImport.py | 4 ++-- > > 1 file changed, 2

Re: [PATCH] gnulib-tool.py: Append, don't replace existing VCS ignore files

2017-09-11 Thread Eric Blake
On 09/11/2017 06:49 AM, Darshit Shah wrote: > * pygnulib/GLImport.py(_update_ignorelist_): Append the ignore data to > any existing VCS ignore files instead of replacing them > --- > pygnulib/GLImport.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

[PATCH] gnulib-tool.py: Append, don't replace existing VCS ignore files

2017-09-11 Thread Darshit Shah
* pygnulib/GLImport.py(_update_ignorelist_): Append the ignore data to any existing VCS ignore files instead of replacing them --- pygnulib/GLImport.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pygnulib/GLImport.py b/pygnulib/GLImport.py index 4352a7ec5..b0e3ec655