do not set errno after failing malloc [Re: getline() behaviour change

2007-08-23 Thread Jim Meyering
Bruno Haible [EMAIL PROTECTED] wrote: Jim Meyering wrote: Are you advocating support for non-POSIX malloc/realloc? Sure. gnulib supports - to a large extent - mingw. It uses a malloc implementation from msvcrt.dll. This malloc does not set errno. You're dumbing down gnulib to accommodate

Re: getline() behaviour change

2007-08-23 Thread Jim Meyering
Ben Pfaff [EMAIL PROTECTED] wrote: Bruno Haible [EMAIL PROTECTED] writes: Jim Meyering wrote: A *lot* of code expects malloc and realloc to set errno when they fail. Such code is not portable to plain ISO C 99 systems. We could extend gnulib's existing malloc/realloc wrappers to ensure

Re: getline.h

2007-08-23 Thread Jim Meyering
Eric Blake [EMAIL PROTECTED] wrote: According to Eric Blake on 8/22/2007 6:04 PM: According to Bruno Haible on 8/22/2007 3:02 PM: Hi Eric, Thanks for working on this, and for the unit tests. The patch - excluding the one of getdelim.c - is nearly perfect. But I see three problems: Thanks

Re: getline.h

2007-08-23 Thread Simon Josefsson
Jim Meyering [EMAIL PROTECTED] writes: [is this ok with you, Simon? ] Yes, please add it. /Simon

Re: Multiply exported Gnulib symbols

2007-08-23 Thread Simon Josefsson
Bruno Haible [EMAIL PROTECTED] writes: 3) Two different libraries, say, libguile and libgettextpo, using auxiliary functions from gnulib. It may happen that libguile and libgettextpo both define rpl_strcasecmp, and that this leads to link-time issues. For this we have nothing

Re: getline.h

2007-08-23 Thread Jim Meyering
Simon Josefsson [EMAIL PROTECTED] wrote: Jim Meyering [EMAIL PROTECTED] writes: [is this ok with you, Simon? ] Yes, please add it. Committed.

xreadlink: Rewrite as a simple mreadlink wrapper.

2007-08-23 Thread Jim Meyering
I did most of this weeks ago and just noticed I never checked it in. Ok with you, Bruno? Rewrite xreadlink as a trivial mreadlink wrapper. * lib/xreadlink.c (xreadlink): Rewrite as a simple mreadlink wrapper. * modules/xreadlink: Adjust dependencies. Index:

getline.h removal fixes

2007-08-23 Thread Simon Josefsson
Committed. /Simon Index: ChangeLog === RCS file: /sources/gnulib/gnulib/ChangeLog,v retrieving revision 1.1900 diff -u -p -r1.1900 ChangeLog --- ChangeLog 23 Aug 2007 08:33:16 - 1.1900 +++ ChangeLog 23 Aug 2007 15:44:00

adding vasprintf pulls in vasnprintf

2007-08-23 Thread Simon Josefsson
Hi! GnuTLS uses vasprintf (in just one place...) so I depend on the vasprintf module. On glibc systems, vasprintf exists and is properly detected: checking for vasprintf... yes However, the vasprintf module depends unconditionally on vasnprintf, see gnulib/modules/vasprintf: Depends-on: