Re: [libvirt] Fwd: libvirtd failing on MacOS in setgroups

2019-09-30 Thread Daniel P . Berrangé
On Mon, Sep 30, 2019 at 02:06:07PM +0200, Bruno Haible wrote: > Daniel P. Berrangé wrote: > > > > FWIW I compiled libvirt without the setgroups code on Mac and it > > > > worked as expected. Not sure what the implications of that are though? > > > > &

Re: [libvirt] Fwd: libvirtd failing on MacOS in setgroups

2019-09-30 Thread Daniel P . Berrangé
On Sat, Sep 28, 2019 at 01:36:15PM +0200, Bruno Haible wrote: > Marcus Furlong wrote: > > FWIW I compiled libvirt without the setgroups code on Mac and it > > worked as expected. Not sure what the implications of that are though? > > OK, then the fix would be to not use setgroups on Mac, and nothi

Re: [libvirt] [PATCH] maint: update to latest gnulib

2018-07-17 Thread Daniel P . Berrangé
On Tue, Jul 17, 2018 at 10:14:18AM +0200, Andrea Bolognani wrote: > On Sat, 2018-07-14 at 09:20 +0200, Michal Privoznik wrote: > > The changelog is quite long because we haven't updated gnulib in > > a while. Anyway, among the new changes you'll find GCC 8 support, > > faster build time, mingw fixe

Regression in ffs() detection on mingw

2018-07-16 Thread Daniel P . Berrangé
Libvirt just updated to gnulib 5b78831df03b49408676227604cf16f90dee07ac, from our previous snapshot d6397dde2e127e246e3eeb5254a21f42cac783c8. Since doing that we see failure to build on mingw32/64 platforms due to missing ffs() function util/virrandom.c: In function 'virRandomInt': util/virra

Re: test-poll failing on FreeBSD 10/11

2018-05-15 Thread Daniel P . Berrangé
On Mon, May 14, 2018 at 11:49:55PM -0700, Pádraig Brady wrote: > On 08/05/18 09:40, Daniel P. Berrangé wrote: > > Libvirt CI recently started running "make check" on our FreeBSD 10 & 11 > > hosts, and we see frequent failure of the test-poll unit test in gnulib >

test-poll failing on FreeBSD 10/11

2018-05-08 Thread Daniel P . Berrangé
Libvirt CI recently started running "make check" on our FreeBSD 10 & 11 hosts, and we see frequent failure of the test-poll unit test in gnulib IIUC, gnulib is not actually building a replacement poll() function on FreeBSD, it is merely running the gnulib test suite against the FreeBSD system impl

Re: fseeko broken by Fedora rawhide glibc / git master (ie future 2.28)

2018-03-07 Thread Daniel P . Berrangé
On Wed, Mar 07, 2018 at 09:05:59AM -0600, Eric Blake wrote: > On 03/05/2018 01:25 PM, Paul Eggert wrote: > > On 03/05/2018 11:20 AM, Daniel P. Berrangé wrote: > > > Yes, this worked on rawhide when I tested with libvirt. > > > > Thanks, I installed it into Gnuli

Re: fseeko broken by Fedora rawhide glibc / git master (ie future 2.28)

2018-03-05 Thread Daniel P . Berrangé
On Mon, Mar 05, 2018 at 11:00:40AM -0800, Paul Eggert wrote: > On 03/05/2018 04:19 AM, Daniel P. Berrangé wrote: > > I'm curious why we're trying to replace fseeko impl at all, since I > > would expect the modern glibc impl to be suitable to use as-is. > > It'

Re: [libvirt] fseeko broken by Fedora rawhide glibc / git master (ie future 2.28)

2018-03-05 Thread Daniel P . Berrangé
On Mon, Mar 05, 2018 at 12:19:24PM +, Daniel P. Berrangé wrote: > Fedora rawhide has just upgraded to the latest glibc git master snapshot, > of what will become the 2.28 release, and this has exposed bugs in gnulib's > fseeko.c implementation (and probably more macros) besides.

fseeko broken by Fedora rawhide glibc / git master (ie future 2.28)

2018-03-05 Thread Daniel P . Berrangé
Fedora rawhide has just upgraded to the latest glibc git master snapshot, of what will become the 2.28 release, and this has exposed bugs in gnulib's fseeko.c implementation (and probably more macros) besides. The issue starts are line 50: http://git.savannah.gnu.org/cgit/gnulib.git/tree/lib/fs