Re: bug#16843: Error caused due to regression in git

a and b, while retaining the double space between c and d. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org -- Thanking You, Darshit Shah

gperf 3.1 breaks module unicase

changing the prototype will cause builds to fail with older versions of gperf. -- Thanking You, Darshit Shah PGP Fingerprint: 7845 120B 07CB D8D6 ECE5 FF2B 2A17 43ED A91A 35B6 signature.asc Description: PGP signature

Re: gperf 3.1 breaks module unicase

Sure, if making such a change is okay, I can prepare the patch quickly. I will also go through all the other gperf files in the repository and update their respective prototypes as well. * Paul Eggert <egg...@cs.ucla.edu> [170213 17:15]: On 02/13/2017 07:24 AM, Darshit Shah wrote:

Re: gperf 3.1 breaks module unicase

I've attached a simple patch that fixes the build on my end. This simply assumes the latest version of Gperf is used to generate the files. * Paul Eggert <egg...@cs.ucla.edu> [170213 17:15]: On 02/13/2017 07:24 AM, Darshit Shah wrote: simply changing the prototype will cause builds t

Higher accuracy output from human_readable()

point up to 10 MiB. Beyond that, the function always returns a value without any decimal points. I would like the function to always return a value with 2 decimal points, even if it means returning xx.00 MiB for example. How can I achieve this using the module? -- Thanking You, Darshit Shah PGP

Re: Feature Request: Implement glibc reallocarray() function

* Paul Eggert <egg...@cs.ucla.edu> [170813 09:15]: Darshit Shah wrote: what is the first NetBSD version that includes `reallocarray`? I would say NetBSD 8. But that's not what the text is about. The text doesn't talk about the first NetBSD version that includes 'reallocarray'. It

Re: Feature Request: Implement glibc reallocarray() function

patch was made perfectly. And also to deal with my broken MUA configuration for a while, not to mention my editor which is set to use tabs and I kept forgetting to change it for the gnulib code. Now, I have a better idea of how ti work with gnulib even for my own projects. -- Thanking You, D

Re: Feature Request: Implement glibc reallocarray() function

test-calloc-gnu.c. I've updated it with the sample you provided and added another test to ensure that the correct errno is set as well. -- Thanking You, Darshit Shah PGP Fingerprint: 7845 120B 07CB D8D6 ECE5 FF2B 2A17 43ED A91A 35B6 From 2b618ad315124e302d74affd1fd3a95135339799 Mon Sep 17 00:00:0

Re: Feature Request: Implement glibc reallocarray() function

* Paul Eggert <egg...@cs.ucla.edu> [170810 23:23]: Darshit Shah wrote: This page was written in 2015. However, on netbsd.org, NetBSD 7.1 is the current latest release. Also, when exactly do we consider reallocarray being available in NetBSD since the page only states that the rede

Re: Feature Request: Implement glibc reallocarray() function

ning a prototype for reallocarray(). Where did I go wrong / what did I miss? I don't see a problem. IMO $ ./gnulib-tool --test reallocarray should work fine. Let's debug it when you've resubmitted once more. Bruno -- Thanking You, Darshit Shah PGP Fingerprint: 7845 120B 07CB D8D6 ECE5 FF2B 2A17 43E

Re: Feature Request: Implement glibc reallocarray() function

You're right. I missed that part. Here's an updated version * Paul Eggert <egg...@cs.ucla.edu> [170809 11:58]: Darshit Shah wrote: +This function is missing on all non-glibc platforms: glibc 2.25 No, as I mentioned it's present in the three main BSD platforms. Please change "al

Re: Feature Request: Implement glibc reallocarray() function

https://www.gnu.org/software/gnulib/manual/html_node/Writing-modules.html -- Thanking You, Darshit Shah PGP Fingerprint: 7845 120B 07CB D8D6 ECE5 FF2B 2A17 43ED A91A 35B6 From c47f7e2a300d9cf4a4163e29bc3329bd9508c9e5 Mon Sep 17 00:00:00 2001 From: Darshit Shah <dar...@gmail.com> Date: Tue,

Re: Feature Request: Implement glibc reallocarray() function

selves. This is done through an invocation of AC_USE_SYSTEM_EXTENSIONS from within m4/reallocarray.m4. Bruno -- Thanking You, Darshit Shah PGP Fingerprint: 7845 120B 07CB D8D6 ECE5 FF2B 2A17 43ED A91A 35B6 From 85b855a446cf0f634627f03b3bb10694ac419c74 Mon Sep 17 00:00:00 2001 From: Darshit Sha

Re: Feature Request: Implement glibc reallocarray() function

carray() without defining _GNU_SOURCE by themselves. This is done through an invocation of AC_USE_SYSTEM_EXTENSIONS from within m4/reallocarray.m4. Bruno -- Thanking You, Darshit Shah PGP Fingerprint: 7845 120B 07CB D8D6 ECE5 FF2B 2A17 43ED A91A 35B6 From 3a5a5ffdfc215b4ee0bee2383097bd2e1cbebd1b M

Feature Request: Implement glibc reallocarray() function

this function within in gnulib. If someone will willing to help me out / give me pointers on what would be required to implement this within gnulib, I will happily port the code from glibc to gnulib and submit a completed patch. -- Thanking You, Darshit Shah PGP Fingerprint: 7845 120B 07CB D8D6 ECE5

Re: gnulib-tool.py

is usually discouraged, and my guess is exactly what the commit hooks are catching on to. You could try to set your editor to highlight such spaces or even to delete them on saving a file. Or you could use a regex like: `s/\s\+$//g` to remove all the trailing whitespaces -- Thanking You, Darshit Shah PGP Fingerprint: 7845 120B 07CB D8D6 ECE5 FF2B 2A17 43ED A91A 35B6 signature.asc Description: PGP signature

gnulib-tool.py adds new files to project tests/ directory

these are now added to the project directories? -- Thanking You, Darshit Shah PGP Fingerprint: 7845 120B 07CB D8D6 ECE5 FF2B 2A17 43ED A91A 35B6 signature.asc Description: PGP signature

[PATCH] gnulib-tool.py: Append, don't replace existing VCS ignore files

* pygnulib/GLImport.py(_update_ignorelist_): Append the ignore data to any existing VCS ignore files instead of replacing them --- pygnulib/GLImport.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pygnulib/GLImport.py b/pygnulib/GLImport.py index 4352a7ec5..b0e3ec655

Re: [PATCH] gnulib-tool.py: Append, don't replace existing VCS ignore files

and > gnulib-tool > evolve in sync. That is, any new feature of gnulib-tool should be a new > feature of gnulib-tool.py, and vice versa. > I understand this very well. I've been following the mailing lists and the development of gnulib-tool.py. Dmitry's work with the Python script h

Re: [PATCH] gnulib-tool.py: Append, don't replace existing VCS ignore files

* Eric Blake <ebl...@redhat.com> [170911 14:00]: > On 09/11/2017 06:49 AM, Darshit Shah wrote: > > * pygnulib/GLImport.py(_update_ignorelist_): Append the ignore data to > > any existing VCS ignore files instead of replacing them > > --- > > pygnulib/GLImport.p

Re: [PATCH] gnulib-tool.py: Append, don't replace existing VCS ignore files

s, I've just rewritten what was created before in another > language. :-) Anyway, thank you for your kind words! > > > -- > With best regards, > Dmitry Selyutin Bruno, Could you please push this patch to master? -- Thanking You, Darshit Shah PGP Fingerprint: 7845 120B 07CB D8D6 ECE5 FF2B 2A17 43ED A91A 35B6 signature.asc Description: PGP signature

Re: [PATCH] gnulib-tool.py: Append, don't replace existing VCS ignore files

Hi, Is there something blocking this patch? It doesn't seem like it has been merged yet. * Darshit Shah <darnirml...@gmail.com> [170913 00:19]: > * Dmitry Selyutin <ghostman...@gmail.com> [170911 21:32]: > > Hi all, > > > > > As explained above, this

Re: [PATCH] gnulib-tool.py: Append, don't replace existing VCS ignore files

Thanks! * Dmitry Selyutin <ghostman...@gmail.com> [171120 20:17]: > Hi Darshit, > > I've just pushed your patch. I took the liberty to > format it as if it was sent via git format-patch. > Thank you again! -- Thanking You, Darshit Shah PGP Fingerprint: 7845 120B 07C

Re: [PATCH] gnulib-tool.py: Append, don't replace existing VCS ignore files

It's been a while. Atleast some response on why it isn't being accepted would be appreciated * Darshit Shah <darnirml...@gmail.com> [171113 09:07]: > Hi, > > Is there something blocking this patch? It doesn't seem like it has been > merged > yet. > > * Darshit

Re: [PATCH] gnulib-tool.py: Append, don't replace existing VCS ignore files

> 20 нояб. 2017 г. 2:53 ДП пользователь "Darshit Shah" <darnirml...@gmail.com> > написал: > > It's been a while. Atleast some response on why it isn't being accepted > would > be appreciated > > * Darshit Shah <darnirml...@gmail.com> [171113 09:07]: > >

gnulib-tool.py does not write the gitignore file correctly

this please be fixed? It's not a major issue, just a minor inconvenience. -- Thanking You, Darshit Shah PGP Fingerprint: 7845 120B 07CB D8D6 ECE5 FF2B 2A17 43ED A91A 35B6 signature.asc Description: PGP signature

Re: Change the python interpretor to use /usr/bin/env python3

Which Fedora release and architecture, and > > what > > What is the output of 'ls -l /usr/bin/python*' and of 'dnf list --installed > > 'python*''? That sort of thing. I don't understand why '#!/usr/bin/python' > > would > > fail at the same time that '#!/usr/bin/env python' worked. Thanks. > > > > -- Thanking You, Darshit Shah PGP Fingerprint: 7845 120B 07CB D8D6 ECE5 FF2B 2A17 43ED A91A 35B6 signature.asc Description: PGP signature

Change the python interpretor to use /usr/bin/env python3

the shebang line to `/usr/bin/env python3`, this can be eliminated. I don't mind if you would like to keep it as `/usr/bin/env python` to use the python2 interpretor by default either. -- Thanking You, Darshit Shah PGP Fingerprint: 7845 120B 07CB D8D6 ECE5 FF2B 2A17 43ED A91A 35B6 From

Re: Fix crash in gnulib-tool.py under Python 2.6 and lower

* Tim Rühsen [181014 15:07]: > On 13.10.18 23:19, Darshit Shah wrote: > > Well, I don't think there will be a Python 4 for a very long time. The major > > version number changes only for a large backwards incompatibility. It's > > taken > > them ~10 years and p

Fix crash in gnulib-tool.py under Python 2.6 and lower

of the script also uses 2.7+ syntax. Hence, I have also added a check to the script to exit out if the version of Python being used is less than 2.7. -- Thanking You, Darshit Shah PGP Fingerprint: 7845 120B 07CB D8D6 ECE5 FF2B 2A17 43ED A91A 35B6 From de43800deb2fa524eea054d1e8b7185814d58dbb Mon Sep

Add support for using the experimental pygnulib tool

adds a new option to botstrap.conf that allows the developers to enable the new Python version of the gnulib tool. -- Thanking You, Darshit Shah PGP Fingerprint: 7845 120B 07CB D8D6 ECE5 FF2B 2A17 43ED A91A 35B6 From 5ceff6bed76fb11ba6b70c1cc62b230c54cbc6e9 Mon Sep 17 00:00:00 2001 From: Darshit

Re: Fix crash in gnulib-tool.py under Python 2.6 and lower

the minimum version number. * Tim Rühsen [181013 23:05]: > On 13.10.18 21:28, Darshit Shah wrote: > > gnulib-tool.py will currently crash immediately on start if the underlying > > Python version is 2.6 or lower. The immediate crash that is seen occurs > > during > > the c

Re: Fix crash in gnulib-tool.py under Python 2.6 and lower

rchive/html/bug-gnulib/2017-09/msg00123.html > > Bruno > > -- Thanking You, Darshit Shah PGP Fingerprint: 7845 120B 07CB D8D6 ECE5 FF2B 2A17 43ED A91A 35B6 signature.asc Description: PGP signature

Re: Add support for using the experimental pygnulib tool

Given that pygnulib aims to support on Python 3, maybe we should change this patch slightly to also provide for a way to fallback if the python version fails? Any ideas on how it should be implemented? * Darshit Shah [181013 22:03]: > We at GNU Wget have been using the new Python implementat

Re: [RFC] Adding a real HashTable implementation to gnulib

missing in the implementation in GNU PSPP is the ability to grow the size of the table based on a certain threshold of "fullness". * Ben Pfaff [181127 00:41]: > On Tue, Nov 27, 2018 at 12:16:16AM +0100, Darshit Shah wrote: > > I recently tried to use the hash table implementat

Re: gnupload: fix Shellcheck warnings

ective >$dbg cp $files $base.directive.asc $dest_host > @@ -404,7 +404,7 @@ upload () > stmt= > if test -n "$symlink_files"; then >stmt="$stmt > -`mksymlink $symlink_files`" > +$(mksymlink $symlink_files)" > fi > > for file

[RFC] Adding a real HashTable implementation to gnulib

could extract that code and turn it into a hash table module for gnulib. We should be able to reuse some part of the existing code in "hash.c" for this purpose as well -- Thanking You, Darshit Shah PGP Fingerprint: 7845 120B 07CB D8D6 ECE5 FF2B 2A17 43ED A91A 35B6 signature.asc Description: PGP signature

Re: Fix more typos

On January 12, 2019 12:21:36 PM UTC, "Dmitry V. Levin" wrote: >On Sat, Jan 12, 2019 at 12:00:47PM +0100, Tim Rühsen wrote: >> Used a spell checker (codespell) to wipe out several typos. >[...] >> diff --git a/build-aux/texinfo.tex b/build-aux/texinfo.tex >> index 48d532bc6..74bea4134 100644 >>

Re: Emacs time stamp hook

he comment below states that the line **MUST** be within the first eight lines of the file. Assuming that this was just a minor oversight, I reported it. Do we really need these timestamp lines when everything is source-controlled using git? Can we just remove it all? -- Thanking You, Darshit Shah PGP

Re: Alpine: useless-if-before-free: Exec format error

through /bin/sh. When executed by > +# perl, the next two lines are a no-op. > +eval 'exec perl -wSx "$0" "$@"' > + if 0; > + > # Generate a release announcement message. > > my $VERSION = '2018-03-07 03:46'; # UTC Won't this break the emacs times

sc_prohibit_magic_number_exit false positive on string

(0|77),|[^,]*)|"(usage|exit|error).*"' \ -- Thanking You, Darshit Shah PGP Fingerprint: 7845 120B 07CB D8D6 ECE5 FF2B 2A17 43ED A91A 35B6 signature.asc Description: PGP signature

Re: sc_prohibit_magic_number_exit false positive on string

* Jim Meyering [190908 17:19]: > On Sun, Sep 8, 2019 at 6:06 AM Darshit Shah wrote: > > I just realized that the syntax check rule sc_prohibit_magic_number_exit > > will > > cause a false positive when it finds the relevant tokens within a string as > > well. >

Wget bootstrapping problem

Hence, I request that the patch be reverted. We could switch the order such that Wget is the default and rsync is used as a fallback, but that allows us to build Wget without already needing a Wget binary from somewhere else. Thanking You, Darshit Shah

Re: Wget bootstrapping problem

The problem happens when you try to run ./bootstrap on a fresh git checkout. The bootstrap script tries to sync the updated translations before running configure. What Bruno suggests is that Wget sets SKIP_PO=1 in the bootstrap script and then updates the translations during build time. This

Re: Bootstrap with old Python

On 8/21/20 10:57 AM, Jeffrey Walton wrote: On Fri, Aug 21, 2020 at 4:45 AM Bruno Haible wrote: Hi Jeffrey, I'm testing Wget2. I believe it uses Gnulib from master. Older Python does not respond to 'python --version': Unknown option: -- usage: python [option] ... [-c cmd | file | -]

Re: [PATCH 1/3] posix: Remove alloca usage on regex set_regs

Hi, Since this patch has been applied, GNU Wget fails during the linking stage due to regmatch_list_free not being available: /usr/bin/ld: ../lib/libgnu.a(regex.o): in function `set_regs': /home/rincewind/Programming/wget/lib/regexec.c:1444: undefined reference to `regmatch_list_free'

Re: [PATCH] Allow setting CVS username for gnu-web-doc-update

Hi Bruno, Yes, the account is active, but I didn't mean to use it for the commit. I just forgot to set the user.email for the gnulib repo. For all GNU projects, I still use the dar...@gnu.org email. On Sat, Jan 9, 2021, at 13:01, Bruno Haible wrote: > Hi Darshit, > > > I would like to apply

[PATCH] Allow setting CVS username for gnu-web-doc-update

I would like to apply the attached patch to Gnulib in order to improve how gnu-web-doc-update works. >From 0fe04a57a1f4476e6d893ddee973805b15ca9338 Mon Sep 17 00:00:00 2001 From: Darshit Shah Date: Sat, 9 Jan 2021 11:42:26 +0100 Subject: [PATCH] Allow setting CVS username for gnu-web-doc-upd

Re: different CFLAGS for gnulib code?

On 15.01.21 12:11, Paul Eggert wrote: > On 1/15/21 12:55 AM, Bruno Haible wrote: >> Would compiling the gnulib >> part with options for fewer warnings be OK with you? > > Not only is it OK, it's routine. Coreutils, Emacs, etc. do it. > Wget does the same thing as well. I treat gnulib as

Re: [PATCH] build-aux/announce-gen: Use Release keyrings on Savannah for GnuPG

at the end. It's late at night, and I shouldn't have sent the patch when semi-asleep. I'll fix the issue and send a new version later in the day. On Tue, Mar 8, 2022, at 00:45, Darshit Shah wrote: > * build-aux/announce-gen: The default SKS Keyserver pool for GnuPG Keys was > deprecated a

[PATCH] build-aux/announce-gen: Use Release keyrings on Savannah for GnuPG

insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index e3f0ed216c..c2ea26f5ca 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,14 @@ +2022-03-08 Darshit Shah + + build-aux/announce-gen: Use Release keyrings on Savannah for GnuPG + * build-aux/announce-gen: The default SKS

[PATCH] build-aux/announce-gen: Use Release keyrings on Savannah for GnuPG

+ b/ChangeLog @@ -1,3 +1,14 @@ +2022-03-08 Darshit Shah + + build-aux/announce-gen: Use Release keyrings on Savannah for GnuPG + * build-aux/announce-gen: The default SKS Keyserver pool for GnuPG Keys was + deprecated and has been offline since the middle of 2021. The defa

Re: [PATCH] build-aux/announce-gen: Use Release keyrings on Savannah for GnuPG

On Sun, Mar 13, 2022, at 09:10, Simon Josefsson wrote: > Darshit Shah writes: > >> + --gpg-keyring-url=URLURL pointing to the GnuPG Keyring containing >> +the key used to sign the tarballs > ... >> If that command f

[PATCH] modules/unicase/special-casing: Fix compilation error

changed, 8 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 49a1e6a168..55442c84dd 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2022-02-25 Darshit Shah + + modules/unicase/special-casing: Fix compilation error + * modules/unicase/special-casing: Don

Re: planning for beta-testing gnulib-tool.py

Hi Bruno and Colin, I'm following the development of gnulib-tool.py pretty closely. Wget and Wget2 have tried to use the Python version multiple times in the past with varying levels of success. I'll volunteer my time for using GNU Wget and Wget2 as initial beta testers of the new Python

Re: what can we expect from developers

Hi Bruno, I think you make some fair points on the contributions made by people with a passable knowledge of the language. However, when I said "maintained", I kind of assumed that there will be someone with a good enough command over the language who will be the arbiter of what patches get

Re: Python Iterable

On Wed, Mar 27, 2024, at 17:52, Bruno Haible wrote: > Collin Funk wrote: >> I have also made a conscious choice not to use more abstract >> collections like 'Iterable' even though they are recommended [4]. >> >> The first is because some functions check the type: >> >> def