Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain

2009-05-25 Thread H. Langos
On Sun, May 24, 2009 at 10:22:17PM +0200, Richard van den Berg wrote: > On 5/24/09 2:33 AM, H. Langos wrote: >> One thing to keep in mind is that the --min-vol-adj and --max-vol-adj now >> only affect the RVA/RVAD tag information instead of something extracted >> from RVA2 tags. (I need to update

Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain

2009-05-24 Thread Richard van den Berg
On 5/24/09 2:33 AM, H. Langos wrote: One thing to keep in mind is that the --min-vol-adj and --max-vol-adj now only affect the RVA/RVAD tag information instead of something extracted from RVA2 tags. (I need to update the help text about that.) Since RVA2 now changes the SoundCheck field in

Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain

2009-05-23 Thread H. Langos
On Sat, May 23, 2009 at 01:11:41PM +0200, Richard van den Berg wrote: > On 5/22/09 11:38 PM, H. Langos wrote: >> Just commited it all to CVS. >> Please take a look and see if it does the right thing for your music >> collection. >> > > Great. It works fine with my mp3s (that just contain ReplayG

Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain

2009-05-23 Thread Richard van den Berg
On 5/22/09 11:38 PM, H. Langos wrote: Just commited it all to CVS. Please take a look and see if it does the right thing for your music collection. Great. It works fine with my mp3s (that just contain ReplayGain info in APE tags). Let me know if you find any bugs. I looked over the

Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain

2009-05-22 Thread H. Langos
Hi Richard, On Sun, May 10, 2009 at 10:35:57AM +0200, Richard van den Berg wrote: > On 5/10/09 1:35 AM, H. Langos wrote: >> I guess we should go this way: >> >> 1. Use RVA2/XRVA or (if the former is missing) REPLAY_GAIN_x to compute a >>new "soundcheck" value. >> >> If the first step didn't y

Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain

2009-05-12 Thread H. Langos
On Sat, May 09, 2009 at 08:34:57PM +0200, H. Langos wrote: > > Yes. We would leave volume alone and go for soundcheck instead. > > We would stop using that crude one byte and start using that 32bit dBm > value. At least thats what it is supposed to encode. > > I just greped through my mp3s and I

Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain

2009-05-11 Thread H. Langos
Hi Richard, On Sun, May 10, 2009 at 10:53:42PM +0200, H. Langos wrote: > On Sun, May 10, 2009 at 10:35:57AM +0200, Richard van den Berg wrote: > > > Do you want to wait until we have a all of the above working before you > > commit my current ReplayGain patches to CVS? > > I hope I get around

Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain

2009-05-10 Thread H. Langos
On Sun, May 10, 2009 at 10:35:57AM +0200, Richard van den Berg wrote: > On 5/10/09 1:35 AM, H. Langos wrote: >> I guess we should go this way: >> >> 1. Use RVA2/XRVA or (if the former is missing) REPLAY_GAIN_x to compute a >>new "soundcheck" value. >> >> If the first step didn't yield any info

Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain

2009-05-10 Thread Richard van den Berg
On 5/10/09 1:35 AM, H. Langos wrote: I guess we should go this way: 1. Use RVA2/XRVA or (if the former is missing) REPLAY_GAIN_x to compute a new "soundcheck" value. If the first step didn't yield any information: 2. Use iTunNORM's "soundcheck" value and RVA "volume" adjustment. This wou

Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain

2009-05-09 Thread H. Langos
On Sat, May 09, 2009 at 12:13:01PM +0200, Richard van den Berg wrote: > On 5/9/09 9:14 AM, Frank Blendinger wrote: >> I'll talk to the mpd developers to see if they are willing to support >> RVA2/RGAD and/or APE tags. > > I used mpd before switching to a Squeezebox. IIRC it is written in perl. >

Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain

2009-05-09 Thread H. Langos
On Sat, May 09, 2009 at 05:29:50PM +0200, Richard van den Berg wrote: > Since you already came to the conclusion that mp3gain is about the only > implementation of the Replay Gain algorithm, I'm sure it uses 89dB as > well. From mp3gain.c: > >> /* the TAG version of the suggested Track Gain sho

Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain

2009-05-09 Thread H. Langos
On Sat, May 09, 2009 at 06:37:19PM +0200, Richard van den Berg wrote: > On 5/9/09 6:01 PM, H. Langos wrote: >> The volume attribute however is limited in its scale. it can only go from >> -100% to +100%. The lower bound is ok as it represents silence, but the >> upper bound is BS as it only allows

Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain

2009-05-09 Thread Richard van den Berg
On 5/9/09 6:01 PM, H. Langos wrote: The volume attribute however is limited in its scale. it can only go from -100% to +100%. The lower bound is ok as it represents silence, but the upper bound is BS as it only allows gains of 6dB. Very good point, I didn't think of that. Quite a shame to li

Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain

2009-05-09 Thread H. Langos
Hi Frank, On Fri, May 08, 2009 at 12:14:53PM +0200, Frank Blendinger wrote: > > On Thu 2009-05-07 21:16, Richard van den Berg > proclaimed: > > On 5/7/09 5:06 PM, H. Langos wrote: > >> What's important is the fact that there seems to be a standard that defines > >> how volume adjustment data can

Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain

2009-05-09 Thread Richard van den Berg
On 5/9/09 4:41 PM, H. Langos wrote: Well, the gain is given in dB relative to a reference level that most times is 83dB (But sometimes might be 89dB. The nasty details are here: http://www.mars.org/mailman/public/mad-dev/2004-February/000993.html ) I assume that mp3gain uses 83dB. But it wouldn't

Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain

2009-05-09 Thread H. Langos
Sorry about that. It's fixed now. cheers -henrik On Sat, May 09, 2009 at 01:04:15PM +0200, Richard van den Berg wrote: > On 5/8/09 2:26 PM, H. Langos wrote: >> BTW: I just added XRVA support as it is a too simple to let it pass. >> > > Always test before commit. ;-) > > Global symbol "%hs" req

Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain

2009-05-09 Thread H. Langos
On Fri, May 08, 2009 at 04:16:45PM +0200, Richard van den Berg wrote: > On 5/8/09 2:26 PM, H. Langos wrote: >> Yeap. And if mp3gain can't be changed to do write RVA2 tags by itself, >> maybe there is a way to make mp3gain only do the analysis and pass its >> result to a programm that can write th

Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain

2009-05-09 Thread Richard van den Berg
On 5/9/09 9:14 AM, Frank Blendinger wrote: [...] gnupod_convert_OGG.pl uses Ogg::Vorbis::Header which may or may not support the RG tags. If you send me an ogg file (privately) that contains RG info I can check (and patch gnupod_convert_OGG.pl). I've sent you a private mail on this, it

Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain

2009-05-09 Thread Richard van den Berg
On 5/8/09 2:26 PM, H. Langos wrote: BTW: I just added XRVA support as it is a too simple to let it pass. Always test before commit. ;-) Global symbol "%hs" requires explicit package name at /opt/local/lib/perl5/5.8.9/darwin-2level/GNUpod/FileMagic.pm line 542. $hs{RVA2} = $hs->{XRVA} if

Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain

2009-05-09 Thread Richard van den Berg
On 5/9/09 9:14 AM, Frank Blendinger wrote: I'll talk to the mpd developers to see if they are willing to support RVA2/RGAD and/or APE tags. I used mpd before switching to a Squeezebox. IIRC it is written in perl. If they are using MP3::Info adding APE support is easy; just add an extra option

Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain

2009-05-09 Thread Frank Blendinger
Hello Richard. On Fri 2009-05-08 13:30, Richard van den Berg proclaimed: > On 5/8/09 12:14 PM, Frank Blendinger wrote: >> You might want to take a look at this python script: >> http://mpd.wikia.com/wiki/Hack:ape2id3.py >> >> It will read the ReplayGain settings from APE tags and add it to ID3v2

Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain

2009-05-08 Thread Richard van den Berg
On 5/8/09 2:26 PM, H. Langos wrote: Could you send me a sample of an iTunes generated RVA2 tag? Sure. I'll fire up iTunes later and send it to you privately. Yeap. And if mp3gain can't be changed to do write RVA2 tags by itself, maybe there is a way to make mp3gain only do the analysis and pa

Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain

2009-05-08 Thread H. Langos
On Thu, May 07, 2009 at 09:16:51PM +0200, Richard van den Berg wrote: > On 5/7/09 5:06 PM, H. Langos wrote: >> What's important is the fact that there seems to be a standard that defines >> how volume adjustment data can be stored in id3 tags. > > Nice research. RVA2 is definitely the standard to u

Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain

2009-05-08 Thread Richard van den Berg
On 5/8/09 12:14 PM, Frank Blendinger wrote: You might want to take a look at this python script: http://mpd.wikia.com/wiki/Hack:ape2id3.py It will read the ReplayGain settings from APE tags and add it to ID3v2 tags. It has worked without any problems for me so far. That script seems to crea

Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain

2009-05-08 Thread Frank Blendinger
Hey guys, I'm very pleased to know you are working on ReplayGain support in gnupod. I have just recently started to add ReplayGain tags to my music collection, as mpd has started to support that. Now it seems I can also benefit from this in my iPod, very nice. On Thu 2009-05-07 21:16, Richard va

Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain

2009-05-07 Thread Richard van den Berg
On 5/7/09 5:06 PM, H. Langos wrote: Nowerdays I wouldn't let it come anywhere near my iPod. :-) I'm still practicing on my 30GB iPod until I convert it to a 240GB one. After that I guess I won't risk iTunes screwing it up either. It really blows. What's important is the fact that there

Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain

2009-05-07 Thread H. Langos
> RVA2 > A most flexible definition seems RVA2 as defined in id3v2.4.0 . It allows to > define several adjustment sets. Using an "Identification" string that could > take > the role of the "Radio" vs, "Audiophile" distinctions AND in each of those > adjustment sets each channel can have a di

Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain

2009-05-07 Thread H. Langos
On Thu, May 07, 2009 at 10:51:04AM +0200, Richard van den Berg wrote: > On 5/7/09 10:09 AM, H. Langos wrote: >> Did you check when (at which version) MP3::Info gained APE support? > > I did just now and APE support was added in MP3::Info v1.20, Saturday, > January 7, 2006 > >> It would >> be good

Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain

2009-05-07 Thread Richard van den Berg
On 5/7/09 10:09 AM, H. Langos wrote: Did you check when (at which version) MP3::Info gained APE support? I did just now and APE support was added in MP3::Info v1.20, Saturday, January 7, 2006 It would be good to check for this in configure.ac as it already is done for utf8 support. Con

Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain

2009-05-06 Thread Richard van den Berg
Hello Henrik, I finally found some time to make a proper patch for the ReplayGain support. Let me know if this is acceptable, or if it needs some more tweaking. I've added the following options to gnupod_addsong.pl: --disable-apeDo not read APE Tags (MP3 Only) --disable-v1 wi

Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain

2009-04-20 Thread Richard van den Berg
Hi Henrik, On Mon, April 20, 2009 17:47, H. Langos wrote: > I hope the iPod does take care of clipping issues. (Or aren't there any?) In theory there could be clipping, but for 99% of the current pop music releases the volume will be lowered. And even for those (older) releases where the volume w

Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain

2009-04-20 Thread H. Langos
Hi Richard, On Mon, Apr 20, 2009 at 04:45:03PM +0200, Richard van den Berg wrote: > Hi Henrik, > > I agree with your reasoning in principle (and will provide a patch for the > --noAPEtag option) but if you had ever tried to use iTunes' SoundCheck and > compare it against ReplayGain, you wouldn't

Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain

2009-04-20 Thread Richard van den Berg
Hi Henrik, On Mon, April 20, 2009 15:32, H. Langos wrote: > But in the end they both produce one integer number that is applied as a > simple scaling factor, right? So the "superiority" of the the ReplayGain > algorithm is something that depends on the software used to produces those > tags. There

Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain

2009-04-20 Thread H. Langos
Hi Richard, On Fri, Apr 17, 2009 at 11:02:22PM +0200, Richard van den Berg wrote: > I'm successfully using gnupod on my iPod video 30GB. Thanks to everyone > who contributed to this great tool! > > I have all my mp3s tagged for ReplayGain volume leveling using mp3gain. > This tool adds ReplayGain

[Bug-gnupod] Patch to support ReplayGain / mp3gain

2009-04-17 Thread Richard van den Berg
I'm successfully using gnupod on my iPod video 30GB. Thanks to everyone who contributed to this great tool! I have all my mp3s tagged for ReplayGain volume leveling using mp3gain. This tool adds ReplayGain information using APE tags. Making gnupod read these tags and apply them as SoundCheck v