Hi Jim,
- dnl Work around a bug of AC_EGREP_CPP in autoconf-2.57.
- AC_REQUIRE([AC_PROG_CPP])
- AC_REQUIRE([AC_PROG_EGREP])
-
AC_CACHE_CHECK([whether inttypes.h defines strtoimax as a macro],
gl_cv_func_strtoimax_macro,
[AC_EGREP_CPP([inttypes_h_defines_strtoimax],
Bruno Haible wrote:
Hi Jim,
- dnl Work around a bug of AC_EGREP_CPP in autoconf-2.57.
- AC_REQUIRE([AC_PROG_CPP])
- AC_REQUIRE([AC_PROG_EGREP])
-
AC_CACHE_CHECK([whether inttypes.h defines strtoimax as a macro],
gl_cv_func_strtoimax_macro,
Jim Meyering wrote:
While the dependency of AC_EGREP_CPP on AC_PROG_EGREP
is unavoidable, there are others that are indeed unnecessary,
since they serve only to work around a bug in autoconf-2.57,
which is no longer relevant, since we (gnulib-tool) now
requires 2.59 or newer.
...
Now we
Hi Jim,
The proposed patch is solely clean-up on the gnulib side.
As the subject implies, initially I thought this was the solution
to the grep-configure problem.
As a pure clean-up patch, it is OK. But you confused me completely
by proposing it under the subject grep fails to build on
Bruno Haible wrote:
Jim Meyering wrote:
While the dependency of AC_EGREP_CPP on AC_PROG_EGREP
is unavoidable, there are others that are indeed unnecessary,
since they serve only to work around a bug in autoconf-2.57,
which is no longer relevant, since we (gnulib-tool) now
requires 2.59 or
On 11/14/2010 03:09 PM, Jim Meyering wrote:
It is possible to disable the body of these two expansions by
assigning values to GREP and EGREP inside the configure script.
But with no grep program already installed, that will always fail.
You can implement a basic grep that is good enough for
Paolo Bonzini wrote:
On 11/14/2010 03:09 PM, Jim Meyering wrote:
It is possible to disable the body of these two expansions by
assigning values to GREP and EGREP inside the configure script.
But with no grep program already installed, that will always fail.
You can implement a basic grep
* src/system.h: Add multiple inclusion guards.
* src/grep.h: Likewise.
---
src/grep.h |5 +
src/system.h |4
2 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/src/grep.h b/src/grep.h
index 67ea793..72146e7 100644
--- a/src/grep.h
+++ b/src/grep.h
@@ -17,6 +17,9 @@
Paolo Bonzini wrote:
* src/system.h: Add multiple inclusion guards.
* src/grep.h: Likewise.
...
diff --git a/src/grep.h b/src/grep.h
+#ifndef GREP_GREP_H
+#define GREP_GREP_H 1
...
+#endif
...
diff --git a/src/system.h b/src/system.h
...
Those look fine. Thanks.
You're adding them just on
On 11/14/2010 05:11 PM, Jim Meyering wrote:
Paolo Bonzini wrote:
* src/system.h: Add multiple inclusion guards.
* src/grep.h: Likewise.
...
diff --git a/src/grep.h b/src/grep.h
+#ifndef GREP_GREP_H
+#define GREP_GREP_H 1
...
+#endif
...
diff --git a/src/system.h b/src/system.h
...
Those
Paolo Bonzini wrote:
+# Override grep during configure.
+fn_grep () {
I would suggest more comments.
- What is the purpose of this override?
- What are its limitations?
10 years from now, no one will remember.
Suggestion:
# Set the GREP and EGREP variables to a dummy replacement for the
On 11/14/2010 05:25 PM, Bruno Haible wrote:
Paolo Bonzini wrote:
+# Override grep during configure.
+fn_grep () {
I would suggest more comments.
- What is the purpose of this override?
- What are its limitations?
10 years from now, no one will remember.
True, but there is git
Follow-up Comment #2, patch #7379 (project grep):
Yes, tested with bleeding edge from git and found issue not reproducible.
Thanks.
___
Reply to this item at:
http://savannah.gnu.org/patch/?7379
On 11/14/2010 06:48 PM, Florin Iucha wrote:
checking build system type... i386-pc-solaris2.10
checking host system type... i386-pc-solaris2.10
checking how to run the C preprocessor... cc -E
checking for grep that handles long lines and -e... configure: error: no
acceptable grep could be found
* Paolo Bonzini wrote on Sun, Nov 14, 2010 at 08:09:12PM CET:
On 11/14/2010 06:48 PM, Florin Iucha wrote:
checking build system type... i386-pc-solaris2.10
checking host system type... i386-pc-solaris2.10
checking how to run the C preprocessor... cc -E
checking for grep that handles long
On Sun, Nov 14, 2010 at 05:31:25PM +0100, Paolo Bonzini wrote:
Florin, can you try building GNU sed and see if it has a similar problem?
The released (4.2) version?
[flo...@icarus sed-4.2]$ ./configure --prefix=/usr/local
checking for a BSD-compatible install... build-aux/install-sh -c
checking
16 matches
Mail list logo
