Re: #!/usr/bin/env perl

2013-02-25 Thread Ludovic Courtès
Andreas Enge skribis: > Am Montag, 25. Februar 2013 schrieb Mark H Weaver: >> Andreas Enge writes: >> > (has-env (string-suffix? "/env" interp)) >> >> I think we might want to make this test more restrictive. I'm looking >> at a package (guile-figl) that includes an 'env' script in its build >

Re: #!/usr/bin/env perl

2013-02-25 Thread Andreas Enge
Am Montag, 25. Februar 2013 schrieb Mark H Weaver: > Andreas Enge writes: > > (has-env (string-suffix? "/env" interp)) > > I think we might want to make this test more restrictive. I'm looking > at a package (guile-figl) that includes an 'env' script in its build > directory, analogous to 'pre-i

Re: #!/usr/bin/env perl

2013-02-24 Thread Mark H Weaver
Hi Andreas, Andreas Enge writes: > (has-env (string-suffix? "/env" interp)) I think we might want to make this test more restrictive. I'm looking at a package (guile-figl) that includes an 'env' script in its build directory, analogous to 'pre-inst-env' in Guix. This makes me worry that the te

Re: #!/usr/bin/env perl

2013-02-23 Thread Andreas Enge
Am Samstag, 23. Februar 2013 schrieb Ludovic Courtès: > Aaah yes, that’s because ‘master’ (which adds the ‘guix’ script) hasn’t > been merged yet into ‘core-updates’. I’ve done it locally, and will > probably push real soon, but in the meantime you must still use > ‘./pre-inst-env guix-build’ on ‘

Re: #!/usr/bin/env perl

2013-02-23 Thread Ludovic Courtès
Andreas Enge skribis: > Very strange. I have ui.{scm,go} in the installation location in > /usr/local/guix-git/share/guile/site/2.0/guix/, and also in the guix > subdirectory of the source directory. With master, there are no problems. Aaah yes, that’s because ‘master’ (which adds the ‘guix’ sc

Re: #!/usr/bin/env perl

2013-02-23 Thread Andreas Enge
Am Samstag, 23. Februar 2013 schrieb Ludovic Courtès: > Hmm, what about guile -c '(use-modules (guix ui))'? In ice-9/boot-9.scm: 149: 16 [catch #t # ...] 157: 15 [#] In unknown file: ?: 14 [catch-closure] In ice-9/boot-9.scm: 63: 13 [call-with-prompt prompt0 ...] In ice-9/eval.scm: 407: 12

Re: #!/usr/bin/env perl

2013-02-23 Thread Ludovic Courtès
Andreas Enge skribis: >> For info about why this happens, you could try: >> guile -c '(pk (@ (guix ui) guix-main))' [...] > In unknown file: >?: 0 [memoize-variable-access! # #f] > > ERROR: In procedure memoize-variable-access!: > ERROR: In procedure module-lookup: Wrong type argument in

Re: #!/usr/bin/env perl

2013-02-23 Thread Andreas Enge
Am Samstag, 23. Februar 2013 schrieb Ludovic Courtès: > Andreas Enge skribis: > > I had test failures in coreutils, > > Do you still have the details around? ‘env’ is part of Coreutils, so it > may be that it’s testing its behavior, and that patching prevents that. This was also my suspicion, b

Re: #!/usr/bin/env perl

2013-02-23 Thread Ludovic Courtès
Andreas Enge skribis: > I had test failures in coreutils, Do you still have the details around? ‘env’ is part of Coreutils, so it may be that it’s testing its behavior, and that patching prevents that. Perhaps ‘patch-shebang’ could have a ‘patch-env?’ keyword parameter, defaulting to #t, and i

Re: #!/usr/bin/env perl

2013-02-23 Thread Andreas Enge
Am Freitag, 22. Februar 2013 schrieb Andreas Enge: > Please find attached a patch for review. I tested it on a few example > files, but not yet with a real packet - I am waiting for the full > rebuild ;-) I had test failures in coreutils, and to check whether it was related to my patch, I tried f

Re: #!/usr/bin/env perl

2013-02-23 Thread Ludovic Courtès
Andreas Enge skribis: > Am Samstag, 23. Februar 2013 schrieb Ludovic Courtès: >> > (make-regexp >> > "^[[:blank:]]*([[:graph:]]+)[[:blank:]]*([[:graph:]]*)(.*)$"))) >> >> I think it should be a + after the second [[:blank:]], because there >> should be space between the interpreter name and its

Re: #!/usr/bin/env perl

2013-02-22 Thread Andreas Enge
Am Samstag, 23. Februar 2013 schrieb Ludovic Courtès: > > (make-regexp > > "^[[:blank:]]*([[:graph:]]+)[[:blank:]]*([[:graph:]]*)(.*)$"))) > > I think it should be a + after the second [[:blank:]], because there > should be space between the interpreter name and its argument. Sometimes, there is

Re: #!/usr/bin/env perl

2013-02-22 Thread Ludovic Courtès
Andreas Enge skribis: > Am Samstag, 26. Januar 2013 schrieb Ludovic Courtès: >> The function you want to patch ;-) is ‘patch-shebang’ in >> build/utils.scm. Since that entails a full rebuild, that’s something >> for a new ‘core-updates’ branch. > > Please find attached a patch for review. I test

Re: #!/usr/bin/env perl

2013-02-22 Thread Andreas Enge
Am Samstag, 26. Januar 2013 schrieb Ludovic Courtès: > The function you want to patch ;-) is ‘patch-shebang’ in > build/utils.scm. Since that entails a full rebuild, that’s something > for a new ‘core-updates’ branch. Please find attached a patch for review. I tested it on a few example files, b

Re: #!/usr/bin/env perl

2013-01-26 Thread Ludovic Courtès
Andreas Enge skribis: > the lonely "perl" in a file containing the subject line survives in the > patch-shebang phase. Right now, I am patching it by hand to replace the > complete line by the path to perl for the curl package; would it make sense > to add a general automatism? Yes, probably,

#!/usr/bin/env perl

2013-01-26 Thread Andreas Enge
Hello, the lonely "perl" in a file containing the subject line survives in the patch-shebang phase. Right now, I am patching it by hand to replace the complete line by the path to perl for the curl package; would it make sense to add a general automatism? Andreas